| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-10-10 | |||
| 16:14:35 | bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | |
| 16:14:38 | bauzas | #info As a reminder, people eager to review changes can +1 to indicate their interest, +2 for asking cores to also review | |
| 16:15:00 | bauzas | I said I was about to propose a Gerrit dashboard for those, I had no time yet to do it | |
| 16:15:08 | bauzas | #action bauzas to propose a Gerrit dash | |
| 16:15:15 | bauzas | #topic Stable Branches | |
| 16:15:20 | bauzas | elodilles: ? | |
| 16:15:24 | elodilles | yepp | |
| 16:15:32 | elodilles | i'm not aware of any gate issue | |
| 16:15:41 | elodilles | otherwise nothing else to report | |
| 16:15:48 | elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | |
| 16:16:09 | elodilles | please add stable gate issues if you see any ^^^ | |
| 16:16:14 | bauzas | ++ | |
| 16:16:22 | elodilles | that's all from me | |
| 16:17:19 | bauzas | cool | |
| 16:19:19 | bauzas | #topic Open discussion | |
| 16:19:24 | bauzas | (bauzas) Specless blueprint approval for https://blueprints.launchpad.net/nova/+spec/aggregatemultitenancyisolation-to-support-unlimited-tenant | |
| 16:20:23 | sean-k-mooney | hum | |
| 16:20:42 | bauzas | wdyt about that ? | |
| 16:21:06 | sean-k-mooney | dont we support having multiple keys | |
| 16:21:18 | sean-k-mooney | so i didnt think there was an effective limit today | |
| 16:22:46 | sean-k-mooney | or parhaps we require one aggreate per tenatnt today i would have to review the code | |
| 16:23:10 | sean-k-mooney | the patch is basiclly enabling what i orgianlly tought already worked | |
| 16:23:22 | sean-k-mooney | instead of looking for filter_tenant_id explictly | |
| 16:23:28 | sean-k-mooney | just making that a prefix | |
| 16:24:00 | sean-k-mooney | so you can have filter_tenant_id=<tenant-0> filter_tenant_id_1=<tenant-1> | |
| 16:24:30 | sean-k-mooney | thats proably an ok change to make | |
| 16:25:35 | sean-k-mooney | tenant isolation shoudl be done via placement | |
| 16:25:45 | sean-k-mooney | and we shoudl really be removing the filter based approch so im not sure | |
| 16:27:16 | bauzas | sahid wanted to still use the filters | |
| 16:27:53 | sean-k-mooney | i would be in favor of deprecateding it for removal in D if the current fucntionlaiy is supproted by the placment approch | |
| 16:28:41 | sean-k-mooney | https://docs.openstack.org/nova/latest/admin/aggregates.html#tenant-isolation-with-placement | |
| 16:28:47 | dansmith | tenant isolation can't be done entirely in placement right? | |
| 16:28:55 | bauzas | I think sahid actually wanted to backport this | |
| 16:28:57 | sean-k-mooney | i belive it can | |
| 16:29:02 | dansmith | all we can do is select an aggregate and then get placement to limit for us | |
| 16:29:14 | bauzas | you know what ? we can punt this until he can be around | |
| 16:29:33 | sean-k-mooney | so given this dicussion i would say not a specless blueprint | |
| 16:29:40 | sean-k-mooney | spec or ptg discussion | |
| 16:29:41 | dansmith | right | |
| 16:30:48 | sean-k-mooney | i think the fucntionaliyt is possible today withthe placement approch so i would question why we dont remove the filter | |
| 16:30:59 | sean-k-mooney | so i would like to capture the answer to that | |
| 16:31:51 | bauzas | okay, let's say this | |
| 16:31:57 | bauzas | I'll tell this to sahid tomorrow | |
| 16:32:12 | bauzas | and he could explain why he still wants to use filters | |
| 16:32:20 | bauzas | (IMHO like I said, backports) | |
| 16:32:39 | bauzas | do all agree ? | |
| 16:32:44 | sean-k-mooney | backports are a downstream problem | |
| 16:33:01 | bauzas | sure, but this is easier with a python module like a filter, right?. | |
| 16:33:03 | sean-k-mooney | that is not a good reason to extend it upstream unless its useful upstream | |
| 16:33:21 | bauzas | sure, we need to discuss the usecases | |
| 16:33:33 | bauzas | but I'm not in favor of removing every single filter we have | |
| 16:33:44 | bauzas | some operators still run filters on their choices | |
| 16:33:44 | dansmith | agree | |
| 16:34:17 | bauzas | anyway, let's punt this until PTG or when sahid can join us | |
| 16:34:26 | dansmith | we have the prefilter for isolation, which uses placement's aggregates to do some isolation, but I'll have to revisit my understanding of the differences | |
| 16:34:31 | bauzas | #agreed defer this agreement to the next PTG | |
| 16:34:49 | bauzas | I'll add a topic in the PTG etherpad | |
| 16:34:55 | sean-k-mooney | dansmith: we deveoped that prefilter to eventurlly remove this one | |
| 16:36:07 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/placement-req-filter.html#proposed-change | |
| 16:36:43 | bauzas | sean-k-mooney: well, for CPUFilter, I totally agree with removing it | |
| 16:36:47 | sean-k-mooney | this was the first prefilter that you wote many moons ago | |
| 16:37:24 | bauzas | I'm just saying that for non-allocatable filters (placing things) we may leave those if those are cheap to maintain | |
| 16:37:41 | sean-k-mooney | right but this filter is know to be problematic | |
| 16:37:42 | bauzas | because this is a python module and not another SQL query | |
| 16:37:54 | sean-k-mooney | so i realy dont think this is a good example ot extned | |
| 16:37:55 | dansmith | sean-k-mooney: I know, but I think there were limitations | |
| 16:38:18 | bauzas | anyway, we punted the potential agreement to the next PTG | |
| 16:38:21 | dansmith | I thought we agreed to punt until PTG ? | |
| 16:38:22 | dansmith | yeah | |
| 16:38:30 | bauzas | so let's stop for now | |
| 16:38:40 | bauzas | and I'll give you all extra 20 mins of your time | |
| 16:38:40 | sean-k-mooney | sure | |
| 16:38:42 | bauzas | thanks all | |
| 16:38:52 | bauzas | any other item before we close ? | |
| 16:39:07 | sean-k-mooney | i just wanted to highlight i reporposed the healtcheck spec https://review.opendev.org/c/openstack/nova-specs/+/897225 | |
| 16:39:16 | bauzas | oh right, I've seen it | |
| 16:39:20 | sean-k-mooney | so if we can reappove that it would be good | |
| 16:39:22 | bauzas | I just need to look at it | |
| 16:39:25 | sean-k-mooney | ack | |
| 16:39:41 | sean-k-mooney | thats all from me | |
| 16:39:43 | bauzas | tuesdays are usually upstream days for me, but I was vamped into some crazy internal thing | |
| 16:39:57 | bauzas | anyway, ending now | |
| 16:40:00 | bauzas | thanks all | |
| 16:40:04 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-10-10-16.00.log.html | |
| 16:40:04 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-10-10-16.00.txt | |
| 16:40:04 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-10-10-16.00.html | |
| 16:40:04 | opendevmeet | Meeting ended Tue Oct 10 16:40:04 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:40:04 | bauzas | #endmeeting | |
| 16:40:33 | sean-k-mooney | bauzas: if your looking at repoposals then https://review.opendev.org/c/openstack/nova-specs/+/895924 would be alos nice to look at | |
| 16:40:46 | bauzas | yeah I need to do reviews | |
| 16:40:59 | bauzas | my gerrit nova-specs dashboard misses me | |
| 16:42:13 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Compile mdev samples for nova-next https://review.opendev.org/c/openstack/nova/+/897708 | |
| 16:42:24 | dansmith | okay locally mtty.ko gets built and inserted during devstack | |
| 16:43:58 | bauzas | <3 | |
| 16:44:47 | bauzas | if I have time tomorrow, I'll work on a nova WIP to change the libvirt driver to use a specific 'virtual' device for mtty | |
| 16:45:02 | bauzas | so we shall be able to test | |
| 16:58:34 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Compile mdev samples for nova-next https://review.opendev.org/c/openstack/nova/+/897708 | |
| 17:21:36 | dansmith | 2023-10-10 17:19:30.055298 | controller | mdev 28672 1 mtty | |
| 17:21:36 | dansmith | 2023-10-10 17:19:30.033749 | controller | ++ /opt/stack/nova/devstack/lib/mdev_samples:compile_mdev_samples:28 : grep mdev | |
| 17:21:47 | dansmith | \o/ | |