| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-07-12 | |||
| 13:21:04 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 14:09:15 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Workaround SQLAlchemy 2.x bug https://review.opendev.org/c/openstack/placement/+/888281 | |
| 14:20:03 | opendevreview | Amit Uniyal proposed openstack/nova master: Refactor CinderFixture https://review.opendev.org/c/openstack/nova/+/885756 | |
| 14:20:04 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 14:20:04 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 15:00:08 | auniyal | will it be okay to use RuntimeError directly inside compute/manager ? or new Exception InvalidConnectorError(RuntimeError) should be in exception.py ? | |
| 15:00:08 | auniyal | I think if new Exception shouldn't be from NovaException then as you suggested RuntimeError makes more sense; | |
| 15:00:08 | auniyal | dansmith, regarding which exception to raise if provided connector is not correct; https://review.opendev.org/c/openstack/nova/+/877446/comment/16f7cd47_d2c8aef9/; | |
| 15:12:07 | opendevreview | Merged openstack/nova stable/wallaby: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879405 | |
| 15:22:01 | dansmith | auniyal: this is nova-manage right? | |
| 15:22:51 | dansmith | I think it's fine to have "class HostConflict(Exception): pass" in manage.py and then use that internally to manage itself | |
| 15:22:58 | dansmith | I would not do that in any service code probably | |
| 15:24:36 | auniyal | yes, nova-manage | |
| 15:24:37 | auniyal | ack | |
| 15:27:22 | dansmith | sean-k-mooney: can you rubber-stamp this cinder fixture refactor? https://review.opendev.org/c/openstack/nova/+/885756 | |
| 15:27:44 | dansmith | converts stub_out to MockPatch so we can get that out from under auniyal's other stack | |
| 15:28:05 | sean-k-mooney | ill take a look now | |
| 15:28:17 | dansmith | don't look, just +W (j/k) | |
| 15:28:19 | sean-k-mooney | oh this hit the complexity limit right | |
| 15:28:25 | dansmith | yeah | |
| 15:31:30 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Optionally set lessee on deployment https://review.opendev.org/c/openstack/nova/+/888290 | |
| 15:41:41 | astupnik | It will be great if anyone has time to give +2/wf+1 for https://review.opendev.org/c/openstack/nova/+/883014 (already has +2 from Elod). Fix is about deleting nova flavor | |
| 15:41:42 | astupnik | eleted projects from flavor's | |
| 15:41:44 | astupnik | access lists | |
| 15:59:34 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 16:01:48 | auniyal | thanks dansmith, sean-k-mooney for +2 | |
| 16:03:19 | auniyal | sean-k-mooney can you please have another look at https://review.opendev.org/c/openstack/nova/+/873648/ | |
| 16:11:32 | opendevreview | Merged openstack/nova master: Refactor CinderFixture https://review.opendev.org/c/openstack/nova/+/885756 | |
| 16:19:21 | astupnik | thank you again Dan! | |
| 21:58:30 | opendevreview | Merged openstack/nova stable/xena: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/883014 | |
| 22:10:42 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/wallaby: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/888333 | |
| #openstack-nova - 2023-07-13 | |||
| 09:42:09 | opendevreview | efineshi proposed openstack/nova master: Not destroy the vm as it migrate back before evacuate clean https://review.opendev.org/c/openstack/nova/+/887564 | |
| 09:44:11 | opendevreview | efineshi proposed openstack/nova master: Not destroy the vm as it migrate back before evacuate clean https://review.opendev.org/c/openstack/nova/+/887564 | |
| 10:04:34 | opendevreview | dzogchen proposed openstack/nova master: Adding a wait before attempting to update a resource https://review.opendev.org/c/openstack/nova/+/888452 | |
| 11:24:46 | opendevreview | Amit Uniyal proposed openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | |
| 11:24:47 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 13:34:50 | dansmith | bauzas: most of the other online migrations use count instead of max_count, but some of them are right. So I'm going to put a trivial patch on top of this to move them all (including mine) to max_count | |
| 13:35:39 | bauzas | dansmith: no worries, I just told +1 but this is a close +2 | |
| 13:35:52 | bauzas | just in case you need to provide a new revision | |
| 13:37:11 | dansmith | bauzas: the way I have it matches the other one in the file just above it, so I think the patch is okay as-is for consistency, and I will push another on top to fix these both and all the others | |
| 13:37:15 | dansmith | running tests now | |
| 13:39:06 | dansmith | also, I think we probably need to think about removing some of these online migrations at some point.. we probably don't need to be scanning for situations that were introduced in pike | |
| 14:07:37 | opendevreview | Dan Smith proposed openstack/nova master: Fix up inconsistent max_count argument in o-d-ms https://review.opendev.org/c/openstack/nova/+/888470 | |
| 14:07:41 | dansmith | bauzas: ^ | |
| 14:10:44 | dansmith | hopefully that earns me a +2 on the one below :) | |
| 15:28:14 | dansmith | sean-k-mooney[m]: if you're looking for some easy nova work, this series could use some +Ws (or review comments): https://review.opendev.org/q/topic:bp/compute-object-ids+status:open | |
| 15:38:52 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 16:23:51 | opendevreview | yatin proposed openstack/nova master: Add config option to configure TB cache size https://review.opendev.org/c/openstack/nova/+/868419 | |
| 22:25:44 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888205 | |
| 22:25:45 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888206 | |
| 22:40:43 | opendevreview | melanie witt proposed openstack/nova stable/train: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888508 | |
| 22:40:44 | opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | |
| #openstack-nova - 2023-07-14 | |||
| 00:28:01 | opendevreview | melanie witt proposed openstack/nova stable/train: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888508 | |
| 00:28:02 | opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | |
| 01:13:02 | opendevreview | melanie witt proposed openstack/nova stable/train: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888508 | |
| 01:13:03 | opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | |
| 02:02:24 | opendevreview | melanie witt proposed openstack/nova stable/train: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888508 | |
| 02:02:25 | opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | |
| 02:56:30 | opendevreview | melanie witt proposed openstack/nova master: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/888513 | |
| 07:18:27 | opendevreview | Amit Uniyal proposed openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | |
| 07:18:28 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 10:38:35 | opendevreview | suzhengwei proposed openstack/nova-specs master: spec: evacuate api return migration https://review.opendev.org/c/openstack/nova-specs/+/888101 | |
| 10:54:08 | noonedeadpunk | folks, have anything landed recently to stable branches that could result in `Placement service credentials do not work.` during nova-status upgrade check? | |
| 10:55:49 | noonedeadpunk | I bet we're doing smth wrong with service_tokens to be fair, but not sure I see what exactly | |
| 10:56:03 | noonedeadpunk | as that wasn't an issue couple of days ago | |
| 10:58:52 | noonedeadpunk | like that's nova.conf https://zuul.opendev.org/t/openstack/build/1c40a9d73f1c44a8b61da87bc101b89e/log/logs/etc/host/nova/nova.conf.txt#84 | |
| 11:00:47 | noonedeadpunk | (and I don't see anything obvious in git logs) | |
| 11:17:09 | anskiy | noonedeadpunk: https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/886458 could it be this thing?.. | |
| 11:21:10 | noonedeadpunk | hm... | |
| 11:22:48 | noonedeadpunk | well, this patch is defenitelly in-place, as these would be "changed" otherwise https://zuul.opendev.org/t/openstack/build/1c40a9d73f1c44a8b61da87bc101b89e/log/job-output.txt#24524-24526 | |
| 11:23:02 | noonedeadpunk | so it might be it indeed | |
| 11:35:30 | noonedeadpunk | anskiy: but it could be intermittent as well (or related to the patch?) as https://review.opendev.org/c/openstack/openstack-ansible/+/887866 is not failing the same way | |
| 11:37:40 | noonedeadpunk | I don't see how it can be related to the patch itself though... | |
| 14:48:44 | opendevreview | Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339 | |
| 15:25:41 | auniyal | hi dansmith, regarding context is not targeted and context cell uuid is None; as we need admin context if cell_uuid is presentI think we should raise AdminRequired exception | |
| 15:26:00 | auniyal | is it okay ? or only Exception ? | |
| 15:33:06 | dansmith | auniyal: admin has nothing to do with being targeted or not, so I'm not sure what you mean.. this is always using an empty admin context, no? | |
| 16:17:01 | auniyal | context.target_cell(context.get_admin_context(), im.cell_mapping) | |
| 16:17:57 | auniyal | dansmith^^, we use admin context for same | |
| 16:40:29 | dansmith | auniyal: right.. I'm still not sure what you're asking | |
| 16:42:26 | auniyal | I need to raise an Exception of context.cell_uuid is not correct, as this context is made by admin context; I think possible case would be caller did not create it using admin context | |
| 16:43:01 | auniyal | so its appropriate to raise AdminRequired exception | |
| 16:46:52 | dansmith | auniyal: no, I do not think that's reasonable | |
| 16:47:04 | auniyal | ack | |
| 16:47:32 | auniyal | so then Exception('targetcell is not correct') ? | |
| 16:48:07 | dansmith | admin is not even required (for the locking) and you don't need to get *another* context in there like you're doing, right? Use the targeted context that you're being passed | |
| 16:48:31 | dansmith | auniyal: just do 'assert cctxt.cell_uuid is not None' and that's it | |
| 16:48:40 | dansmith | it'll raise AssertionError if that fails | |
| 16:49:12 | auniyal | okay, thanks dansmith | |
| 16:58:14 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 17:09:40 | sean-k-mooney | dansmith: im going to call it a day but im +2w on all but the second last patch. you can see the comment inlien but i think it would be good to add a release not to that and think about docs or a nova-staus check for unmapped instnaces | |
| 17:09:54 | dansmith | yep was just replying | |
| 17:10:41 | dansmith | sean-k-mooney: thanks for all that and I'll hit the reno and status check next week | |
| 17:14:53 | sean-k-mooney | if your going to do that as a fllow up ill upgrade to +2 and we can see about landing the core part today/monday | |
| 17:21:13 | dansmith | up to you, it's already missing a +2 from bauzas so ... | |
| 17:21:30 | dansmith | I'm fine with leaving it, it's a lot closer than it was yesterday thanks to you, so I'm satisfied :) | |
| 18:45:34 | opendevreview | Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339 | |
| 22:18:27 | opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | |
| 22:41:40 | opendevreview | Merged openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| #openstack-nova - 2023-07-17 | |||
| 01:26:56 | opendevreview | efineshi proposed openstack/nova master: Not destroy the vm as it migrate back before evacuate clean https://review.opendev.org/c/openstack/nova/+/887564 | |