| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-06-01 | |||
| 13:15:41 | Uggla_ | or we should just wait virtiofs to support it ? | |
| 13:17:29 | sean-k-mooney | virtio9p does not apprer to be supported by libvirt | |
| 13:18:31 | sean-k-mooney | oh | |
| 13:18:36 | sean-k-mooney | its an atribute you can set 9pfs | |
| 13:18:42 | Uggla_ | hum are you sure, I can configure it using virtual machine manager, and I think it uses libvirt. | |
| 13:21:19 | sean-k-mooney | it might be setting things qit qemu args | |
| 13:23:40 | Uggla_ | it looks like the conf is: https://paste.opendev.org/show/bC6FS8a7RP2J0tT9G2Jn/ | |
| 13:24:42 | sean-k-mooney | ya so it looks like its the defautl driver if you dont use virtio-fs | |
| 13:26:22 | Uggla_ | I have not dig into it, this is just the conf porposed by virtual machine manager. I'm a bit afraid about the <address type="pci"... as I don't really know the purpose so far. | |
| 13:26:29 | sean-k-mooney | im not sure that readonly is really required but perhaps we should consider it | |
| 13:26:58 | Uggla_ | sean-k-mooney, I have discussed and open a ticket to the virt team to have it supported. | |
| 13:27:03 | sean-k-mooney | Uggla_: thats just the adress in the vm where its mounted | |
| 13:27:18 | sean-k-mooney | Uggla_: we can rely on it however fo the intial enablement | |
| 13:27:39 | sean-k-mooney | we have a policy of rquiring features to be in a released version of libvirt/qemu before we can use it in nova | |
| 13:28:10 | sean-k-mooney | i woudl perhaps isnteead consier addign ahard limit on the virtiofs size and allwo it to be read write | |
| 13:28:18 | sean-k-mooney | but lets see what others think | |
| 13:33:58 | Uggla_ | one of the benefits is that virtio9p seems to not have issue with snapshot etc... but probably less performant than virtiofs. | |
| 13:35:00 | Uggla_ | I think virtio9p does not require shared memory that's the reason why. | |
| 13:38:17 | Uggla_ | sean-k-mooney, regarding virtiofs if we really want ro we can work around it using a bind mount and explain it it the doc. | |
| 13:39:33 | Uggla_ | sean-k-mooney, do you thing it worth to also write a spec for virtio9p ? | |
| 14:13:19 | sean-k-mooney | no | |
| 14:13:28 | sean-k-mooney | i dont think we shoudl add supprot for virtio9p | |
| 14:13:49 | sean-k-mooney | it has much lower performacne and it will likely get remvoed eventully once virtiofs has reach feature partiy | |
| 14:30:41 | opendevreview | Danylo Vodopianov proposed openstack/nova-specs master: Add support for Napatech LinkVirt SmartNICs https://review.opendev.org/c/openstack/nova-specs/+/859290 | |
| 14:53:38 | opendevreview | Danylo Vodopianov proposed openstack/nova-specs master: Add support for Napatech LinkVirt SmartNICs https://review.opendev.org/c/openstack/nova-specs/+/859290 | |
| 15:13:24 | opendevreview | Danylo Vodopianov proposed openstack/nova-specs master: Add support for Napatech LinkVirt SmartNICs https://review.opendev.org/c/openstack/nova-specs/+/859290 | |
| #openstack-nova - 2023-06-02 | |||
| 12:00:50 | opendevreview | Vasyl Saienko proposed openstack/os-vif master: Don't break traffic if port already exists https://review.opendev.org/c/openstack/os-vif/+/885127 | |
| 12:01:47 | opendevreview | Vasyl Saienko proposed openstack/os-vif master: Don't break traffic if port already exists https://review.opendev.org/c/openstack/os-vif/+/885127 | |
| 12:04:20 | gibi | sean-k-mooney: we lost your +2 from https://review.opendev.org/c/openstack/nova/+/873216 | |
| 12:04:29 | gibi | ahh sorry | |
| 12:04:38 | gibi | it wasn't review +2 it was prio +2 | |
| 12:04:40 | gibi | then never mind | |
| 12:04:52 | gibi | anyhow I reviewed the fix and I'm +2 on it | |
| 13:28:36 | sean-k-mooney | gibi: i can review it now if your +2 its probly mostly fine | |
| 13:29:37 | sean-k-mooney | actully i think i planned to +2 that previosuly yesterday or the day before | |
| 13:30:49 | sean-k-mooney | ya i had intended to add both CR: +2 and RP: +2 | |
| 15:10:23 | gibi | :) | |
| #openstack-nova - 2023-06-05 | |||
| 11:01:38 | mdbooth | I'll be running a forum session on Kubernetes on OpenStack in Vancouver next week. It's for users and developers of all related projects to talk to each other. Etherpad is here if there's anything you'd like to discuss: https://etherpad.opendev.org/p/openinfra-2023-kubernetes-on-openstack | |
| 11:57:22 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 11:57:23 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 15:53:10 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 15:53:10 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 16:23:36 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: fix the privsep issue when offlining the cpu https://review.opendev.org/c/openstack/nova/+/885293 | |
| 16:23:49 | bauzas | sometimes I hate myself ^ | |
| 16:23:54 | bauzas | gibi: dansmith: ^ | |
| 16:24:04 | bauzas | we need to backport it to Antelope | |
| 16:24:15 | dansmith | ouch | |
| 16:24:27 | bauzas | yeah :( | |
| 16:24:36 | bauzas | and the functests don't verify it | |
| 16:25:07 | bauzas | maybe I should also create a relnote | |
| 16:25:34 | bauzas | so operators would see to use the next Antelope .z release if they want to use it | |
| 16:26:05 | dansmith | maybe you'll need to make a release before your demo so people can actually use it :D | |
| 16:28:39 | bauzas | yeah, I'll prepare a release | |
| 16:28:52 | bauzas | and I'll tell it loudly | |
| 16:28:58 | bauzas | as I'm very sad :( | |
| 16:30:31 | bauzas | also we maybe should have some test that verify that we don't forget a privsep decorator | |
| 16:30:52 | bauzas | like we do with objects or other stuff | |
| 16:31:35 | bauzas | but that's a bit difficult | |
| 16:47:21 | dansmith | yeah, not sure how to do that | |
| 17:42:45 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: fix the privsep issue when offlining the cpu https://review.opendev.org/c/openstack/nova/+/885293 | |
| 17:43:00 | bauzas | dansmith: added a relnote for making it more public | |
| 17:43:25 | bauzas | and again, sorry for this bug :( | |
| 17:43:38 | dansmith | how could permissions cause a FileNotFound/ | |
| 17:43:44 | dansmith | that doesn't seem right o me | |
| 17:43:50 | bauzas | dansmith: see the bug report | |
| 17:44:04 | bauzas | I added the log | |
| 17:44:20 | dansmith | the bug report *says* there's a FileNotFound but I don't see *why* that would happen | |
| 17:44:25 | dansmith | users can see the file | |
| 17:44:29 | bauzas | this is a permission error as the base exception | |
| 17:45:01 | dansmith | oh I see, we're translating | |
| 17:45:05 | bauzas | yeah | |
| 17:45:37 | dansmith | okay, so the reno reads a bit strange to me because of the "if you want".. can I suggest alternative wording? | |
| 17:45:45 | bauzas | dansmith: sure, do this | |
| 17:46:03 | bauzas | tbc, I prefer -1s rather than +2s :) | |
| 17:49:21 | dansmith | commented | |
| 17:50:20 | dansmith | bauzas: if you're using the offlining the scaling being missing from /sys isn't a problem right? Could we enable this in nova-next or something so we see some coverage? | |
| 17:53:27 | bauzas | dansmith: you mean about the fact that we miss scaling_governor in my instance ? | |
| 17:53:49 | bauzas | I can find a way to say 'meh, fair enough' if you wan | |
| 17:53:51 | bauzas | want | |
| 17:54:06 | bauzas | so in this case, we would only support to ask to offline/online cpus | |
| 17:55:42 | dansmith | don't you choose modes, either to use scaling or cpu offlniing? | |
| 17:56:39 | dansmith | if you're using offlining, I would expect the missing cpufreq support wouldn't be a problem and that we could just enable this in nova-next | |
| 17:58:38 | bauzas | dansmith: yeah, we have a config option for saying which strategy you want https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.cpu_power_management_strategy | |
| 17:58:56 | dansmith | right, so can we configure nova-next for offlining mode so we get some CI coverage? | |
| 17:59:02 | bauzas | we could so | |
| 17:59:49 | bauzas | okay, so I'll create another bugfix for making sure that if you want to offline, it's fine if we don't verify the scaling governor | |
| 18:00:01 | bauzas | unless you ask for it by the config opt | |
| 18:00:09 | dansmith | oh, is that not currently working? | |
| 18:00:35 | dansmith | because we should not depend on a working cpufreq implementation if we're using offlining | |
| 18:00:54 | dansmith | I can imagine some of the other platforms (maybe arm or power) don't always have cpufreq enabled | |
| 18:01:02 | bauzas | unfortunately no, because when we restart we check both the governor and the state here : https://github.com/openstack/nova/blob/master/nova/virt/libvirt/cpu/api.py#L143 | |
| 18:01:12 | dansmith | and some server hardware if you enable platform-based scaling I think they don't expose it to the OS | |
| 18:01:13 | bauzas | so I'll change this | |
| 18:01:18 | dansmith | bauzas: okay yeah, that'd be good | |
| 18:01:42 | bauzas | dansmith: ++ your concern is awesome btw. | |
| 18:02:08 | bauzas | dansmith: because indeed I wasn't thinking about the other platforms but indeed you're right | |
| 18:02:12 | dansmith | yeah | |
| 18:02:25 | bauzas | +++ definitely, will fix it too and will backport it | |
| 18:02:37 | dansmith | cpufreq is pretty common these days, but if you unload a module or don't have it built into your kernel, we shouldn't fail | |
| 18:03:04 | dansmith | (shouldn't fail to allow offlining I mean) | |