| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-30 | |||
| 16:59:59 | opendevmeet | Meeting ended Tue May 30 16:59:59 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:59:59 | bauzas | #endmeeting | |
| 17:00:09 | elodilles | thanks o/ | |
| 17:01:21 | stephenfin | Didn't bring it up in the meeting cos it doesn't belong there, but another round of +2s on the outstanding sqlalchemy-20 stuff would make my week and get us towards unblocking that in Bobcat. sean-k-mooney[m] has already spun through them | |
| 17:01:22 | stephenfin | All can be found here https://review.opendev.org/q/project:openstack/nova+topic:sqlalchemy-20+is:open | |
| 17:01:38 | stephenfin | Happy to answer any questions you may have on any/all of them | |
| 17:02:53 | bauzas | stephenfin: ack, no promises but I'll try to review them soon | |
| 17:03:01 | bauzas | stephenfin: bump me again next week if not | |
| 17:03:16 | stephenfin | will do, thanks bauzas | |
| 17:06:36 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations https://review.opendev.org/c/openstack/nova/+/879499 | |
| 17:06:36 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 17:06:37 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | |
| 17:06:37 | opendevreview | Dan Smith proposed openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | |
| 17:06:38 | opendevreview | Dan Smith proposed openstack/nova master: Add online migration for Instance.compute_id https://review.opendev.org/c/openstack/nova/+/884752 | |
| 17:06:38 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| 17:24:36 | dansmith | So, the last GPF kernel crash we had was a week ago | |
| 17:25:04 | dansmith | it was on the new cirros but it doesn't look exactly like what we saw before | |
| 17:25:27 | dansmith | but it does look related to acpi hotplug, which I assume is related to the volume attach or detach, and _is_ in one of those volume-having tests | |
| 17:26:33 | dansmith | so at this point I'd say the new cirros didn't fix it, but we'll have to wait for a few weeks of data to see if it's better or different | |
| 17:44:16 | frickler | dansmith: do you have a link to that crash handy? also we're right now publishing 0.6.2 with an updated kernel, that might help https://github.com/cirros-dev/cirros/actions/runs/5123918187 | |
| 17:45:45 | dansmith | frickler: here's the 0.6.1 one: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ad6/826755/16/check/nova-lvm/ad65569/job-output.txt | |
| 17:45:51 | dansmith | search for "general protection" | |
| 17:48:37 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 17:50:17 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 17:53:22 | opendevreview | Sylvain Bauza proposed openstack/nova stable/yoga: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883724 | |
| 17:55:05 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 18:02:54 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | |
| 20:57:01 | opendevreview | Merged openstack/nova master: db: Remove the legacy 'migration_version' table https://review.opendev.org/c/openstack/nova/+/872429 | |
| 21:50:10 | melwitt | jjm9ASDFGHJJKOL;;;;;'''' | |
| 21:51:33 | melwitt | geguileo: w2f | |
| 21:51:48 | melwitt | argh sorry | |
| 21:56:11 | dansmith | noice | |
| 21:59:24 | melwitt | 😆 | |
| 21:59:24 | melwitt | 😆 | |
| #openstack-nova - 2023-05-31 | |||
| 06:23:16 | LarsErikP | frickler: (reading backlog) - ok, thanks =) | |
| 07:40:01 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | |
| 07:44:30 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | |
| 07:46:55 | bauzas | elodilles: gibi: could you please give a swing to https://review.opendev.org/c/openstack/nova/+/883724 as a stable/yoga patch ? It would be nice thanks | |
| 07:47:50 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 07:48:51 | gibi | bauzas: I guess you mean the stable/zed first) | |
| 07:48:52 | gibi | :) | |
| 07:49:26 | bauzas | gibi: indeed | |
| 07:49:30 | bauzas | + yoga | |
| 07:50:01 | bauzas | I'm trying to backport https://review.opendev.org/c/openstack/nova/+/883725 down to wallaby but I also need to create some backport for https://review.opendev.org/c/openstack/nova/+/884808 down to Wallaby too | |
| 07:51:59 | gibi | bauzas: it seems that unit test errors in https://review.opendev.org/c/openstack/nova/+/883726 are relevant | |
| 07:52:24 | bauzas | gibi: indeed, I'm working atm on this | |
| 07:52:35 | bauzas | we need a dependent backport | |
| 07:53:17 | bauzas | https://review.opendev.org/c/openstack/nova/+/705792 hits me hard | |
| 07:53:40 | bauzas | that's why I sometimes hate to just modify a lot of methods :( | |
| 08:17:09 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | |
| 08:17:10 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 08:26:00 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | |
| 08:26:01 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | |
| 08:43:36 | bauzas | gibi: thanks for the stable reviews, could you also please look at https://review.opendev.org/c/openstack/nova/+/884808 ? | |
| 08:44:03 | bauzas | and I think I fixed the wallaby issues for https://review.opendev.org/c/openstack/nova/+/883726 | |
| 08:50:48 | gibi | bauzas: I have a request in https://review.opendev.org/c/openstack/nova/+/884830 | |
| 08:51:17 | bauzas | gibi: easy request | |
| 08:51:36 | bauzas | gibi: in general, we don't remove that in the backports, amarite elodilles ? | |
| 08:51:47 | bauzas | but sure, I can do it | |
| 08:51:57 | gibi | I think we do, but I deffer to elodilles | |
| 08:54:59 | bauzas | I can hold until he replies | |
| 08:55:20 | bauzas | or the other way | |
| 09:02:52 | elodilles | o/ | |
| 09:03:01 | elodilles | what is the question? :) | |
| 09:04:20 | elodilles | yepp, the conflicts that are not valid anymore just confuse reviewers, so best to drop them | |
| 09:09:36 | bauzas | cool, will do | |
| 09:09:38 | bauzas | elodilles: thanks | |
| 09:14:09 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | |
| 09:14:10 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | |
| 09:14:48 | elodilles | np | |
| 09:14:53 | bauzas | elodilles: your help would be appreciated :) | |
| 09:15:16 | elodilles | i need to be AFK, but sure, when i'll be back i'll review it o:) | |
| 09:15:23 | bauzas | elodilles: could you please look at https://review.opendev.org/c/openstack/nova/+/883724 and then https://review.opendev.org/c/openstack/nova/+/884808/ ? | |
| 09:15:42 | bauzas | elodilles: tl;dr: we want to backport a bugfix down to Wallaby | |
| 09:15:53 | bauzas | and we need to backport a dependent change | |
| 09:16:21 | elodilles | ACK, added to my TODO :) | |
| 09:17:03 | bauzas | thanks | |
| 10:52:55 | gibi | bauzas: could you look at the backports of https://review.opendev.org/q/topic:bug%252F1941005 I think stable/wallaby is the next one | |
| 12:12:44 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 12:12:44 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 13:10:09 | bauzas | gibi: I'll try to look at those patches for sure | |
| 13:22:16 | sean-k-mooney | bauzas: gibi can one of ye review https://review.opendev.org/c/openstack/nova/+/873216 | |
| 13:22:58 | bauzas | sean-k-mooney: it seems a legit bug | |
| 13:23:03 | bauzas | I'll review it | |
| 13:23:45 | sean-k-mooney | bug/feature but its a bug that was reported downstream, which was then fixed by our customer and has been waiting for upstream review for a while | |
| 13:24:44 | sean-k-mooney | we did a downstream bug scub yesterday and this was one of the ones that we decied to try and move forward since it was passing ci and bacially ready to go | |
| 13:50:38 | bauzas | sean-k-mooney: I just Review-Prio +1d it | |
| 13:50:52 | sean-k-mooney | thanks | |
| 14:13:29 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 14:13:30 | opendevreview | Dan Smith proposed openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | |
| 14:13:30 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations https://review.opendev.org/c/openstack/nova/+/879499 | |
| 14:13:31 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| 14:13:31 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | |
| 14:13:32 | opendevreview | Dan Smith proposed openstack/nova master: Add online migration for Instance.compute_id https://review.opendev.org/c/openstack/nova/+/884752 | |
| 14:13:58 | dansmith | well, rebasing a migration due to a conflict is nicer under alembic, that's for sure | |
| 14:21:55 | sean-k-mooney | i have not looked at the delta too closely but i assuem with alembic ist largely just updating some hashes liek this https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py#26 | |
| 14:23:28 | sean-k-mooney | """Another thing to notice is the down_revision variable. This is how Alembic knows the correct order in which to apply migrations. When we create the next revision, the new file’s down_revision identifier would point to this one:""" | |
| 14:23:28 | sean-k-mooney | """Another thing to notice is the down_revision variable. This is how Alembic knows the correct order in which to apply migrations. When we create the next revision, the new file’s down_revision identifier would point to this one:""" | |
| 14:23:59 | dansmith | this is all I had to do: https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py | |
| 14:24:15 | sean-k-mooney | so i guess if a migration has landed in teh interm you just need to update that but your migration will still refer to the same revision ids in the pater patches | |