| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-04-06 | |||
| 17:55:47 | sean-k-mooney | so this comes form the initall commit it seams | |
| 17:55:49 | sean-k-mooney | https://github.com/openstack/nova/commit/b11dbfa4902cdd74bad3745db177d80b1c8b07c6 | |
| 17:57:32 | sean-k-mooney | https://github.com/openstack/nova/blob/b11dbfa4902cdd74bad3745db177d80b1c8b07c6/nova/virt/hardware.py#L1121-L1151 | |
| 17:58:14 | sean-k-mooney | that predates OVOs being split out of nova i think i wonder if it just the clone did not exist then | |
| 17:59:08 | dansmith | no, it did | |
| 17:59:49 | dansmith | perhaps just an omission | |
| 17:59:58 | sean-k-mooney | https://github.com/openstack/nova/blob/b11dbfa4902cdd74bad3745db177d80b1c8b07c6/nova/objects/base.py#L370-L372 | |
| 18:00:04 | sean-k-mooney | so ya it did | |
| 18:00:11 | sean-k-mooney | and since it worked we just didnt clean it up | |
| 18:00:38 | sean-k-mooney | anyway i woudl prefer to proceed with the small fix and maybe swap to that on master in a followup | |
| 18:01:05 | sean-k-mooney | we would ahve to see if there are any field that should not be cloned | |
| 18:01:27 | sean-k-mooney | liek we want to reset the usage filed | |
| 18:01:28 | dansmith | ...that's what I said | |
| 18:02:11 | sean-k-mooney | oh i know im just confirming that looking at the git history its not obvious why that approch was nto taken orginally | |
| 18:02:34 | dansmith | okay | |
| 18:03:44 | sean-k-mooney | ok im going to finish for today. if i dont get to your spec on tuesday feel free to remind me | |
| 18:03:51 | sean-k-mooney | enjoy your weekend o/ | |
| 18:04:05 | opendevreview | Merged openstack/nova stable/xena: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879404 | |
| 18:04:18 | dansmith | ack, thanks, later | |
| #openstack-nova - 2023-04-07 | |||
| 07:39:28 | Uggla | bauzas, can we merge https://review.opendev.org/c/openstack/nova/+/868089, as all fixes from Amit have been merged ? | |
| 07:40:16 | bauzas | Uggla: I can take a look | |
| 07:40:58 | Uggla | bauzas, sure last time you told me that it was ok. But you would like to merge Amit patches first. | |
| 07:41:31 | bauzas | -ETOOMANYBUGFIXESINMYBRAIN | |
| 07:43:21 | bauzas | I wish I could just change some internal SDcard | |
| 07:43:32 | Uggla | bauzas, no hurries. I just want to not forget about it. | |
| 07:44:10 | Uggla | I have another one for review but I will submit it to you next week. I don't want to ruin your Friday. ;) | |
| 07:44:48 | bauzas | well | |
| 07:44:55 | bauzas | my Friday is just a regular Friday | |
| 07:44:58 | bauzas | paperworks and so. | |
| 07:45:15 | bauzas | Gerrit was updated, yet again UI \o/ | |
| 08:49:37 | kashyap | bauzas: "Bugs increase to fill the available time" ;-) | |
| 08:50:14 | kashyap | Original quote: "Work expands to fill the available time" | |
| 11:12:30 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/864730 | |
| 11:15:37 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run the lower constraints jobs as periodics https://review.opendev.org/c/openstack/nova/+/879886 | |
| 11:15:37 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add lower-* unit and functional jobs https://review.opendev.org/c/openstack/nova/+/879885 | |
| 11:15:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: show that lower-* jobs has no false positives https://review.opendev.org/c/openstack/nova/+/879888 | |
| 11:15:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: example bug that caught by lower-* jobs https://review.opendev.org/c/openstack/nova/+/879887 | |
| 12:03:45 | songwenping_ | bauzas, sean-k-mooney: hi guys, i have attach gpu to the vm with 'virsh attach-device --persistent --live' , i can find the gpu in the vm with lspci, but nvidia-smi cnanot find the gpu, with the error 'NVRM: GPU 0000:05:00.0: RmInitAdapter failed! ', is there any advices? | |
| 12:46:03 | dansmith | kashyap: I assume you saw this that tobias-urdin cc'd you on? https://review.opendev.org/c/openstack/nova/+/879021 | |
| 13:08:48 | kashyap | dansmith: Looking; no, I didn't see it. Thanks for notifying me :) | |
| 13:09:31 | kashyap | Okay, yes, it is indeed a long-term TODO that I left to remove it that Tobias has done, nice -- https://review.opendev.org/c/openstack/nova/+/879021/2/nova/virt/libvirt/driver.py | |
| 13:21:34 | kashyap | tobias-urdin: Thanks for the above code! It looks good to me, I just like a double-check from another reviewer about the code-removal in this method, check_can_live_migrate_source() | |
| 15:08:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: show that lower-* jobs has no false positives https://review.opendev.org/c/openstack/nova/+/879888 | |
| 15:08:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: example bug that caught by lower-* jobs https://review.opendev.org/c/openstack/nova/+/879887 | |
| 15:57:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add lower-* unit and functional jobs https://review.opendev.org/c/openstack/nova/+/879885 | |
| 15:57:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: example bug that caught by lower-* jobs https://review.opendev.org/c/openstack/nova/+/879887 | |
| 15:57:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run the lower constraints jobs as periodics https://review.opendev.org/c/openstack/nova/+/879886 | |
| 15:57:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: show that lower-* jobs has no false positives https://review.opendev.org/c/openstack/nova/+/879888 | |
| 16:18:11 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 16:18:12 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| 19:23:09 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations https://review.opendev.org/c/openstack/nova/+/879499 | |
| 19:23:09 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 19:23:10 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | |
| 19:23:10 | opendevreview | Dan Smith proposed openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | |
| 19:23:11 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| #openstack-nova - 2023-04-08 | |||
| 03:45:06 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 03:45:07 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 03:45:07 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 03:45:08 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 03:45:08 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870933 | |
| 03:45:09 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 03:45:09 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 03:45:10 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870937 | |
| 03:45:11 | opendevreview | melanie witt proposed openstack/nova master: Update driver BDMs with ephemeral encryption image properties https://review.opendev.org/c/openstack/nova/+/870939 | |
| 03:45:11 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 03:45:13 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 03:50:55 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw https://review.opendev.org/c/openstack/nova/+/862416 | |
| #openstack-nova - 2023-04-09 | |||
| 19:35:10 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/wallaby: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879405 | |
| #openstack-nova - 2023-04-10 | |||
| 06:37:02 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Add cleanup flag to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | |
| 21:10:48 | opendevreview | Merged openstack/nova master: Make scheduler lazy-load the placement client https://review.opendev.org/c/openstack/nova/+/878238 | |
| 22:46:16 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 22:46:17 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 22:46:17 | opendevreview | melanie witt proposed openstack/nova master: Update driver BDMs with ephemeral encryption image properties https://review.opendev.org/c/openstack/nova/+/870939 | |
| #openstack-nova - 2023-04-11 | |||
| 08:07:46 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Re-propose using extend volume completion action for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877233 | |
| 10:05:50 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix trivial doc issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 12:03:42 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix trivial doc issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 12:50:54 | gibi | bauzas: sean-k-mooney: dansmith: gmann: here is my take on the limited lower constraint job https://review.opendev.org/q/topic:limited-lower-constraints-jobs it already can catch the issue I want to catch (see the example DNM patches) | |
| 12:50:58 | gibi | https://review.opendev.org/q/topic:limited-lower-constraints-jobs | |
| 12:51:52 | bauzas | gibi: ack, will look | |
| 12:52:29 | sean-k-mooney | gibi: is there a reason you are stating which packages to restrict | |
| 12:52:37 | sean-k-mooney | gibi: instead of everything in requirements.txt | |
| 12:53:15 | gibi | sean-k-mooney: yes, I wanted to limit the scope of the lower constraint jobs as we know that pulling everythin back can be tricky | |
| 12:53:40 | gibi | we can try to pull back all our direct depts | |
| 12:53:42 | sean-k-mooney | ok so now its only testing other nova deliverables | |
| 12:54:03 | sean-k-mooney | honsetly those are the ones i was the least worried about | |
| 12:54:25 | gibi | funnily in Zed we delivered nova with a wrong os-traits dept | |
| 12:54:38 | gibi | and that triggered my thinking about this job | |
| 12:54:52 | gibi | *wrong minimum os-traits dept | |
| 12:55:12 | sean-k-mooney | for which feature | |
| 12:55:20 | gibi | let me dig it out | |
| 12:55:32 | sean-k-mooney | there was one that i expicty didint want to bump it for shice it was optional | |
| 12:55:56 | sean-k-mooney | although that was os-brick i think not os-traits | |
| 12:56:22 | gibi | sean-k-mooney: this was the fix https://review.opendev.org/c/openstack/nova/+/858280 | |
| 12:56:59 | gibi | we released RC2 due to this ^^ | |
| 12:57:23 | gibi | and we only detected that in time because zigo was eager to package the RC1 | |
| 12:57:39 | sean-k-mooney | did it cause failusre when pci in placment was disabeld | |
| 12:57:49 | sean-k-mooney | becaus if it did not we should not have released an rc2 for that | |
| 12:58:30 | sean-k-mooney | in zed we had already stop including lower constraits in the PTI | |
| 12:59:39 | zigo | gibi: And it's out of luck that I found it (ie: because using sbuild + git-buildpackage with the experimental as overlay only, which takes packages from unstable unless there's a strong hint that the experimental version is needed...) | |
| 13:00:00 | sean-k-mooney | i guess given it broke unit tests it could break packagers workflows | |