Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-04-04
16:43:20 dansmith bauzas: yeah, I think that's reasonable
16:43:22 gibi bauzas: that is the idea
16:43:28 gmann I am ok to doing 1 and even in check pipeline as unit test also ok
16:43:34 gmann sean-k-mooney: yes
16:43:41 bauzas so a specific tox target ?
16:43:55 gibi bauzas: yepp
16:43:59 bauzas to -epy38-min ?
16:44:00 gmann yeah, that will be helpful to check locally also
16:44:12 bauzas ok, then I don't disagree the idea
16:44:16 dansmith a specific tox target that runs both in a single go would be nice to avoid needing separate unit/functional jobs yeah
16:44:22 bauzas I see
16:44:38 dansmith and I'd prefer periodic until/unless we see it breaking more often
16:44:39 gibi sean-k-mooney, gmann : I agree to aim for 1. If somebody want to find the real lower bound (i.e 2) then that person can play with the requirements.txt and with the new job
16:44:42 bauzas so the tox target would call out a script that would copy/sed reqs.txt by pinning to the mins
16:45:09 gmann gibi: agree
16:45:17 gibi bauzas: yeah
16:45:36 bauzas and the gate would periodically run a job that would call this target
16:45:42 bauzas then I don't disagree
16:45:46 gibi cool
16:45:51 gibi I see an agreement forming :)
16:45:52 bauzas anyone having concerns ?
16:46:05 gibi (now I need to find the time to do the scripting)
16:46:17 bauzas say it now or forever hold your peace
16:46:34 bauzas crickets, all cool
16:46:38 gibi thanks
16:46:44 gibi and sorry again for missing the firday sessions
16:46:51 gibi Friday even
16:47:12 bauzas #agreed gibi to work on a new tox target that would run unittests with a pinned min version of reqs.txt, with a periodic job testing it weekly
16:47:53 bauzas gibi: I guess you may want to do it as well for functional tests but this doesn't harm to me
16:48:14 gibi bauzas: yeah, lets see the unit first, adding functional to it is easy then
16:48:24 bauzas cool
16:48:31 bauzas I think dust is settled now
16:48:43 bauzas anything else before I call it a wrap ?
16:48:47 auniyal bauzas, I dont have anything w.r.t PTG missing item, can we discuss few backports ?
16:48:55 gibi I've updated the etherpad with the link to this meeting log
16:49:10 bauzas gibi: excellent for tracking decisions
16:49:27 bauzas auniyal: are you asking for specific change reviews ?
16:49:36 auniyal I have few backports which can be merged mostly for zed and yoga, I have reviewed them from my end, I would like to request cores to review them
16:49:46 bauzas if so, I'd prefer if you could ping folks off the meeting
16:50:04 bauzas (we generally try to avoid review requests during the meeting, for obvious reasons)
16:50:09 auniyal okay
16:50:23 bauzas (the main one is brevity)
16:50:37 bauzas ok, so, last call ?
16:51:51 bauzas thanks all
16:51:56 gibi o/
16:51:56 opendevmeet Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-04-16.00.log.html
16:51:56 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-04-16.00.txt
16:51:56 opendevmeet Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-04-16.00.html
16:51:56 opendevmeet Meeting ended Tue Apr 4 16:51:56 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
16:51:56 bauzas #endmeeting
16:52:15 elodilles thanks o/
16:53:47 bauzas that's also it for me today
16:53:50 bauzas see ya folks
16:54:21 bauzas for the fun, I want to test virtiofs on my laptop with a windows guest :)
16:57:31 bauzas waaah that works with winfcp
17:01:45 dansmith gibi: sean-k-mooney: can ya'll hit this at some point: https://review.opendev.org/c/openstack/nova/+/878238
17:01:55 dansmith related to a recent conversation we had
17:04:16 gibi dansmith: added to my list
17:04:25 dansmith thanks
17:42:38 opendevreview Dan Smith proposed openstack/nova master: Add compute_id column to instances table https://review.opendev.org/c/openstack/nova/+/879499
17:42:39 opendevreview Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500
17:45:47 dansmith anyone else having trouble with the fast8 target? it's complaining about python not being in the list of allowed externals, presumably because of the install_command override
17:46:06 dansmith adding it causes it to fail install because it tries to install nova to my /usr/local instead of the venv
17:46:37 dansmith other targets don't seem to have any problems
17:48:11 clarkb python shouldn't be in externals because it is in the venv
17:48:25 dansmith I know that's how it should work
17:50:02 dansmith okay I blew away .tox and it may be working
17:50:35 dansmith I cleaned a(n apparently very old) .tox/fast8 before and it didn't fix it, but I think because flake8 now uses .tox/shared
17:50:41 dansmith so removing that seems to have fixed it up
17:51:05 dansmith I dunno how it got confused about that, but it was the python pip install on the nova package that it was failing with that error
17:51:14 dansmith so maybe something to do with me recently upgrading to py311 on my system
17:51:28 dansmith yeah, that worked
17:54:13 dansmith the pep8 target worked, but I guess it doesn't use the shared venv so I guess it got rebuilt and the one fast8 uses didn't trigger it or soemthing
17:59:34 sean-k-mooney it could be related to the fact we now dont set useddevelop
17:59:37 sean-k-mooney or what ever
18:01:20 dansmith we still do for all the regular venvs, AFAICT
18:01:44 dansmith I think it's more likely a stale bin/python link in that venv pointing to the old python3.10 on my system or something
18:01:52 sean-k-mooney as in i cant fine the sepcific thing i was likign for
18:02:02 sean-k-mooney it might be related to this https://github.com/openstack/nova/commit/5e5b6751d32aa50dc372c55b5c2044d0dade51f4
18:02:13 sean-k-mooney but i toug we change how ew used sdigts
18:02:32 sean-k-mooney i tought we did somethign for tox 4
18:02:39 dansmith yeah, that added isntall_command which was the problem
18:03:54 sean-k-mooney ok ya that was the tox 4 change https://review.opendev.org/c/openstack/nova/+/869545
18:04:12 sean-k-mooney i tought thact actully bumped the min version to 4 but it did not
18:04:16 sean-k-mooney just made it compatible
18:55:01 sean-k-mooney dansmith: im going to call it a day but this is the youtube link i added to the vdpa spec https://www.youtube.com/watch?v=zyDSUU0TLB4 its not that long but it answered some of my questions
18:55:22 dansmith I saw the link but haven't watched it
18:55:24 dansmith cool
18:56:21 sean-k-mooney i think we are going to want two flags hw_disk_bus=vdpa-blk and then a second flag for if it requires hardware offload
18:56:48 sean-k-mooney if we want to supprot the software and hardware backends eventually
18:57:20 dansmith hmm okay I guess I don't know why we'd need two flags, but I'm sure it's ignorance.. I'll watch, we can chat tomorrow or later
18:57:55 sean-k-mooney well its vdpa-blk in the guest in either caes but ya watch the vid and we can chat about it whenever
18:57:57 sean-k-mooney o/
18:58:04 dansmith o/
19:34:30 opendevreview Merged openstack/nova stable/yoga: db: Resolve additional SAWarning warnings https://review.opendev.org/c/openstack/nova/+/874065
#openstack-nova - 2023-04-05
09:09:49 opendevreview Sylvain Bauza proposed openstack/nova stable/xena: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866155
09:10:41 opendevreview Sylvain Bauza proposed openstack/nova stable/xena: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866156
09:17:09 bauzas sean-k-mooney: could you please look at this small PTL doc change ? https://review.opendev.org/c/openstack/nova/+/875730
09:46:23 sean-k-mooney bauzas: sure ill review it now. for what its worth i never really found the nova wiki useful
09:46:54 sean-k-mooney so i prefer having this in the main schdule

Earlier   Later