| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-12 | |||
| 09:42:56 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/yoga: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869912 | |
| 09:47:47 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/xena: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869913 | |
| 09:51:15 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/wallaby: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869914 | |
| 09:52:29 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/victoria: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869915 | |
| 09:53:40 | opendevreview | Merged openstack/nova-specs master: Use extend volume completion action https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 09:53:52 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/ussuri: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869916 | |
| 09:55:08 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/train: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869917 | |
| 10:38:56 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 10:39:10 | kashyap | gibi: When you're about --^ | |
| 11:13:30 | auniyal | gibi, right now I have single node devstack setup in that, during this test sql-connection is getting failed at here - https://github.com/openstack/nova/blob/2eb358cdcec36fcfe5388ce6982d2961ca949d0a/nova/compute/manager.py#L1753 | |
| 11:13:53 | auniyal | I think its a env issue, so will be deploying new devstack | |
| 11:14:17 | auniyal | should I go with node have 2 compute node ? or single node would be enough ? | |
| 11:14:52 | auniyal | exact error I am getting is this - "oslo_messaging.rpc.client.RemoteError: Remote error: CantStartEngineError No sql_connection parameter is established" | |
| 12:16:15 | sean-k-mooney | gibi: regardign the hacking check for privsep | |
| 12:17:01 | sean-k-mooney | we dont have to stickly enforce "never import privladged fucntions" it might be nice to but as long as we are deliberate in keeping the contract narrow some limited shareing is proably ok | |
| 12:17:15 | sean-k-mooney | we just dont want to repate teh current issues we have with the shared ones. | |
| 12:18:13 | sean-k-mooney | i dont really know how easy it woudl be to do what you suggested in hacking but its not something im against trying | |
| 12:31:14 | gibi | sean-k-mooney: ack | |
| 12:31:22 | gibi | I agree that this is not a super imporant thing | |
| 12:35:40 | gibi | kashyap: I will check it | |
| 12:36:27 | gibi | auniyal: "No sql_connection parameter is established" means the configuration is incomplete. Yeah try to rebuild devstack | |
| 12:37:10 | kashyap | gibi: 🙏 | |
| 12:37:17 | gibi | auniyal: if you want to reproduce the problem in devstack first then you need two nodes as the BuildFailureWeigher won't fail a build but deproritize the affected compute | |
| 12:37:49 | gibi | auniyal: but I'm not sure how easy it is to fail the late affinity check in devstack without modifying the nova code itself | |
| 12:40:48 | sean-k-mooney | in genreally if you are wokring on schudler or move op related code its good to do at least some testign in a multi node devstack env but i agree with gibi that repoducing in a functional test is goign to be easier then repoducign in a devstack env | |
| 12:43:20 | gibi | kashyap: I'm OK with the direction of https://review.opendev.org/c/openstack/nova/+/869950 | |
| 12:43:51 | gibi | sean-k-mooney: this ^^ is now a patch that do a drop in replacement of the old compare cpu with a new compar hypervisor cpu, much cleaner than the past trials | |
| 12:45:21 | sean-k-mooney | ack that is what i was hoping for ill take a look | |
| 12:46:47 | kashyap | sean-k-mooney: gibi: Thanks! Yeah, it looks clean. I have also asked a Red Hat person to get it tested in a real env | |
| 12:47:08 | sean-k-mooney | this does not seam to be taking account fo the cpu_extra flags | |
| 12:47:17 | kashyap | gibi: Heh, about the wrapping, I did it locally and didn't just commit it | |
| 12:50:09 | gibi | sean-k-mooney: did the old code took account of it? | |
| 12:50:37 | gibi | if so the I think this will too | |
| 12:50:38 | sean-k-mooney | gibi: no which was a bug in the current implemenation | |
| 12:50:42 | gibi | ahh | |
| 12:57:38 | sean-k-mooney | i also dont think compareHypervisorCPU is correct | |
| 12:59:28 | opendevreview | Merged openstack/nova-specs master: Allow local scaphandre directory to be mapped to an instance using virtiofs https://review.opendev.org/c/openstack/nova-specs/+/861881 | |
| 13:16:09 | kashyap | sean-k-mooney: What do you mean by not correct? | |
| 13:16:40 | kashyap | gibi: sean-k-mooney: Again, the extra flags are handled elsewhere and will be considered "together" | |
| 13:17:27 | kashyap | Extra flags are handled here: _get_guest_cpu_model_config() | |
| 13:17:53 | kashyap | (gibi's reading is correc here.) | |
| 13:18:20 | sean-k-mooney | in that case that does not coralate with the know bug | |
| 13:18:48 | kashyap | sean-k-mooney: I gave the fix for the buggy environment to a Red Hat colleague. I'm waiting for that result too | |
| 13:21:27 | sean-k-mooney | kashyap: myu questions are basically related to the fixutre https://review.opendev.org/c/openstack/nova/+/869950/1/nova/tests/fixtures/libvirt.py | |
| 13:21:53 | sean-k-mooney | you seam to have change very little and its surpising that that is sufficent to emulate the new behavior | |
| 13:21:58 | sean-k-mooney | of the new api | |
| 13:22:35 | kashyap | sean-k-mooney: Exactly, I didn't change much of the fixture, as it is indeed a "drop-in" replacement and I don't think we should implement all the internal mechanics of libvirt | |
| 13:23:06 | kashyap | sean-k-mooney: Oh, we can also keep the vendor check there too. I don't think that'll affect it either | |
| 13:23:24 | sean-k-mooney | well then its identical to the ohter one :) | |
| 13:23:34 | sean-k-mooney | so we can just have one function call the other or alias thme | |
| 13:23:47 | kashyap | Yes :) | |
| 13:23:57 | kashyap | How do I alias? | |
| 13:24:01 | sean-k-mooney | have you any concenrs withthe delta in behavior of the fixture/real code | |
| 13:24:18 | sean-k-mooney | compareHypervisorCPU = compareCPU | |
| 13:24:49 | kashyap | I don't have any concerns. I'm just waiting for a real-life test to come back | |
| 13:25:16 | kashyap | Thanks for looking! | |
| 13:29:31 | sean-k-mooney | actually the alais wont work in this case | |
| 13:29:40 | sean-k-mooney | kashyap: the fucntion signiture is differnt | |
| 13:30:00 | kashyap | sean-k-mooney: Err, oh, right. Indeed | |
| 13:30:01 | sean-k-mooney | but you can jsut havc compareHypervisorCPU call compareCPU in the fixutre | |
| 13:30:37 | sean-k-mooney | assuming the vendor bit does not matter | |
| 13:30:56 | kashyap | Yep, it does not matter. I'll do the call and run the tests | |
| 13:49:06 | kashyap | sean-k-mooney: Good you raised the fixture point, I caught a few more buggy unit tests :) | |
| 13:51:29 | kashyap | Hmm, I fixed all but 2 of 'em seem a bit tricky; /me digs | |
| 14:09:11 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 14:20:23 | tobias-urdin | sean-k-mooney: weird question, if one implements a scheduler host filter the RequestSpec.image.properties is a ImageProps class, does that get populated for BFV instances? i.e would it read cached properties of image props for that volume and populate ImageProps or read existing image props for image volume spawned from an populate ImageProps? | |
| 14:20:56 | tobias-urdin | I'm guessing that is cached since it exists in RequestSpec from when it was spawned | |
| 14:29:12 | sean-k-mooney | tobias-urdin: yes its gets populated for BFV instances if the volume was created from a glance image it will have the image properties stored in the volume metadata and we also copy them into the nova databasein two locaionts | |
| 14:29:29 | sean-k-mooney | the request spec and teh instance_system_metadata in teh cell db | |
| 14:31:22 | sean-k-mooney | tobias-urdin: the request spec copy is used for schdulign to avoid needing to get the info out of the cell db | |
| 14:31:24 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L64 | |
| 14:32:21 | sean-k-mooney | the image filed is an nova imagemeta object which has the image properies embded in it https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L75 | |
| 14:35:55 | tobias-urdin | sean-k-mooney: thanks that good then it was like I expected :) as always, thanks for the detailed answer! | |
| 14:45:58 | opendevreview | Sofia Enriquez proposed openstack/nova master: WIP: Implement encryption on backingStore https://review.opendev.org/c/openstack/nova/+/870012 | |
| 14:50:40 | opendevreview | Sofia Enriquez proposed openstack/nova master: WIP: Implement encryption on backingStore https://review.opendev.org/c/openstack/nova/+/870012 | |
| 15:11:09 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 15:12:12 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 15:24:07 | bauzas | shall I propose chatgpt for nova-core ? https://twitter.com/sylvainbauza/status/1613556643945672704 | |
| 15:24:24 | kashyap | bauzas: :D | |
| 15:24:31 | kashyap | bauzas: Please ask it to also fix my unit tests! | |
| 15:24:54 | kashyap | (Or even better, just I submit a blueprint to it, write the rest of the code + docs + tests :P) | |
| 15:24:59 | bauzas | kashyap: its trained data dates from 2021 | |
| 15:25:22 | bauzas | kashyap: but you can ask it why your test is failing, I'm sure it will find you the bug | |
| 15:26:12 | sean-k-mooney | how do you know im not chatgpt in disguise | |
| 15:27:01 | sean-k-mooney | oh chatgpt can spell | |
| 15:27:17 | sean-k-mooney | that a problem if i want to use it to automate my job in secret | |
| 15:27:34 | sean-k-mooney | i should ask it if can respond in seanspeak | |
| 15:27:50 | dansmith | hah | |
| 15:41:13 | kashyap | sean-k-mooney: LOL | |
| 15:41:26 | kashyap | sean-k-mooney: I'd totally believe if you're SeanGPT5 | |
| 15:41:27 | kashyap | ! | |
| 15:45:41 | tobias-urdin | hehe | |
| 15:47:28 | bauzas | sean-k-mooney: hahaha | |
| 15:49:12 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 15:49:54 | bauzas | sean-k-mooney: well, chatgpt sometimes says some wrong answers, but eventually it finds the right one | |
| 15:51:11 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 15:57:38 | noonedeadpunk | hey folks! I was trying to find a way to get `failed_builds` counter through API but I'm not sure I udnerstand what provides ComputeNode object there. As it's not hypervisor, hosts are deperecated... | |
| 15:58:46 | noonedeadpunk | it looks a bit like internal scheduler thing to me at this point... | |
| 15:59:16 | noonedeadpunk | I mean specifically this thing https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/host_manager.py#L261-L262 | |
| 16:01:24 | noonedeadpunk | What I'm trying to do is monitor this counter to see when node falls out from scheduling and fix the issue/restart nova-compute to return it back | |