| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-09 | |||
| 14:35:01 | sean-k-mooney | proably the import_lib version | |
| 14:35:10 | sean-k-mooney | althogh i think we dropped support for python 3.7 | |
| 14:35:30 | sean-k-mooney | we used to have a workaround for older python versions | |
| 14:35:39 | kashyap | Right; I just learn that flake8 on master min requires 3.8 | |
| 14:35:53 | sean-k-mooney | not quite master required 3.8 | |
| 14:36:22 | sean-k-mooney | but importlib_metadata gain suppport for some feautre sin 3.8 | |
| 14:36:38 | sean-k-mooney | before that we had a workaorund when we had 3.6 suoprt still | |
| 14:37:39 | sean-k-mooney | anyway if you can use 3.8 that woudl be better | |
| 14:39:16 | kashyap | Yeah, trying :) | |
| 14:39:50 | sean-k-mooney | you could change [testenv:pep8] to [testenv:pep8{,-py38,-py39,-py310}] | |
| 14:40:04 | sean-k-mooney | pep8 is runnign with your systems default python | |
| 14:40:29 | sean-k-mooney | so your other option is to update the alternitives to make python3.8 the default python | |
| 14:40:47 | sean-k-mooney | actully you can create a python venv with 3.8 and run tox form that too if needed | |
| 14:41:52 | kashyap | It's a new venv; but the pre-commit hook seems to use system python | |
| 14:45:24 | sean-k-mooney | what im suggestign is you should do python3.8 -m venv .venv | |
| 14:45:32 | sean-k-mooney | and install precommit and tox in that | |
| 14:45:49 | sean-k-mooney | and use those to mange your tox envs and commit ectra | |
| 14:46:02 | sean-k-mooney | if you are not able to update your default system python to 3.8+ | |
| 14:46:30 | kashyap | Python 3.10.8 | |
| 14:46:30 | kashyap | $> /usr/bin/python3 --version | |
| 14:46:48 | kashyap | Default system is already well above 3.8+. I just don't know how pre-commit is getting 3.7 | |
| 14:46:59 | sean-k-mooney | od | |
| 14:47:08 | sean-k-mooney | i would unistall and reinstal it | |
| 14:47:25 | kashyap | Yep, tryin | |
| 15:16:15 | kashyap | This fixed it for me: | |
| 15:16:17 | kashyap | $> pre-commit install --allow-missing-config | |
| 15:16:21 | kashyap | $> rm -rf /home/kashyapc/.cache/pre-commit/ | |
| 15:18:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove basepython def from tox.ini https://review.opendev.org/c/openstack/nova/+/869545 | |
| 15:19:53 | gibi | bauzas: ^^ needed to unblock the nova gate | |
| 15:20:02 | gibi | bauzas: and https://review.opendev.org/c/openstack/placement/+/868418 needed to unblock the placement gate | |
| 15:21:26 | opendevreview | Balazs Gibizer proposed openstack/placement master: Make tox.ini tox 4.0.0 compatible https://review.opendev.org/c/openstack/placement/+/868418 | |
| 15:37:20 | darkhorse | artom: I tried to boot from image that is related to the shelved instance but failed. I don't see an image created when I shelve an instance. I tried openstack images list and also checked in the glace > images table in mariadb but nothing is created when I shelve an instance. | |
| 15:46:16 | artom | darkhorse, has to be shelved_offloaded | |
| 15:46:33 | artom | That's either a manual step after the instance is shelved, or done automatically by the cloud depending on config | |
| 15:46:51 | darkhorse | artom: yes its shelved_offloaded. | |
| 15:47:08 | artom | Err, there should be an image... | |
| 15:47:42 | artom | Unless it's boot from volume? I'm not sure about that case | |
| 15:48:06 | darkhorse | no its not boot from volume | |
| 15:48:30 | darkhorse | I launched the instance from cirros image and flavor. | |
| 15:48:42 | bauzas | gibi: sorry was at the school for getting my child | |
| 15:48:45 | bauzas | reviewing the change | |
| 15:48:56 | bauzas | and thanks for having worked on it :) | |
| 15:51:15 | artom | darkhorse, not sure what to tell you. If the shelve was successful there should be an image. | |
| 15:52:45 | darkhorse | Is the image hidden maybe? I guess it is not visible to other users? It's not showing in the horizon dashboard nor from cli when I do openstack image list. | |
| 16:06:59 | artom | Normally only admins can shelve, and admins can see all the images | |
| 16:09:57 | bauzas | I have a network issue folks | |
| 16:10:21 | bauzas | sean-k-mooney: I have a network issue, please move on | |
| 17:07:58 | opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/859312 | |
| 17:08:00 | opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/859313 | |
| 17:14:31 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/859314 | |
| 17:14:32 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/859315 | |
| 17:22:51 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/859320 | |
| 17:22:52 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/859321 | |
| 17:31:46 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/869583 | |
| 17:31:47 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/869584 | |
| 17:34:05 | sean-k-mooney | bauzas: can you take a look at https://review.opendev.org/c/openstack/nova-specs/+/865432 again | |
| 17:34:47 | sean-k-mooney | melwitt: gibi: and if one of ye has time https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 17:35:11 | sean-k-mooney | the cinder spec is appvoed for ^ if i recall | |
| 17:35:35 | sean-k-mooney | https://review.opendev.org/c/openstack/cinder-specs/+/866718 | |
| 17:38:05 | melwitt | sean-k-mooney: I've been meaning to get back to that one 😓 | |
| 17:38:05 | melwitt | sean-k-mooney: I've been meaning to get back to that one 😓 | |
| 17:38:33 | opendevreview | Dan Smith proposed openstack/nova master: Add virt/node module for stable uuids https://review.opendev.org/c/openstack/nova/+/863915 | |
| 17:38:34 | opendevreview | Dan Smith proposed openstack/nova master: Add get_available_node_uuids() to virt driver https://review.opendev.org/c/openstack/nova/+/863917 | |
| 17:38:34 | opendevreview | Dan Smith proposed openstack/nova master: Pass service ref to init_host(), if exists https://review.opendev.org/c/openstack/nova/+/863916 | |
| 17:38:35 | opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 17:38:35 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | |
| 17:38:36 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 17:43:09 | dansmith | melwitt: sean-k-mooney ^ | |
| 17:43:20 | dansmith | I was able to make it all work without removing that test after all it seems | |
| 17:43:50 | sean-k-mooney | cool is ignore WIP status is that more or less feature complete at this point | |
| 17:44:02 | sean-k-mooney | *so ignoring.. | |
| 17:44:05 | dansmith | the two WIP ones just need more tests | |
| 17:44:11 | sean-k-mooney | ack | |
| 17:44:51 | melwitt | ack also | |
| 17:44:52 | sean-k-mooney | but in terms fo the spec i assume that series now covers most of the work itmes or all of it? | |
| 17:45:06 | dansmith | re: that test, I had one thing in the fake driver that was being done earlier in the set than needed, which meant I was triggering the undelete early in the stack before we had the code to handle it | |
| 17:45:14 | dansmith | sean-k-mooney: yeah | |
| 17:47:45 | sean-k-mooney | "lambda: None" ... ok i guess that one way to noop | |
| 17:48:37 | sean-k-mooney | i guess fixtures.MockPatch need a callback functions to work | |
| 17:48:43 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/869585 | |
| 17:48:44 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/869586 | |
| 17:57:42 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check in _check_cpu_compatiblity() https://review.opendev.org/c/openstack/nova/+/869587 | |
| 18:01:39 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check in _check_cpu_compatibility() https://review.opendev.org/c/openstack/nova/+/869587 | |
| 18:06:01 | gmann | gibi: thanks. +2, leaving approval to stephenfin in case anything else missing | |
| 18:08:42 | opendevreview | Ghanshyam Mann proposed openstack/nova master: Enable new defaults and scope checks by default https://review.opendev.org/c/openstack/nova/+/866218 | |
| 18:09:14 | opendevreview | Ghanshyam Mann proposed openstack/placement master: Avoid rbac defaults conflict in functional tests https://review.opendev.org/c/openstack/placement/+/869525 | |
| 18:39:58 | sean-k-mooney | dansmith: nothing major so far just weighed in on the open() discussion https://review.opendev.org/c/openstack/nova/+/863915 i looked into why your useage is actully safe but this change between python 2 and 3 | |
| 18:52:05 | dansmith | sean-k-mooney: yeah I do this all the time to avoid extra indents for no reason.. I'm pretty surprised it's even controversial | |
| 18:52:28 | sean-k-mooney | its not really just never seen this done before | |
| 18:52:54 | sean-k-mooney | but again im pretty sure that was because it was not safe on python 2 but we dont need to supprot that anymore | |
| 18:52:55 | dansmith | also it hasn't changed, python 2.7 works the same way | |
| 18:53:19 | dansmith | I just re-confirmed to convince myself as I still have a system with 2.7 on it | |
| 18:53:20 | sean-k-mooney | well python2 gave you back the file like object but i tough you had to close that | |
| 18:53:38 | dansmith | no, when the last reference goes away it closes | |
| 18:53:40 | sean-k-mooney | ok then this is just the inertia of tutorials | |
| 18:53:46 | sean-k-mooney | ack | |
| 18:54:49 | opendevreview | Ghanshyam Mann proposed openstack/python-novaclient stable/yoga: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869597 | |
| 18:55:21 | dansmith | it's of course not critical to that patch and I could change it, there's just no reason :) | |
| 18:55:33 | opendevreview | Ghanshyam Mann proposed openstack/python-novaclient stable/xena: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869598 | |
| 18:55:50 | sean-k-mooney | ya im not going to block on it if gibi is fine with the explanation | |