| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-10-20 | |||
| 08:46:07 | bauzas | ralonsoh: sorry, I only see 2 topics in our etherpad | |
| 08:46:16 | ralonsoh | bauzas, https://etherpad.opendev.org/p/neutron-antelope-ptg | |
| 08:46:26 | ralonsoh | we have 4 | |
| 09:10:25 | bauzas | ralonsoh: my bad, then I'll remove the 2 topics from the nova etherpad and rather link to the neutron etherpad | |
| 12:33:03 | opendevreview | ribaudr proposed openstack/nova-specs master: Draft spec to support scaphandre https://review.opendev.org/c/openstack/nova-specs/+/861881 | |
| 12:37:29 | opendevreview | ribaudr proposed openstack/nova-specs master: Draft spec to support scaphandre https://review.opendev.org/c/openstack/nova-specs/+/861881 | |
| 12:53:28 | stephenfin | bauzas: I will be an hour late today (14:00 UTC). Feel free to discuss the soft-delete thing in my absence if you need to | |
| 12:54:56 | bauzas | stephenfin: we will first discuss the neutron topics until 1500UTC | |
| 12:55:11 | bauzas | stephenfin: we'll then discuss the nova topics after 1500 | |
| 13:00:25 | bauzas | neutron-nova session starting now in the bexar room | |
| 13:00:43 | bauzas | don't let me feel alone in the dark :) | |
| 13:00:49 | gibi | bauzas: bexar or mitaka? | |
| 13:00:56 | bauzas | bexar, as I wrote :) | |
| 13:01:09 | gibi | OK, the neutron etherpad has mitaka in it | |
| 13:01:31 | sean-k-mooney | lol | |
| 13:01:51 | sean-k-mooney | https://www.openinfra.dev/ptg/rooms/bexar | |
| 13:59:45 | elodilles | (i'll need to change to relmgmt session for now, bbl) | |
| 14:23:08 | bauzas | dang, can't find where we suffix the instance name with multicreate | |
| 14:31:38 | gibi | bauzas: https://github.com/openstack/nova/blob/bcdf5988f6ae902dba9b41144a7b4a60688b627c/nova/compute/api.py#L2031 | |
| 14:31:52 | bauzas | gibi: thanks I was grabbing the compute.api | |
| 14:33:04 | gibi | bauzas: do we continue with nova at 15:00 UTC? | |
| 14:33:12 | gibi | i.e. we have 27m break? | |
| 14:35:09 | bauzas | gibi: we're just discussing one topic about robustify hosntames | |
| 14:35:14 | bauzas | and then we take a break | |
| 14:35:15 | gibi | ack, joined | |
| 17:35:27 | stephenfin | melwitt: Regarding https://paste.opendev.org/show/bTNEGH3Z97Ee1Em5zcGI/, for the first bit that seems to be an argparse limitation https://stackoverflow.com/questions/23032514/argparse-disable-same-argument-occurrences | |
| 18:47:54 | darkhorse | Hi team | |
| 18:48:28 | darkhorse | I am trying to fix a nova issue that instance delete action log is not added when deleting a shelved_offloaded instance. | |
| 18:48:42 | darkhorse | https://review.opendev.org/c/openstack/nova/+/861951 | |
| 18:49:26 | darkhorse | I committed the patchset but the CI build fails. Can anyone help figuring out why it fails? | |
| 18:59:46 | frickler | fyi I kind of answered the above in #openstack-dev | |
| 19:38:26 | darkhorse | @frickler | |
| 19:38:36 | darkhorse | Thank you for your information. | |
| 19:38:55 | darkhorse | How can I verify if the bug exists in master branch? | |
| 22:22:47 | melwitt | stephenfin: ack, I never noticed that before with argparse in general. looking at that stackoverflow, I believe I've seen the if len(args.things) > 1: raise error saying no repeats method before for handling that scenario | |
| 22:23:27 | melwitt | but it's good to know this is "expected behavior" from argparse | |
| #openstack-nova - 2022-10-21 | |||
| 07:14:33 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861871 | |
| 07:14:34 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861872 | |
| 09:14:01 | opendevreview | Slawek Kaplonski proposed openstack/nova master: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/855664 | |
| 09:41:06 | opendevreview | Amit Uniyal proposed openstack/nova stable/zed: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861856 | |
| 09:41:07 | opendevreview | Amit Uniyal proposed openstack/nova stable/zed: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861857 | |
| 09:46:57 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861871 | |
| 12:52:18 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/861871 | |
| 12:52:19 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/861872 | |
| 13:01:31 | bauzas | reminder : we start now our last PTG day, just sayin' :) | |
| 13:03:26 | sean-k-mooney | oh | |
| 13:03:34 | sean-k-mooney | ah ill get coffee then join | |
| 13:03:40 | sean-k-mooney | feel free to start without me | |
| 13:03:46 | sean-k-mooney | ill be 5 minutes | |
| 13:03:49 | bauzas | cool | |
| 13:55:17 | bauzas | stephenfin: we're about to discuss your OSC topic next in a second | |
| 13:56:03 | stephenfin | bauzas: I'm in the SDK/OSC session :( Can you take notes and I can address async? | |
| 13:56:21 | bauzas | stephenfin: oh, when is this session done ? | |
| 13:56:30 | stephenfin | 1 hour | |
| 13:56:49 | bauzas | stephenfin: I see, ending at 3pm UTC ? | |
| 13:57:02 | stephenfin | yes | |
| 14:30:13 | darkhorse | Hi team | |
| 14:30:20 | darkhorse | File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/fixtures/nova.py", line 224, in _poison_configure | |
| 14:30:21 | darkhorse | Exception: This test uses methods that set internal oslo_db state, but it does not claim to use the database. This will conflict with the setup of tests that do use the database and cause failures later. | |
| 14:30:21 | darkhorse | raise Exception('This test uses methods that set internal oslo_db ' | |
| 14:31:18 | darkhorse | I have committed a patchset to fix the issue that I reported [here] (https://bugs.launchpad.net/nova/+bug/1993736) | |
| 14:31:49 | darkhorse | I am getting a CI build error above. | |
| 14:32:11 | darkhorse | What does that exception mean and how can I fix it? | |
| 14:33:11 | gibi | darkhorse: you have a unit test case that actaully try to hit the DB | |
| 14:33:46 | gibi | could you point to the failure in CI? | |
| 14:37:46 | darkhorse | yes my patch is trying to add delete action log for shelved instances. when an instance is deleted at shelved_offloaded state, delete action is not added to action-list. | |
| 14:38:08 | darkhorse | https://review.opendev.org/c/openstack/nova/+/861951 | |
| 14:38:17 | darkhorse | here is the patchset | |
| 14:38:29 | darkhorse | and this is the failure in CI | |
| 14:38:37 | darkhorse | https://zuul.opendev.org/t/openstack/build/0ed00dd1d0354da9b7724f32339f063e | |
| 14:39:51 | darkhorse | gibi: thank you for replying to my questions. | |
| 14:43:28 | gibi | darkhorse: so that unit test case https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/tests/unit/compute/test_api.py#L7908 is set up in a way that it mocks out every call that touches the DB. But the patch https://review.opendev.org/c/openstack/nova/+/861951 added a new call _record_action_start that is eventually write to the DB | |
| 14:45:59 | gibi | darkhorse: so you have to change the test to also mock _record_action_start | |
| 14:46:38 | darkhorse | gibi: will you point me how to do that? | |
| 14:47:21 | gibi | darkhorse: you can look at the other tests in https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/tests/unit/compute/test_api.py#L7908 how mocking is doen | |
| 14:47:25 | gibi | done | |
| 14:47:50 | gibi | for example https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/tests/unit/compute/test_api.py#L8090-L8102 is mocking _record_action_start | |
| 14:58:41 | darkhorse | gibi: thank you so much!! | |
| 15:23:51 | bauzas | thanks folks, was a productive PTG | |
| 15:37:56 | gibi | bauzas: thanks for running it | |
| 15:39:33 | melwitt | bauzas: thank you for connecting me with whoami-rajat for ptg, cinder team were able to fit me in the agenda and we had a good chat and a way forward | |
| 15:39:52 | bauzas | ++ | |
| 17:02:19 | whoami-rajat | melwitt, thanks for joining and discussing it | |
| 17:02:46 | melwitt | ++ | |
| 18:37:06 | opendevreview | Alex Chan proposed openstack/nova stable/xena: fix instance action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/861951 | |
| 19:14:12 | opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/836016 | |
| 19:14:13 | opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Adds regression test for bug LP#1944619 https://review.opendev.org/c/openstack/nova/+/862401 | |
| 19:18:40 | opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Adds regression test for bug LP#1944619 https://review.opendev.org/c/openstack/nova/+/838332 | |
| 19:18:41 | opendevreview | Erlon R. Cruz proposed openstack/nova stable/wallaby: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/836016 | |
| 20:14:24 | opendevreview | Alex Chan proposed openstack/nova master: record action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/862404 | |
| #openstack-nova - 2022-10-22 | |||
| 02:19:04 | opendevreview | melanie witt proposed openstack/nova master: DNM testing images_type = raw with resize enabled https://review.opendev.org/c/openstack/nova/+/862416 | |
| 02:21:15 | opendevreview | melanie witt proposed openstack/nova master: DNM testing images_type = raw with resize enabled https://review.opendev.org/c/openstack/nova/+/862416 | |
| 07:01:41 | opendevreview | melanie witt proposed openstack/nova master: DNM testing images_type = raw with resize enabled https://review.opendev.org/c/openstack/nova/+/862416 | |
| 13:03:34 | opendevreview | melanie witt proposed openstack/nova master: DNM testing images_type = raw with resize enabled https://review.opendev.org/c/openstack/nova/+/862416 | |
| #openstack-nova - 2022-10-24 | |||
| 09:34:57 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 09:34:58 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 09:54:16 | sean-k-mooney1 | sahid: ill try to summerise the ptg discussion on the spec review but when we discussed you feature we agreed on two high level things. | |
| 09:55:06 | sean-k-mooney1 | 1.) we wont ask you to fix all the drivers to not start the vms, we will file that as an existing bug and adress that later although your free to do that too once your feature is complete | |
| 09:55:38 | sean-k-mooney1 | 2.) we dont wat to add a new api parmater. instead we woudl prefer the new micro verion to just make evacuate always evacuate to powered off | |
| 09:57:52 | sean-k-mooney | sahid: what that means for you is all the rpc changes you made are still correct and can be resused but you do not need to add a new api parmater, the new microversion means set the target state to stopped and old means dont pass it for the rpc call. | |