| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-09-12 | |||
| 14:34:56 | zigo | gibi: In oslo.concurrency, I tried reverting "Fix fair internal lock used from eventlet.spawn_n" and it was still stuck, so now I'm trying to revert "Prove that spawn_n with fair lock is broken" ... | |
| 14:35:35 | sean-k-mooney | zigo: just an an fyi that fix is needed | |
| 14:35:49 | sean-k-mooney | zigo: without it none of the fair logs in nova actully work | |
| 14:36:07 | zigo | You mean the "Fix fair internal lock used from eventlet.spawn_n" ? | |
| 14:36:14 | sean-k-mooney | yes | |
| 14:36:24 | sean-k-mooney | that is required for correctness | |
| 14:36:26 | zigo | Right, though it doesn't seem to be the brokenness ... | |
| 14:36:31 | sean-k-mooney | ack | |
| 14:39:43 | zigo | It passed ... | |
| 14:40:27 | zigo | Removing https://review.opendev.org/c/openstack/oslo.concurrency/+/855713 fixed my issue. | |
| 14:42:49 | gibi | as I noted earlier you are probably running those test ^^ without monkey patching hence the they stuck | |
| 14:43:20 | gibi | you have no better option now but removing those tests | |
| 14:43:38 | gibi | but you still have to keep the fix form "Fix fair internal lock used from eventlet.spawn_n"as sean-k-mooney noted | |
| 14:44:30 | zigo | I did. | |
| 14:45:09 | zigo | gibi: Is it possible that I'm running into this problem because I'm not doing `TEST_EVENTLET=0 lockutils-wrapper` before stestr run ? | |
| 14:45:23 | gibi | zigo: yes, I think so | |
| 14:45:29 | zigo | Ok, will try. | |
| 14:46:16 | zigo | Thanks. | |
| 14:57:13 | zigo | Indeed, that looks like fixing the issue, thanks gibi! :) | |
| 14:58:08 | gibi | as a follow up we need a better handling of those test in oslo.concurrency. The eventlet specific test should be skipped if TEST_EVENTLET is not requested | |
| 15:11:42 | zigo | I'd prefer if the whole unit test suite was failing with a TEST_EVENTLET is not set ... | |
| 15:11:56 | zigo | This way, a guy like me would know what to do... :) | |
| 15:12:02 | zigo | (just my 2 cents of advice...) | |
| 15:27:15 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: [doc] Add os_vif configuration options https://review.opendev.org/c/openstack/nova/+/857202 | |
| 15:27:27 | gibi | zigo: yeah it is not helpful if the test just stuck | |
| 22:10:17 | JayF | So heads up, it looks like there might be some persistent failure in stable/yoga: https://review.opendev.org/c/openstack/nova/+/854257 the openstacksdk functional job has failed almost every time on this change (and it's clearly unrelated) | |
| 22:10:49 | JayF | I didn't see it mentioned on the etherpad so I figured I'd mention it here. I'm not too attached to that patch specifically anymore (all the things we know need backporting from Ironic driver have been) -- but it works well as a test case to see the failures. | |
| #openstack-nova - 2022-09-13 | |||
| 08:24:11 | Uggla | sean-k-mooney[m], can you please recall me the link to your devstack installation tool using ansible + molecule ? | |
| 09:39:30 | whoami-rajat | hi sean-k-mooney , can you take a look at the comment here? basically stephenfin wants to rename the parameter to reimage-boot-volume and add a negative parameter along with it https://review.opendev.org/c/openstack/python-openstackclient/+/831014/7/openstackclient/compute/v2/server.py#3095 | |
| 10:32:23 | zigo | I'm reading Nova release notes for Zed, and saw the thingy about hw:locked_memory. I wonder: what's the point of this feature? In which case one would want the memory to be locked, and to achieve what? Is this a security feature? | |
| 10:36:43 | sean-k-mooney | zigo: o/ | |
| 10:37:01 | zigo | :) | |
| 10:37:06 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check if blk_dev_info has correct falvor.swap https://review.opendev.org/c/openstack/nova/+/857339 | |
| 10:37:49 | sean-k-mooney | zigo: it was added for the viommu feature not because it requires it but on some aarch64 systems we needed to lock the memoy so that the acclerator could properly do a dma transfer | |
| 10:38:41 | sean-k-mooney | on x86 in general you dont need to do it at least when booting with pci device passhtough libvit will lock enough for the inital devices | |
| 10:38:55 | zigo | Oh, I see... So that's related to HW accelleration. Makes sense. | |
| 10:39:02 | sean-k-mooney | zigo: it was already used implictly when you enabled realtime cpus | |
| 10:39:27 | sean-k-mooney | yep locking the memory marks it as unswappable and unmovable | |
| 10:44:54 | sean-k-mooney | but if you do now you can | |
| 10:44:54 | sean-k-mooney | anything else catch your eye? | |
| 10:44:54 | sean-k-mooney | most of the time you do not need that kind of guarentee | |
| 12:25:17 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Add API for assisted volume extend https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 12:42:04 | opendevreview | Bence Romsics proposed openstack/nova stable/victoria: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/857423 | |
| 12:58:03 | opendevreview | Bence Romsics proposed openstack/nova stable/ussuri: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/857427 | |
| 13:30:10 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Add API for assisted volume extend https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 14:23:46 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Add API for assisted volume extend https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 15:17:35 | bauzas | reminder : nova meeting in 43 mins | |
| 15:17:39 | bauzas | here* | |
| 15:33:17 | elodilles | bauzas: i'll do a quick update now to the stable section if you are not editing right now the agenda on the meeting page | |
| 15:34:14 | bauzas | elodilles: do it now, I was working on the prelude change so I didn't had time yet to edit it | |
| 15:39:08 | elodilles | bauzas: ack, thanks, done | |
| 15:39:23 | bauzas | elodilles: ok, will do it now | |
| 15:42:48 | opendevreview | Sylvain Bauza proposed openstack/nova master: Prelude section for Zed release https://review.opendev.org/c/openstack/nova/+/857467 | |
| 16:00:11 | gibi | o/ | |
| 16:00:12 | elodilles | o/ | |
| 16:00:17 | gibi | heh | |
| 16:00:18 | gibi | :) | |
| 16:00:19 | Uggla | o/ | |
| 16:00:23 | sean-k-mooney | o/ | |
| 16:00:26 | gibi | we are too fast | |
| 16:00:38 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:38 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:38 | opendevmeet | Meeting started Tue Sep 13 16:00:38 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:38 | bauzas | #startmeeting nova | |
| 16:00:45 | bauzas | heh | |
| 16:00:47 | dansmith | o/ | |
| 16:00:52 | bauzas | sorry, was finishing to update the agenda :) | |
| 16:01:02 | bauzas | you can raise hands if you want tho | |
| 16:01:07 | bauzas | or meh | |
| 16:01:14 | bauzas | bonjour everyone | |
| 16:01:17 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:46 | bauzas | ok, let's start, I'm pretty sure people who started earlier are not already gone | |
| 16:01:55 | bauzas | #topic Bugs (stuck/critical) | |
| 16:02:01 | bauzas | #info One Critical bug | |
| 16:02:07 | bauzas | #link https://bugs.launchpad.net/nova/+bug/1988311 Now u-c updated https://review.opendev.org/c/openstack/requirements/+/856044 shall we set to High or close the bug ? | |
| 16:02:12 | bauzas | #link https://bugs.launchpad.net/nova/+bug/1988311 Now u-c updated https://review.opendev.org/c/openstack/requirements/+/856044 shall we set to High or close the bug ? | |
| 16:02:17 | bauzas | so, | |
| 16:02:33 | bauzas | oslo.concurrency now is released with 5.0.1 | |
| 16:02:39 | bauzas | upper-constraints are now updated | |
| 16:02:47 | bauzas | #link https://review.opendev.org/c/openstack/requirements/+/856044 | |
| 16:03:26 | bauzas | I verified and both stable/yoga and master ask for oslo.concurrency older than 4.5.0 | |
| 16:03:36 | bauzas | https://review.opendev.org/c/openstack/requirements/+/856044 | |
| 16:03:41 | sean-k-mooney | if the locks are now fixed with the oslo release we could clsoe but we need to raise our min verion | |
| 16:03:52 | bauzas | so technically, I haven't checked but our gate uses the latest version | |
| 16:04:00 | sean-k-mooney | otherwise the problem still exstis and we might need to work around it on stable branches in nvoa | |
| 16:04:02 | bauzas | sean-k-mooney: correct, that's my point | |
| 16:04:26 | bauzas | so we need to bump our mins for both yoga and master | |
| 16:04:26 | sean-k-mooney | gibi i assume we will backprot the eventlet fix in oslo | |
| 16:04:28 | sean-k-mooney | to stable | |
| 16:04:41 | sean-k-mooney | we cant bump mins on stable | |
| 16:04:53 | sean-k-mooney | but we need to backport and ensure its allwoed by upper constratis | |
| 16:05:01 | sean-k-mooney | or we need to patch the lock in nova | |
| 16:05:05 | sean-k-mooney | and backprot that | |
| 16:05:13 | gibi | I assume we backport the fix in oslo | |
| 16:05:21 | sean-k-mooney | that would be my prefernce too | |
| 16:05:22 | gibi | but I did not have time to propose that | |
| 16:05:37 | bauzas | ok, at least I propose to set the bug to High | |
| 16:05:47 | bauzas | the gate isn't longer impact, our distros are tho | |
| 16:05:49 | sean-k-mooney | ack | |
| 16:05:54 | bauzas | impacted* | |