| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-29 | |||
| 18:08:17 | whoami-rajat | ack | |
| 18:08:36 | sean-k-mooney | the functional test are almost finsihed locally and then ill push likely in the next 60 secons | |
| 18:08:44 | sean-k-mooney | just making sure it will pass ci | |
| 18:13:14 | opendevreview | sean mooney proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 18:13:23 | sean-k-mooney | whoami-rajat: ^ there you go | |
| 18:13:33 | whoami-rajat | ack | |
| 18:13:56 | sean-k-mooney | this was the fix https://review.opendev.org/c/openstack/nova/+/816157/14..15/nova/tests/unit/api/openstack/compute/test_server_actions.py | |
| 18:54:01 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 18:54:02 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 18:54:02 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 18:58:13 | whoami-rajat | updated the series however I'm still facing some functional test failure related to green thread queue, I figured it might be my environment so pushed to see what gate thinks | |
| 18:58:57 | opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| 19:02:46 | gmann | dansmith: ^^ fixed as per review comments | |
| 20:14:54 | opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| 20:15:27 | gmann | dansmith: ^^ updated, I have fixed your comments | |
| 20:15:32 | dansmith | gmann: looking now | |
| 20:16:35 | dansmith | gmann: done thanks | |
| 20:17:46 | gmann | dansmith: thanks | |
| 22:24:00 | opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| #openstack-nova - 2022-08-30 | |||
| 06:57:22 | bauzas | good morning Nova | |
| 07:48:27 | gibi | bauzas: welcome back | |
| 07:50:44 | bauzas | gibi: thanks | |
| 09:08:00 | gibi | the user_data patch looks good to me, but needs a second code. The rebuild of bfv also look good to me but I have some nits that can be fixed in the last patch or as a follow up if needed | |
| 09:10:11 | gibi | I will keep an eye on the manila series | |
| 09:10:45 | kgube | hi, I'm new to Nova development! I've been working on a blueprint+spec that I'd like to submit and get feedback on, but I have been wondering, should I wait with this until after the Zed release? | |
| 09:17:21 | sean-k-mooney | kgube: if its a spec you can submit it to the spec repo now | |
| 09:17:39 | gibi | kgube: welcome! | |
| 09:17:41 | sean-k-mooney | kgube: it might not get much review for the next week or two but you can feel free to create it | |
| 09:17:56 | gibi | kgube: it is a good time to submit the spec as we soon be freed up from Zed and start planning the AA cycle | |
| 09:18:29 | sean-k-mooney | kgube: once we release our first release candiate the master banch will technically be open for the a cycle development | |
| 09:18:47 | sean-k-mooney | although we tend not to merge large changes until the final release is done | |
| 09:19:45 | gibi | kgube: also if the spec is a bit controversial then we can add it to the AA PTG planning to discussit in real time | |
| 09:20:15 | kgube | alright, thanks for the info! | |
| 09:20:24 | gibi | sean-k-mooney: I've replied your question in https://review.opendev.org/c/openstack/nova/+/853835 | |
| 09:25:15 | sean-k-mooney | gibi: thanks ill look again shortly. most o fthe seriese i looked at looks good | |
| 09:25:33 | sean-k-mooney | i see a good split point again about half way through the open patches | |
| 09:26:10 | sean-k-mooney | around here ish https://review.opendev.org/c/openstack/nova/+/854440 | |
| 09:26:44 | kgube | sean-k-mooney: since AA is not yet available in the spec repo, should I submit it to Zed for now? | |
| 09:27:50 | sean-k-mooney | kgube: you can just creat the directory locally like dan did here https://review.opendev.org/c/openstack/nova-specs/+/853837 | |
| 09:28:09 | sean-k-mooney | kgube: ill create a patch to do it properly later today | |
| 09:28:19 | sean-k-mooney | and then you can rebase when its merged | |
| 09:28:34 | sean-k-mooney | for now just copy the zed template and use that for the basis of the spec | |
| 09:28:39 | kgube | alright! | |
| 09:29:03 | sean-k-mooney | i dont think we plan to update it for antelope currently | |
| 09:34:24 | bauzas | I was planning to do the AA paperwork right after Zed-3 FWIW | |
| 09:35:35 | sean-k-mooney | ack well that thursday so if you want to create it go for it otherwise ill go create it when i get time | |
| 09:35:49 | sean-k-mooney | we have two things to do for the specs repo | |
| 09:35:58 | sean-k-mooney | one create teh new folder and copy the template | |
| 09:36:20 | sean-k-mooney | two run the script to move/symlink the implemented specs | |
| 09:36:41 | sean-k-mooney | that second task uses the bluepirnt state in launchpad to generate teh list | |
| 09:36:59 | sean-k-mooney | so that is better to wait until next week when everything is updated before we do that | |
| 09:40:18 | gibi | sean-k-mooney: ack | |
| 09:52:58 | bauzas | sean-k-mooney: moving the specs is generally planned for RC1 https://docs.openstack.org/nova/latest/contributor/ptl-guide.html#milestone-3 | |
| 09:53:17 | bauzas | I mean approved => implementeds | |
| 09:59:47 | sean-k-mooney | yep | |
| 10:00:02 | sean-k-mooney | that is to account for possible FFEs | |
| 10:30:25 | sean-k-mooney | kgube: what is the thing you have been working on by the way | |
| 10:38:47 | kgube | sean-k-mooney: support for extending attached file-based volumes (such as NFS volumes) | |
| 10:39:05 | sean-k-mooney | oh that shoudl already exists | |
| 10:39:23 | sean-k-mooney | provided the cinder volume supprots it | |
| 10:39:40 | sean-k-mooney | i rememebr that case being speical but i belive it should work | |
| 10:40:10 | sean-k-mooney | ah yes https://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_online_extend_support | |
| 10:40:24 | sean-k-mooney | Generic NFS Reference Driver (NFS): missing | |
| 10:41:04 | sean-k-mooney | but some vendor nfs drivers supprot it | |
| 10:41:06 | sean-k-mooney | Veritas Cluster NFS Driver (NFS): complete | |
| 10:41:12 | sean-k-mooney | NetApp Data ONTAP Driver (iSCSI, NFS, FC): complete | |
| 10:41:27 | sean-k-mooney | kgube: so that is likely a cidner feature rahter then a nova one | |
| 10:41:33 | kgube | sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1978294 | |
| 10:43:16 | sean-k-mooney | hum | |
| 10:43:35 | sean-k-mooney | im not sure if we really want nova to have logic to resize these volumes on behalf of the backend | |
| 10:43:50 | sean-k-mooney | i guess we can review your proposal | |
| 10:44:04 | sean-k-mooney | but i would proably push this towards os-brick | |
| 10:44:12 | kgube | the logic is already there, though | |
| 10:44:21 | sean-k-mooney | or require the backend driver to do it not nova | |
| 10:44:45 | kgube | its just exposed as an external server event only | |
| 10:44:55 | sean-k-mooney | changing the external events api to be synconous is likely not somethign we can do | |
| 10:45:22 | kgube | The problem is that QEMU has to perform the resize | |
| 10:45:35 | sean-k-mooney | qemu or qemu image | |
| 10:45:46 | sean-k-mooney | *qemu-img | |
| 10:46:21 | kgube | qemu holds a lock on the attached file, which qemu-img respects | |
| 10:46:38 | kgube | so it refuses to resize | |
| 10:46:41 | sean-k-mooney | right but you can call qemu-img with force-share | |
| 10:47:05 | sean-k-mooney | my understandign is that is what the nfs driver normally did to reseize the device | |
| 10:47:10 | sean-k-mooney | is that not the case | |
| 10:47:22 | kgube | that does not work for modifying the image, afaik | |
| 10:48:39 | kgube | and the qemu-img docu explicitely warns against modifying attached volumes | |
| 10:49:58 | sean-k-mooney | i see | |
| 10:50:04 | sean-k-mooney | then rather then a new server action | |
| 10:50:29 | sean-k-mooney | i think you should modle the new api on the existing /os-assed-volume-shapshots api | |
| 10:50:31 | sean-k-mooney | https://docs.openstack.org/api-ref/compute/#create-assisted-volume-snapshots | |
| 10:51:40 | sean-k-mooney | actully https://docs.openstack.org/api-ref/compute/#assisted-volume-snapshots-os-assisted-volume-snapshots is slight better link | |
| 10:52:19 | sean-k-mooney | you could add a /os-assisted-volume-extend api for this usecase | |
| 10:52:57 | sean-k-mooney | that can be blocking or nonblocking as its a new api for this exact usecase | |
| 10:53:43 | sean-k-mooney | its not really a server action like the other instance actions hence new top level api | |
| 10:54:41 | kgube | ok, yeah, I guess that makes sense | |
| 10:56:24 | kgube | so Cinder does not need to care which instance the volume is attached to | |
| 10:58:43 | sean-k-mooney | well im not actully sure why we dont include the instance uuid it woudl make our life simpler | |
| 10:59:06 | sean-k-mooney | so i would proably include it in teh request as its simpelr for use to then make the rpc to the compute node work | |
| 11:00:05 | sean-k-mooney | im not actully user that /os-assisted-volume-snapshots works properly for multi_attach volumes for example | |
| 11:00:26 | sean-k-mooney | although i suspect that is not supproted via nfs backends | |