| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-29 | |||
| 13:56:16 | sean-k-mooney | in a new test | |
| 13:56:35 | dansmith | sean-k-mooney: we always make calls at the lowest version they need | |
| 13:56:42 | sean-k-mooney | and by pinning to the X.0 we meake suer we did not break it | |
| 13:56:46 | sean-k-mooney | ok | |
| 13:56:47 | dansmith | so calls that haven't changed since the last major bump are made at .0 | |
| 13:57:04 | sean-k-mooney | ya i tought we did it the other way but that makes sense why we do it this way | |
| 13:59:34 | opendevreview | sean mooney proposed openstack/nova stable/yoga: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/855022 | |
| 13:59:35 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/855023 | |
| 13:59:36 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking https://review.opendev.org/c/openstack/nova/+/855024 | |
| 13:59:37 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/855025 | |
| 13:59:38 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/855026 | |
| 13:59:40 | opendevreview | sean mooney proposed openstack/nova stable/yoga: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/855035 | |
| 14:00:55 | sean-k-mooney | dansmith: by the way the 5.x support is already deprecated yes we should ensure we can drop it next cycle without being impacted by the new lifecycle | |
| 14:01:25 | sean-k-mooney | we dont have to drop it next cycle but i dont want to be force to keep it until BB | |
| 14:01:39 | dansmith | I dunno, I thought we were thinking about keeping it around for longer | |
| 14:01:43 | sean-k-mooney | now that we have 6.X RPCs | |
| 14:02:07 | sean-k-mooney | well we shoudl dicuss it i guess | |
| 14:02:21 | sean-k-mooney | the epecation in yoga was no new deploymets would use 5.X | |
| 14:02:43 | sean-k-mooney | but we were keeping the compat for zed | |
| 14:17:09 | dansmith | whoami-rajat: the patch underneath you has shifted again, so you should rebase *on* it before you push if possible | |
| 15:02:28 | hkominos | Hi guys! I have a question regarding policies that I want to ask. When we edit lets say /etc/nova/policy.json , is the nova-api process that will read these new policies or the keystone process ? | |
| 15:06:02 | dansmith | nova-api | |
| 15:06:13 | hkominos | thx ! | |
| 15:24:06 | gmann | gibi: dansmith: please check this documentation and releasenote for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| 15:24:15 | gibi | gmann: will check sooon | |
| 15:24:20 | gmann | thanks | |
| 16:30:58 | whoami-rajat | dansmith, yep, this time i first rebased on top of it then made changes :) | |
| 16:31:07 | dansmith | whoami-rajat: good :) | |
| 17:36:16 | sean-k-mooney | gibi: https://review.opendev.org/c/openstack/nova/+/816157/14#message-b94abbc42dea06b9d989f698ffbee826a9283a19 should fix the failing unit test in the userdata update patch | |
| 17:37:45 | gibi | sean-k-mooney: thanks for looking into that | |
| 17:38:12 | sean-k-mooney | the os-traits relases happened at the weekend yes? | |
| 17:38:18 | gibi | I think so | |
| 17:38:36 | gibi | otherwise the user_data patch could not bump the os-traits req in nova successfully | |
| 17:38:39 | gibi | but it did :) | |
| 17:39:01 | sean-k-mooney | ya actully my tox env was able to pull in the traits too | |
| 17:39:09 | sean-k-mooney | just looking at the api check for the trait now | |
| 17:39:15 | gibi | yepp it was merged on fridayt https://review.opendev.org/c/openstack/releases/+/854617 | |
| 17:39:27 | sean-k-mooney | i think that was the last thing that needed to be updated since i last looked | |
| 17:39:39 | sean-k-mooney | so once the unit test is fixed i think its ready to go | |
| 17:39:48 | sean-k-mooney | just going to finish reviewing the rest of the change | |
| 17:40:16 | gibi | yes, I had the same feeling this morning | |
| 17:40:20 | gibi | it is fairly close | |
| 17:40:42 | sean-k-mooney | do we have a way to reach out to the author | |
| 17:40:56 | sean-k-mooney | do we know what timezone they are in? | |
| 17:42:56 | gibi | he was on nova before with the nick jhartkopf but I don't know him | |
| 17:43:15 | sean-k-mooney | looks like its a german email so emea timezones most likely | |
| 17:43:35 | gibi | he updated the patch over the weekend so I think he is still actively engaged with this | |
| 17:43:39 | sean-k-mooney | ok lets see if they update it in the morning | |
| 17:43:40 | dansmith | if it's a semi-trivial test fix, perhaps we could just fix it for him? | |
| 17:44:01 | sean-k-mooney | i mean i can do that if its ok with ye | |
| 17:44:03 | dansmith | like, unless it's likely he has other things pending, the risk is low ... | |
| 17:44:24 | sean-k-mooney | i dont think there is honestly anythign that could not be in a follow up change | |
| 17:44:29 | gibi | I can do the test fix earlies tomorrow morning, but sean-k-mooney if you can do it I can review it | |
| 17:44:54 | dansmith | it just sounded like sean-k-mooney has the fixes locally for testing, so might as well just push and update | |
| 17:46:02 | sean-k-mooney | yep i have ok i can push them let me see if i have any pep issue first and run the full set of unit and funcitonal tests. | |
| 17:47:32 | sean-k-mooney | if im pushing this do ye want me to cherry-pick the follow up patches and or rebases it to master | |
| 17:48:00 | sean-k-mooney | i think its relitivly up todate but i know ye were waiting on a rebase over the weekend | |
| 17:48:06 | sean-k-mooney | i think that was already done | |
| 17:48:27 | dansmith | nah, I'd just push that up and let whoami-rajat rebase on the result | |
| 17:48:37 | dansmith | oh, sorry, | |
| 17:48:55 | dansmith | the follow-ups.. I dunno, less concerned about that than just the main one which is the key in the pipeline | |
| 17:49:14 | sean-k-mooney | well followups i ment whoami-rajat seriese | |
| 17:49:29 | sean-k-mooney | but sure ill just update this one when the test finish | |
| 17:49:32 | dansmith | I'd let him do it, he's working on them now I htink | |
| 17:49:37 | sean-k-mooney | and then whoami-rajat can update there set | |
| 17:49:41 | dansmith | yea | |
| 17:54:37 | opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out base class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | |
| 17:54:37 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 17:54:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |
| 17:54:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 17:54:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | |
| 17:54:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | |
| 17:54:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | |
| 17:54:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | |
| 17:54:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | |
| 17:54:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | |
| 17:54:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | |
| 17:54:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Enable pci in placement feature https://review.opendev.org/c/openstack/nova/+/854925 | |
| 17:55:18 | gibi | sean-k-mooney, stephenfin: ^^ I managed to finish all the TODOs in the series | |
| 17:55:56 | gibi | from tomorrow I will start collecting the follow up from already merged patches | |
| 17:56:03 | sean-k-mooney | well done :) i guess i know what im doing tomorrow | |
| 17:56:35 | gibi | but now I need a glass of wine | |
| 17:56:44 | gibi | see you all tomorrow o/. | |
| 18:07:59 | whoami-rajat | sean-k-mooney, dansmith is there going to be an update on 2.93 patch? I'm finalizing tests and pushing changes | |
| 18:08:11 | dansmith | whoami-rajat: yeah, just hold on a bit | |
| 18:08:17 | whoami-rajat | ack | |
| 18:08:36 | sean-k-mooney | the functional test are almost finsihed locally and then ill push likely in the next 60 secons | |
| 18:08:44 | sean-k-mooney | just making sure it will pass ci | |
| 18:13:14 | opendevreview | sean mooney proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 18:13:23 | sean-k-mooney | whoami-rajat: ^ there you go | |
| 18:13:33 | whoami-rajat | ack | |
| 18:13:56 | sean-k-mooney | this was the fix https://review.opendev.org/c/openstack/nova/+/816157/14..15/nova/tests/unit/api/openstack/compute/test_server_actions.py | |
| 18:54:01 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 18:54:02 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 18:54:02 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 18:58:13 | whoami-rajat | updated the series however I'm still facing some functional test failure related to green thread queue, I figured it might be my environment so pushed to see what gate thinks | |
| 18:58:57 | opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| 19:02:46 | gmann | dansmith: ^^ fixed as per review comments | |
| 20:14:54 | opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| 20:15:27 | gmann | dansmith: ^^ updated, I have fixed your comments | |