| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-26 | |||
| 17:08:29 | sean-k-mooney | bauzas if you dont specy how you want flavor.ephemeral_gb to be devied up on the server create api request | |
| 17:08:38 | sean-k-mooney | we use that config to determin the format | |
| 17:08:53 | sean-k-mooney | and we provide a single ephemeral disk | |
| 17:09:27 | sean-k-mooney | but you can ask for nova to provide multiple disks as long as the total is equal to or less then flavor.ephemeral_gb | |
| 17:09:56 | bauzas | looks like I need to end this meeting | |
| 17:10:01 | bauzas | but let's continue | |
| 17:10:02 | sean-k-mooney | this gets modeled in the block device mapping info passed in the api request | |
| 17:10:04 | sean-k-mooney | ack | |
| 17:10:07 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-07-26-16.00.log.html | |
| 17:10:07 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-07-26-16.00.txt | |
| 17:10:07 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-07-26-16.00.html | |
| 17:10:07 | opendevmeet | Meeting ended Tue Jul 26 17:10:07 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:10:07 | bauzas | #endmeeting | |
| 17:10:37 | bauzas | I'm trying to see whether we have 'ephemeral' as an API contract besides the ephemeral disks | |
| 17:11:20 | sean-k-mooney | that depends on the definition of ephemeral | |
| 17:11:57 | sean-k-mooney | if you use ephemeral or not to imply falult tollerance then no | |
| 17:12:30 | sean-k-mooney | if you are using it to imply tied to lifecycle fo vm its no differnt then root other thatn its not included in snapshots | |
| 17:12:38 | bauzas | from a BDM perspective, nothing changes between a root disk and an ephemeral disk, right? (by default, I mean) | |
| 17:12:59 | sean-k-mooney | nothign major | |
| 17:13:10 | sean-k-mooney | they are slithgly differnt in that root will have an imave as it source | |
| 17:13:16 | bauzas | correct | |
| 17:13:17 | sean-k-mooney | and ephemeral disk are always empty | |
| 17:13:22 | stephenfin | totally unrelated to ephemeral stuff, but I think we're finally reading to switch from mock to unittest.mock | |
| 17:13:25 | stephenfin | The removal of Python 3.6 support simplifies our job significantly since the unittest.mock lib there was buggy as hell | |
| 17:13:47 | sean-k-mooney | stephenfin: i think i saw you respin that last week | |
| 17:13:48 | stephenfin | Do we want to prioritize reviews of that patch so we can avoid rebase hell? https://review.opendev.org/c/openstack/nova/+/714676/ | |
| 17:14:02 | stephenfin | I think melwitt and sean-k-mooney have been interested in that in the past | |
| 17:14:07 | stephenfin | interested/involved | |
| 17:14:23 | stephenfin | sean-k-mooney: Yeah, I meant to do it sooner and, um, forgot | |
| 17:14:32 | sean-k-mooney | ya so we likely need to land the unshleve to host patch first but then i would be open to landing that next | |
| 17:15:02 | sean-k-mooney | bauzas: is the unshelve to host patch ready to emrge once the gate issue is resolved | |
| 17:15:11 | stephenfin | It's simultaneously low priority (mock works just fine) and high priority (so much chance of merge conflicts) | |
| 17:15:27 | bauzas | stephenfin: that makes me a bit nervous | |
| 17:15:30 | sean-k-mooney | bauzas: https://review.opendev.org/c/openstack/requirements/+/851002/ is merged by the way | |
| 17:15:31 | stephenfin | sean-k-mooney: fine by me. I'm just raising this up now before I forget again 0:) | |
| 17:15:47 | sean-k-mooney | bauzas: why? | |
| 17:15:58 | bauzas | stephenfin: sean-k-mooney: because we're on zed-3 | |
| 17:16:02 | sean-k-mooney | bauzas: i really dont think it will break anything | |
| 17:16:08 | bauzas | and we'll create a ton of merge conflicts | |
| 17:16:16 | sean-k-mooney | bauzas: right we punted it last time for the same reason | |
| 17:16:32 | sean-k-mooney | bauzas: so i would prefer to either do this after zed-3 but beofre rc1 | |
| 17:16:39 | sean-k-mooney | or do it sooner rather then later | |
| 17:16:48 | bauzas | don't disagree | |
| 17:17:12 | gibi | do it sooner | |
| 17:17:27 | gibi | later means we will have the same discussion again in the future :) | |
| 17:17:31 | bauzas | after zed-3 and before zed-rc1 seems reasonable, as is after we branch zed | |
| 17:17:34 | sean-k-mooney | can we merge it now | |
| 17:17:35 | stephenfin | the merge conflicts should only happen in the imports section since I've been able to remove most of the workarounds that were needed to workaround Python 3.6 bugs in unittest.mock | |
| 17:17:40 | sean-k-mooney | thet gate shoudl not be blocked | |
| 17:17:51 | sean-k-mooney | then merge the api change patches | |
| 17:18:19 | bauzas | are we done with the ephemeral bikeshed ? | |
| 17:18:48 | sean-k-mooney | bauzas: well we can continue but this was a nice break | |
| 17:18:51 | stephenfin | (to be specific, only nova/tests/functional/regressions/test_bug_1781286.py and nova/tests/fixtures/nova.py needed more that a simple import replacement) | |
| 17:19:10 | melwitt | stephenfin: I added a small change in a func test in that patch ages ago to help it pass CI at the time. I wasn't sure if I should be +2ing it bc of that | |
| 17:19:17 | bauzas | for that unittest usage, well, I'd appreciate if we could target it post-FF | |
| 17:19:32 | bauzas | but cores are free to vote | |
| 17:20:11 | sean-k-mooney | if we agree ahead of time that this is oke to merge say on the monday after FF to give time for rechecks | |
| 17:20:23 | sean-k-mooney | then im ok with that otherwise i would prefer to merge it this week | |
| 17:20:43 | sean-k-mooney | instead of defering to next cycle again | |
| 17:20:47 | gibi | at FF we might have potential FF exceptions that and we will run against the clock | |
| 17:20:49 | stephenfin | melwitt: Yeah, that's the change in nova/tests/functional/regressions/test_bug_1781286.py. I've touched that code also at this point so I wouldn't like us to both abstain | |
| 17:21:02 | gibi | imposing merge conflict that point feels worse than imposing it now | |
| 17:21:13 | stephenfin | bauzas: I'd rather deal with merge conflicts now than when the gate is hammered before FF | |
| 17:21:13 | sean-k-mooney | yep | |
| 17:21:20 | stephenfin | personally | |
| 17:21:24 | sean-k-mooney | same | |
| 17:21:35 | bauzas | then, looks like you have your two cores | |
| 17:21:41 | bauzas | :) | |
| 17:22:30 | stephenfin | Wow, I proposed this in March 24 2020. 3 days before lockdown #1 (in Ireland, anyway) | |
| 17:22:40 | stephenfin | Oh, the innocence of pre-COVID times :) | |
| 17:22:53 | sean-k-mooney | heh | |
| 17:23:14 | sean-k-mooney | i set Review-Priority +2 so ill review this today | |
| 17:23:29 | sean-k-mooney | bauzas: melwitt do we want to continue talking about ephemeral | |
| 17:23:31 | gibi | you can ping me tomorrow to review it | |
| 17:23:59 | stephenfin | gibi: will do (y) | |
| 17:24:23 | stephenfin | bauzas: They had it coming | |
| 17:24:28 | melwitt | stephenfin: ok, I'll help review if gibi or sean-k-mooney end up not being able to for some reason | |
| 17:26:48 | bauzas | stephenfin: I don't see a hacking rule preventing us to import the mock lib | |
| 17:27:13 | bauzas | stephenfin: so I guess you ask reviewers to make sure we don't pull that lib again ? | |
| 17:27:13 | stephenfin | bauzas: it's here. I just need to rebase it https://review.opendev.org/c/openstack/nova/+/708768 | |
| 17:27:22 | stephenfin | I can do that now | |
| 17:27:40 | bauzas | stephenfin: ok, gtk | |
| 17:27:41 | sean-k-mooney | ack was just going to say seperate patch please | |
| 17:29:14 | gibi | I need to disappeare. see you tomorrow | |
| 17:29:20 | sean-k-mooney | gibi: o/ | |
| 17:29:48 | sean-k-mooney | bauzas: back to ephmeral if you look at https://github.com/openstack/python-openstackclient/commit/4da4b96296c6b6d4351ebd47e32d5049a88211f1#diff-6759a29d0fccaa3a8d26137549b909fa3b3925b71d5318f30fe9fe7021f8558eR1227 you will see how osc construts the bdms | |
| 17:30:03 | sean-k-mooney | for swap and ephemeral | |
| 17:30:14 | sean-k-mooney | if you pass --swap or --epmeral to the server create | |
| 17:30:51 | bauzas | I'm just wondering whether we'll be able to merge things :D | |
| 17:31:25 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851034 | |
| 17:31:56 | sean-k-mooney | bauzas: this is perhaps better https://github.com/openstack/python-openstackclient/blob/4da4b96296c6b6d4351ebd47e32d5049a88211f1/openstackclient/tests/unit/compute/v2/test_server.py#L2734-L2785= | |
| 17:31:57 | bauzas | sean-k-mooney: about the ephemeral encryption name, I can try to propose something | |
| 17:32:39 | sean-k-mooney | sure | |
| 17:32:44 | bauzas | "local BDM encryption" | |
| 17:32:54 | sean-k-mooney | maybe | |
| 17:32:59 | sean-k-mooney | they might not alwasy be type local | |
| 17:33:03 | dansmith | that's the proposed title of the feature/spec? | |
| 17:33:22 | bauzas | dansmith: I said earlier, I'm terrible at naming | |
| 17:33:28 | bauzas | I'm just quite giving up | |
| 17:33:57 | dansmith | I think the problem is, things were named, and then we implemented lots of features that blurred all the lines we had, which makes not only the existing names less than ideal, but also makes it hard to accurately describe what we're talking about | |