| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-19 | |||
| 19:28:17 | sean-k-mooney | and it was chosen to go that appoch since we already did it for unicode and we were following the rfc for mangeling rules | |
| 19:28:46 | sean-k-mooney | and we explictly asks operator if they were depenidng on the fqdns in the hostname at the time | |
| 19:28:52 | dansmith | johnsom: agree, and unless we let people opt into the old behavior with a microversion, we're already changing that behavior underneath them | |
| 19:29:22 | sean-k-mooney | that is an option | |
| 19:29:25 | dansmith | no, | |
| 19:29:29 | dansmith | I mean with the previous change | |
| 19:29:35 | sean-k-mooney | disable the mangeling in new microverion | |
| 19:29:42 | dansmith | going from more mangling to less mangling is less disruptive, I'm sure | |
| 19:29:58 | sean-k-mooney | it will go from 200 to 400 | |
| 19:30:08 | dansmith | no, because we won't know until too late, right? | |
| 19:30:21 | dansmith | but as I said above, there's a discussion to be had on the microversion requirement | |
| 19:30:26 | sean-k-mooney | actully right it will not change the respocne and go form active to errror | |
| 19:30:30 | dansmith | ...right | |
| 19:34:25 | sean-k-mooney | https://github.com/openstack/nova/commit/9046f0fff4be424eda25401a3f9b8752964de775 that was the change we did 2 years ago to adress https://bugs.launchpad.net/nova/+bug/1581977 | |
| 19:35:02 | sean-k-mooney | https://lists.openstack.org/pipermail/openstack-discuss/2020-November/019113.html was the mailing list thread | |
| 19:37:45 | dansmith | sean-k-mooney: that's because we set hostname from display name if hostname isn't set specifically right? | |
| 19:38:10 | sean-k-mooney | yes before xena that was teh only way to set hostname | |
| 19:38:20 | sean-k-mooney | it was an internal atribute on the instance | |
| 19:38:24 | dansmith | ah | |
| 19:38:54 | sean-k-mooney | we added an api to set that in repsonce to the issues raised with ^ | |
| 19:38:59 | dansmith | okay so, this is even less of a problem I think.. if they specify the hostname, we can just take it as-is and if not, then we keep the existing display->filter->hostname behavior right? | |
| 19:39:03 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html | |
| 19:39:30 | sean-k-mooney | well we do not allow FQDNs via that api | |
| 19:39:42 | sean-k-mooney | e.g. if you pass --hostname it must not be an fqdn | |
| 19:39:54 | dansmith | ack, so that requires a microversion then | |
| 19:40:04 | sean-k-mooney | to allow it to be an fqdn yes | |
| 19:40:14 | sean-k-mooney | if we want to allwo that | |
| 19:40:15 | dansmith | all sounds fine to me, and isn't going to break anyone | |
| 19:40:32 | sean-k-mooney | well that is what the --domain spec was trying to do | |
| 19:40:34 | johnsom | dansmith Yeah, that was what I was thinking. The display name is always going to be a mess. But the hostname field is pretty clear it can't be crazy and should be good for pass through | |
| 19:40:44 | sean-k-mooney | add a domain filed to not continute to overload hostname | |
| 19:40:58 | sean-k-mooney | since hostnanme is used for dns_name and that cant be an fqdn today | |
| 19:41:05 | dansmith | johnsom: right and since we have the displayname->hostname(ifunset) part, we can keep the mangling if you don't otherwise set it to something... but if you do, it better be right | |
| 19:41:06 | sean-k-mooney | well ok it kind of can | |
| 19:41:36 | dansmith | "it" being hostname in my statement above | |
| 19:41:47 | sean-k-mooney | dansmith: so the propsoal is to just relax instanstnce.hostname if you pass it explictly | |
| 19:41:58 | sean-k-mooney | that might need a db migration | |
| 19:42:09 | sean-k-mooney | i would hae to check the column size | |
| 19:42:11 | johnsom | Nope, I looked, the field is fine in the DB | |
| 19:42:13 | dansmith | sean-k-mooney: sounds like that's all that needs to happen? | |
| 19:42:18 | johnsom | It's 255 already | |
| 19:42:22 | sean-k-mooney | oh ok | |
| 19:42:27 | sean-k-mooney | we are limiting it to 63 | |
| 19:42:29 | sean-k-mooney | in the api | |
| 19:42:50 | sean-k-mooney | so we would just need to drop the extra vlaidation on hostname when its passed explcitly | |
| 19:43:00 | sean-k-mooney | and live with the fact it can be an fqdn | |
| 19:43:01 | dansmith | for the new microversion yeah | |
| 19:43:14 | sean-k-mooney | and document that it will be passed as is to neutron | |
| 19:43:25 | dansmith | I don't love it, but I like it a lot better than us taking multiple things and constructing FQDNs | |
| 19:43:49 | sean-k-mooney | ya we dissucsed having --fqdn when --hostname was added | |
| 19:43:55 | sean-k-mooney | but we did not want to support fqdns | |
| 19:44:13 | sean-k-mooney | but i guess that is a less invasive change | |
| 19:44:20 | dansmith | okay now hold up, | |
| 19:44:24 | dansmith | what about the multi-create case? | |
| 19:44:46 | sean-k-mooney | we will sufix the fqdn | |
| 19:44:47 | dansmith | that would require the parsing of the hostname in nova to insert the index | |
| 19:44:59 | sean-k-mooney | well or that | |
| 19:45:17 | sean-k-mooney | or make the sufic a prefix | |
| 19:45:18 | dansmith | suffixing the fqdn won't yield anything valid, so no point in doing that | |
| 19:45:27 | dansmith | yeah 1-$hostname would work I think | |
| 19:45:36 | sean-k-mooney | we could change that in the microversion | |
| 19:46:00 | sean-k-mooney | i assume we cant just decied to not support multi create | |
| 19:46:12 | dansmith | well, I was going to say, | |
| 19:46:13 | sean-k-mooney | it would make life eiser in many ways :) | |
| 19:46:19 | dansmith | I wonder how useful hostname really is in the multi case | |
| 19:46:50 | sean-k-mooney | so in artoms spec he nandedl this by saying we woudl continue to suffix the hostname part as we do today | |
| 19:47:06 | sean-k-mooney | but the doamin value would be appended and the same for all instnaces | |
| 19:47:16 | sean-k-mooney | which when you have it as two parts makes sense | |
| 19:47:52 | sean-k-mooney | but if we want to avodi parsing then ya prefix or declare not supported | |
| 19:48:20 | dansmith | or just set them all to what they gave us | |
| 19:48:31 | sean-k-mooney | or that | |
| 19:48:40 | sean-k-mooney | ok its getting late here | |
| 19:48:56 | sean-k-mooney | if we want to explore this this cycle i can update the spec | |
| 19:48:59 | dansmith | ...and I'm sick of obsessing over hostnames :) | |
| 19:49:06 | sean-k-mooney | and formally ask for a spec freeze on the mailing list | |
| 19:49:13 | dansmith | I can't imagine we're going to get to agreement on all this in time | |
| 19:49:38 | sean-k-mooney | thats fine i suspect the same | |
| 19:50:04 | sean-k-mooney | im also kind of burnt out on this but i can prepare a draft or at least link to this in the spec | |
| #openstack-nova - 2022-07-20 | |||
| 02:14:28 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: default by_name image_type to config correctly https://review.opendev.org/c/openstack/nova/+/826526 | |
| 02:14:29 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | |
| 02:14:29 | opendevreview | melanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | |
| 02:14:30 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | |
| 02:14:30 | opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | |
| 02:14:31 | opendevreview | melanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter https://review.opendev.org/c/openstack/nova/+/760456 | |
| 02:14:31 | opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | |
| 02:14:32 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | |
| 02:14:32 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | |
| 02:14:34 | opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | |
| 02:14:34 | opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | |
| 02:14:36 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | |
| 02:14:36 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | |
| 02:14:38 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | |
| 02:14:38 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | |
| 02:14:40 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 03:49:20 | opendevreview | melanie witt proposed openstack/nova master: Workaround qemu query-migrate issue during live migration https://review.opendev.org/c/openstack/nova/+/842687 | |
| 05:10:45 | opendevreview | liuhuajie proposed openstack/nova master: Remove None for get method, the default value is None https://review.opendev.org/c/openstack/nova/+/850450 | |
| 07:09:28 | opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 07:27:50 | opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | |
| 08:06:05 | gibi | o/ | |
| 08:18:22 | bauzas | \o | |