| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-13 | |||
| 12:04:25 | gibi | ahh I see | |
| 12:04:49 | sean-k-mooney | the user data on hard reboot is for when you want to fully replace it on reboot | |
| 12:05:02 | sean-k-mooney | which is how i woudl expect this to be used most offten honestly | |
| 12:05:02 | gibi | I'm fine with a flag in system meta | |
| 12:05:17 | jhartkopf | sean-k-mooney: Yes, so with an additional variable, we could track if the config drive should be regenerated or not | |
| 12:06:00 | sean-k-mooney | jhartkopf: yep the instance_system_metadata table is internal to nova and jsut a key value pair with the instance as a primary key | |
| 12:06:31 | sean-k-mooney | jhartkopf: so you can jsut add a flag to that on server update if you update the user-data field | |
| 12:07:17 | sean-k-mooney | then reboot can check it and clear it. does ^ work for you | |
| 12:07:37 | sean-k-mooney | if so we can leave the spec as it is. | |
| 12:10:22 | jhartkopf | Seems to be the part that was missing, thanks! I will then try to implement this for libvirt initially. | |
| 12:15:39 | sean-k-mooney | jhartkopf: just an fyi the instance system metadata is a feild on the instance object https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L194= | |
| 12:16:14 | sean-k-mooney | so you will have direct access to that in the driver and you will be able to update it on save as part of the reboot flow | |
| 12:17:24 | sean-k-mooney | just set the key config_drive_dirty flag to false and it will be save when we next call save i.e. when we update the task/vm state | |
| 12:18:51 | sean-k-mooney | jhartkopf: if you want you can expose this directly as a property on the instance object to keep it clean so that the virt driver dont need to check the system metadata directly. | |
| 12:19:06 | sean-k-mooney | just have the property update the system metadata | |
| 12:33:24 | jhartkopf | sean-k-mooney: good point, I will look into this | |
| 13:11:24 | bauzas | sean-k-mooney: gibi: fwiw, I'm currently reviewing the hard https://review.opendev.org/c/openstack/nova/+/829248/9/nova/compute/manager.py | |
| 13:11:46 | bauzas | (that and doing some expense report...) | |
| 13:12:22 | sean-k-mooney | i dont think i have used concour sicne we switch to it | |
| 13:12:42 | sean-k-mooney | but if its like the deployment of concour we had at intel its much nicer | |
| 13:12:54 | sean-k-mooney | then the oracle suite we used to use for expenses | |
| 13:12:56 | gibi | expense was easy but that single line in the manager seems easier :D | |
| 13:12:57 | bauzas | concur is good for preparing your report | |
| 13:13:25 | bauzas | but there are some bugs in the concur android app | |
| 13:13:36 | bauzas | I can't modify some expenses | |
| 13:13:49 | sean-k-mooney | ah ok i have only really used the web app | |
| 13:13:59 | sean-k-mooney | i dont like haveing compay stuff on my personal phone | |
| 13:14:35 | sean-k-mooney | so i jsut take pictures fo the recipts and email them to my company adress and fill it out after the fact | |
| 13:15:38 | gibi | bauzas: yepp I had issues with the app but I was able to fix it with the web based too | |
| 13:15:41 | gibi | l | |
| 13:16:27 | gibi | I guess you hit the issue with setting expense type to ~food and the app asking for some additional fields that was not editable | |
| 13:17:38 | bauzas | gibi: yup | |
| 13:18:15 | bauzas | gibi: yeah, I provided all my receipts to concur thanks to the android app when waiting for my flight :) | |
| 13:18:31 | bauzas | gibi: but eventually I got some problem with a meal and for my hotel expense | |
| 13:19:03 | sean-k-mooney | bauzas: not to add to your paper work but are you plannign to send a writeup or operator feedback to the list or similar | |
| 13:19:06 | bauzas | but eventually, today I used the webapp and I was able to modify the expenses correctly | |
| 13:19:43 | bauzas | sean-k-mooney: we'll be discussing this tomorrow during the meeting and after that, I'll provide a feedback to the list | |
| 13:19:49 | sean-k-mooney | ack | |
| 13:19:59 | bauzas | sean-k-mooney: but most of the operators told they don't want to have a lot of emails from us | |
| 13:20:11 | sean-k-mooney | while you were away there was a request to do a release of stable yoga and xena by the way | |
| 13:20:17 | sean-k-mooney | i was going to bring that up in the meeting | |
| 13:20:23 | bauzas | sean-k-mooney: oh ok | |
| 13:20:31 | sean-k-mooney | i have not looked at whats pending but we have not done a release of yoga yet | |
| 13:20:52 | sean-k-mooney | so there proably are some valid bugfixes that would be good to release | |
| 13:22:28 | sean-k-mooney | bauzas: i asked mainly for people outside of redhat i was going to ask you about your feedback in our downstream meeting but if were planing to send somethign to the list anyway i was happy enough to just read that | |
| 13:23:17 | bauzas | sean-k-mooney: yeah I understand it about the feedback | |
| 13:23:41 | bauzas | like I said, I'd first discuss with our folks tomorrow before replying | |
| 13:24:05 | sean-k-mooney | no worries. did you enjoy the conference | |
| 13:24:17 | bauzas | sean-k-mooney: we had a problem with the etherpad, it became chinese but eventually thanks to fungi it was fixed | |
| 13:24:37 | sean-k-mooney | ah did we forget to add teh disclaminer at the top | |
| 13:24:48 | bauzas | sean-k-mooney: I actually prefered to discuss with the operators on hallways | |
| 13:25:02 | fungi | there was a disclaimer at the top, it was just ignored apparently | |
| 13:25:21 | bauzas | sean-k-mooney: we had the same issue with the ptg one, which had the disclaimer | |
| 13:25:24 | sean-k-mooney | fungi:ack it happens thanks for helping to fix it | |
| 13:25:28 | fungi | np | |
| 13:26:10 | sean-k-mooney | bauzas: ya when we are done with the ptg we shoudl share/archive the readonly link | |
| 13:26:33 | fungi | highly recommended | |
| 13:26:55 | bauzas | sean-k-mooney: if you see my feedback email from the ptg, I was providing the readonly link | |
| 13:27:08 | sean-k-mooney | ack | |
| 13:27:17 | bauzas | but if someone finds the writable one, then... | |
| 13:27:48 | sean-k-mooney | ya you can alway go back in the timeline and find the orginal content but thats hassel | |
| 13:28:02 | sean-k-mooney | look liek we are starting to see videos form the summit | |
| 13:28:02 | bauzas | I think the ptg one was changed because I provided a link to the writable etherpad in the session etherpad too | |
| 13:28:06 | gibi | at some point I was wondering how hard it would be to detect the translator from the etherpad software and bring up a warning | |
| 13:28:43 | sean-k-mooney | i would guess its clientside | |
| 13:28:52 | sean-k-mooney | so proably not trivial | |
| 13:28:57 | bauzas | so, if someone was looking at the operator session etherpad with a chinese translation app and if she/he was clicking the ptg etherpad from it... | |
| 13:29:09 | gibi | sean-k-mooney: yeah it would need some js magic | |
| 13:29:12 | bauzas | but that's a guess | |
| 13:29:29 | sean-k-mooney | bauzas: or right ya crosslinking would cause issues | |
| 13:29:50 | sean-k-mooney | its too bad there isnt a settign to mark teh main one readonly when we are done | |
| 13:29:55 | sean-k-mooney | i.e. to lock it | |
| 13:30:18 | bauzas | yeah | |
| 13:30:26 | sean-k-mooney | still i like the flexiblity that etherpad has so im still happy we have it | |
| 13:30:54 | sean-k-mooney | well the simplicty and the autour color trackign more then flexiblity | |
| 13:35:25 | fungi | etherpad has a pluggable extension architecture, so maybe there's a plugin opendev could add for it to provide that feature (or maybe someone who likes js could write one) | |
| 13:36:24 | fungi | we try to stay current with upstream releases, making it easy to develop against their master branch and latest api | |
| 13:39:58 | sean-k-mooney | i dont see one that jumps out at me on https://static.etherpad.org/index.html but ya maybe | |
| 13:41:25 | bauzas | ideally a click button to lock/unlock would suffice | |
| 13:41:35 | fungi | agreed | |
| 13:41:47 | bauzas | but... I wrote JS a while ago | |
| 13:41:56 | sean-k-mooney | oh https://www.npmjs.com/package/ep_disable_reset_authorship_colours | |
| 13:41:59 | sean-k-mooney | we should add that one | |
| 13:42:58 | fungi | has clearing the authorship colors been a problem for folks? i tend to use that a lot when i'm writing some large bit of prose and want only subsequent edits highlighted | |
| 13:43:10 | sean-k-mooney | fungi: just the keybinding | |
| 13:43:17 | fungi | ahh, okay | |
| 13:43:23 | sean-k-mooney | i think its ctrl shift c | |
| 13:43:28 | fungi | what i end up seeing as more of a problem is when someone accidentally deletes everything and then pastes it back in | |
| 13:43:33 | sean-k-mooney | so doign it by mistack when copy pasting | |
| 13:43:57 | fungi | interesting, i didn't even realize there was a keybind for that, but i agree that sounds like a trap | |
| 13:44:30 | sean-k-mooney | yep we add that to the header now too since i did it by mistake when i tought i had selected my terminial but had not | |
| 13:44:44 | sean-k-mooney | so just disbaleing that one keybind would be nice | |
| 13:45:04 | sean-k-mooney | we can keep the feature but the keybind is not a good default | |
| 13:45:33 | fungi | if you want to propose that addition, you can push a change for our image builds here: https://opendev.org/opendev/system-config/src/branch/master/docker/etherpad/Dockerfile#L33 | |
| 13:45:43 | fungi | looks like it's already in the commented-out example even? | |
| 13:46:55 | sean-k-mooney | im not sure if that plugin disables it outright or just the keybind or if its configurable | |
| 13:47:00 | sean-k-mooney | just llook at the source now | |
| 13:47:50 | sean-k-mooney | https://github.com/ether/ep_disable_reset_authorship_colours/blob/main/static/js/disable_reset_authorship_colours.js looks like its just hiding the button | |
| 13:47:55 | sean-k-mooney | so that wont actully help | |
| 13:48:45 | sean-k-mooney | but ya good to know we can look into it sometime | |