| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-03-23 | |||
| 01:19:56 | EugenMayer | maybe, but https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4162 accesses a field that could never have been loaded from nova::instance_extra | |
| 01:20:23 | sean-k-mooney[m] | why? | |
| 01:20:32 | EugenMayer | there is no such field? | |
| 01:20:59 | sean-k-mooney[m] | the flaovr is stored as a json blob in the instance extra table | |
| 01:21:13 | sean-k-mooney[m] | so name would be in the blob not a colum in that table | |
| 01:22:19 | EugenMayer | i see that instance_extra::flavor is a json serialized model of the flavor | |
| 01:22:32 | sean-k-mooney[m] | yes | |
| 01:22:38 | sean-k-mooney[m] | we serialse the ovo | |
| 01:22:50 | sean-k-mooney[m] | and store it in the flaovr column | |
| 01:22:51 | EugenMayer | and there is the name field indeed | |
| 01:23:34 | sean-k-mooney[m] | so other then the new flavor we shoudl not have a depency on the old flavor exising | |
| 01:23:47 | EugenMayer | so this is deserialized. I understand. Then there is something else trying to access the 'flavor' of the 'old flavor' which leads to an exception | |
| 01:23:48 | sean-k-mooney[m] | in the api db | |
| 01:24:10 | EugenMayer | i see the idea here, got you. But there must be still a expectation left | |
| 01:24:39 | sean-k-mooney[m] | there may be an in correct lookup using the id or some other reference | |
| 01:24:53 | EugenMayer | i guess you can easily try that. Create an instance with a flavor, then change the flavor id in nova_api::flavor and you should no longer be able to resize the instance | |
| 01:25:14 | sean-k-mooney[m] | we could test it in a functional test | |
| 01:25:37 | sean-k-mooney[m] | create a flavor , boot an instnace ,delete the flavor then try to resize | |
| 01:25:42 | EugenMayer | you should see, when using `openstack server resize` - 409 | |
| 01:26:17 | sean-k-mooney[m] | well we should see a 200 :) but we might see a 409 indeed | |
| 01:26:26 | sean-k-mooney[m] | that would be a bug which we should fix | |
| 01:26:42 | EugenMayer | I would have loved to see a 200 :) | |
| 01:29:30 | sean-k-mooney[m] | so looking at the functional test quickly im not seeing a test for resizing after flavor delete in test_server.py | |
| 01:30:07 | sean-k-mooney[m] | we can try creating one tomorrow/later today and see if we can repoduce | |
| 01:31:26 | sean-k-mooney[m] | do you have teh stack trace by the way | |
| 01:32:20 | sean-k-mooney[m] | i can try and take a look at it in the morning its 01:30 here so i was just heading to sleep but i can take another look once im online tomorrow | |
| 01:32:39 | EugenMayer | well that's the funny thing, noboday on the 'user side' ever knows which sub-system is responsible here | |
| 01:32:52 | EugenMayer | so grabbing a stacktrace is not as easy as you might think :) | |
| 01:33:11 | EugenMayer | it's 2:30 here, so i'am with you | |
| 01:33:35 | EugenMayer | sure, i'll be online tomorrow, just mention me. Happy to help if i can. Thank you for your effort! | |
| 01:34:10 | sean-k-mooney[m] | EugenMayer: ah your in europe then i tought you were across the pond. ok ya ill see if i can put up a DNM patch with a simple resize test tomorrow and we will see if i can trigger it | |
| 01:34:46 | EugenMayer | sure! Have a good night then, i'am off to bed :) | |
| 02:51:36 | opendevreview | anguoming proposed openstack/nova master: fix the bug of the log line has no request_id info at source host when live migration https://review.opendev.org/c/openstack/nova/+/834677 | |
| 06:57:00 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Improve creating images INFO log https://review.opendev.org/c/openstack/nova/+/826524 | |
| 06:57:00 | opendevreview | melanie witt proposed openstack/nova master: block_device_info: Add swap to inline https://review.opendev.org/c/openstack/nova/+/826523 | |
| 06:57:01 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: default by_name image_type to config correctly https://review.opendev.org/c/openstack/nova/+/826526 | |
| 06:57:01 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Remove defunct comment https://review.opendev.org/c/openstack/nova/+/826525 | |
| 06:57:02 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | |
| 06:57:02 | opendevreview | melanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | |
| 06:57:03 | opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | |
| 06:57:03 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | |
| 06:57:04 | opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | |
| 08:23:13 | EugenMayer | sean-k-mooney[m] are you awake already? :) | |
| 08:24:51 | EugenMayer | sean-k-mooney[m] i can still reproduce it: Service is unavailable at this time. (HTTP 409) (Request-ID: req-686ad3ee-d15b-4361-94c8-5775092c4746) | |
| 08:25:34 | EugenMayer | i see "POST /v2.1/servers/acbf9ae7-8433-4b2f-bf61-66327ca134aa/action HTTP/1.1" 409 88 52160 "-" "python-novaclient" in the nova-api logs,nova-api error logs do not show anything | |
| 08:25:48 | Uggla | gibi, hi o/ | |
| 08:28:22 | gibi | Uggla: o/ | |
| 08:29:40 | EugenMayer | sean-k-mooney[m] i see only warnings about deprecations in horizon.log - i found some logs on the compute from yesterday failing to contact rabbitmq which are most probably unrelated: https://gist.github.com/EugenMayer/cf06fadc52c66018f09a470fe0ed260f - that's about what i could find | |
| 08:32:36 | gibi | Uggla: thanks again fort the docs :) | |
| 08:34:25 | Uggla | gibi, you are welcome. | |
| 09:00:44 | bauzas | gibi: \o | |
| 09:01:29 | gibi | bauzas: o/ | |
| 09:33:12 | opendevreview | ribaudr proposed openstack/nova master: Fix unit tests when they are run with OS_DEBUG=True https://review.opendev.org/c/openstack/nova/+/833115 | |
| 09:58:49 | opendevreview | Stephen Finucane proposed openstack/nova master: doc: Remove useless contributor/api-2 doc https://review.opendev.org/c/openstack/nova/+/828599 | |
| 10:59:39 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 10:59:39 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 10:59:40 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 11:05:49 | EugenMayer | when an instance keeps in the 'spawning' phase - where can i check for the cause? | |
| 11:09:52 | kashyap | gibi: Hey, on git/main with a patch, I see this: https://cpaste.org/?37b24bb8794dcdca#9jFENZMo38Bxjskev5QkLoGncaKucSgpx1tBHhvVKAYd | |
| 11:10:04 | kashyap | gibi: Am I missing anything trivial? os_traits is installed in my virtualenv. | |
| 11:36:49 | gibi | you probably have old os_traits lib in the venv | |
| 11:37:09 | opendevreview | Elod Illes proposed openstack/nova stable/xena: [stable-only] Set nova-tox-functional-centos8-py36 non-voting https://review.opendev.org/c/openstack/nova/+/834854 | |
| 11:38:06 | gibi | kashyap: you need 2.7.0 from os-traits https://github.com/openstack/os-traits/commits/2.7.0 | |
| 12:42:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/829248 | |
| 12:45:19 | kashyap | gibi: Darn lemme check | |
| 12:46:19 | kashyap | $> pip show os_traits | grep Version | |
| 12:46:19 | kashyap | gibi: Hm, I do have it: | |
| 12:46:20 | kashyap | Version: 2.7.0 | |
| 12:46:48 | gibi | that is strange | |
| 12:49:29 | gibi | https://paste.opendev.org/show/buddLlqeEzZc7ClpZWF3/ I can import that constant | |
| 12:51:23 | gibi | kashyap: could you try just import that constan in an interpreter started in that env? | |
| 12:54:12 | Uggla | I though a "reverify" comment would restart the CI... but it appears to not be the case. How to restart CI on a patches ? | |
| 12:55:10 | kashyap | gibi: Lemme try | |
| 12:56:02 | kashyap | gibi: Hmm, import of that constant does work just fine here. | |
| 12:57:59 | kashyap | gibi: I tell a lie; it's not git/main, but on top of the CPU APIs patch (that I rebased). I'll try on git/main and report back. (Bad me) | |
| 12:58:34 | kashyap | Hmm, same on git/master too. | |
| 13:22:40 | kashyap | Okay, that fixed it. (Sorry for the noise. | |
| 13:22:41 | kashyap | ) | |
| 13:32:29 | artom | Uggla, it's 'recheck' | |
| 13:32:38 | artom | 'reverify' is only in our downstream CI | |
| 13:32:49 | artom | Trigger words can be configured in Zuul, IIUC | |
| 13:34:44 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use improved guest CPU config APIs https://review.opendev.org/c/openstack/nova/+/762330 | |
| 13:36:16 | Uggla | artom, I tried "rebuild", "reverify".... ;) | |
| 13:36:26 | artom | ;) | |
| 13:38:57 | Uggla | artom, thanks, it seems to be in the zull queue now. | |
| 13:39:13 | gibi | kashyap: no worries, then something was mixed in that env | |
| 13:39:46 | Uggla | zuul* | |
| 14:13:41 | sean-k-mooney | Uggla: reverify in the long ago before times used to be use to tirgger just the gate pipeline rather then both gate and check. we removed it whith the green check policy dission about 8 years ago but downstream we trigger off both recheck and reverify for legacy reasons but ya as artom said recheck is what is used upstream when reqruied | |
| 14:41:56 | Uggla | sean-k-mooney, thx for the info. | |
| 14:44:52 | sean-k-mooney | gmann: bauzas since ye have already +2'd the followup care to review https://review.opendev.org/c/openstack/nova/+/828598/1 so that the docs pathes can proceed | |
| 14:45:32 | bauzas | sean-k-mooney: shit I missed the fact it was depending on this | |
| 14:46:02 | gmann | I had in list then missed somehow. thanks | |
| 14:46:03 | sean-k-mooney | no worreis this has been on my review list for a while | |
| 14:56:42 | sean-k-mooney | gibi: just looking at https://review.opendev.org/q/topic:any-traits-support the remaining patches are just using any traits right e.g. client supprot nova testing ectra. the feature is "complete" from the placmenet side in yoga? | |
| 14:57:49 | sean-k-mooney | just going through my review backlog but i had mentally check that off as complete | |
| 14:58:50 | gibi | sean-k-mooney: yes the feature is complete from placement perspective | |
| 14:59:17 | gibi | I have the placement client patch open, but that is not super important | |
| 14:59:29 | gibi | and I have the todo to check the sql performance and improve if needed | |
| 15:00:58 | opendevreview | Merged openstack/nova master: doc: Split up notifications document https://review.opendev.org/c/openstack/nova/+/828598 | |
| 15:01:19 | gibi | hm I missed that review ^^ but quickly checked and looks good to me too | |