| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-24 | |||
| 19:17:01 | chateaulav | ill keep watching the ci patchset though | |
| 19:44:18 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/830894 | |
| 19:50:54 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 19:55:44 | opendevreview | melanie witt proposed openstack/nova master: Follow up for nova-manage image property commands https://review.opendev.org/c/openstack/nova/+/830895 | |
| 20:03:30 | sean-k-mooney | chateaulav: one test failed but thats pretty good https://zuul.opendev.org/t/openstack/build/3cba136d39924d73b775a2b3a8d626ba | |
| 20:07:53 | chateaulav | ok, ill get that | |
| 20:08:52 | sean-k-mooney | nova.exception.InterfaceAttachFailed: Failed to attach network adapter device to 61a0c10a-930f-4b46-8651-c8583d1d9ff7 | |
| 20:09:02 | sean-k-mooney | caused by r libvirt.libvirtError: internal error: No more available PCI slots | |
| 20:09:17 | sean-k-mooney | chateaulav: so that is a simple fix | |
| 20:10:05 | sean-k-mooney | i suspec that just as we have to preacllocatre pcie root ports for x86 with q35 machine type | |
| 20:10:30 | sean-k-mooney | we likely need to do that too for aarch64 and virt machien type | |
| 20:11:08 | sean-k-mooney | chateaulav: for q35 we use https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.num_pcie_ports to contol this | |
| 20:11:35 | sean-k-mooney | so you proably need to set that to 28 | |
| 20:11:39 | sean-k-mooney | or similar | |
| 20:11:48 | sean-k-mooney | in the ci job and that should be all that is requried | |
| 20:11:51 | chateaulav | alright | |
| 20:12:18 | sean-k-mooney | its possibel we have to alter the driver slightly but it shoudl be trivial that is what i woudl try first to adress it | |
| 20:12:38 | sean-k-mooney | chateaulav: i approved the previous patch and rechecke the first patch | |
| 20:12:42 | sean-k-mooney | so they shoudl proceed | |
| 20:12:47 | chateaulav | great! | |
| 20:12:56 | chateaulav | sean-k-mooney: appreciate the help | |
| 20:13:04 | sean-k-mooney | no worries | |
| 20:13:15 | sean-k-mooney | im proably going to call it a day now | |
| 20:13:42 | sean-k-mooney | the failure is here by the way if you were wonderign https://zuul.opendev.org/t/openstack/build/3cba136d39924d73b775a2b3a8d626ba/log/controller/logs/screen-n-cpu.txt#9219 | |
| 20:14:19 | sean-k-mooney | looking at the xml https://zuul.opendev.org/t/openstack/build/3cba136d39924d73b775a2b3a8d626ba/log/controller/logs/screen-n-cpu.txt#9035 | |
| 20:14:53 | sean-k-mooney | i dont see any addtional pcie root ports in the xml we sent to libvirt | |
| 20:15:26 | sean-k-mooney | normally libvirt will allcoate 1 addtional pcie endpoint but that might only be for q35 | |
| 20:15:55 | sean-k-mooney | anyway o/ | |
| 20:16:07 | chateaulav | \o | |
| 20:18:39 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 20:46:11 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/830894 | |
| 20:46:11 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add volume-rebuild support to cinder module https://review.opendev.org/c/openstack/nova/+/830882 | |
| 20:46:12 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 21:09:01 | melwitt | gmann: do you know if there is any known issue with gate failure "[ERROR] /opt/stack/devstack/lib/neutron_plugins/ovn_agent:178 Socket /var/run/openvswitch/ovnnb_db.sock not found"? I've hit it twice today | |
| 21:09:51 | gmann | melwitt: not i am aware of. seems new to me | |
| 21:10:02 | melwitt | ack | |
| 21:11:03 | gmann | latest i saw my rbac patches passed gate ~2hr ago | |
| 21:14:28 | melwitt | thanks | |
| 23:35:14 | opendevreview | Merged openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 23:35:21 | opendevreview | Merged openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 23:50:32 | sean-k-mooney | melwitt: locally or in the gate | |
| 23:50:48 | melwitt | sean-k-mooney: gate. but looks like I was just unlucky | |
| 23:51:01 | sean-k-mooney | locally devstack is not always proeperly cleaning up when you unstack | |
| 23:51:03 | sean-k-mooney | ack | |
| 23:51:42 | sean-k-mooney | im not sure what would cause that on a clean install | |
| #openstack-nova - 2022-02-25 | |||
| 00:10:32 | opendevreview | melanie witt proposed openstack/nova master: Follow up for unified limits https://review.opendev.org/c/openstack/nova/+/830918 | |
| 00:17:28 | opendevreview | Merged openstack/nova master: Make more project level APIs scoped to project only https://review.opendev.org/c/openstack/nova/+/828670 | |
| 00:17:35 | opendevreview | Merged openstack/nova master: Add volume-rebuild support to cinder module https://review.opendev.org/c/openstack/nova/+/830882 | |
| 00:27:55 | opendevreview | melanie witt proposed openstack/nova-specs master: Amend unified limits spec to explain "API limit" enforcement https://review.opendev.org/c/openstack/nova-specs/+/829413 | |
| 01:48:59 | opendevreview | Merged openstack/nova master: Move keypair quota error message into exception https://review.opendev.org/c/openstack/nova/+/828186 | |
| 01:49:06 | opendevreview | Merged openstack/nova master: Add stub unified limits driver https://review.opendev.org/c/openstack/nova/+/712137 | |
| 02:10:44 | opendevreview | melanie witt proposed openstack/nova master: Follow up for unified limits https://review.opendev.org/c/openstack/nova/+/830918 | |
| 07:31:50 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 07:55:53 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/830939 | |
| 08:10:42 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 08:13:24 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 09:46:28 | opendevreview | Merged openstack/nova master: Assert quota related API behavior when noop https://review.opendev.org/c/openstack/nova/+/712140 | |
| 10:54:50 | sean-k-mooney | gibi: bauzas FF also applies to docs changes? | |
| 10:54:57 | bauzas | no | |
| 10:55:13 | sean-k-mooney | ok stephen has https://review.opendev.org/q/topic:notifications-docs and i was going to go review them | |
| 10:55:39 | sean-k-mooney | they will need a second +2 anyway but just wonderingif they should wait until after rc1 | |
| 10:56:01 | sean-k-mooney | if they can merge before it ill try and review them later today | |
| 10:56:18 | sean-k-mooney | otherwise i was going to wait and come back in a few weeks | |
| 11:12:31 | opendevreview | sean mooney proposed openstack/nova master: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/830966 | |
| 11:23:46 | elodilles | bauzas sean-k-mooney : fyi, yesterday was the deadline for yoga-milestone-3 client library releases, python-novaclient - https://review.opendev.org/c/openstack/releases/+/830249 , and osc-placement - https://review.opendev.org/c/openstack/releases/+/830227 | |
| 11:24:04 | elodilles | if you have a sec and could review them that would be awesome :) | |
| 11:24:35 | sean-k-mooney | ack ill look at them now | |
| 11:24:45 | elodilles | sean-k-mooney: thanks \o/ | |
| 11:25:10 | sean-k-mooney | thanks for the reminder i forgot that m3 was the release deadline for client libs | |
| 11:25:25 | sean-k-mooney | /libs// | |
| 11:32:49 | elodilles | no worries :) | |
| 11:41:43 | opendevreview | sean mooney proposed openstack/nova master: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/830966 | |
| 11:41:55 | sean-k-mooney | the nova client one looks correct so ill +1 that shortly | |
| 11:50:06 | sean-k-mooney | gibi: i have not reviewed this yet but do we want to try and land https://review.opendev.org/c/openstack/osc-placement/+/828545 | |
| 11:50:18 | sean-k-mooney | before we do the osc-pacement release later today | |
| 12:01:36 | whoami-rajat | sean-k-mooney, Hi, I'm not totally sure if which of the two reason is for the -2 on my patch (https://review.opendev.org/c/openstack/python-novaclient/+/827163) | |
| 12:01:52 | whoami-rajat | 1) if it's regarding proposing changes directly to OSC (in favor of deprecation of novaclient), i can do that sure | |
| 12:02:39 | whoami-rajat | 2) If it's regarding client freeze (due to which my patch wouldn't land in yoga) then the patch is up for review since long time and noone provided this feedback before | |
| 12:10:08 | sean-k-mooney | whoami-rajat: the freeze was yesterday | |
| 12:10:32 | sean-k-mooney | am but as of this cycle we are nolonger addign feature to novaclients cli | |
| 12:10:38 | sean-k-mooney | so that is the main rason for -2 | |
| 12:10:49 | sean-k-mooney | if you want to add helper funciton its fine | |
| 12:11:00 | sean-k-mooney | but in this case i think just adding it to osc is the way to go | |
| 12:12:26 | sean-k-mooney | im not sure is see a usecase wehre other projects will want to import nova client to trigger a rebuild but i guess heat coudl leverage that so im not againt having the libary functions in novaclient | |
| 12:12:37 | sean-k-mooney | the sdk woudl be better in the long run | |
| 12:13:00 | sean-k-mooney | but we intend to keep supporting novaclient as a python lib for a few cycles until sdk has full parity | |
| 12:15:09 | sean-k-mooney | whoami-rajat: i know -2 can seam a bit harsh but it was a mix of procedual and directional i would have just left a -1 if we were not past the feature freeze for the cycle | |
| 12:26:23 | sean-k-mooney | whoami-rajat: by the way just incase you are not aware -2 does not mean never it means the review has an objection directonaly or procerdurally beyond the content or quality of the code under review. if you recive a -2 it should always have an explaination as to why and you shoudl always feel free to reach out and discuss how to move forward as you have | |
| 13:08:39 | gibi | sean-k-mooney: regarding the osc-placement change, I will take that later as the lib FF happend last week | |
| 13:10:21 | gibi | ohh the yoga schedul has the client FF at the same time as the service FF | |
| 13:10:50 | gibi | still it is not super important | |
| 13:10:51 | sean-k-mooney | yes | |
| 13:10:59 | gibi | this part of placement is mostly for machine consumption | |
| 13:11:02 | sean-k-mooney | technially it would have been yesterday | |
| 13:11:25 | sean-k-mooney | ok in that case i guess this can wait till next cycle | |
| 13:11:33 | sean-k-mooney | and i can approve the release patch | |
| 13:17:25 | gibi | yes it can wait | |
| 13:17:33 | gibi | thanks for looking at the release patches | |
| 13:17:48 | gibi | I had a crazy morning so I will only start really looking at gerit now | |
| 13:18:25 | sean-k-mooney | thats ok | |