| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-23 | |||
| 18:08:12 | dansmith | event first, then api change | |
| 18:08:34 | dansmith | I would put the cinder volume change and test in a separate early patch too and we can sink that quickly, IMHO | |
| 18:10:22 | whoami-rajat | hmm, I'm still slightly confused, the addition of a new event has required an MV bump, so you're saying don't do the bump at all or use 2.91 for it as well ? https://review.opendev.org/c/openstack/nova/+/820368/8/nova/api/openstack/compute/schemas/server_external_events.py | |
| 18:11:43 | dansmith | uh | |
| 18:12:18 | dansmith | okay I didn't realize we started adding microversions for new event names | |
| 18:13:03 | dansmith | pretty sure that didn't happen in the earlier days (was never my intent) but clearly has been happening since v51 or so | |
| 18:13:28 | dansmith | so yeah maybe not worth splitting in that case, I guess | |
| 18:13:40 | dansmith | I'd update with the other comments and then we can see what bauzas thinks | |
| 18:13:54 | dansmith | it's just such a large cut of things all over the API | |
| 18:15:36 | whoami-rajat | I can understand it's a burden to review it but having no prior experience working in nova, I also don't have much ideas to do it in a better way | |
| 18:15:53 | whoami-rajat | I will update with the given tests (and continue work on the tempest test) until then | |
| 18:16:00 | whoami-rajat | s/tests/comments | |
| 18:16:05 | dansmith | yep, sounds good | |
| 18:16:19 | whoami-rajat | cool, thanks! | |
| 18:17:06 | whoami-rajat | dansmith, i think we also have novaclient release this week right? | |
| 18:17:48 | dansmith | I dunno, but seems likely | |
| 18:18:26 | whoami-rajat | So i also have a novaclient patch modifying the rebuild command https://review.opendev.org/c/openstack/python-novaclient/+/827163 | |
| 18:18:42 | whoami-rajat | it's currently failing on docs since it can't find MV 2.91 in docs (will be available after API patch merges) | |
| 18:19:22 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 18:19:23 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 18:19:28 | dansmith | whoami-rajat: okay I would have thought depends-on would take care of that, but yeah if it's just the doc failure that's easy to overlook | |
| 18:20:55 | whoami-rajat | I had the same thought and I'm not sure how this has worked in the past since every client change (having MV bump) requires API change to merge first | |
| 18:22:41 | dansmith | yeah | |
| 18:22:53 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 18:25:02 | chateaulav | have a good day everyone, I have the emulation ci running now to see if it corrects the IDE error, and will have that finished tomorrow | |
| 20:12:05 | opendevreview | Merged openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | |
| 20:38:38 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 23:42:07 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 23:45:12 | sean-k-mooney[m] | depends-on does not work for tox but it can work for devstack based test if the project is listed in the jobs required_projects | |
| 23:47:33 | sean-k-mooney[m] | so yes if you are working on a client change the api change need to merge first if you are dont test that alls the api or otherwise depend on the microversion unless you have mocked the nova api | |
| #openstack-nova - 2022-02-24 | |||
| 00:22:12 | clarkb | sean-k-mooney[m]: it actually can be made to work with tox | |
| 00:22:18 | clarkb | but ya a lot of projects don't bother with that | |
| 00:22:30 | clarkb | (we have what we call tox siblings support in the tox jobs which enables this) | |
| 01:02:21 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Register defaults for undefined hw image properties https://review.opendev.org/c/openstack/nova/+/800708 | |
| 01:02:22 | opendevreview | melanie witt proposed openstack/nova master: manage: Add image_property commands https://review.opendev.org/c/openstack/nova/+/824392 | |
| 01:07:58 | opendevreview | Ghanshyam proposed openstack/nova master: Add DB and scheduler filter method for getting nodes,RP https://review.opendev.org/c/openstack/nova/+/830704 | |
| 04:32:20 | melwitt | gibi: I respun https://review.opendev.org/c/openstack/nova/+/824392 and https://review.opendev.org/c/openstack/nova/+/800708 to address stephenfin's comments | |
| 04:32:51 | melwitt | gibi: also the top two unified limits patches have +2 from bauzas if you might be able to take a look | |
| 04:46:23 | opendevreview | Ghanshyam proposed openstack/nova master: API change to allow project admin to boot server on specific host https://review.opendev.org/c/openstack/nova/+/830543 | |
| 07:55:13 | gibi | melwitt: o/ sure I will take look at both | |
| 09:04:00 | yuval | Guys good morning | |
| 09:04:33 | gibi | yuval: o/ good morning | |
| 09:04:41 | yuval | this have +1 from zuul passed lightbits ci and +2 from gibi, can another core check it out: https://review.opendev.org/c/openstack/nova/+/821606 | |
| 09:05:06 | yuval | today is the deadline right? | |
| 09:05:21 | gibi | yuval: yes, today is the deadline | |
| 09:05:28 | yuval | ok | |
| 09:05:37 | gibi | but I think you are in a good position | |
| 09:06:12 | yuval | thank you | |
| 10:20:01 | bauzas | yuval: gibi: looking at it | |
| 11:00:55 | bauzas | sean-k-mooney: ha | |
| 11:01:12 | bauzas | you already +Wd the lightbits driver | |
| 11:01:20 | bauzas | I had a comment | |
| 11:01:35 | bauzas | we need a reno file | |
| 11:02:06 | sean-k-mooney[m] | ah you are right | |
| 11:02:15 | sean-k-mooney[m] | i can pull +w or we can add a followup patch | |
| 11:02:16 | bauzas | yuval: https://review.opendev.org/c/openstack/nova/+/821606/16/nova/tests/unit/virt/libvirt/volume/test_lightos.py#28 | |
| 11:02:51 | bauzas | sean-k-mooney: well, given it's already going, and given the deadline is today, that's OK | |
| 11:03:04 | bauzas | sean-k-mooney: but I want yuval to create it | |
| 11:03:10 | bauzas | and also I had a comment https://review.opendev.org/c/openstack/nova/+/821606/16/nova/tests/unit/virt/libvirt/volume/test_lightos.py#28 | |
| 11:03:24 | bauzas | yuval: around ? | |
| 11:03:40 | sean-k-mooney[m] | ok yuval if you add a follow up patch with a release note we can review that quickly | |
| 11:04:01 | sean-k-mooney[m] | ya just saw the question re flags | |
| 11:04:16 | sean-k-mooney[m] | i thihk that was a leftover form a previous patch | |
| 11:05:41 | sean-k-mooney[m] | oh its for the retires | |
| 11:05:53 | sean-k-mooney[m] | that is what they ment to set in the test | |
| 11:07:07 | sean-k-mooney[m] | although they asserted its default value in the test so not entirly needed | |
| 11:17:37 | yuval | hey | |
| 11:17:40 | yuval | I am here | |
| 11:17:57 | yuval | release note ok | |
| 11:18:08 | bauzas | thanks | |
| 11:18:17 | bauzas | yuval: do you know how to do it ? | |
| 11:18:58 | yuval | last time I add it in cinder I copied an existing release note and edited it. | |
| 11:19:11 | yuval | need to keep the correct format etc | |
| 11:19:34 | sean-k-mooney[m] | we have a tool | |
| 11:19:51 | sean-k-mooney[m] | you can do tox -e venv reno new lightos | |
| 11:20:05 | sean-k-mooney[m] | that will create a release note you can edit | |
| 11:20:22 | sean-k-mooney[m] | then you can test that its valied with tox -e releasenotes | |
| 11:20:43 | bauzas | yuval: no, let me give you the doc | |
| 11:21:18 | yuval | ok | |
| 11:21:28 | sean-k-mooney[m] | in this case you can delete all sections except feature where you should provide a short overview of the feature and any version requirements | |
| 11:21:40 | sean-k-mooney[m] | e.g. this need lightos version X | |
| 11:22:27 | bauzas | yuval: https://docs.openstack.org/nova/latest/contributor/releasenotes.html | |
| 11:22:58 | bauzas | yuval: just use the 'features' section for the YAML file | |
| 11:23:12 | bauzas | yuval: also, I had a nit for a test | |
| 11:23:23 | bauzas | yuval: could you just reply on gerrit ? | |
| 11:23:32 | yuval | yes, I saw I didnt understand it actually | |
| 11:23:43 | bauzas | https://review.opendev.org/c/openstack/nova/+/821606/16/nova/tests/unit/virt/libvirt/volume/test_lightos.py#28 | |
| 11:24:31 | sean-k-mooney[m] | ok going to grab coffee. brb | |
| 11:31:28 | gibi | bauzas: I'm +2 on the unified limits series. Is it OK with you if I go back and plug the missing +As to the series? | |
| 11:31:45 | bauzas | gibi: sure | |
| 11:31:50 | gibi | ack, on it | |
| 11:31:51 | bauzas | do this if you want | |
| 11:53:00 | sean-k-mooney | :) i care about that landign but also know i do not have the time before FF to load the context required to review it properly so i have been staying away from the series | |
| 11:56:42 | gibi | melwitt: I have a small question in https://review.opendev.org/c/openstack/nova/+/789963 | |
| 12:23:22 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 12:23:23 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 12:24:36 | chateaulav | gibi: fixed the pep8 error, i promise this is the last time the driver patch will be updated, focus is on the zuul patch today | |
| 12:26:28 | gibi | chateaulav: no worries :) | |
| 12:32:49 | sean-k-mooney | given gibi has +2'd the first two patches i take it this series is generally in a good postion for review | |
| 12:33:01 | gibi | sean-k-mooney: yes | |