| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-22 | |||
| 16:10:40 | liorf95 | yes please | |
| 16:10:44 | bauzas | yes, I'll do | |
| 16:10:44 | gmann | thanks gibi for reviews | |
| 16:10:48 | gmann | thanks | |
| 16:10:51 | liorf95 | https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath | |
| 16:10:57 | bauzas | liorf95: we'll discuss about your bp in the open discussion topic | |
| 16:10:58 | sean-k-mooney | liorf95: i think yours is in opendicuss at the end but we coudl bring it up now too | |
| 16:11:19 | liorf95 | as you want | |
| 16:11:35 | bauzas | liorf95: that's in the agenda :) | |
| 16:11:39 | bauzas | anyway | |
| 16:11:49 | bauzas | secure RBAC, yes I'll review | |
| 16:12:04 | bauzas | we merged a few features before | |
| 16:12:19 | bauzas | I'll modify Launchpad on Friday | |
| 16:12:35 | chateaulav | just reviews for emulation to ensure nothing bltent sticks out | |
| 16:13:09 | bauzas | ok | |
| 16:14:03 | bauzas | ok, moving on then | |
| 16:14:14 | bauzas | #topic Review priorities | |
| 16:14:17 | bauzas | #topic Review priorities | |
| 16:14:25 | bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+label:Review-Priority%252B1 | |
| 16:14:36 | bauzas | most of the priorities were merged | |
| 16:15:05 | bauzas | nothing to tell here | |
| 16:15:10 | bauzas | let's continue to review | |
| 16:15:17 | bauzas | #topic Stable Branches | |
| 16:15:21 | bauzas | elodilles: your time | |
| 16:15:41 | elodilles | info stable/queens gate fix proposed: https://review.opendev.org/830327 (needs to backport to pike as well) | |
| 16:15:44 | elodilles | #info stable/xena gate should be better as Artom's workaround was merged (test_tagged_attachment) | |
| 16:15:47 | elodilles | #info stable/wallaby still needs the libvirt_disable_apic to merge + it seems the test_tagged_attachment issue is also present | |
| 16:15:50 | elodilles | oops | |
| 16:15:52 | elodilles | sorry | |
| 16:16:09 | elodilles | anyway, this is mostly it ^^^ | |
| 16:16:50 | elodilles | we might need the workarounds to stable/victoria too | |
| 16:17:31 | elodilles | #info stable/queens gate fix proposed: https://review.opendev.org/830327 (needs to backport to pike as well) | |
| 16:17:40 | elodilles | (just to have it in the logs) | |
| 16:18:02 | bauzas | :) | |
| 16:19:44 | bauzas | thanks elodilles | |
| 16:19:50 | elodilles | np | |
| 16:19:58 | bauzas | #topic Open discussion | |
| 16:20:08 | bauzas | liorf95: (lior Friedman) https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath | |
| 16:20:14 | bauzas | liorf95: your turn | |
| 16:20:21 | liorf95 | yes please | |
| 16:20:23 | bauzas | or I can explain | |
| 16:20:32 | bauzas | maybe some of them don't understand the contect | |
| 16:20:36 | bauzas | so, | |
| 16:20:36 | bauzas | context | |
| 16:20:47 | liorf95 | we need this bp to be approved for https://review.opendev.org/c/openstack/nova/+/823941 | |
| 16:21:34 | bauzas | basically we had https://review.opendev.org/c/openstack/nova/+/823941 that was reviewed | |
| 16:21:48 | bauzas | and stephenfin and sean-k-mooney accepted the change | |
| 16:21:49 | bauzas | but, | |
| 16:22:09 | bauzas | as you can look at the comments, we saw it was actually a feature | |
| 16:22:51 | bauzas | that's why I accepted to have a discussion in this meeting to see whether folks accept to merge this one even if we had not accepted the blueprint before | |
| 16:23:08 | bauzas | for the moment, there is a procedural -2 from me | |
| 16:23:38 | bauzas | but if folks agree here to have an exception for https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath as a specless bp, then I could remove it | |
| 16:24:07 | bauzas | now, the question : is https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath a specless BP and are folks accepting it as a exception ? | |
| 16:24:54 | gibi | I've nothing against it. It is just a volume driver so no spec needed. And the change is really small | |
| 16:25:12 | bauzas | correct | |
| 16:26:02 | bauzas | change is small and only touching a very few places | |
| 16:26:27 | sean-k-mooney | i am supprotive fo doign it as a specless blueprint | |
| 16:26:42 | bauzas | ok, anyone having concern ? | |
| 16:26:45 | sean-k-mooney | its after teh cutoff but the scale of it is small enought that i think an excption can be made | |
| 16:26:55 | bauzas | yeah | |
| 16:27:08 | opendevreview | Merged openstack/placement master: Extend the RP db query to support any-traits https://review.opendev.org/c/openstack/placement/+/825848 | |
| 16:27:10 | opendevreview | Merged openstack/placement master: DB layer should only depend on trait id not names https://review.opendev.org/c/openstack/placement/+/826490 | |
| 16:27:12 | bauzas | basically we have deadlines for accepted blueprints because they change lots of things | |
| 16:27:13 | opendevreview | Merged openstack/placement master: Enhance doc of _get_trees_with_traits https://review.opendev.org/c/openstack/placement/+/825780 | |
| 16:27:16 | opendevreview | Merged openstack/placement master: Extend the RP tree DB query to support any-traits https://review.opendev.org/c/openstack/placement/+/825849 | |
| 16:27:18 | opendevreview | Merged openstack/placement master: Add any-traits support for listing resource providers https://review.opendev.org/c/openstack/placement/+/826491 | |
| 16:27:45 | bauzas | so we're procedural not for the sake of being it, but for making sure we are sure how this works | |
| 16:27:57 | bauzas | here, I don't see a problem | |
| 16:28:04 | gibi | I agree | |
| 16:29:00 | bauzas | ok so, | |
| 16:30:25 | bauzas | #agreed specless BP for https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath as an exception | |
| 16:30:35 | bauzas | liorf95: I'll then remove my -2 | |
| 16:30:41 | bauzas | and +W it | |
| 16:30:45 | bauzas | that's it I had | |
| 16:31:00 | liorf95 | Thanks a lot for your efforts here | |
| 16:33:28 | bauzas | any other topic to discuss as a last minute ? | |
| 16:33:36 | gibi | - | |
| 16:34:16 | bauzas | looks not | |
| 16:34:18 | bauzas | thanks all | |
| 16:34:22 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-22-16.02.log.html | |
| 16:34:22 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-22-16.02.txt | |
| 16:34:22 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-22-16.02.html | |
| 16:34:22 | opendevmeet | Meeting ended Tue Feb 22 16:34:22 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:34:22 | bauzas | #endmeeting | |
| 16:34:23 | gibi | thanks | |
| 16:34:28 | elodilles | thanks bauzas o/ | |
| 16:34:30 | liorf95 | Thanks | |
| 16:34:45 | gibi | sean-k-mooney: just a reminder you only left +1 on https://review.opendev.org/c/openstack/placement/+/82649 yesterday :) | |
| 16:35:34 | chateaulav | thanks o/ | |
| 16:35:47 | gmann | thanks | |
| 16:38:53 | gibi | kashyap: https://logserver.rdoproject.org/83/38983/2/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset035-victoria/67d64d4/logs/undercloud/var/log/tempest/stestr_results.html.gz the tempest logs does not contain either the server uuid or the request id for the snapshot command :/ | |
| 16:39:01 | kashyap | gibi: Good news! | |
| 16:39:01 | gibi | I cannot correlate the logs :/ | |
| 16:39:04 | gibi | oh | |
| 16:39:18 | kashyap | gibi: I just talked to Peter Krempa on #virt, he already identified it as a libvirt bug ... | |
| 16:39:22 | kashyap | gibi: The problem is this, in short: | |
| 16:39:55 | kashyap | [quote] | |
| 16:39:56 | kashyap | libvirt has a piece of code which ensures that thh backing image of the reused destination image is added only when finishing the job. On cancellation of the [copy] job, we want to unplug the image, but the backing image was not yet plugged in. | |
| 16:40:00 | kashyap | [/quote] | |
| 16:40:08 | kashyap | It assumes a bit of libvirt storage knowledge, but Peter is already working on a fix | |