Earlier  
Posted Nick Remark
#openstack-nova - 2022-01-25
15:09:30 sean-k-mooney asking for nova ot also enforce it or just relay on neutron
15:10:01 gibi if neutron enforces it then I think nova does not need to enforce it
15:10:25 ralonsoh the port connectivity parameter was for Nova
15:10:36 sean-k-mooney i guess im just surpesed because neutron did not want to enfoce it orginally which is why we added the connectivy
15:10:39 ralonsoh in Neutron we check the backend connectivity (doesn't need to be in the port)
15:10:46 ralonsoh and if the port has or not IP addresses
15:11:23 ralonsoh sean-k-mooney, https://review.opendev.org/c/openstack/neutron/+/678027/3/neutron/plugins/ml2/managers.py
15:11:27 sean-k-mooney right but we added the connectivty parmater becasue neuton did not want to do that backend check when we first dicussed this featre
15:11:28 ralonsoh is this what you need?
15:12:01 sean-k-mooney yes but that means we dont need the connectivty parmater in the respocne any more
15:12:22 ralonsoh so we can remove it from the port dict
15:12:33 opendevreview Merged openstack/nova master: libvirt: Create qcow2 disks with the correct size without extending https://review.opendev.org/c/openstack/nova/+/779275
15:12:33 ralonsoh in any case, the ML2 plugin should keep it
15:12:41 sean-k-mooney am we could although it proably does not hurt to leave it there
15:12:56 ralonsoh perfect, doesn't add any overhead
15:13:08 sean-k-mooney the user might want to check what connectivy is aviaable to them i guess
15:13:27 bauzas sean-k-mooney: ok, so you're OK if we don't verify it in nova ?
15:13:38 bauzas as neutron already does it ?
15:13:39 sean-k-mooney bauzas: ya given that bug fix im ok with it
15:13:44 bauzas ++
15:13:54 bauzas simplier for me then
15:14:01 bauzas I just need to rebase the change from stephenfin
15:14:03 sean-k-mooney bauzas: as i said im just surprised that was done since it was orginaly rejected.
15:14:16 sean-k-mooney yep
15:14:17 bauzas and I'll just provide a Tempest test
15:14:46 sean-k-mooney ralonsoh: qq while your here
15:15:03 sean-k-mooney ralonsoh: did you recently add the binding driver to the port details as part of the recent ovn work you were doing
15:15:14 ralonsoh yes
15:15:21 ralonsoh let me find the patch
15:15:36 sean-k-mooney it was part of https://specs.openstack.org/openstack/neutron-specs/specs/xena/ovn-auxiliary-port-bridge-live-migration.html right
15:15:57 sean-k-mooney is "backend" now populated for all ml2 drivers
15:16:00 ralonsoh https://review.opendev.org/c/openstack/neutron/+/814143
15:16:21 ralonsoh "connectivity" you mean
15:16:24 opendevreview Sylvain Bauza proposed openstack/nova master: WIP neutron: Allow to spawn VMs with port without IP address https://review.opendev.org/c/openstack/nova/+/669411
15:16:27 ralonsoh yes for all in-tree drivers
15:16:29 bauzas there it goes ^
15:16:40 ralonsoh the default value is "legacy"
15:16:43 sean-k-mooney ralonsoh: no i mean backend
15:16:53 sean-k-mooney ralonsoh: https://specs.openstack.org/openstack/neutron-specs/specs/xena/ovn-auxiliary-port-bridge-live-migration.html#nova-neutron-events
15:17:03 sean-k-mooney this is unrelated to the connectivy question
15:17:13 bauzas holy shit, we actually don't need to have it WIP
15:17:48 ralonsoh sean-k-mooney, TBH, I don't remember now, let me check
15:17:50 sean-k-mooney bauzas: stephens patch? im pretty sure it worked in the past
15:18:58 sean-k-mooney ralonsoh: i dont see the constant defiend in neutron-lib
15:19:06 sean-k-mooney so i think this is missing again
15:19:24 ralonsoh sean-k-mooney, this is part of VIF_DETAILS
15:19:32 ralonsoh we don't need to add it to the API
15:19:33 opendevreview Sylvain Bauza proposed openstack/nova master: neutron: Allow to spawn VMs with port without IP address https://review.opendev.org/c/openstack/nova/+/669411
15:19:39 sean-k-mooney ralonsoh: yes you do
15:19:43 bauzas sean-k-mooney: stephenfin's rebased patch without WIP
15:19:54 sean-k-mooney the keys in VIF_DETAILS are part of the prot binding extenion
15:20:04 ralonsoh sean-k-mooney, yes, but not the content
15:21:06 sean-k-mooney we normaly defien the keys of vif_details here https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings.py#L76
15:21:19 sean-k-mooney https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings.py#L49-L76
15:21:32 sean-k-mooney so if you have not defiend the key there its a bug IMO
15:21:52 ralonsoh sean-k-mooney, I didn't add anything to the vif details yet
15:21:56 ralonsoh I missed that part
15:22:08 sean-k-mooney ack so the backend is not specifed ok
15:22:24 sean-k-mooney so nova still cannot make decsion based on if its ovn
15:22:38 sean-k-mooney vs ml2/ovs
15:23:37 ralonsoh yeah sorry, I really missed that part
15:23:46 ralonsoh it will be this release for sure
15:24:27 sean-k-mooney ack no worries. i dont have time to start usign it this cycle anyway
15:24:50 sean-k-mooney but when its there we might be able to adress some of the livmigratio/move op issue we have with ovn
15:25:08 sean-k-mooney ralonsoh: on a related note we have merged the self-annouch change so that should help with ovn migration downtime
15:25:17 sean-k-mooney ralonsoh:i have started the backports too
15:25:36 ralonsoh sean-k-mooney, perfect
15:53:00 bauzas last reminder : nova meeting in 8 mins here
15:53:05 bauzas s/8/7
16:00:10 opendevmeet The meeting name has been set to 'nova'
16:00:10 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:10 opendevmeet Meeting started Tue Jan 25 16:00:10 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:10 bauzas #startmeeting nova
16:00:17 bauzas gosh I was late
16:00:26 bauzas howdy
16:00:29 gibi of a whole 10 seconds :)
16:00:55 sean-k-mooney o/
16:01:08 bauzas #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:01:21 bauzas should be a quick one
16:02:10 elodilles o/
16:02:20 bauzas okay, let's start
16:02:25 bauzas #topic Bugs (stuck/critical)
16:02:29 bauzas #info No Critical bug
16:02:32 bauzas #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 36 new untriaged bugs (+4 since the last meeting)
16:02:37 bauzas #help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage
16:02:41 bauzas #link https://storyboard.openstack.org/#!/project/openstack/placement 23 open stories (-2 since the last meeting) in Storyboard for Placement
16:02:51 opendevmeet Removing item from minutes: #link https://storyboard.openstack.org/#!/project/openstack/placement
16:02:51 bauzas #undo
16:03:01 bauzas #link https://storyboard.openstack.org/#!/project/openstack/placement 25 open stories (+2 since the last meeting) in Storyboard for Placement
16:03:08 bauzas there it is
16:03:15 bauzas (sorry, wrong paste)
16:03:33 bauzas any bug to discuss ?
16:03:45 gibi yepp that +2 is the two any-traits ticket that are open again as I pushed implementation
16:04:12 bauzas okidoki thanks
16:05:03 bauzas ok, let's continue
16:05:17 bauzas #topic Gate status
16:05:21 bauzas #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:05:25 bauzas #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status
16:05:29 bauzas #info Please look at the gate failures, file a bug, and add an elastic-recheck signature in the opendev/elastic-recheck repo (example: https://review.opendev.org/#/c/759967)
16:05:48 bauzas that's been a while since I've seen a gate failure

Earlier   Later