| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-11-18 | |||
| 16:37:49 | melwitt | so reviewers will want to look at those Depends-On oslo.limit changes as well to see if they are OK with the new interfaces on that side. finally, I have Depends-On tempest test running in nova-next job in the last nova patch as well as some testing in the post test hook to provide at least some integration test of the global/default unified limits | |
| 16:39:12 | melwitt | so in nova-next it will run with unified limits enabled and the tempest test tests the project limits and the post test hook tests the registered-only limits | |
| 17:09:24 | bauzas | melwitt: ack, OK, thanks for the reminder, then I'll look at those patches | |
| 17:22:40 | melwitt | bauzas: k, just wanted to hopefully help make review easier bc it could be confusing with all the dependencies | |
| 20:06:46 | opendevreview | Merged openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| #openstack-nova - 2021-11-19 | |||
| 03:07:31 | opendevreview | Stanislav Dmitriev proposed openstack/nova master: Retry image download if it's corrupted https://review.opendev.org/c/openstack/nova/+/818503 | |
| 07:45:25 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Support remote-managed SmartNIC DPU ports https://review.opendev.org/c/openstack/nova/+/812111 | |
| 07:45:25 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Add PCI VPD Capability Handling https://review.opendev.org/c/openstack/nova/+/808199 | |
| 08:22:33 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to use NUMA cell with free resources first https://review.opendev.org/c/openstack/nova/+/805649 | |
| 08:35:35 | opendevreview | Dmitrii Shcherbakov proposed openstack/os-traits master: Add a trait for remote_managed port-capable nodes https://review.opendev.org/c/openstack/os-traits/+/818514 | |
| 08:47:46 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818515 | |
| 09:06:35 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818519 | |
| 10:27:35 | pslestang | Hey all | |
| 10:28:09 | pslestang | I would like your opinion about a change I'd like to propose on instance_action | |
| 10:28:55 | pslestang | actually instance_action are never soft-deleted even if an instance is deleted | |
| 10:29:42 | pslestang | I'd like to propose to add an option that let the operator choose if the instance_action have to be deleted or not | |
| 10:29:51 | pslestang | soft-deleted I mean | |
| 10:30:32 | pslestang | something like delete_instance_actions_on_instance_delete = True/False | |
| 10:31:33 | pslestang | we would let it to False by default to avoid breaking what's actually | |
| 10:34:01 | pslestang | as the api call is already filtering the instance_actions that are deleted we would add the possibility to get the instance_action delete with a --deleted flag | |
| 11:53:37 | sean-k-mooney | stephenfin: by the way you deleted xenapi 2? cycles ago but we still have os-xenapi in our requirements.txt | |
| 11:53:39 | sean-k-mooney | https://github.com/openstack/nova/blob/master/requirements.txt#L58 | |
| 11:53:49 | sean-k-mooney | i assume we can just delete that now | |
| 11:53:59 | stephenfin | oh, yeah, kill it with fire | |
| 11:54:11 | sean-k-mooney | cool will do | |
| 11:54:35 | stephenfin | we could probably backport that too | |
| 11:54:46 | stephenfin | I assume _dropping_ requirements is okay by stable policy | |
| 11:54:55 | sean-k-mooney | ya it should be | |
| 11:55:15 | sean-k-mooney | it cant possibel break anyone unless we were depending on a transitive dep | |
| 11:55:25 | sean-k-mooney | which we shoudl not be | |
| 12:06:02 | kashyap | pslestang: File a brief blueprint with your idea here: https://blueprints.launchpad.net/nova/+addspec | |
| 12:08:04 | kashyap | pslestang: If you want to write something longer about the design, you can even file a quick spec so it can be granularly discussed in Gerrit | |
| 12:15:39 | sean-k-mooney | kashyap: pslestang this woudl be an api change so a spec is always required | |
| 12:16:19 | kashyap | sean-k-mooney: Sure. I didn't wanted to impose big barriers right up, to at least get the design rolling | |
| 12:16:29 | sean-k-mooney | unless this is prosing a config option to alter the behavior of deleing the instance actions rows? | |
| 12:16:50 | kashyap | Yeah, I'm not sure of that | |
| 13:09:45 | sean-k-mooney | bauzas: the first of the off path acclerator seris looks ready for review to me https://review.opendev.org/c/openstack/nova/+/808199 perhaps we should set the RP+1 flag on that? | |
| 13:12:30 | sean-k-mooney | bauzas: also if you are around today can you take a look at this patch form lee https://review.opendev.org/c/openstack/nova/+/811716 | |
| 13:13:11 | sean-k-mooney | or stephenfin ^ pretty simple patch ro ewciwq | |
| 13:13:17 | sean-k-mooney | *to review | |
| 13:14:25 | stephenfin | sure | |
| 13:16:29 | pslestang | kashyap: sean-k-mooney ok understood, I will create a blueprint | |
| 13:18:08 | sean-k-mooney | pslestang: can you discirbe your intent by the way do you want the instnace action ros to be deleted when the vm is deleted or do you want them to be simple marked as deleted but still present | |
| 13:18:47 | sean-k-mooney | pslestang: they should currently get removed when the arcive delete rows command is run i belive | |
| 13:23:55 | pslestang | sean-k-mooney: simply marked as deleted (soft delete only) | |
| 13:33:50 | pslestang | sean-k-mooney: indeed the instance actions rows are moved in shadow tables and deleted when archiving | |
| 13:36:10 | sean-k-mooney | yes is that not the behavior we have today | |
| 13:36:27 | sean-k-mooney | the instance action rows are marked as deleted (but still present) and then archive later | |
| 13:36:45 | sean-k-mooney | and only delete when we purge deleted rows form the shadow tables | |
| 13:57:06 | bauzas | sean-k-mooney: done and don | |
| 13:57:08 | bauzas | done* | |
| 13:57:42 | bauzas | sean-k-mooney: I was currently looking at my RP labels | |
| 14:49:58 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818559 | |
| 15:03:12 | pslestang | sean-k-mooney: the behavior we have today is that on archiving all instances and their correponding rows (so instance actions) are moved in the shadows table | |
| 15:05:05 | pslestang | sean-k-mooney: when purging, instances and corresponding rows are deleted based on deleted_at column except for instance_actions, instance_actions_events (and task_log if I remember well) for which the deletion is based on created_at | |
| 15:12:41 | bauzas | folks, have a good weekend | |
| 15:21:13 | gibi | bauzas: o/ | |
| 15:21:15 | gibi | same to you | |
| 15:33:14 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818564 | |
| 16:05:08 | opendevreview | Gustavo Santos proposed openstack/nova master: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/815373 | |
| 16:34:55 | opendevreview | Stephen Finucane proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/c/openstack/nova/+/714676 | |
| 16:42:06 | opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818598 | |
| 16:50:18 | opendevreview | Artom Lifshitz proposed openstack/nova master: api-ref: server rescue adminPass injection is conf-dependant https://review.opendev.org/c/openstack/nova/+/818022 | |
| 16:51:30 | opendevreview | Balazs Gibizer proposed openstack/nova stable/stein: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818601 | |
| 16:53:39 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Add PCI VPD Capability Handling https://review.opendev.org/c/openstack/nova/+/808199 | |
| 16:53:40 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Support remote-managed SmartNIC DPU ports https://review.opendev.org/c/openstack/nova/+/812111 | |
| 16:56:34 | opendevreview | Balazs Gibizer proposed openstack/nova stable/rocky: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818604 | |
| 17:00:05 | opendevreview | Balazs Gibizer proposed openstack/nova stable/queens: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818605 | |
| 17:05:21 | opendevreview | Balazs Gibizer proposed openstack/nova stable/rocky: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818604 | |
| 17:07:41 | opendevreview | Balazs Gibizer proposed openstack/nova stable/queens: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818605 | |
| 17:09:59 | opendevreview | Balazs Gibizer proposed openstack/nova stable/queens: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/818605 | |
| 17:13:17 | opendevreview | Balazs Gibizer proposed openstack/nova stable/pike: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813437 | |
| 17:54:38 | johnthetubaguy[m] | dansmith: just had a thought, if you delete a project in keystone, but now you need a project token to delete a server, the operator could get in quite a bad place now? Or is there something I am missing there? | |
| 17:55:28 | dansmith | johnsom: hmm | |
| 17:56:29 | johnsom | dansmith Wrong nic? o/ John | |
| 17:56:43 | dansmith | yes, sorry | |
| 17:56:50 | dansmith | johnthetubaguy[m]: hmm | |
| 17:57:00 | johnsom | NP | |
| 17:57:19 | sean-k-mooney | johnthetubaguy[m]: ya even domain scopetd tokens wont work | |
| 17:57:29 | sean-k-mooney | cause the proejct is gone | |
| 17:57:37 | sean-k-mooney | can we just say dont do that :P | |
| 17:57:47 | dansmith | yeah, they'd still be able to list those instances, | |
| 17:57:49 | johnthetubaguy[m] | ... now I think you create a project with a known uuid, but not if you deleted an old one | |
| 17:58:09 | johnthetubaguy[m] | yeah, you can still see them and find the project uuid at least | |
| 17:58:12 | sean-k-mooney | johnthetubaguy[m]: i tought the uuid was not user setable when creating users and proejcts | |
| 17:58:18 | dansmith | but we'd have to have some workaround, like if you delete with a domain scoped token, use the project id of the instance while deleting or something | |
| 17:58:36 | dansmith | I think deleing projects in keystone before the resources are cleaned up is a general problem too right? | |
| 17:58:41 | dansmith | like, because you have to remember to do that today | |
| 17:58:47 | johnthetubaguy[m] | sean-k-mooney: just checking, I remember it being wanted for region <-> region sync | |
| 17:58:48 | dansmith | s/that/that cleanup/ | |
| 17:59:25 | johnthetubaguy[m] | I mean, its about getting a token for the correct project uuid, maybe that is allowed for deleted ones in certain cases, possibly... | |
| 17:59:30 | sean-k-mooney | dansmith: well because admin is god today i think you can fix some of those issue on a project by project basis | |
| 17:59:56 | sean-k-mooney | as in most porject allow you to list reouces by projects | |
| 17:59:56 | dansmith | sean-k-mooney: right I know today it works | |
| 18:00:18 | johnthetubaguy[m] | (as an aside, why my brain thinks up these things at 6pm on a Friday, is beyond me!) | |
| 18:00:20 | opendevreview | Gustavo Santos proposed openstack/nova master: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/815373 | |
| 18:01:13 | sean-k-mooney | johnthetubaguy[m]: part of the probelm is there is nothing keystone can do to prevent you deleteing the project as it never know if its in use today | |
| 18:01:44 | sean-k-mooney | well unified limits/placment might help | |
| 18:01:50 | johnthetubaguy[m] | yeah, its nasty, I remember the os-purge discussions in berlin (and a few other places) | |
| 18:02:01 | sean-k-mooney | but we dont track all resouce in palcment so not really | |