| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-18 | |||
| 15:15:41 | lyarwood | ah that sucks | |
| 15:16:12 | stephenfin | Out of curiosity, is there any value in me addressing the remaining SQLAlchemy 2.x issues or is bandwidth too limited? https://review.opendev.org/c/openstack/nova/+/804878/ They'll have to be fixed eventually but not necessarily right now | |
| 15:17:15 | stephenfin | The pro being I have the context on this right now that I'm likely to lose and the con being it'll be another 10 patches (or fewer more complex patches, obv) | |
| 15:17:39 | lyarwood | I'm happy to review them if you have the time and context still | |
| 15:18:29 | stephenfin | okay, cool, I'll try whip them together Friday once I've reviewed the few series on my todo list | |
| 15:36:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: [nova-manage]support extended resource request https://review.opendev.org/c/openstack/nova/+/802060 | |
| 15:37:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reno for qos-minimum-guaranteed-packet-rate https://review.opendev.org/c/openstack/nova/+/805046 | |
| 16:00:03 | NobodyCam | Good Morning Nova folks, would anyone have a recommendation for a efficient way to provide kilobytes of metadata... to instances, the Compute meta data is working perfectly but not with larger amounts of data. looking at a requirement to provide 8 to 16 Kb of dynamic metadata over the life of a lease. | |
| 16:00:08 | lyarwood | melwitt: https://review.opendev.org/q/topic:bug/1939545 - would you mind taking a look at this bugfix series this week if you have time? | |
| 16:00:56 | lyarwood | https://review.opendev.org/c/openstack/nova/+/802317 also if you have time | |
| 16:28:46 | melwitt | lyarwood: sure, will do | |
| 18:01:05 | opendevreview | Merged openstack/nova master: libvirt: Abort live-migration job when monitoring fails https://review.opendev.org/c/openstack/nova/+/764435 | |
| 19:07:19 | melwitt | bauzas: sorry to bother you, I wasn't sure if you saw there are two more patches in the placement consumer types series starting here https://review.opendev.org/c/openstack/placement/+/679441 if you might be able to get to them before FF | |
| 20:01:54 | lyarwood | https://bugs.launchpad.net/nova/+bug/1939108/comments/1 \o/ found the source of our weird volume detach issues, a kernel panic during boot... | |
| 20:18:43 | melwitt | lyarwood: nice find!! | |
| 20:25:37 | lyarwood | https://review.opendev.org/c/openstack/nova/+/96090 All this has happened before, and all this will happen again.... | |
| 20:29:29 | melwitt | :( | |
| 23:29:22 | gmann | lyarwood: gibi can we remove 'id' field also in this which was very confused with attachment_id https://review.opendev.org/c/openstack/nova/+/804275/5/nova/api/openstack/compute/volumes.py#256 | |
| 23:32:52 | artom | gmann, heh, I was saying something similar on the spec review | |
| 23:33:49 | artom | https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 23:36:52 | gmann | artom: ah, yeah that is same concern from me too | |
| 23:38:15 | artom | gmann, maybe you can come up with something better that folks are happy with | |
| 23:38:26 | artom | I couldn't think of anything that Lee was willing to accept | |
| 23:48:28 | gmann | artom: i agree with your concern, replied in spec. | |
| 23:48:52 | gmann | and 'id' filed is return as volume_id not id of BlockDeviceMapping https://github.com/openstack/nova/blob/a6690e8a3e6e4b009fb821257170cf1bd06fab7d/nova/api/openstack/compute/volumes.py#L231 | |
| 23:57:15 | artom | gmann, huh, yeah, it is the volume ID | |
| 23:57:26 | artom | I trusted Lee implicitly on that and didn't double check | |
| 23:59:06 | artom | gmann, hrmm, so looking at interfaceAttachments for inspiration, there's no 'id' there at all, it's all <foo>_id for port and net | |
| 23:59:48 | artom | And the deprecated virtualInterfaces API has an `id`, but it's a UUID for the virtual interface itself and doesn't map to anything | |
| #openstack-nova - 2021-08-19 | |||
| 02:28:17 | opendevreview | Merged openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 07:35:35 | gibi | lyarwood: good find about the deatch issue | |
| 07:38:24 | gibi | gmann, artom, lyarwood: replied in https://github.com/openstack/nova/blob/a6690e8a3e6e4b009fb821257170cf1bd06fab7d/nova/api/openstack/compute/volumes.py#L231 | |
| 08:12:41 | gibi | cores: I'm happy to trade some reviews today. I would need a second core on the pps series in return https://review.opendev.org/q/topic:bp/qos-minimum-guaranteed-packet-rate+project:openstack/nova+status:open | |
| 08:54:41 | gibi | stephenfin: do I undernstand correctly the we no longer need to add db migration backport placeholders as alembic handles that transparentl? | |
| 09:10:17 | stephenfin | gibi: correct | |
| 09:10:22 | gibi | stephenfin: cool thanks | |
| 09:13:20 | stephenfin | gibi: Just for context, the tl;dr: is that the reference to the predecessor is stored in the migration file itself, as opposed to encoded in the filename via an incrementing integer. If you want to slot stuff in, you can simply modify the references as part of the backport or introduce an additional branch | |
| 09:13:33 | stephenfin | I'm sure we'll figure it out if/when we come to it :) | |
| 09:13:58 | gibi | OK. If there is a way then sure we will find that when we need it | |
| 09:15:10 | gibi | then I removed the placeholder todo from the release checklist | |
| 09:15:44 | stephenfin | I wonder if we want to work on adding a trivial migration this cycle to test the machinery? | |
| 09:15:58 | stephenfin | Remove one of the unused tables from the main DB or something like that | |
| 09:17:12 | gibi | would removal of a tabla be special as it is a contraction? | |
| 09:27:41 | gibi | but yes a test would be nice to have | |
| 09:27:46 | gibi | I'm happy to review it | |
| 09:54:32 | opendevreview | Stephen Finucane proposed openstack/os-traits master: Add 'COMPUTE_FIRMWARE_UEFI', 'COMPUTE_FIRMWARE_BIOS' https://review.opendev.org/c/openstack/os-traits/+/779495 | |
| 09:54:56 | stephenfin | gibi: sean-k-mooney: As requested ^ | |
| 09:55:21 | stephenfin | gibi: As for the migration: good point. We can address a TODO on the base migration instead | |
| 09:55:46 | stephenfin | (I'll also get to the PPS series before EOW btw) | |
| 10:04:22 | ignaziocassano | Hello, I just updated my kolla wallaby installation, and seems the bug 1815989 has not solved yet. | |
| 10:04:30 | opendevreview | Merged openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | |
| 10:19:45 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Pass request to 'addresses' view builder https://review.opendev.org/c/openstack/nova/+/803753 | |
| 10:19:45 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 10:19:46 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 10:19:46 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary 'base_' prefix from schemas https://review.opendev.org/c/openstack/nova/+/803754 | |
| 10:19:47 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 10:23:12 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Sanity check some tests https://review.opendev.org/c/openstack/nova/+/803755 | |
| 10:23:13 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 10:23:13 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 11:01:35 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 11:01:36 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 11:05:43 | gibi | there seems to be a close competition for getting version 2.89 :) | |
| 11:10:43 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Drop extension prefixes and legacy fields https://review.opendev.org/c/openstack/nova/+/805186 | |
| 11:10:43 | opendevreview | Stephen Finucane proposed openstack/nova master: api-ref: Rename prefixed parameter definitions https://review.opendev.org/c/openstack/nova/+/803757 | |
| 11:10:52 | stephenfin | I noticed :) I can move mine if necessary | |
| 11:12:27 | gibi | so far no clear winners so don't move it yet :) | |
| 11:32:27 | gibi | stephenfin: I left feedback in https://review.opendev.org/c/openstack/nova/+/778550 | |
| 11:45:31 | sean-k-mooney | stephenfin: +1 on https://review.opendev.org/c/openstack/os-traits/+/779495 now thanks | |
| 11:46:30 | sean-k-mooney | stephenfin: i kasyap around this week | |
| 11:46:41 | stephenfin | no, he's still on PTO afaik | |
| 11:46:51 | sean-k-mooney | i can go update his os-traits patch then https://review.opendev.org/c/openstack/os-traits/+/794807 | |
| 11:53:07 | opendevreview | sean mooney proposed openstack/os-traits master: Add a trait for the "bochs" display device https://review.opendev.org/c/openstack/os-traits/+/794807 | |
| 12:11:42 | opendevreview | Lee Yarwood proposed openstack/nova master: WIP compute: Remove no-op setup_networks_on_host calls https://review.opendev.org/c/openstack/nova/+/803191 | |
| 12:12:06 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 12:12:07 | opendevreview | Lee Yarwood proposed openstack/nova master: fixtures: Add legacy APIs to cinder fixture https://review.opendev.org/c/openstack/nova/+/805195 | |
| 12:16:06 | lyarwood | gibi: ^ if you have time this week reviews on the above ^ nova-manage command change would really be appreciated | |
| 12:20:05 | lyarwood | huh that skipped pre-commit somehow | |
| 12:23:55 | lyarwood | weird the hook went AWOL | |
| 12:24:46 | sean-k-mooney | lyarwood:.... https://github.com/cirros-dev/cirros/issues/69 | |
| 12:25:07 | sean-k-mooney | you kknow that i brought up this io apic issue a few months ago too | |
| 12:25:37 | lyarwood | can't recall no | |
| 12:25:45 | lyarwood | link? | |
| 12:25:53 | sean-k-mooney | https://review.opendev.org/q/topic:%22workaround-disable-apic%22 | |
| 12:26:35 | sean-k-mooney | lyarwood: i mentioned it to you when they were doing the cirrus image respine for the sata dirver | |
| 12:26:59 | sean-k-mooney | i also had a devstack based fix https://review.opendev.org/c/openstack/devstack/+/766079 | |
| 12:28:16 | lyarwood | kk I honestly don't remember this coming up before tbh | |
| 12:29:13 | sean-k-mooney | the guest command line is not used normally by the way | |
| 12:29:25 | sean-k-mooney | lyarwood: it wont be used with qcow images for example | |
| 12:29:35 | sean-k-mooney | its only used if we pass a seperate kernel image | |
| 12:29:36 | lyarwood | eh? | |
| 12:29:52 | lyarwood | right, that's the command line embedded in the image itself | |
| 12:29:55 | lyarwood | so that's always used | |
| 12:30:10 | sean-k-mooney | not in the nova patch | |
| 12:30:16 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/96090 | |
| 12:30:21 | lyarwood | right | |
| 12:30:25 | sean-k-mooney | that wont be used by default | |
| 12:30:27 | lyarwood | I'm talking about my change in Cirros | |
| 12:30:32 | sean-k-mooney | ah right | |
| 12:31:05 | lyarwood | that's why I pushed this, I didn't think we could just leave out the entire apic libvirt conf part out tbh | |
| 12:31:16 | lyarwood | if that's an option we can revive your workaround | |