| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-28 | |||
| 10:27:31 | lyarwood | stephenfin: ./me was about to look at that this cycle once the nova-manage stuff was done | |
| 10:47:41 | sean-k-mooney | that was part of the cleanup you wanted to do be fore encypeted stroage right | |
| 10:49:13 | lyarwood | nope unrelated, just cruft. | |
| 10:49:52 | sean-k-mooney | oh ok i know using the dict accessor on much of that has been considerd tech debt for sometime | |
| 10:50:04 | sean-k-mooney | well using NovaObjectDictCompat in general | |
| 12:57:53 | opendevreview | Artom Lifshitz proposed openstack/nova master: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/801285 | |
| 12:57:54 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802697 | |
| 13:19:37 | opendevreview | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658 | |
| 13:19:37 | opendevreview | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657 | |
| 13:19:38 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170 | |
| 13:19:38 | opendevreview | Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806 | |
| 16:48:46 | opendevreview | sean mooney proposed openstack/os-vif stable/wallaby: add configurable per port bridges https://review.opendev.org/c/openstack/os-vif/+/802475 | |
| 17:01:18 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 17:01:19 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 18:00:30 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Add --task-log option to nova-manage db archive_deleted_rows https://review.opendev.org/c/openstack/nova/+/802766 | |
| 19:42:11 | opendevreview | Lee Yarwood proposed openstack/nova master: Add regression test for bug 1938326 https://review.opendev.org/c/openstack/nova/+/802801 | |
| 19:42:11 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Do not mark disabled but down services as in maintenance https://review.opendev.org/c/openstack/nova/+/802317 | |
| 19:54:13 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | |
| 19:54:30 | opendevreview | Lee Yarwood proposed openstack/nova master: trivial: Cleanup a comment about a now removed libvirt version check https://review.opendev.org/c/openstack/nova/+/802617 | |
| #openstack-nova - 2021-07-29 | |||
| 08:45:59 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802840 | |
| 08:46:00 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802841 | |
| 08:49:39 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802842 | |
| 08:49:40 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802843 | |
| 08:57:03 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802846 | |
| 08:57:04 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802847 | |
| 09:01:03 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802848 | |
| 09:01:04 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802849 | |
| 09:56:37 | opendevreview | Qiu Fossen proposed openstack/nova master: Allow migrating PMEM's data https://review.opendev.org/c/openstack/nova/+/802225 | |
| 11:07:42 | opendevreview | Merged openstack/placement master: Fix SQL query counting the number of individual consumers having allocations by only selecting the aggregated consumer_id column. https://review.opendev.org/c/openstack/placement/+/801419 | |
| 11:26:49 | stephenfin | bauzas: lyarwood: Dead simple typo fix here if you have 5 seconds https://review.opendev.org/c/openstack/nova/+/800855 | |
| 11:27:01 | bauzas | ack | |
| 11:27:45 | bauzas | stephenfin: we need a test, right? | |
| 11:28:03 | stephenfin | eh, I thought about it. didn't seem worth the effort | |
| 11:47:59 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Remove 'stub_out_trusted_certs' https://review.opendev.org/c/openstack/nova/+/765432 | |
| 11:48:36 | opendevreview | Takashi Kajinami proposed openstack/nova master: Clean up allocations left by evacuation when deleting service https://review.opendev.org/c/openstack/nova/+/778696 | |
| 11:50:55 | opendevreview | Takashi Kajinami proposed openstack/nova master: Clean up allocations left by evacuation when deleting service https://review.opendev.org/c/openstack/nova/+/778696 | |
| 11:56:43 | sean-k-mooney | ah they used & assuming the were appendign to an existing query string effectivly | |
| 11:56:50 | sean-k-mooney | ya that fix is correct | |
| 11:58:18 | sean-k-mooney | a unit test would be nice but im kindof with stephen. in this cae im not sure its required | |
| 12:02:48 | sean-k-mooney | it should not be hard to add as a follow up if ye want i woudl be tempetd to say though a better follow up would be to extra this funciton form manage.py and put the resouce provider query into the SchedulerReportClient and then just use it form nova manage | |
| 12:03:03 | sean-k-mooney | *extract | |
| 12:04:19 | sean-k-mooney | nova manage should not really be wriging its own functions for interacting with placment it should just use common ones and focus on the cli aspect and the business logic of the thing its tryign to do | |
| 12:14:12 | lyarwood | stephenfin: sorry was afk looks like it's already in | |
| 13:54:47 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add test for bug #1936278 https://review.opendev.org/c/openstack/nova/+/802893 | |
| 13:54:56 | stephenfin | bauzas: FYI ^ | |
| 13:59:09 | bauzas | ta | |
| 14:16:25 | stephenfin | bauzas: lyarwood: You think you folks could look at https://review.opendev.org/c/openstack/nova/+/773643 and the patch above it to get those nice docs fixes in? Trying to close out what I can :) | |
| 14:39:24 | lyarwood | stephenfin: ack | |
| 14:56:21 | opendevreview | Stephen Finucane proposed openstack/nova master: manager: Reduce unnecessary calls https://review.opendev.org/c/openstack/nova/+/795027 | |
| 15:46:56 | opendevreview | Stephen Finucane proposed openstack/nova master: Moved all calls from _ENFORCER.authorize to a separate _authorize method https://review.opendev.org/c/openstack/nova/+/749080 | |
| 16:38:35 | bauzas | sean-k-mooney: still around ? can't find where we uppercase the RC names in https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/objects/resource_class.py#L33 | |
| 16:39:10 | bauzas | the API accepts lowercasing for the name but I'm almost sure we do create the RC object with uppercase name | |
| 16:39:20 | bauzas | just can't find where | |
| 16:56:56 | opendevreview | Sylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev https://review.opendev.org/c/openstack/nova/+/801607 | |
| 16:56:57 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 16:56:57 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 17:00:25 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 17:01:36 | melwitt | bauzas: you likely already found it but it doesn't look like lowercase is allowed https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/schemas/common.py#L17-L21 | |
| 17:21:34 | sean-k-mooney | bauzas: sorry yes im still here | |
| 17:22:24 | sean-k-mooney | bauzas: i think there is a normalise fucntion | |
| 17:23:12 | sean-k-mooney | maybe this one https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/util.py#L233 | |
| 17:23:54 | sean-k-mooney | well that is just checkign the query stiring but i think there is a helper util for it | |
| 17:25:28 | sean-k-mooney | bauzas: the api should not accpet lowercase | |
| 17:26:11 | sean-k-mooney | bauzas: here |https://github.com/openstack/os-resource-classes/blob/145ed791d050725394dbd786a5d45600da656812/os_resource_classes/__init__.py#L94-L113 | |
| 17:26:29 | sean-k-mooney | bauzas: its in os-resouce-classes | |
| 17:28:33 | sean-k-mooney | that used to also be in placment https://github.com/openstack/placement/blob/1257198effa3b41d206d18356dded543810da6fd/nova/rc_fields.py#L58-L66 | |
| 17:38:09 | sean-k-mooney | bauzas i think melwitt is right that the scema will rejct it if its not uppercase | |
| 17:38:23 | sean-k-mooney | bauzas: and we will not do the conversion automatically | |
| 17:38:47 | sean-k-mooney | but os-resource-class does provide teh function to do the normalisation which you should use | |
| 17:38:52 | sean-k-mooney | we do use it in nova i belive | |
| 17:39:33 | sean-k-mooney | yep we do https://github.com/openstack/nova/blob/d64edd3da2336a5c7c8f69cced45272cbaf638a9/nova/tests/functional/compute/test_resource_tracker.py#L529 | |
| 17:40:55 | sean-k-mooney | well actully here https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/scheduler/utils.py#L304 | |
| 17:41:17 | sean-k-mooney | but anytime we constoct a custom RC name we should use it really | |
| 20:52:07 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 20:57:27 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 22:01:15 | opendevreview | Vlad Gusev proposed openstack/nova stable/train: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791807 | |
| 22:03:04 | opendevreview | Vlad Gusev proposed openstack/nova stable/stein: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/802935 | |
| 22:04:35 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 22:26:45 | opendevreview | melanie witt proposed openstack/nova master: Assert quota related API behavior when noop https://review.opendev.org/c/openstack/nova/+/712140 | |
| 22:26:45 | opendevreview | melanie witt proposed openstack/nova master: Add stub unified limits driver https://review.opendev.org/c/openstack/nova/+/712137 | |
| 22:26:46 | opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | |
| 22:26:46 | opendevreview | melanie witt proposed openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/c/openstack/nova/+/712141 | |
| 22:26:47 | opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | |
| 22:26:47 | opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | |
| 22:26:48 | opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | |
| 22:26:48 | opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | |
| 22:26:49 | opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | |
| 22:26:50 | opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to unified limits https://review.opendev.org/c/openstack/nova/+/713498 | |
| 22:26:50 | opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | |
| 22:26:52 | opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | |
| 22:26:52 | opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | |
| 23:01:14 | opendevreview | Vlad Gusev proposed openstack/nova stable/stein: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/802935 | |
| #openstack-nova - 2021-07-30 | |||
| 07:04:53 | opendevreview | Simon Li proposed openstack/nova-specs master: support ironic instance change host while it's host not up https://review.opendev.org/c/openstack/nova-specs/+/802991 | |
| 07:08:31 | opendevreview | Simon Li proposed openstack/nova-specs master: support ironic instance change host while it's host not up https://review.opendev.org/c/openstack/nova-specs/+/802991 | |
| 09:01:07 | bauzas | stephenfin: sean-k-mooney[m]: lovely reviews for my generic mdevs implementation, thanks !: | |
| 09:03:05 | artom_ | bauzas, have time to hit https://review.opendev.org/c/openstack/nova/+/802697? | |
| 09:21:27 | artom | bauzas, thanks for the review - so, I did consider doing a functional test, but given that this is 1. niche and 2. straightforward, any functional test I'd write would be either 1. a lot of groundwork to use the Ironic virt driver in the test or 2. have so much stuff mocked out, it'd be functionally (heh) identical to the existing unit test | |
| 09:29:25 | bauzas | artom: you don't need to use the ironic driver | |
| 09:29:49 | bauzas | artom: just use the standard fake driver and mock out (in the func test) the return you want | |
| 09:30:02 | artom | bauzas, that's what the unit test is doing :P | |