| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-22 | |||
| 15:17:27 | lyarwood | gibi: ah sorry I'm not in that channel, sounds good :) | |
| 15:17:40 | gibi | yeah it is in good hands now :) | |
| 15:26:02 | gibi | 12 | |
| 15:26:08 | gibi | ups | |
| 15:26:39 | gibi | melwitt: re consumer_types: so you created one transaction that containst both the ensure_consumer and the Allocation.replace_all calls | |
| 15:27:31 | gibi | melwitt: with a @db_api.placement_context_manager.writer decorator on the top. | |
| 15:27:43 | melwitt | gibi: yes, put both calls into a helper function decorated with the database context manager (this initiates the session/transaction) | |
| 15:28:39 | melwitt | it took me a long time to arrive at that because previously I was looking at the wrong code path for a different "set allocations" path that was already a single transaction /o\ | |
| 15:28:43 | gibi | melwitt: and later on when the ensure_consumer or the Allocation.replace_all calls the db_api.placement_context_manager.writer again then it won't start a separate transaction as the new, bigger one, is already started. Is it how the nested db decorator works? | |
| 15:32:42 | melwitt | gibi: right, it will check whether there is a session already created and if not it creates a new one (which will be a new transaction). if it finds a session already there, it will use that and that's how the nested things get connected. the session is an attribute on the RequestContext | |
| 15:33:14 | gibi | melwitt: awesome, thanks for the explanation | |
| 15:33:21 | melwitt | so you put the decorator on the outermost function with RequestContext as the first argument to group things into same transaction | |
| 15:35:01 | gibi | cool, clever solution | |
| 15:36:38 | melwitt | I couldn't move past the "why is it not a single transaction" because from all the code comments around setting allocations, it should have been. so I was going to keep looking until I found out why 😆 | |
| 15:36:45 | opendevreview | Merged openstack/nova master: docs: Clarify host-model, host-passthrough differences https://review.opendev.org/c/openstack/nova/+/782410 | |
| 15:37:10 | gibi | :) | |
| 15:42:48 | gmann | gibi: lyarwood for sdk https://review.opendev.org/c/openstack/openstacksdk/+/801872 | |
| 15:42:57 | melwitt | easy review to correct a reno https://review.opendev.org/c/openstack/nova/+/801144 if anyone can take a look. has a +2 from stephenfin already | |
| 15:43:58 | opendevreview | Samuel proposed openstack/nova master: Add REST and compute APIs to migrate instances between projects https://review.opendev.org/c/openstack/nova/+/801377 | |
| 15:44:37 | melwitt | I was able to consult a SME on telemetry and they let me know telemetry doesn't call the audit log API, it uses only the notifications | |
| 15:44:45 | lyarwood | gmann: cool thanks | |
| 15:55:23 | gibi | melwitt: I left 3 small comment in the consumer_type impl but over all it looks good https://review.opendev.org/c/openstack/placement/+/679441 | |
| 15:55:50 | gibi | gmann: will check soon | |
| 15:56:43 | gibi | melwitt: approved the reno update. thanks for that! | |
| 15:56:51 | melwitt | gibi: thanks for your patience on this one! and one of your comments looks familiar, apologies if it's one I missed in previous PS's | |
| 15:57:05 | melwitt | I will address them | |
| 15:58:15 | gibi | melwitt: no worries. | |
| 16:19:09 | opendevreview | Merged openstack/nova master: Correct reno for archiving task_log database records https://review.opendev.org/c/openstack/nova/+/801144 | |
| 16:43:16 | opendevreview | Stephen Finucane proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware https://review.opendev.org/c/openstack/nova/+/792364 | |
| 16:48:48 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 16:48:49 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 16:57:01 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/c/openstack/nova/+/738239 | |
| 16:57:02 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/c/openstack/nova/+/738018 | |
| 16:57:02 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/c/openstack/nova/+/738240 | |
| 16:57:03 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: add ovo-mypy-plugin to type hinting o.vos https://review.opendev.org/c/openstack/nova/+/758851 | |
| 16:57:03 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/c/openstack/nova/+/738019 | |
| 16:59:47 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Further tweaks to the CPU models document https://review.opendev.org/c/openstack/nova/+/784066 | |
| 17:36:29 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 17:36:32 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 18:21:11 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 18:21:15 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 21:22:45 | opendevreview | melanie witt proposed openstack/nova master: WIP Add force kwarg to delete_allocation_for_instance https://review.opendev.org/c/openstack/nova/+/688802 | |
| #openstack-nova - 2021-07-23 | |||
| 00:18:45 | gmann | gibi: stephenfin any plan to cut intermediate release for placement ? that will unblock converting the oslo warnings to error https://review.opendev.org/c/openstack/oslo.policy/+/801929 | |
| 07:05:23 | gibi | gmann: intermediate release from oslo.policy? | |
| 07:17:59 | bauzas | good morning folks | |
| 07:18:12 | bauzas | gibi: saw your email about the CI issue | |
| 07:19:07 | bauzas | gibi: thanks for following it | |
| 07:29:12 | gibi | bauzas: good morning | |
| 07:29:40 | gibi | bauzas: it was a full gate block for nova, so it needed to be resolved | |
| 07:29:50 | bauzas | that's what I saw | |
| 07:29:57 | bauzas | but the fix is merged, right? | |
| 07:30:04 | bauzas | oh, a new email :) | |
| 07:30:18 | gibi | yepp gtema fixed it while we slept | |
| 07:44:39 | gibi | sean-k-mooney: when you are up, melwitt holds her +A on the PR re-parenting patch waiting for your re-review. https://review.opendev.org/c/openstack/placement/+/784020 | |
| 07:44:51 | gibi | sean-k-mooney: so if you have time then a quick look would be appreciated | |
| 08:48:31 | opendevreview | Felix Huettner proposed openstack/nova master: Fix duplicate BDMs in compute manager https://review.opendev.org/c/openstack/nova/+/801990 | |
| 09:27:46 | opendevreview | Christian Rohmann proposed openstack/placement master: Fix SQL query counting the number of individual consumers having allocations by only selecting the aggregated consumer_id column. https://review.opendev.org/c/openstack/placement/+/801419 | |
| 10:50:25 | sean-k-mooney | gibi: a sorry about that was not looking at irc. ill be away for then next 30 mins but ill get it when im back | |
| 10:50:34 | gibi | sean-k-mooney: thanks! | |
| 11:06:37 | sean-k-mooney | ok you successfully nerd sniped me i did the review so +1 ok now ill be away for 30 mins :) | |
| 11:07:22 | gibi | sean-k-mooney: thanks a lot | |
| 11:50:50 | opendevreview | Lee Yarwood proposed openstack/nova master: WIP: Add functional test for duplicate bdms https://review.opendev.org/c/openstack/nova/+/802011 | |
| 12:28:27 | sean-k-mooney | bauzas: can you prioritiese reviewing https://review.opendev.org/c/openstack/nova/+/797428/2 i would like to see if we can get that landed this week so we can start backporting it | |
| 12:28:45 | bauzas | ack | |
| 12:29:08 | bauzas | hmpf, a os-vif change | |
| 12:29:10 | bauzas | I'll try | |
| 12:29:16 | sean-k-mooney | we were waitign for it a nova one | |
| 12:29:59 | sean-k-mooney | its fixing a bug i had in my patch that always delectas pluging to os-vif for ovs | |
| 12:31:53 | sean-k-mooney | we were waitign for that pacth to pass ci before mergeing the proceeding patch https://review.opendev.org/c/openstack/nova/+/797142/1 since we wanted to merge them at the same time | |
| 12:38:45 | bauzas | sean-k-mooney: I trusted you as I said in the comment : https://review.opendev.org/c/openstack/nova/+/797428 | |
| 12:39:25 | sean-k-mooney | thanks i was adding you since your revied the preceeding patch | |
| 12:39:44 | sean-k-mooney | mind adding +w to https://review.opendev.org/c/openstack/nova/+/797142 as well | |
| 12:39:48 | opendevreview | Felix Huettner proposed openstack/nova master: Fix duplicate BDMs in compute manager https://review.opendev.org/c/openstack/nova/+/801990 | |
| 12:43:02 | sean-k-mooney | * pinging you | |
| 12:53:59 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Deprecate support for floppy drives in 'Xena' https://review.opendev.org/c/openstack/nova/+/802022 | |
| 13:18:46 | opendevreview | Lee Yarwood proposed openstack/nova master: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/802011 | |
| 13:18:47 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/801990 | |
| 13:43:07 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 14:29:20 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove redundant service version check https://review.opendev.org/c/openstack/nova/+/768195 | |
| 14:29:21 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Use correct microversion for server group tests https://review.opendev.org/c/openstack/nova/+/768196 | |
| 14:30:36 | stephenfin | Yo, anyone care to look at these two scheduler-related functional tests? bauzas perhaps? https://review.opendev.org/q/topic:%22scheduler-filter-tests%22+(status:open%20OR%20status:merged) | |
| 14:31:14 | gibi | stephenfin: I will try before my vacation | |
| 14:31:18 | bauzas | sure, I can try to look | |
| 14:39:37 | gibi | stephenfin: one nit in https://review.opendev.org/c/openstack/nova/+/754115/1/nova/tests/functional/test_scheduler.py#104 | |
| 14:48:27 | bauzas | stephenfin: you misses a few tests | |
| 14:48:37 | bauzas | but thanks for the fish | |
| 14:49:49 | sean-k-mooney | is it me or does this debug log not make sense https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L1032-L1033 | |
| 14:50:09 | sean-k-mooney | if we take the else branch we are not applying any migration context | |
| 14:50:22 | sean-k-mooney | let alone one that does not belog to this instance | |
| 14:53:21 | gibi | stephenfin: also one more nit in https://review.opendev.org/c/openstack/nova/+/754116/1 | |
| 14:54:36 | gibi | sean-k-mooney: I guess it try to say that no migration context is set on the instance | |
| 14:54:55 | sean-k-mooney | right that would make sense | |
| 14:55:20 | sean-k-mooney | i might submit a 2 liner patch to adress that | |
| 14:55:56 | gibi | :) | |
| 14:55:58 | sean-k-mooney | the code is form 6 years ago so its possibel that the function signiture has changeed and it was possibel before or something like that and the message just never got fixed | |
| 14:57:04 | sean-k-mooney | re reading it i can see the interpertation you are suggesting just looking at it in the nova logs it looks odd | |
| 14:57:15 | gibi | I looked at the blame for that reason but I don't see signature changes | |
| 15:04:55 | stephenfin | bauzas: RE: your comment here https://review.opendev.org/c/openstack/nova/+/754116/1/nova/tests/functional/test_scheduler.py#150, is that a thing? | |
| 15:05:02 | stephenfin | the code says no | |
| 15:05:19 | stephenfin | I don't see us stripping the prefix from the metadata properties | |