| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-22 | |||
| 13:48:40 | sean-k-mooney | in general nova does not allow you to change the column data types form what we have in the schema | |
| 13:48:53 | sean-k-mooney | btu the encoding i dont think will break anything | |
| 13:49:09 | sean-k-mooney | belmoreira: are they plannign to actully modify the types in the tables | |
| 13:50:13 | sean-k-mooney | we generally are allowing sqlalchmy to mange the filed types | |
| 13:50:24 | belmoreira | I'm afraid to just discover some of these changes in prod. Anyway I will try to test it as much as possible and I will let you know if I discover something | |
| 13:51:01 | belmoreira | sean-k-mooney no they will not explicitly change the schema but they say it can happen when moving to utf8mb4 | |
| 13:51:34 | sean-k-mooney | well text files unlike nvarcars are not actully stored in the db correct | |
| 13:51:39 | belmoreira | I'm learning about all of this utf8 encoding :) | |
| 13:51:40 | sean-k-mooney | they are stored as sepereate files | |
| 13:51:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | |
| 13:51:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 13:52:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | |
| 13:52:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | |
| 13:52:29 | sean-k-mooney | we use string https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L256 when we wnat fixed lenght nvarchar columns | |
| 13:53:21 | belmoreira | I think the best is to do the conversion of a test DB and I will go manually through the schema. Maybe at the end there is nothing about this | |
| 13:54:16 | sean-k-mooney | ya | |
| 13:55:45 | sean-k-mooney | but ya just confirm that text filds are stored off table https://www.navicat.com/en/company/aboutus/blog/1308-choosing-between-varchar-and-text-in-mysql | |
| 13:55:55 | sean-k-mooney | belmoreira: where the issue might happen | |
| 13:56:02 | sean-k-mooney | would be for user-data | |
| 13:56:22 | sean-k-mooney | text field cans sture up to 64k fo data | |
| 13:57:00 | belmoreira | sean-k-mooney thanks a lot. I will let you know if something comes up | |
| 13:57:01 | sean-k-mooney | user-data is defiened to be medium text already https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L288 | |
| 13:57:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 13:57:17 | sean-k-mooney | so it should not need to be upgraded but ya let us know | |
| 13:58:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 13:58:52 | sean-k-mooney | MediumText can store 16 MB but we limit the user-data to 64k i belive in the api so it should fit thats the only filed that is likely to get close to 64k i think so hopefully it will just work out | |
| 14:04:28 | gibi | stephenfin:I've fixed your comments in the pps series | |
| 14:07:36 | gibi | I think we have a gate block due to https://zuul.opendev.org/t/openstack/builds?job_name=openstacksdk-functional-devstack&project=openstack/nova | |
| 14:08:58 | gibi | coudl be due to https://review.opendev.org/c/openstack/cinder/+/792299 | |
| 14:09:04 | gibi | moving to cinder ... | |
| 14:14:56 | lyarwood | Yeah you should be able to drop the v2 tests from osc now on master | |
| 14:15:07 | lyarwood | the sdk even sorry | |
| 14:16:36 | gibi | lyarwood: hm, good point, these are v2 tests | |
| 14:16:51 | gibi | then I'm going to delete them ... | |
| 14:38:25 | gibi | lyarwood: fyi, here is the removal of those tests https://review.opendev.org/c/openstack/openstacksdk/+/801864 | |
| 15:00:57 | sean-k-mooney | gibi: how did the v2 removal impact the nova gate by the way | |
| 15:01:23 | sean-k-mooney | https://review.opendev.org/c/openstack/openstacksdk/+/801864 should not affefct us right | |
| 15:03:05 | melwitt | gibi: thanks! and ack, will check the re-parenting | |
| 15:03:47 | gibi | sean-k-mooney: we gate on openstacksdk-functional-devstack job that started failing as it runs against a devstack and trying to find block storage v2 | |
| 15:04:16 | lyarwood | sean-k-mooney: I don't think it did | |
| 15:04:40 | lyarwood | sean-k-mooney: all of our cinderv2 stuff goes through cinderv3 now anyway | |
| 15:06:27 | sean-k-mooney | gibi: oh it is | |
| 15:14:54 | lyarwood | gibi: re osc, sorry I'm not trying to be difficult but I think we can just exclude these tests for now | |
| 15:17:07 | gibi | lyarwood: sure no worries. I #openstack-sdks gtema said he will inventigate a better way to fix this so I defer to him | |
| 15:17:27 | lyarwood | gibi: ah sorry I'm not in that channel, sounds good :) | |
| 15:17:40 | gibi | yeah it is in good hands now :) | |
| 15:26:02 | gibi | 12 | |
| 15:26:08 | gibi | ups | |
| 15:26:39 | gibi | melwitt: re consumer_types: so you created one transaction that containst both the ensure_consumer and the Allocation.replace_all calls | |
| 15:27:31 | gibi | melwitt: with a @db_api.placement_context_manager.writer decorator on the top. | |
| 15:27:43 | melwitt | gibi: yes, put both calls into a helper function decorated with the database context manager (this initiates the session/transaction) | |
| 15:28:39 | melwitt | it took me a long time to arrive at that because previously I was looking at the wrong code path for a different "set allocations" path that was already a single transaction /o\ | |
| 15:28:43 | gibi | melwitt: and later on when the ensure_consumer or the Allocation.replace_all calls the db_api.placement_context_manager.writer again then it won't start a separate transaction as the new, bigger one, is already started. Is it how the nested db decorator works? | |
| 15:32:42 | melwitt | gibi: right, it will check whether there is a session already created and if not it creates a new one (which will be a new transaction). if it finds a session already there, it will use that and that's how the nested things get connected. the session is an attribute on the RequestContext | |
| 15:33:14 | gibi | melwitt: awesome, thanks for the explanation | |
| 15:33:21 | melwitt | so you put the decorator on the outermost function with RequestContext as the first argument to group things into same transaction | |
| 15:35:01 | gibi | cool, clever solution | |
| 15:36:38 | melwitt | I couldn't move past the "why is it not a single transaction" because from all the code comments around setting allocations, it should have been. so I was going to keep looking until I found out why 😆 | |
| 15:36:45 | opendevreview | Merged openstack/nova master: docs: Clarify host-model, host-passthrough differences https://review.opendev.org/c/openstack/nova/+/782410 | |
| 15:37:10 | gibi | :) | |
| 15:42:48 | gmann | gibi: lyarwood for sdk https://review.opendev.org/c/openstack/openstacksdk/+/801872 | |
| 15:42:57 | melwitt | easy review to correct a reno https://review.opendev.org/c/openstack/nova/+/801144 if anyone can take a look. has a +2 from stephenfin already | |
| 15:43:58 | opendevreview | Samuel proposed openstack/nova master: Add REST and compute APIs to migrate instances between projects https://review.opendev.org/c/openstack/nova/+/801377 | |
| 15:44:37 | melwitt | I was able to consult a SME on telemetry and they let me know telemetry doesn't call the audit log API, it uses only the notifications | |
| 15:44:45 | lyarwood | gmann: cool thanks | |
| 15:55:23 | gibi | melwitt: I left 3 small comment in the consumer_type impl but over all it looks good https://review.opendev.org/c/openstack/placement/+/679441 | |
| 15:55:50 | gibi | gmann: will check soon | |
| 15:56:43 | gibi | melwitt: approved the reno update. thanks for that! | |
| 15:56:51 | melwitt | gibi: thanks for your patience on this one! and one of your comments looks familiar, apologies if it's one I missed in previous PS's | |
| 15:57:05 | melwitt | I will address them | |
| 15:58:15 | gibi | melwitt: no worries. | |
| 16:19:09 | opendevreview | Merged openstack/nova master: Correct reno for archiving task_log database records https://review.opendev.org/c/openstack/nova/+/801144 | |
| 16:43:16 | opendevreview | Stephen Finucane proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware https://review.opendev.org/c/openstack/nova/+/792364 | |
| 16:48:48 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 16:48:49 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 16:57:01 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/c/openstack/nova/+/738239 | |
| 16:57:02 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/c/openstack/nova/+/738018 | |
| 16:57:02 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/c/openstack/nova/+/738240 | |
| 16:57:03 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: add ovo-mypy-plugin to type hinting o.vos https://review.opendev.org/c/openstack/nova/+/758851 | |
| 16:57:03 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/c/openstack/nova/+/738019 | |
| 16:59:47 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Further tweaks to the CPU models document https://review.opendev.org/c/openstack/nova/+/784066 | |
| 17:36:29 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 17:36:32 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 18:21:11 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 18:21:15 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 21:22:45 | opendevreview | melanie witt proposed openstack/nova master: WIP Add force kwarg to delete_allocation_for_instance https://review.opendev.org/c/openstack/nova/+/688802 | |
| #openstack-nova - 2021-07-23 | |||
| 00:18:45 | gmann | gibi: stephenfin any plan to cut intermediate release for placement ? that will unblock converting the oslo warnings to error https://review.opendev.org/c/openstack/oslo.policy/+/801929 | |
| 07:05:23 | gibi | gmann: intermediate release from oslo.policy? | |
| 07:17:59 | bauzas | good morning folks | |
| 07:18:12 | bauzas | gibi: saw your email about the CI issue | |
| 07:19:07 | bauzas | gibi: thanks for following it | |
| 07:29:12 | gibi | bauzas: good morning | |
| 07:29:40 | gibi | bauzas: it was a full gate block for nova, so it needed to be resolved | |
| 07:29:50 | bauzas | that's what I saw | |
| 07:29:57 | bauzas | but the fix is merged, right? | |
| 07:30:04 | bauzas | oh, a new email :) | |
| 07:30:18 | gibi | yepp gtema fixed it while we slept | |
| 07:44:39 | gibi | sean-k-mooney: when you are up, melwitt holds her +A on the PR re-parenting patch waiting for your re-review. https://review.opendev.org/c/openstack/placement/+/784020 | |
| 07:44:51 | gibi | sean-k-mooney: so if you have time then a quick look would be appreciated | |
| 08:48:31 | opendevreview | Felix Huettner proposed openstack/nova master: Fix duplicate BDMs in compute manager https://review.opendev.org/c/openstack/nova/+/801990 | |