| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-21 | |||
| 05:58:33 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 07:09:51 | opendevreview | Eric Xie proposed openstack/nova master: Fix error '404 Not Found' https://review.opendev.org/c/openstack/nova/+/797233 | |
| 08:32:34 | slaweq | elodilles hi, can You +W patch https://review.opendev.org/c/openstack/nova/+/787252 ? It was rebased recently | |
| 08:34:19 | elodilles | slaweq: +W'd | |
| 08:36:41 | elodilles | I hope it really merges now... the gate is in surprisingly bad shape according to the rechecks on this patch :/ | |
| 08:37:55 | elodilles | despite that a number of gate improvements were merged :X | |
| 08:56:15 | lyarwood | sean-k-mooney / gibi / artom / bauzas ; https://review.opendev.org/c/openstack/nova/+/797142 - can you all take a look at this when you get a chance? Blocks the already in progress backport of https://review.opendev.org/q/I11fb5d3ada7f27b39c183157ea73c8b72b4e672e | |
| 08:56:21 | lyarwood | oh and morning btw :) | |
| 08:56:30 | bauzas | fer sur | |
| 08:56:44 | bauzas | and bonjour | |
| 09:27:22 | slaweq | elodilles thx a lot | |
| 09:37:20 | elodilles | slaweq: np | |
| 10:52:28 | stephenfin | sean-k-mooney: It's working for real this time now https://review.opendev.org/c/openstack/nova/+/797142 | |
| 10:53:32 | sean-k-mooney | stephenfin: yep reviewing it again | |
| 10:54:16 | sean-k-mooney | i did not have a chance to test that since i added the detection mechanium in a real mixed env only with the ci | |
| 10:54:35 | sean-k-mooney | its annoying that this sliped though but im about to +1 that | |
| 10:55:16 | stephenfin | lyarwood: I'd rather avoid addressing those nits on ^, since I've already prepared the backports (with a -1 to prevent anyone merging yet) and don't want to drag more work on myself :-D | |
| 10:55:31 | stephenfin | I could do a follow-up but they seem too minor to bother, for once | |
| 10:56:21 | sean-k-mooney | i dont think the new=... | |
| 10:56:24 | sean-k-mooney | is needed | |
| 10:56:31 | sean-k-mooney | its defenetly nice to prefer to do that | |
| 10:56:38 | sean-k-mooney | if the mock is not required in the test | |
| 10:57:04 | sean-k-mooney | but we didnt do that until about a year or so ago because we did not know we could | |
| 10:57:22 | sean-k-mooney | so its not inconsitnet with thte exsiting test just not the optimal way | |
| 11:05:09 | stephenfin | yeah, my thinking too | |
| 11:05:22 | stephenfin | I'd respin if I hadn't already started on the backports, but ... | |
| 11:05:32 | stephenfin | backports appear to be working as expected too | |
| 11:05:45 | stephenfin | I'll tackle stable/ussuri and stable/train after lunch | |
| 11:06:27 | sean-k-mooney | yeah!!! i really wasnt looking forward to debuging that if it didint | |
| 11:07:20 | sean-k-mooney | /yeah/yay/ | |
| 11:22:26 | sean-k-mooney | by the way http://paste.openstack.org/show/806817/ | |
| 11:22:36 | sean-k-mooney | we have q35 testing right? | |
| 11:23:48 | sean-k-mooney | actully this is more userful http://paste.openstack.org/show/806818/ | |
| 11:24:50 | sean-k-mooney | wait i wonder did i uppercase Q35 instead of q35 | |
| 11:41:57 | sean-k-mooney | lyarwood: stephenfin bauzas https://bugs.launchpad.net/nova/+bug/1933097 this is what i get form deploying openstack at home, more work | |
| 12:24:12 | bauzas | sean-k-mooney: *me* facepalms | |
| 12:28:11 | sean-k-mooney | i never write it with an uppercase but this time i did... | |
| 12:37:07 | opendevreview | Merged openstack/nova master: api: Log correct client IP if load balancer in use https://review.opendev.org/c/openstack/nova/+/786766 | |
| 12:50:13 | sean-k-mooney | bauzas: can you take a look at https://review.opendev.org/q/topic:%22bug%252F1910466%22+(status:open%20OR%20status:merged) | |
| 12:50:30 | bauzas | ack, will look | |
| 12:50:42 | sean-k-mooney | we suspect the customer might start escalating that soonish so just trying to get ahead fo that | |
| 13:09:06 | opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797291 | |
| 13:46:34 | lyarwood | stephenfin: yeah no issues | |
| 13:46:50 | lyarwood | sean-k-mooney: haha nice, I did think about that when I was doing the nova-manage stuff that does validate that | |
| 14:11:45 | opendevreview | Stephen Finucane proposed openstack/nova stable/train: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797316 | |
| 14:13:09 | stephenfin | sean-k-mooney: ^ will wait and see how the stable/ussuri change goes (I can't run all tests locally in my env) but that _should_ be it | |
| 14:17:30 | sean-k-mooney | ok good | |
| 14:17:40 | sean-k-mooney | did you hit any issue with python2 compatiablity | |
| 14:17:53 | sean-k-mooney | or other funcitonal test issue | |
| 14:19:22 | opendevreview | Merged openstack/nova master: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/769601 | |
| 14:22:56 | stephenfin | sean-k-mooney: not that I can tell. The modified tests did pass | |
| 14:23:04 | stephenfin | (I could run those) | |
| 14:23:42 | sean-k-mooney | i was ok cool from thje commit it looks like the conflict were not as bad as i was fearing | |
| 14:23:42 | stephenfin | gibi: Are you around today? Care to look at https://review.opendev.org/c/openstack/nova/+/797142 if so? | |
| 14:24:06 | sean-k-mooney | s/i was// | |
| 16:11:44 | opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797291 | |
| 16:20:11 | opendevreview | Stephen Finucane proposed openstack/nova stable/train: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797316 | |
| 17:51:36 | sean-k-mooney | stephenfin: https://zuul.opendev.org/t/openstack/build/73f734b9ffe745bd833ffe90f324d6d8/log/controller/logs/screen-n-cpu.txt#7643-7653 | |
| 17:51:55 | sean-k-mooney | stephenfin: its still using <interface type=bridge> | |
| 17:52:22 | sean-k-mooney | stephenfin: it should be <interface type=ethernet> | |
| 17:59:41 | sean-k-mooney | stephenfin: this is how i orginally set teh flag by the way https://review.opendev.org/c/openstack/nova/+/602432/29..30/nova/objects/migrate_data.py | |
| 18:02:05 | sean-k-mooney | i was trying to use udate which updates in place and returns None instead of the updated dict which was a bug | |
| 18:04:42 | sean-k-mooney | this is the only other thing that chaged that jumped out at me https://review.opendev.org/c/openstack/nova/+/602432/29..30/nova/conductor/tasks/live_migrate.py#b403 | |
| 18:04:52 | sean-k-mooney | but i think that is logically the same thing | |
| 18:06:48 | sean-k-mooney | so we still have the same probelm that i was havign with that patch orginally when i put in the code to detect if the dest was patched it always disables the code even after fixing the profile update issue | |
| 18:07:04 | sean-k-mooney | even with https://review.opendev.org/c/openstack/nova/+/797142 | |
| 18:07:53 | sean-k-mooney | i can try and take a look at this with you tomorow if you like but i think we need a functional test that assert the xml has interface type=ethernet | |
| #openstack-nova - 2021-06-22 | |||
| 08:37:04 | zigo | Since Bullseye, live migration is broken on my system, with libvirt not listening on the qemu+tcp port (it's using socket activation). Does anyone know how to configure the new libvirt correctly for this? | |
| 08:58:09 | stephenfin | sean-k-mooney1: you're looking at the wrong XML, I think | |
| 08:59:47 | stephenfin | sean-k-mooney1: You can see the update happening here https://zuul.opendev.org/t/openstack/build/73f734b9ffe745bd833ffe90f324d6d8/log/compute1/logs/screen-n-cpu.txt#7468-7476 | |
| 09:02:09 | bauzas | do someone know whether we use in our jobs the singleconductor devstack value ? https://github.com/openstack/devstack/blob/master/lib/nova#L537 ? | |
| 09:02:42 | bauzas | I was expecting us to create a superconductor by default even for a devstack AIO | |
| 09:09:06 | bauzas | nevermind, found it | |
| 09:09:15 | bauzas | this is just legacy | |
| 09:09:45 | bauzas | I can't see a single job running with a singleconductor | |
| 09:15:34 | stephenfin | bauzas: maybe remove it so? | |
| 09:15:41 | stephenfin | *we should | |
| 09:15:47 | bauzas | yup, think so | |
| 10:07:34 | sean-k-mooney1 | stephenfin the xml should always be ethernet | |
| 10:08:40 | sean-k-mooney1 | stephenfin: it is useing ethernet in that segment which is good | |
| 10:08:54 | sean-k-mooney1 | but it should spawn with it too | |
| 10:09:51 | sean-k-mooney1 | stephenfin: ok so we need to determin why its only taking effect on migration and not on inital spawn | |
| 10:10:12 | sean-k-mooney1 | that narrows it down at least | |
| 10:14:54 | stephenfin | sean-k-mooney: We never set the 'delegate_create' attribute of the VIF object anywhere except as part of a migration | |
| 10:15:37 | stephenfin | sean-k-mooney: https://github.com/openstack/nova/commit/a62dd42c0dbb6b2ab128e558e127d76962738446#diff-d47af556a60631b879ac4f609e24b5616aa81643d152583b1591ef90848382bbR108 | |
| 10:16:01 | stephenfin | which means it's never set as part of the os-vif object https://github.com/openstack/nova/commit/a62dd42c0dbb6b2ab128e558e127d76962738446#diff-918e740344fd54062b1d2040fc7d83a6fb349e33a484b3a442d154977a7f872bR350 | |
| 10:16:05 | sean-k-mooney | ah ok that was my orginal error then. i used to do it uncondtionally then i added the code to do the patch detection | |
| 10:17:05 | sean-k-mooney | so we want to default it to true but have the migration code check and disable if the dest is not supported | |
| 10:19:49 | stephenfin | I can look into that. It's a different issue than the one I'm fixing in that patch though, so I think that patch is still valid by itself | |
| 10:22:03 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | |
| 10:22:35 | sean-k-mooney | it is but without that other change its a really odd behavior | |
| 10:22:45 | sean-k-mooney | i kind of think they need to be in one patch | |
| 10:23:16 | sean-k-mooney | we dont want the interface to be differn after a live migration and have it chagne back after a hard reboot do we | |
| 10:23:26 | sean-k-mooney | we could do that but it feels odd | |
| 10:23:59 | sean-k-mooney | its also not what i had planned in that libvirt would still be invovled in port plugging | |
| 10:24:41 | sean-k-mooney | stephenfin: we can just set it here i belive https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L2972 | |
| 10:26:10 | sean-k-mooney | although that technically would mean it should be in the vif model object | |
| 10:27:06 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | |
| 10:28:02 | sean-k-mooney | this is where we make the desision currently | |
| 10:28:25 | stephenfin | sean-k-mooney: we create the VIF just after we call that function https://github.com/openstack/nova/blob/5979c648462b03a2fe90148f20f099c964cdd298/nova/network/neutron.py#L3078 | |