| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-16 | |||
| 15:56:02 | sean-k-mooney | <server> Server (name or ID) | |
| 15:56:04 | sean-k-mooney | <migration> Migration (ID) | |
| 15:56:06 | sean-k-mooney | so basically you have to start the live migration | |
| 15:56:22 | sean-k-mooney | then you can get the migration id and then force the completeion of the live migation | |
| 15:57:41 | sean-k-mooney | melwitt: sorry dont rememebr the context of that but if the hint? helpped im glad | |
| 15:57:57 | sean-k-mooney | oh | |
| 15:58:07 | sean-k-mooney | melwitt: the socket activation? | |
| 15:58:23 | melwitt | sean-k-mooney: haha yeah the fixing for bionic thing | |
| 16:00:09 | melwitt | stephenfin, lyarwood, bauzas: I'm meh about approving older branches before the newer one merges, I don't think it solves the ping problem. in my case it's just I don't always remember to review all the older versions and I don't often like to do them all at the same time anyway | |
| 16:01:11 | stephenfin | I figured it would solve the ping problem, or at least significantly reduce it | |
| 16:01:35 | stephenfin | in theory, if all branches were approved, one could get them merged by a simple recheck | |
| 16:05:00 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 16:05:56 | melwitt | yeah. I guess one potential thing that could happen is if the author/rechecker doesn't realize they can't merge out of order and they go on a recheck loop in the wrong order. I have seen that before anyway but I'd imagine it's more tempting when you see the shiny +W on there | |
| 16:10:23 | admin1 | sean-k-mooneythanks .. it worked | |
| 16:22:00 | opendevreview | Merged openstack/nova master: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796269 | |
| 16:31:40 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796707 | |
| 16:59:57 | stephenfin | le sigh https://storyboard.openstack.org/#!/story/2008549 | |
| 17:00:27 | stephenfin | "I set the state of my shelved offloaded instance to active and it broke things" | |
| 17:01:55 | lyarwood | lol | |
| 17:01:56 | melwitt | lol | |
| 17:02:06 | melwitt | we need a required option on set state like --I-acknowledge-this-might-break-something | |
| 17:03:16 | lyarwood | -i-really-know-what-im-doing-and-if-this-breaks-anything-i-am-to-blame | |
| 17:03:59 | melwitt | 😂 yeah the longer the option, the better | |
| 17:05:14 | melwitt | realistically, we should put a big fat warning in the set state help that says something similar. if there already is one, then ... :| | |
| 17:06:00 | lyarwood | I think there might be in the api-ref but yeah osc could say more | |
| 17:12:09 | stephenfin | * derekh has quit (Quit: Leaving) | |
| 17:12:09 | stephenfin | <stephenfin> "I set the state of my shelved offloaded instance to active and it broke things" | |
| 17:12:09 | stephenfin | ||
| 17:12:09 | stephenfin | melwitt: lyarwood: 96707 | |
| 17:12:10 | stephenfin | whoops | |
| 17:12:21 | stephenfin | lyarwood: melwitt: https://review.opendev.org/c/openstack/python-openstackclient/+/796713 | |
| 17:12:35 | stephenfin | (HexChat copies whatever you highlight to the clipboard) | |
| 17:15:07 | melwitt | sweet | |
| 17:20:04 | lyarwood | stephenfin: that could've been so much worse ^_^ | |
| 17:30:32 | opendevreview | Merged openstack/nova stable/victoria: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/795542 | |
| 17:31:19 | opendevreview | Merged openstack/placement master: Bump os-resource-classes deps to 1.0.0 https://review.opendev.org/c/openstack/placement/+/796593 | |
| 17:39:55 | sean-k-mooney | admin1: useing force complete cool | |
| 17:40:04 | sean-k-mooney | admin1: that makes it a semi live migration | |
| 17:40:25 | sean-k-mooney | the vm does not restart or anythng but it proably will notice its clock is wrong and or drop packets | |
| 17:41:02 | sean-k-mooney | so normally we avoid that but its good to know its an option when you really need to move soemthing and is still friendlier then a cold migrate | |
| 17:41:50 | sean-k-mooney | why is that in story board | |
| 17:42:04 | sean-k-mooney | and ya we had a downstream issue to the same effect recently | |
| 17:42:45 | sean-k-mooney | melwitt: i wonder if we should actully consier blocking that in the api | |
| 17:43:11 | sean-k-mooney | its never valide to reset state form shelve offloaded to any other state then error | |
| 17:45:16 | sean-k-mooney | lyarwood: stephenfin melwitt by the way we still have a todo item somehwer to extend the reset state api to allow more states and to allow settign the task_state too | |
| 17:46:13 | sean-k-mooney | if we do that we should harden the allowed state transations IMO | |
| 17:46:49 | melwitt | sean-k-mooney: yeah... conflicted about that because reset state is kind of a wild west api call to make but on the other hand if we can block something that's guaranteed to be invalid, that makes sense too | |
| 17:46:51 | sean-k-mooney | e.g. ERROR we woudl allow to go to any sate as an escape hatch. but any none ERROR state should not be changable arbitrailly | |
| 17:47:57 | sean-k-mooney | melwitt: im pretty sure it can result in data lose | |
| 17:48:24 | sean-k-mooney | if you do resetstat form shelve offloaded and then do either hard reboot or a migration i cant rememebr which | |
| 17:48:29 | melwitt | ? | |
| 17:48:36 | sean-k-mooney | we had a customer do that with ceph recently | |
| 17:48:42 | sean-k-mooney | and they lost the snapshot | |
| 17:49:15 | melwitt | I guess I'm not realizing how that happens. if it's shelved offloaded there's no guest to reboot | |
| 17:49:59 | sean-k-mooney | yes so if i rememebr correctly unshleve failed so the reset state then hard rebooted | |
| 17:50:03 | sean-k-mooney | that failed because no host | |
| 17:50:42 | sean-k-mooney | the then reset state again and tired to shleve i think? this is where my memory is blank | |
| 17:51:02 | sean-k-mooney | when we got the bz they had tried some cobination of that several times | |
| 17:51:14 | sean-k-mooney | and the rbd volume was nolonger preset for the vm root disk | |
| 17:52:05 | melwitt | ah ok, so you're saying if we prevent that path from even starting, it can avoid whatever future thing they managed to do to lose the data | |
| 17:52:14 | sean-k-mooney | yes | |
| 17:52:58 | melwitt | yeah ok | |
| 17:58:56 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/ussuri: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/796719 | |
| #openstack-nova - 2021-06-17 | |||
| 01:46:55 | opendevreview | melanie witt proposed openstack/nova master: Add func test for nova-manage db archive_deleted_rows --before https://review.opendev.org/c/openstack/nova/+/796744 | |
| 01:57:32 | opendevreview | melanie witt proposed openstack/nova master: Add --task-log option to nova-manage db archive_deleted_rows https://review.opendev.org/c/openstack/nova/+/780395 | |
| 02:00:14 | melwitt | lyarwood, elodilles: it's funny passing CI \o/ (but recheck-a-thon) https://review.opendev.org/c/openstack/nova/+/795432 | |
| 02:00:21 | melwitt | s/funny/finally/ | |
| 07:11:07 | gibi | lyarwood: hi! regarding https://review.opendev.org/c/openstack/nova/+/796523 I'm sure I asked this before but forgot. Where do we have now the evacuation test coverage? | |
| 07:18:13 | opendevreview | Merged openstack/nova stable/rocky: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/c/openstack/nova/+/747612 | |
| 07:18:37 | opendevreview | Merged openstack/nova stable/wallaby: Neutron fixture: don't clobber profile and vif_details if empty https://review.opendev.org/c/openstack/nova/+/792233 | |
| 07:18:50 | opendevreview | Merged openstack/nova stable/wallaby: Test SRIOV port move operations with PCI conflicts https://review.opendev.org/c/openstack/nova/+/790710 | |
| 07:31:09 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 07:31:10 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 07:31:10 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 07:43:53 | lyarwood | melwitt: awesome :) I'll +1 only as I modified it | |
| 07:44:21 | lyarwood | gibi: it's part of the live migration jobs | |
| 07:44:32 | lyarwood | gibi: runs in the post playbook | |
| 07:45:32 | lyarwood | gibi: https://github.com/openstack/nova/tree/master/roles/run-evacuate-hook is the role we use | |
| 07:45:46 | lyarwood | gibi: https://github.com/openstack/nova/blob/master/playbooks/nova-live-migration/post-run.yaml is where it's called | |
| 07:46:10 | lyarwood | gibi: the logic being that we didn't want to stand up another multinode env every run to test evacuation | |
| 07:46:39 | lyarwood | gibi: doing it in post was easier as we didn't need to copy and paste any of the tempest playbook logic into Nova | |
| 07:50:13 | lyarwood | gibi: so for that review evacuation is tested from here https://zuul.opendev.org/t/openstack/build/057093756ca64ef994584e2cae50f537/log/job-output.txt#64392 | |
| 07:50:41 | opendevreview | Merged openstack/nova stable/victoria: Reproduce bug 1897528 https://review.opendev.org/c/openstack/nova/+/791767 | |
| 08:03:14 | gibi | lyarwood: thanks | |
| 08:03:22 | gibi | I hope I will not foget this again :) | |
| 08:14:00 | lyarwood | ^_^ | |
| 09:01:07 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 09:01:07 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 09:01:08 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 09:01:09 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 09:01:10 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 09:02:40 | opendevreview | Merged openstack/nova stable/victoria: Ignore PCI devices with 32bit domain https://review.opendev.org/c/openstack/nova/+/791768 | |
| 09:03:42 | yonglihe | rebase to fix dependency problem, that's weird. | |
| 09:19:39 | lyarwood | yonglihe: A pip dependency problem? We've seen loads that make no sense recently. | |
| 09:21:25 | stephenfin | lyarwood: it's a cache issue, I think | |
| 09:21:41 | lyarwood | oh the limestone thing? | |
| 09:21:44 | stephenfin | yeah, I think so | |
| 09:22:51 | lyarwood | wonderful | |
| 09:22:59 | stephenfin | it's failing with e.g. dep a requesting >=1.2 and upper constraints requesting == 3.0, which would pass unless 3.0 wasn't available | |
| 09:24:48 | stephenfin | hmm, maybe not actually - the error message I get locally is different | |