| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-02 | |||
| 16:36:01 | sean-k-mooney | actully maybe SUPPORTED_VERSIONS[-1] would be better | |
| 16:36:22 | sean-k-mooney | we have a choice of assume oldest or newest microversion for completion | |
| 16:36:33 | sean-k-mooney | newset might be best | |
| 16:36:59 | sean-k-mooney | gibi: do you think ^ is a vaild approch | |
| 16:37:44 | gibi | sean-k-mooney: agree, for completion just assume the newest supported | |
| 16:38:20 | sean-k-mooney | rm_work: you could proably work around this by changing the complation command used in bash | |
| 16:38:42 | sean-k-mooney | to pass --os-placment-api-version or whatever that flag is to the openstack client | |
| 16:38:49 | sean-k-mooney | as a tempory hack | |
| 16:40:40 | sean-k-mooney | gibi: actully if you just run "openstack complete" you get "ould not clean up: 'ClientManager' object has no attribute 'sdk_connection'" | |
| 16:40:42 | sean-k-mooney | at the end | |
| 16:41:03 | gibi | that last error comes from 2.2.0 as well | |
| 16:41:08 | gibi | but it does not break completion I think | |
| 16:41:13 | gibi | or is it? | |
| 16:44:11 | rm_work | yeah i've noticed that for a long time, not sure if that's placement related | |
| 16:44:21 | rm_work | and no, it didn't break completion | |
| 16:45:06 | sean-k-mooney | correct it does not but it does point to the fact that this is a general problem with the complete command | |
| 16:45:54 | sean-k-mooney | in at least the cleanup path its trying to unconditonally clean up the sdk connection that is never established | |
| 16:46:54 | rm_work | yeah | |
| 16:49:12 | sean-k-mooney | rm_work: can you try invoking complete but passing --os-cloud | |
| 16:49:25 | rm_work | uhh sure | |
| 16:49:34 | rm_work | I do have OS_CLOUD exported, FWIW | |
| 16:49:47 | sean-k-mooney | oh in that case never mind | |
| 16:50:01 | rm_work | and yeah no difference | |
| 16:50:02 | sean-k-mooney | i was wondering if we told it what cloud to sue woudl the normal auth kick in | |
| 16:50:24 | rm_work | what is an example `--os-placment-api-version` i could try btw | |
| 16:50:49 | rm_work | well, typed a random number and it works | |
| 16:51:01 | rm_work | `openstack complete --os-placement-api-version 1.2` | |
| 16:51:10 | sean-k-mooney | ya caus its disabling the negocation | |
| 16:51:15 | rm_work | yep | |
| 16:51:23 | rm_work | just confirming your theory for that too | |
| 16:51:43 | sean-k-mooney | thats the workaround for now more or less | |
| 16:52:03 | rm_work | ok, LMK if there's something I can help review :) | |
| 16:52:28 | sean-k-mooney | im just going to push something quickly | |
| 16:52:38 | rm_work | i can test whatever locally | |
| 16:56:09 | opendevreview | sean mooney proposed openstack/osc-placement master: [WIP] default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | |
| 16:57:11 | rm_work | some other client actually IS trying to do auth I think... i have to yubi-key to do `openstack complete` lol | |
| 16:57:20 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/794186 | |
| 16:57:36 | opendevreview | sean mooney proposed openstack/osc-placement master: [WIP] default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | |
| 16:59:00 | sean-k-mooney | rm_work: ya as i said you would have to specificaly code for this with auto negociation | |
| 16:59:10 | rm_work | hmmm | |
| 16:59:15 | rm_work | `ValueError: invalid version number '1'` | |
| 16:59:19 | rm_work | with your patch | |
| 16:59:28 | rm_work | not sure exactly why | |
| 17:00:19 | rm_work | http://paste.openstack.org/show/806286/ | |
| 17:00:30 | rm_work | logically your fix seems right | |
| 17:00:35 | sean-k-mooney | https://github.com/openstack/osc-placement/blob/master/osc_placement/version.py#L18 | |
| 17:00:41 | sean-k-mooney | it is getting that | |
| 17:00:50 | sean-k-mooney | because of https://github.com/openstack/osc-placement/blob/master/osc_placement/version.py#L52 | |
| 17:00:59 | sean-k-mooney | let me try MAX_VERSION_NO_GAP | |
| 17:01:08 | rm_work | OH yeah I see | |
| 17:01:40 | rm_work | I misread SUPPORTED_MICROVERSIONS as SUPPORTED_VERSIONS | |
| 17:01:40 | opendevreview | sean mooney proposed openstack/osc-placement master: [WIP] default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | |
| 17:02:11 | sean-k-mooney | ya so did i when i wrote it | |
| 17:02:21 | sean-k-mooney | i ment to get the last supported microveris | |
| 17:02:39 | rm_work | k looks good | |
| 17:03:14 | sean-k-mooney | i might change it back to SUPPORTED_MICROVERSIONS[-1] but does that seam to fix it | |
| 17:03:30 | rm_work | this seems like it accomplishes your goal pretty explicitly | |
| 17:03:38 | rm_work | since you wanted ... that | |
| 17:03:40 | rm_work | max version | |
| 17:04:24 | melwitt | stephenfin: are you interested in +W-ing the placement re-parenting spec? https://review.opendev.org/c/openstack/nova-specs/+/788243 | |
| 17:04:37 | opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | |
| 17:04:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | |
| 17:04:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | |
| 17:04:58 | sean-k-mooney | rm_work: ok well i can see if we can turn that into a proper patch with some tests | |
| 17:05:07 | rm_work | well I +1'd | |
| 17:05:09 | rm_work | lol | |
| 17:05:40 | sean-k-mooney | well it work but i want to put a unit test that asssert we dont call the thing that explode when session is None | |
| 17:06:13 | rm_work | yep, makes sense | |
| 17:06:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | |
| 17:08:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | |
| 17:13:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | |
| 17:13:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | |
| 17:16:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208 | |
| 17:18:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 17:21:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | |
| 17:22:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 17:30:48 | opendevreview | sean mooney proposed openstack/osc-placement master: default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | |
| 17:33:28 | rm_work | \o/ | |
| 17:35:22 | sean-k-mooney | lol i broke the docs because thre app is non | |
| 17:35:49 | sean-k-mooney | File "/home/zuul/src/opendev.org/openstack/osc-placement/osc_placement/version.py", line 141, in get_version | |
| 17:35:51 | sean-k-mooney | if obj.app.client_manager.session is None: | |
| 17:35:53 | sean-k-mooney | AttributeError: 'NoneType' object has no attribute 'client_manager' | |
| 17:37:49 | opendevreview | sean mooney proposed openstack/osc-placement master: default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | |
| 17:38:07 | sean-k-mooney | rm_work: ok ^ should be the final patch unless peopel ask for feedback | |
| 17:38:12 | sean-k-mooney | well provide feedback | |
| 17:38:35 | sean-k-mooney | gibi: can you add https://review.opendev.org/c/openstack/osc-placement/+/794276 to your review queue | |
| 17:39:08 | rm_work | would docs not also want latest? | |
| 17:39:44 | sean-k-mooney | maybe | |
| 17:39:50 | rm_work | but, starts to be hard to code for every little case like that when you're basically making an inference about the caller | |
| 17:39:59 | sean-k-mooney | but they were previouly getting the oldest | |
| 17:40:01 | rm_work | not "if for_docs:" | |
| 17:40:06 | rm_work | yeah... | |
| 17:40:22 | sean-k-mooney | i can do this a different way | |
| 17:40:30 | sean-k-mooney | i can catch the other error type | |
| 17:40:40 | sean-k-mooney | PluginAtributeERROR | |
| 17:41:05 | sean-k-mooney | but i dont like that since it actully trys to connect the cloud | |
| 17:41:37 | stephenfin | melwitt: Won't have a chance now (I'm just finishing up) but I think I didn't have any concerns of my own, so if you're happy to +W then go for it :) | |
| 17:42:20 | melwitt | cool, thanks stephenfin | |
| 17:42:23 | sean-k-mooney | rm_work: let me see what the docs are using it for | |
| 17:48:39 | sean-k-mooney | rm_work: its from cliff/sphinxext.py | |