Earlier  
Posted Nick Remark
#openstack-nova - 2021-04-14
14:41:26 sean-k-mooney i think you would set somehtin like this "{scheme}://{username}:{password}@{hostname}/{path}?{query}"
14:41:36 sean-k-mooney in the cell mapping
14:41:36 sean-k-mooney in the cell mapping
14:42:08 noonedeadpunk But um. I mean that in nova.conf I should still have regular transport_url ?
14:42:08 noonedeadpunk But um. I mean that in nova.conf I should still have regular transport_url ?
14:43:08 noonedeadpunk So it's transport_url got splited and auto substituted in case cell mapping contains variables??
14:43:08 noonedeadpunk So it's transport_url got splited and auto substituted in case cell mapping contains variables??
14:43:15 sean-k-mooney that im not sure im trying to figure out
14:43:15 sean-k-mooney that im not sure im trying to figure out
14:43:53 sean-k-mooney unfortuetly our downstream sos report replace it with transport_url=********* since it could have password so i dont have an example with tls enable to look at
14:43:53 sean-k-mooney unfortuetly our downstream sos report replace it with transport_url=********* since it could have password so i dont have an example with tls enable to look at
14:44:12 noonedeadpunk as eventually http://paste.openstack.org/show/804476/ is not working in nova.conf... (test env, so I'm not bothered about password there :p)
14:44:12 noonedeadpunk as eventually http://paste.openstack.org/show/804476/ is not working in nova.conf... (test env, so I'm not bothered about password there :p)
14:46:43 sean-k-mooney the unit test seam to be seetting the values in the nova.conf in the tansport url
14:46:43 sean-k-mooney the unit test seam to be seetting the values in the nova.conf in the tansport url
14:46:45 sean-k-mooney https://github.com/openstack/nova/blame/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/tests/unit/objects/test_cell_mapping.py#L216-L231
14:46:45 sean-k-mooney https://github.com/openstack/nova/blame/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/tests/unit/objects/test_cell_mapping.py#L216-L231
14:49:46 noonedeadpunk yep, looks like this way indeed
14:49:46 noonedeadpunk yep, looks like this way indeed
14:50:01 sean-k-mooney noonedeadpunk: i think ya you shoudl be still setting actula datat in the nova.conf
14:50:01 sean-k-mooney noonedeadpunk: i think ya you shoudl be still setting actula datat in the nova.conf
14:50:19 sean-k-mooney and then we split the url and teake the info in the db and templeate it
14:50:19 sean-k-mooney and then we split the url and teake the info in the db and templeate it
14:50:33 noonedeadpunk So I see literally no point in not using templates under any conditions...
14:50:33 noonedeadpunk So I see literally no point in not using templates under any conditions...
14:50:57 noonedeadpunk sean-k-mooney: thanks a lot!
14:50:57 noonedeadpunk sean-k-mooney: thanks a lot!
14:51:10 sean-k-mooney noonedeadpunk: i think we always use the in ooo/OSP since it was added in rocky
14:51:10 sean-k-mooney noonedeadpunk: i think we always use the in ooo/OSP since it was added in rocky
14:52:27 noonedeadpunk I think for us to migrate to it, we need to replace https://opendev.org/openstack/openstack-ansible-os_nova/src/branch/master/tasks/nova_db_setup.yml#L62 and add task to nova-manage cell_v2 update_cell during upgrades as far as I got the process?
14:52:27 noonedeadpunk I think for us to migrate to it, we need to replace https://opendev.org/openstack/openstack-ansible-os_nova/src/branch/master/tasks/nova_db_setup.yml#L62 and add task to nova-manage cell_v2 update_cell during upgrades as far as I got the process?
15:01:10 melwitt gibi: heya, in case you wanted to look at PS2 on the reject force up if evacuations not complete https://review.opendev.org/c/openstack/nova/+/784130 to check before approving
15:01:10 melwitt gibi: heya, in case you wanted to look at PS2 on the reject force up if evacuations not complete https://review.opendev.org/c/openstack/nova/+/784130 to check before approving
15:01:33 gibi melwitt: thanks for the heads up I will look now
15:01:33 gibi melwitt: thanks for the heads up I will look now
15:06:07 gibi melwitt, lyarwood: I'm +A ^^
15:06:07 gibi melwitt, lyarwood: I'm +A ^^
15:06:23 melwitt sweet thanks gibi
15:06:23 melwitt sweet thanks gibi
15:07:40 lyarwood ack thanks :)
15:07:40 lyarwood ack thanks :)
15:08:10 noonedeadpunk sean-k-mooney: well, today I learned, and pushed https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786258 to use templates. Better late, then never...
15:08:10 noonedeadpunk sean-k-mooney: well, today I learned, and pushed https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786258 to use templates. Better late, then never...
15:08:30 gibi lyarwood: btw, I went back to the libvirt detach patch series. I hope I can push some update today
15:08:30 gibi lyarwood: btw, I went back to the libvirt detach patch series. I hope I can push some update today
15:09:37 lyarwood gibi: oh cool, I've had my head downstream all day with internal escalations
15:09:37 lyarwood gibi: oh cool, I've had my head downstream all day with internal escalations
15:10:08 gibi lyarwood: sounds bad
15:10:08 gibi lyarwood: sounds bad
15:18:36 openstackgerrit Johannes Kulik proposed openstack/nova master: vmware: Handle empty list attributes on vSphere objects https://review.opendev.org/c/openstack/nova/+/786262
15:18:36 openstackgerrit Johannes Kulik proposed openstack/nova master: vmware: Handle empty list attributes on vSphere objects https://review.opendev.org/c/openstack/nova/+/786262
15:29:44 gibi woot http://lists.openstack.org/pipermail/openstack-announce/2021-April/002047.html
15:29:44 gibi woot http://lists.openstack.org/pipermail/openstack-announce/2021-April/002047.html
15:30:00 lyarwood \o/
16:32:16 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move instance power state check to _detach_with_retry https://review.opendev.org/c/openstack/nova/+/778918
16:32:16 openstackgerrit Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246
16:33:40 openstackgerrit Balazs Gibizer proposed openstack/nova master: Consolidate device detach error handling https://review.opendev.org/c/openstack/nova/+/778978
16:35:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move the guest.get_disk test to test_guest https://review.opendev.org/c/openstack/nova/+/777151
16:35:40 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable mypy on libvirt/guest.py https://review.opendev.org/c/openstack/nova/+/777155
16:36:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Follow up type hints for a634103 https://review.opendev.org/c/openstack/nova/+/777159
16:36:41 openstackgerrit Balazs Gibizer proposed openstack/nova master: libvirt: Remove dead error handling code https://review.opendev.org/c/openstack/nova/+/779704
16:54:32 openstackgerrit Merged openstack/nova master: docs: Document options for remaining nova-* commands https://review.opendev.org/c/openstack/nova/+/726195
16:54:32 openstackgerrit Merged openstack/nova master: docs: Document options for remaining nova-* commands https://review.opendev.org/c/openstack/nova/+/726195
16:55:12 openstackgerrit Merged openstack/nova master: docs: Populate "See Also" section with meaningful links https://review.opendev.org/c/openstack/nova/+/729917
16:55:12 openstackgerrit Merged openstack/nova master: docs: Populate "See Also" section with meaningful links https://review.opendev.org/c/openstack/nova/+/729917
16:56:30 sean-k-mooney noonedeadpunk: cool
16:56:30 sean-k-mooney noonedeadpunk: cool
16:56:51 sean-k-mooney noonedeadpunk: i think ooo was previously the only tool to make use of that but its a nice feature to have
16:56:51 sean-k-mooney noonedeadpunk: i think ooo was previously the only tool to make use of that but its a nice feature to have
17:43:59 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Remove dead code https://review.opendev.org/c/openstack/nova/+/786291
17:44:00 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Remove unused DB methods https://review.opendev.org/c/openstack/nova/+/786293
17:44:00 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.sqlalchemy.utils' https://review.opendev.org/c/openstack/nova/+/786292
17:44:01 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy https://review.opendev.org/c/openstack/nova/+/786295
17:44:01 openstackgerrit Stephen Finucane proposed openstack/nova master: test: Remove checks for SQLite < 3.7 https://review.opendev.org/c/openstack/nova/+/786294
17:44:01 openstackgerrit Stephen Finucane proposed openstack/nova master: test: Remove checks for SQLite < 3.7 https://review.opendev.org/c/openstack/nova/+/786294
17:44:02 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Fold in ForeignKey constraints https://review.opendev.org/c/openstack/nova/+/786297
17:44:02 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Fold in indexes https://review.opendev.org/c/openstack/nova/+/786296
17:44:03 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Copy docs from 'nova.db.*' to 'nova.db.sqlalchemy.*' https://review.opendev.org/c/openstack/nova/+/786299
17:44:03 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.base' module https://review.opendev.org/c/openstack/nova/+/786298
17:44:04 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Synchronize function signatures https://review.opendev.org/c/openstack/nova/+/786300
17:44:05 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Clean up migration code https://review.opendev.org/c/openstack/nova/+/786301
19:36:13 noonedeadpunk sean-k-mooney: we really want to follow best practises but not always have time for reading all renos for all releases :( So eventually missing cool things :(
19:36:13 noonedeadpunk sean-k-mooney: we really want to follow best practises but not always have time for reading all renos for all releases :( So eventually missing cool things :(
19:42:37 noonedeadpunk oh, wait. Isn't cell name not unique now?
19:42:37 noonedeadpunk oh, wait. Isn't cell name not unique now?
19:43:29 noonedeadpunk http://paste.openstack.org/show/804488/ <- Is it expected?
19:43:29 noonedeadpunk http://paste.openstack.org/show/804488/ <- Is it expected?
19:44:11 noonedeadpunk this happens only with the template by the way
19:44:11 noonedeadpunk this happens only with the template by the way
19:47:54 noonedeadpunk this condition feels wrong for the template https://opendev.org/openstack/nova/src/branch/master/nova/cmd/manage.py#L623-L624
19:47:54 noonedeadpunk this condition feels wrong for the template https://opendev.org/openstack/nova/src/branch/master/nova/cmd/manage.py#L623-L624
19:50:13 noonedeadpunk because `cell.database_connection` and `cell.transport_url` are always resolved while checked, and `database_connection` with `transport_url` are shown as template...
19:50:13 noonedeadpunk because `cell.database_connection` and `cell.transport_url` are always resolved while checked, and `database_connection` with `transport_url` are shown as template...
19:56:56 noonedeadpunk wrote down https://bugs.launchpad.net/nova/+bug/1923899 - will try to check what can be done there tomorrow, unless there already be a suggestions
19:56:56 noonedeadpunk wrote down https://bugs.launchpad.net/nova/+bug/1923899 - will try to check what can be done there tomorrow, unless there already be a suggestions
19:56:57 openstack Launchpad bug 1923899 in OpenStack Compute (nova) "Nova create duplicate cells when templates are used" [Undecided,New]
20:05:08 openstackgerrit Merged openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786059
20:05:08 openstackgerrit Merged openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786059
20:13:48 noonedeadpunk It feels like template conversion is processed somewhere in models, as eventually here it's already converted from template to url https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L258
20:13:48 noonedeadpunk It feels like template conversion is processed somewhere in models, as eventually here it's already converted from template to url https://opendev.org/openstack/nova/src/branch/master/nova/objects/cell_mapping.py#L258

Earlier   Later