Earlier  
Posted Nick Remark
#openstack-nova - 2021-03-03
21:38:14 openstackgerrit Merged openstack/nova master: hyper-v rbd volume support https://review.opendev.org/c/openstack/nova/+/763550
#openstack-nova - 2021-03-04
02:51:09 openstackgerrit YuehuiLei proposed openstack/nova-specs master: Add xena directory for specs https://review.opendev.org/c/openstack/nova-specs/+/778604
03:23:19 openstackgerrit Brin Zhang proposed openstack/nova master: Add missed accel_uuids for _poll_shelved_instances https://review.opendev.org/c/openstack/nova/+/778440
07:41:14 openstackgerrit Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362
07:41:15 openstackgerrit Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944
08:31:17 yonglihe gibi: hope you have some bandwidth..
09:20:17 bauzas lyarwood: morning
09:20:48 openstack Launchpad bug 1820007 in os-brick "Failed to attach encrypted volumes after detach: volume device not found at /dev/disk/by-id" [Undecided,Fix released] - Assigned to Lee Yarwood (lyarwood)
09:21:27 bauzas I'll recheck my change, but given the bug was fixed, I wonder whether it was related
09:33:14 lyarwood morning
09:34:58 gibi morning folks
09:35:13 gibi stephenfin: do we need https://review.opendev.org/c/openstack/nova/+/765798 for the hypervisor api bp?
09:36:02 stephenfin I think it's a nice-to-have rather than a necessity. gmann did say yesterday that he was going to take over that patch though,
09:37:00 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP: nova-next: Start testing the 'q35' machine type https://review.opendev.org/c/openstack/nova/+/708701
09:37:20 lyarwood weird, just had `error: remote unpack failed: error Missing blob 08f698bbe36d414eca19d0760a5acc3a714c404e` errors trying to push that ^
09:37:34 lyarwood appears the git gc actually did something for a change and it's fixed after a git fetch -va
09:37:48 lyarwood bauzas: looking at that issue now sorry
09:38:11 bauzas lyarwood: no worries at all, rechecked meanwhile
09:38:20 bauzas just an open question
09:38:37 bauzas and I thought you could be interested in since you worked on the fix
09:41:17 lyarwood bauzas: yeah this is slightly different
09:41:19 lyarwood 43684 Mar 03 20:53:14.002343 ubuntu-focal-limestone-regionone-0023285105 nova-compute[53948]: ERROR oslo_messaging.rpc.server libvirt.libvirtError: internal error: unable to execute QEMU command 'blockdev-add': Could not open '/dev/disk/by-id/scsi-360000000000000000e00000 000010001': Operation not permitted
09:41:30 lyarwood we find the device but can't attach it
09:42:39 lyarwood weird, we even encrypt it
09:42:58 lyarwood ah but through /dev/sda
09:43:03 lyarwood I hope that's the same device
09:43:28 gibi stephenfin: ack, then I will not push hard on that policy patch
09:46:27 bauzas lyarwood: that looks to me a race finding the device, right?
09:50:14 lyarwood bauzas: no we've found the device fine, /dev/disk/by-id/scsi-360000000000000000e00000000010001 is connected correctly and we even format/encrypt it with LUKSv1
09:50:29 lyarwood bauzas: QEMU just isn't happy with the passphrase we've provided AFAICT
09:50:34 bauzas ah
09:50:46 lyarwood bauzas: the only odd thing is that we format/encrypt /dev/sda
09:51:37 lyarwood https://github.com/openstack/os-brick/blame/bd629a3a4105f7f3f9f35b71350ea3c66f3690e9/os_brick/encryptors/cryptsetup.py#L80-L81 and https://github.com/openstack/os-brick/blob/bd629a3a4105f7f3f9f35b71350ea3c66f3690e9/os_brick/encryptors/luks.py#L97 cause that
09:51:47 lyarwood but I've never seen that be a problem before, it should be the same underlying block device
09:52:35 lyarwood unless theres some weirdness in the block layers and /dev/disk/by-id/scsi-360000000000000000e00000000010001 still doesn't look like it's encrypted by the time QEMU attempts to attach it
09:56:29 stephenfin gibi: lyarwood: bauzas: Finishing off the microversion to allow e.g. 'openstack server create --hostname $HOSTNAME ...'. Do we want to allow users to update the hostname?
09:56:56 bauzas stephenfin: spec ?
09:57:00 stephenfin I said in the spec that we would, but all that will change is what's stored on the metadata service unless someone re-runs e.g. cloud-init
09:57:03 stephenfin https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/configurable-instance-hostnames.html
09:57:24 stephenfin So I'm concerned it might be misleading
09:57:50 bauzas I missed that one or I'm old
09:58:04 stephenfin Well you are old...
09:58:13 stephenfin but I guess you just missed it :P
09:58:44 bauzas it's coming from the display name issue when users were dumb enough to think that ubuntu20.04 was a valid hostname ?
09:58:50 stephenfin yes
09:58:52 bauzas seriously
09:59:07 stephenfin well, sort of
09:59:26 stephenfin we said the idea of tying a display name and hostname together wasn't necessarily that clever
09:59:37 bauzas stephenfin: users can change their instance hostnames without asking nova, right?
09:59:59 bauzas it's just that nova metadata will give you one
10:00:03 bauzas but you can change it
10:00:19 stephenfin of course, but they'd have to disable cloud-init (or part thereof)
10:00:40 bauzas I'm pretty sure they don't need to do it
10:00:48 bauzas at least in 2013, this wasn't required
10:01:06 bauzas but now quantum, err neutron, does exist
10:02:56 bauzas but OK
10:03:26 bauzas stephenfin: let's assume the user wants to change their hostnames on the nova CLI, what's your concern ?
10:03:34 stephenfin I'm trying to find the relevant cloud-init docs. Best I've got is https://cloudinit.readthedocs.io/en/21.1/topics/instancedata.html but that's EC2-specific
10:03:52 stephenfin My concern is that AFAICT cloud-init only runs once when setting up the instance
10:04:26 stephenfin so providing a way to change the hostname in the metadata service could be misleading, since one would need a service to propagate that change to the instance and I don't know if such a service exists
10:04:44 bauzas stephenfin: https://cloudinit.readthedocs.io/en/latest/topics/modules.html#set-hostname
10:05:14 bauzas now I remember
10:05:30 bauzas man, I turned 40 but I forgot I reviewed this one
10:06:46 bauzas and now I see my vote on the change, I remember I approved it by fatigue
10:08:54 lyarwood bauzas: found it, there's another request to attach a volume that also ends up with that WWN somehow
10:09:14 bauzas lyarwood: hah
10:09:23 bauzas good catch, hence the conflict
10:10:09 bauzas stephenfin: so, IIRC, you can turn off the hostname management with cloud-init and set it thru any management tool like ansible or puppet
10:10:39 lyarwood yeah I'm not sure if this is an os-brick or cinder bug tbh
10:11:44 bauzas stephenfin: so, preserve_hostname be True in cloud.cfg and then you can play with /etc/hosts like you want
10:11:57 gibi stephenfin: on use case I can imagine for the changing of the hostname is that the instance is do managed by ansible, and the user changed the hostname with that and want to keep the nova view in sync with what is in the instance
10:12:19 bauzas gibi: yeah, honestly I feel bad with my review of the spec
10:12:46 bauzas I just feel I haven't properly reviewed it and eventually gave up with loosely approving it
10:12:56 bauzas because I see some operator concerns
10:14:06 lyarwood caused by us running multiple c-vol backends ><
10:14:06 lyarwood ah it's a cinder bug, noice.
10:14:15 lyarwood fun, I bet this has burnt us for years and no one has noticed
10:15:53 bauzas eeek, haven't seen the time flying and I need to dad taxi, shit.
10:16:22 bauzas my productivity would dramatically increase in 5 years once my both kids are in college.
10:16:46 bauzas (4 years actually)
10:20:03 stephenfin gibi: That's a fair point
10:20:07 stephenfin Aight, I'll do that so
10:26:28 openstack Launchpad bug 1917750 in Cinder "Running parallel iSCSI/LVM c-vol backends is causing random failures in CI" [Undecided,New]
10:26:28 lyarwood bauzas: FWIW https://bugs.launchpad.net/cinder/+bug/1917750
11:49:29 openstackgerrit Merged openstack/nova master: libvirt: parse alias out from device config https://review.opendev.org/c/openstack/nova/+/772384
11:52:21 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549
11:52:21 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove references to 'inst_type' https://review.opendev.org/c/openstack/nova/+/778548
11:52:22 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550
12:28:11 openstackgerrit Merged openstack/nova master: tests: Poison os.uname https://review.opendev.org/c/openstack/nova/+/775415
12:55:25 kashyap Can anyone give this the final ACK (already has a +2), and put it through, please? -- https://review.opendev.org/c/openstack/nova/+/774240
13:00:01 gibi stephenfin ^^ please?
13:00:59 stephenfin yup, will look shortly
13:01:02 gibi thnks
13:08:47 openstackgerrit Merged openstack/nova stable/ussuri: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/773932
13:28:03 openstackgerrit Takashi Kajinami proposed openstack/nova master: WIP: Clean up allocations left by evacuation https://review.opendev.org/c/openstack/nova/+/778696
13:36:05 openstackgerrit Takashi Kajinami proposed openstack/nova master: WIP: Clean up allocations left by evacuation https://review.opendev.org/c/openstack/nova/+/778696
14:12:35 gmann stephenfin: yeah, was busy yesterday but I am going to update that today.
14:39:41 bauzas gibi: thanks for the +2 on RPC API, tbc I did put a -2 on my own change as I think we should only merge it after FF next week
14:40:01 bauzas gibi: I guess you don't have yet a RC1 etherpad ?
14:41:11 bauzas stephenfin: dansmith: although I marked -2 on https://review.opendev.org/c/openstack/nova/+/761452 I'd appreciate a second core review for making sure we can land it when we want

Earlier   Later