Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-02-17
09:30:14 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Record the machine_type of instances in system_metadata https://review.opendev.org/c/openstack/nova/+/767533
09:30:15 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type get command https://review.opendev.org/c/openstack/nova/+/769548
09:30:16 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type update command https://review.opendev.org/c/openstack/nova/+/774896
09:30:17 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP nova-manage: Add machine_type list_unset command https://review.opendev.org/c/openstack/nova/+/774897
09:30:18 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643
09:30:19 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898
09:30:20 openstackgerrit Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899
09:46:32 swp20 sean-k-mooney: morning, i have linked irc log in the NOVNC patch, please check https://review.opendev.org/c/openstack/nova/+/622336
10:03:43 openstackgerrit Belmiro Moreira proposed openstack/nova master: Change API unexpected exception message https://review.opendev.org/c/openstack/nova/+/628061
10:30:34 bauzas stupid question : given the tox-lower-constraints job failed on https://review.opendev.org/c/openstack/nova/+/773976/6, I guess I can try to reproduce it locally by using the same tox target?
10:50:39 lyarwood bauzas: yes
10:50:51 bauzas it loosely fails
10:51:16 bauzas weirdo
10:51:28 bauzas asked for a recheck b/c I don't understand it a single shit
10:51:50 lyarwood you might need to hardcode the basepython version if you're on Fedora FWIW
10:51:59 lyarwood otherwise it's going to try to use py39
10:52:12 lyarwood that's likely going to break random stuff in that env
10:53:01 lyarwood tbh I assume your issue is with mock==3.0.0
10:53:08 bauzas yup
10:53:30 lyarwood try mock.Mock(spec=client.Client)?
10:53:50 lyarwood but yeah I don't get how auto_spec wouldn't work
10:54:07 lyarwood create_autospec* even
10:54:51 bauzas will try, need to lunch
10:54:54 bauzas lyarwood: thanks
10:55:54 bauzas lyarwood: the fun is that I wrote tests for both segments and networks, and they're both using autospec
10:56:18 bauzas but it only fails for networks, not subnets
10:56:26 bauzas so it looks to me unrelated
11:11:58 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Mock the os-brick connector within base.ServersTestBase https://review.opendev.org/c/openstack/nova/+/728914
11:26:48 openstackgerrit Lee Yarwood proposed openstack/nova master: tox: Add passenv DISABLE_CHERRY_PICK_CHECK to pep8 https://review.opendev.org/c/openstack/nova/+/776111
11:27:33 lyarwood elod: ^ thanks btw, I think we were calling the script directly downstream somewhere so I didn't even think about the tox target
11:47:12 elod lyarwood: oh, i see, np :)
12:32:50 gibi bauzas: went through the routed net series. I have some comments inline but you can convince me to handle those as follow ups
12:33:40 gibi bauzas: at the same time I would like to ask you to look at the last relevant QoS inteface attach patch https://review.opendev.org/c/openstack/nova/+/756530
14:04:13 stephenfin If anyone has some spare review time, https://review.opendev.org/q/topic:%2522poison-os-uname%2522+status:open are easy test improvement patches and getting them merged will help me avoid rebasing them endlessly as I work on the secure boot patches :-D
14:12:56 lyarwood stephenfin: ack
14:13:12 lyarwood sean-k-mooney: https://github.com/cirros-dev/cirros/issues/64 FYI, got it to work finally
14:14:47 sean-k-mooney hum https://github.com/lyarwood/cirros/commit/034d2e2e3719d96c4ef14ea859af72d7b5db311f
14:14:52 sean-k-mooney that really should not be needed
14:15:02 sean-k-mooney it shoudl have been automatically loaded
14:15:14 lyarwood it isn't even present in the image
14:15:15 sean-k-mooney but if it fixes it i gues thats ok
14:15:19 lyarwood that's the problem
14:15:28 lyarwood that list is copied in and everything else is dropped
14:15:34 lyarwood I guess that's what keeps the image so small
14:15:43 sean-k-mooney oh they are usign it for that too
14:15:48 sean-k-mooney i see
14:16:03 sean-k-mooney so the fact we can boot at all implies its in the initramfs
14:16:10 lyarwood yeah indeed
14:16:15 sean-k-mooney but its not in the root filesystem
14:16:19 lyarwood I couldn't work out where it was being pulled in tbh
14:16:33 lyarwood likely from a prebuilt initramfs from Ubuntu or something?
14:16:40 sean-k-mooney ya proably
14:17:01 sean-k-mooney cool hopefully that can get merged soon ish
14:17:15 sean-k-mooney you might want to flag this on #openstack-qa
14:17:28 sean-k-mooney i belive one of the people that maintain cirros is on that channel
14:18:46 lyarwood yeah I can do later today
14:18:48 sean-k-mooney lyarwood: if you are taking to them then it would be ice to fix https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856387
14:18:50 openstack Launchpad bug 1856387 in linux (Ubuntu Bionic) "Freezing on boot since kernel 4.15.0-72-generic release" [High,Fix released] - Assigned to You-Sheng Yang (vicamo)
14:19:07 sean-k-mooney the current currenle they use is missing the backport
14:19:21 sean-k-mooney *current kernel
14:20:35 sean-k-mooney i tried to fix this in devstack https://review.opendev.org/c/openstack/devstack/+/766079 and nova https://review.opendev.org/q/topic:%22workaround-disable-apic%22+(status:open%20OR%20status:merged)
14:20:43 sean-k-mooney but was told it would be fixed in cirros
14:20:57 sean-k-mooney so it woudl be good to confirm that is fixed.
14:21:11 sean-k-mooney if they are rebuilding the image
14:23:26 lyarwood kk
14:30:44 frickler lyarwood: sean-k-mooney: best discuss in #cirros with smoser directly
14:33:03 sean-k-mooney frickler: ack, wasnt sure who was maintianing it
14:48:38 stephenfin bauzas: Reviewed the routed networks series again
15:22:14 openstackgerrit Merged openstack/nova master: Run nova-live-migration job with neutron-trunk enabled https://review.opendev.org/c/openstack/nova/+/775838
15:44:25 openstackgerrit Merged openstack/nova master: use psycopg2 binary instead of source package https://review.opendev.org/c/openstack/nova/+/770473
15:45:14 openstackgerrit Merged openstack/nova stable/ussuri: Add upgrade check about old computes https://review.opendev.org/c/openstack/nova/+/770765
15:45:37 openstackgerrit Merged openstack/nova stable/ussuri: add functional regression test for bug #1888395 https://review.opendev.org/c/openstack/nova/+/759522
15:45:39 openstack bug 1888395 in OpenStack Compute (nova) ussuri "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to Billy Olsen (billy-olsen)
15:45:52 openstackgerrit Merged openstack/nova stable/ussuri: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/c/openstack/nova/+/759151
15:46:20 openstackgerrit Merged openstack/nova master: tox: Add passenv DISABLE_CHERRY_PICK_CHECK to pep8 https://review.opendev.org/c/openstack/nova/+/776111
15:50:38 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766023
15:51:59 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766024
15:52:52 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766025
16:31:04 openstackgerrit Merged openstack/nova stable/victoria: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772984
16:59:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: libvirt: Define and emit DeviceRemovedEvent and DeviceRemovalFailedEvent https://review.opendev.org/c/openstack/nova/+/749929
17:22:36 openstackgerrit Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084
17:33:30 bauzas gibi: thanks for the review
17:34:55 bauzas stephenfin: ack, will try to provide a new revision again
17:46:28 bauzas stephenfin: wdym by "trailing full stop" https://review.opendev.org/c/openstack/nova/+/773976/6/nova/network/neutron.py@3500 ?
17:46:47 stephenfin just add a full stop at the end of the sentence :)
17:46:54 stephenfin you had it elsewhere
17:47:17 bauzas a dot ?
17:47:19 bauzas OK, can do
17:47:23 stephenfin oh, a period
17:47:27 stephenfin British English
17:47:31 stephenfin yeah
17:47:33 bauzas oh maaaaaan
17:47:52 bauzas artom: how quebecian folks name the end of a phrase ? "un point", right?
17:49:07 sean-k-mooney or a "full stop"
17:49:39 sean-k-mooney oh that what you said first
17:50:00 sean-k-mooney bauzas: why is frech frech so differnt for canadian french
17:50:45 sean-k-mooney also stephenfin and i technically speak https://en.wikipedia.org/wiki/Hiberno-English more of the time
17:50:54 bauzas sean-k-mooney: we name it the same AFAIK :p it's "un point"
17:51:25 sean-k-mooney well a decimal point and period/full stop are two different things
17:52:09 bauzas sean-k-mooney: b/c you folks are enough crazy to use a dot for decimal numbers

Earlier   Later