| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-05 | |||
| 20:24:22 | dansmith | so... thanks :) | |
| #openstack-nova - 2021-02-06 | |||
| 00:16:48 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | |
| 00:16:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | |
| 00:16:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: extra specs/image pros: add `socket` PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | |
| 00:16:50 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the `socket` NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | |
| 00:16:50 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Track host NUMA topology in PCI manager https://review.opendev.org/c/openstack/nova/+/774149 | |
| 01:09:45 | openstackgerrit | Merged openstack/nova master: docs: Move the LibvirtDistroSupportMatrix wiki page into our docs https://review.opendev.org/c/openstack/nova/+/771981 | |
| 01:10:17 | openstackgerrit | Merged openstack/nova master: glance: Remove [glance]/allowed_direct_url_schemes https://review.opendev.org/c/openstack/nova/+/772874 | |
| 06:20:21 | openstackgerrit | Merged openstack/nova master: db: Compact Liberty database migrations https://review.opendev.org/c/openstack/nova/+/758397 | |
| 16:38:17 | openstackgerrit | Merged openstack/nova master: db: Compact Mitaka database migrations https://review.opendev.org/c/openstack/nova/+/758398 | |
| #openstack-nova - 2021-02-07 | |||
| 02:49:12 | openstackgerrit | Wenping Song proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | |
| 02:49:12 | openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | |
| 06:37:06 | openstackgerrit | Merged openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720 | |
| 12:02:35 | openstackgerrit | Merged openstack/nova master: db: Compact Newton database migrations https://review.opendev.org/c/openstack/nova/+/759085 | |
| #openstack-nova - 2021-02-08 | |||
| 00:32:04 | openstackgerrit | Merged openstack/nova master: db: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759086 | |
| 01:47:05 | swp20 | sean-k-mooney: hi, about the noVNC patch, i think the case in https://review.opendev.org/c/openstack/nova/+/622336/30/nova/tests/unit/api/openstack/compute/test_remote_consoles.py#375 covers what you said. | |
| 03:37:49 | openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | |
| 09:38:30 | gibi | lyarwood: Hi! What are the patches we need to merge before we can drop one of th grenade job as in https://review.opendev.org/c/openstack/tempest/+/771499 ? | |
| 09:41:23 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/742056 - I think you're confusing this with that moves the job over to zuulv3 | |
| 09:41:33 | lyarwood | gibi: I think we can drop the standalone job ahead of that | |
| 09:41:53 | lyarwood | gibi: but should still try to push the move to zuulv3 along this cycle | |
| 09:55:51 | gibi | lyarwood: do you mean that we could merge https://review.opendev.org/c/openstack/tempest/+/771499 now without any dependency? | |
| 09:56:09 | stephenfin | dansmith: I'm seeing multiple networks found quite often also. I've tried figuring out how to fix that but my Google-fu is failing me :-\ | |
| 09:56:53 | gibi | stephenfin: I think ther is an open tempest patch for that ^^ let me find it | |
| 09:57:38 | lyarwood | yeah that should be listed on status.openstack.org iirc | |
| 09:58:35 | lyarwood | gibi: I believe so yes, the switch to zuulv3 is seperate AFAICT | |
| 09:58:57 | gibi | stephenfin: https://review.opendev.org/c/openstack/tempest/+/770169 | |
| 09:59:13 | lyarwood | stephenfin: http://status.openstack.org/elastic-recheck/#1844568 | |
| 09:59:17 | gibi | lyarwood: cool, please not that on Dan's patch | |
| 10:00:24 | lyarwood | gibi: hmm I see dansmith's note in the change, he might have reasons for waiting until we've completed the switch | |
| 10:00:49 | lyarwood | gibi: let me sync with him later today, I've likley missing some context on Friday while I was out | |
| 10:01:04 | gibi | lyarwood: cool thanks | |
| 10:05:55 | gibi | gmann: Is there anything I can help with https://review.opendev.org/c/openstack/tempest/+/770169 ? | |
| 10:15:31 | openstackgerrit | Johannes Kulik proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/c/openstack/nova/+/699176 | |
| 10:28:17 | kashyap | gibi: This review you of CPU flags (which we'll discuss in the meeting this evening) has a couple of bugs, I'm fixing it as we speak | |
| 10:28:23 | kashyap | [https://review.opendev.org/c/openstack/nova/+/774240] | |
| 10:29:10 | kashyap | It should use lstrip() instead of index slicing; and I'm using the wrong libvirt class in libvirt/driver.py. /me goes to fiddle [after a call] | |
| 10:29:46 | gibi | kashyap: OK. which meeting this evening do you refer to ? | |
| 10:30:22 | kashyap | gibi: Err, is there Nova meeting tonight, or am I dreaming? | |
| 10:30:42 | gibi | nova meetings are every thursday | |
| 10:30:56 | kashyap | Err, right; thx | |
| 11:46:03 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240 | |
| 12:10:45 | gibi | bauzas: left feedback on your the routed net series | |
| 12:18:55 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240 | |
| 12:20:11 | kashyap | gibi: Hey, --^ fixed the problems in the above; and it works as intended | |
| 12:25:22 | kashyap | Note to self: missing doc update; and a rel note | |
| 12:29:49 | gibi | kashyap: ack, will check back | |
| 12:46:04 | bauzas | gibi: ack, will look | |
| 13:26:48 | sean-k-mooney | lyarwood: by the way you can proably drop the WIP on you machine_type patch in the next revision | |
| 13:27:15 | sean-k-mooney | ill try an review it when its up but feel free to ping me if i dont | |
| 13:28:18 | lyarwood | sean-k-mooney: yup planning to, just sorting some tests out and writing docs | |
| 13:28:57 | lyarwood | sean-k-mooney: thanks again for the review btw | |
| 13:29:36 | gibi | kashyap: I've left feedback in https://review.opendev.org/c/openstack/nova/+/774240 | |
| 13:29:47 | kashyap | gibi: Thanks; will look | |
| 13:38:28 | bauzas | gibi: shit about the 2 NICs... | |
| 13:38:34 | bauzas | :( | |
| 13:39:01 | bauzas | gibi: unfortunately, we need to express ONE Requestspec for both | |
| 13:39:26 | bauzas | context : https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py | |
| 13:40:41 | bauzas | but we need to express aggregates requirement something like "(agg1 or agg2) AND agg3" in the same spec | |
| 13:41:51 | bauzas | so, like you said, by calling require_aggs() multiple ways | |
| 13:46:27 | gibi | bauzas: I think we have ONE request spec but we have a list of network requests | |
| 13:47:24 | gibi | and the input in the network request list | |
| 13:47:56 | gibi | and the output is in the Destination | |
| 13:48:13 | gibi | maybe we just need to move the require_aggregate into the for loop | |
| 13:48:24 | gibi | instead of having it after the for loop | |
| 13:58:55 | sean-k-mooney | stephenfin: by the way just notice the cell db still has plamcnet related tables in it | |
| 13:59:03 | sean-k-mooney | we dont support that any more right | |
| 13:59:19 | sean-k-mooney | is that something we should clean up in or after your current db series ? | |
| 14:00:00 | sean-k-mooney | im thinking a nova manage command to drop them from the cell db and remove them form the compacted schema ? | |
| 14:03:33 | bauzas | gibi: indeed, I'll add a func test and verifying it | |
| 14:03:57 | gibi | coolio | |
| 14:06:55 | bauzas | https://www.youtube.com/watch?v=fPO76Jlnz6c | |
| 14:07:58 | kashyap | gibi: Heya, so here: https://review.opendev.org/c/openstack/nova/+/774240/3/nova/virt/libvirt/driver.py#4608 | |
| 14:08:26 | kashyap | gibi: I'm testing both the enabling and disabling part in the test. Would you like me to test something further? | |
| 14:09:17 | gibi | I think the codeblock starging at L698 is not covered while the code blocks starting at L4599 is covered | |
| 14:10:14 | kashyap | gibi: Oh, the one in this method _check_cpu_compatibility() | |
| 14:10:19 | kashyap | gibi: Okay, will figure something out ... | |
| 14:10:32 | kashyap | gibi: I'll respond to the rest on the change; thanks | |
| 14:10:33 | gibi | yes | |
| 14:10:35 | gibi | thanks | |
| 14:11:17 | kashyap | gibi: Good catch | |
| 14:23:13 | stephenfin | sean-k-mooney: Yeah, I have a patch somewhere to clean those up | |
| 14:23:27 | stephenfin | But I think it can/should wait til alembic is in place | |
| 14:34:58 | bauzas | gibi: 2 secs for a quick question ? | |
| 14:35:05 | gibi | bauzas: sure | |
| 14:35:13 | bauzas | gibi: in your example https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#329 | |
| 14:35:22 | bauzas | gibi: you mention 'agg1 or agg2 AND agg3' | |
| 14:35:33 | bauzas | (the and is priority over the or) | |
| 14:35:46 | bauzas | so, we would get NoValidHosts for your example, right? | |
| 14:36:20 | gibi | if there is no host that is in both agg2 and agg3 or agg1 and agg3 then yes it is a no valid host | |
| 14:36:29 | gibi | but a host can be in multiple aggregated | |
| 14:36:32 | gibi | -d | |
| 14:36:44 | bauzas | ok, b/c my functest only has one host per agg | |
| 14:37:00 | bauzas | but I can try to do something | |
| 14:37:20 | bauzas | like, adding host5 that's in both aggregates | |
| 14:37:24 | bauzas | lemme try about it | |
| 14:38:56 | gibi | ok | |
| 14:54:58 | sean-k-mooney | stephenfin: sorry was on a call that sounds fine by me | |
| 14:55:28 | sean-k-mooney | stephenfin: i was just inspecting some data in the db for one of my changes and found it odd that those tabels were still there | |
| 15:00:29 | bauzas | I'm absolutely puzzled | |