Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-06
15:06:40 gibi stephenfin: new you are the closest to grab the microversion 2.88
15:07:15 gibi sean-k-mooney: that is actually a good argument for a separate service as they want independent lifetime
15:07:16 stephenfin gibi: Yup. I'm going to ask gmann to take a look at that later, assuming he's back from his PTO
15:07:23 gibi stephenfin: cool
15:59:57 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/c/openstack/nova/+/673790
16:11:42 dansmith lyarwood: I was just about to +2 that machine type sysmeta spec rev, but saw that stephenfin already did.. I have annoying unrelated questions, one of which might be an accidental state omission
16:12:04 dansmith lyarwood: if it 's cool, I'll just +2 and let you quickly look if you want to throw the other state in there to avoid a rev-to-the-rev,
16:12:19 dansmith and I can just +W if I'm wrong or you want it separate
16:16:11 lyarwood dansmith: just on a call now, happy to answer your questions before this lands. I'll take a look once this is over.
16:16:28 dansmith lyarwood: ack
17:22:56 lyarwood dansmith: replied, need to drop for dinner but I'll respin this evening.
17:23:02 dansmith ack
17:30:13 gmann stephenfin: ack, I will review today.
17:47:30 stephenfin gmann: thanks
18:58:14 openstackgerrit sean mooney proposed openstack/nova master: [WIP] test numa and vcpu topologies https://review.opendev.org/c/openstack/nova/+/769601
18:58:23 sean-k-mooney melwitt:^
18:59:34 melwitt thanks
19:00:17 sean-k-mooney i wonder is there an easy way to print the xml that would be created
19:20:16 sean-k-mooney ah i can use OS_DEBUG=1 and add assert False
19:20:23 sean-k-mooney and it then dumps all the logs
19:22:54 sean-k-mooney http://paste.openstack.org/show/801461/
19:24:12 sean-k-mooney the numa toplogy is correct but the cpu toplogy is not
19:24:14 sean-k-mooney <topology sockets="8" cores="1" threads="1"/>
19:24:35 melwitt a-ha, cool (about the logs)
19:24:56 sean-k-mooney that was the xml for https://review.opendev.org/c/openstack/nova/+/769601/1/nova/tests/functional/libvirt/test_numa_servers.py#158
19:25:06 melwitt ack
19:25:30 sean-k-mooney oh my extra specs are wrong
19:25:47 sean-k-mooney wiat did i copy those form the customer
19:26:11 sean-k-mooney no they have the correct ones im missing cpu_
19:28:37 sean-k-mooney ok i repoduced it now
19:28:58 sean-k-mooney http://paste.openstack.org/show/801463/
19:29:00 melwitt omg !
19:29:02 sean-k-mooney that is the error
19:29:30 melwitt yes, looks like you've got it. sweet
19:30:39 melwitt yeah there's the IndexError which is a separate thing but once that is fixed it will still be an erroneous failure to schedule. need to open I guess two bugs, one for the IndexError and one for the scheduling fail
19:31:57 openstackgerrit sean mooney proposed openstack/nova master: [WIP] test numa and vcpu topologies https://review.opendev.org/c/openstack/nova/+/769601
19:32:17 sean-k-mooney the index error i think is jsut use trying to get the first entry in the list of toplogies
19:32:28 sean-k-mooney but its empty so that is simple to fix
19:32:29 melwitt correct
19:33:44 sean-k-mooney actully just lookking a littel more up in the logs http://paste.openstack.org/show/801464/
19:33:51 sean-k-mooney we have the limits printed
19:34:05 sean-k-mooney so it has the flaovr limits there Flavor limits 2:2:8
19:34:10 melwitt yeah. that is showing on the customer case too
19:34:38 sean-k-mooney ya so the issue is the preference of 0,0,0
19:35:11 melwitt yeah but we use 0 (on master) and -1 (on queens) to mean "no preference"
19:35:35 sean-k-mooney yep so we need to adjust that logic slightly
19:35:47 sean-k-mooney so that the closet match code works
19:41:57 melwitt sean-k-mooney: did you want to work on the fix? or did you want me to stack a change on top of your test?
19:43:17 sean-k-mooney im testing a quick hack but sofar its not working so if you want to stack a change on top go for it
19:43:44 sean-k-mooney that is what im trying currrntly but the two things i have tired so far have no effect :)
19:44:29 melwitt oh heh. well it's up to you
19:46:15 sean-k-mooney oh its becasue its using the numa toplogy object i think
19:46:19 openstackgerrit Merged openstack/nova master: tests: Remove 'test_extended_hypervisors' https://review.opendev.org/c/openstack/nova/+/769519
19:46:28 sean-k-mooney ill give it one more try then im going for dinner and its all yours
19:48:06 melwitt hehe, k. well it was your idea on how to fix it :) so if you want to stick with it that wfm. if not, I can give it a try
19:51:19 openstackgerrit sean mooney proposed openstack/nova master: [WIP] fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/769614
19:51:34 sean-k-mooney this is probaly not right but it passes the new test i added
19:52:08 melwitt ack
19:52:29 sean-k-mooney the vcpu toplogy cannot cahnge per numa node
19:52:44 sean-k-mooney so i dont actully think we shoul dbe looking at the numa node there
19:53:23 sean-k-mooney hum i just ran all the libvirt func tests and they passed
19:53:30 sean-k-mooney im running the full set now
20:00:58 sean-k-mooney :( i hit the subunit parser bug....
20:01:00 sean-k-mooney File "/opt/repos/nova/.tox/functional/lib/python3.8/site-packages/subunit/v2.py", line 227, in _write_packet
20:01:02 sean-k-mooney raise ValueError("Length too long: %r" % base_length)
20:01:04 sean-k-mooney ValueError: Length too long: 5072548
20:01:39 sean-k-mooney there are dissadvatages to OS_DEBUG=1
20:03:31 sean-k-mooney ok im going to have dinner and we can see what the ci says but i thinnk that working acourdign to to the func tests that have run but i think i have disabled too much
20:07:31 sean-k-mooney melwitt: wem might actully be able to just remove https://github.com/openstack/nova/blob/ccb2e11129d4a0730b0ba19a7f49ed8fc5a05f6d/nova/virt/hardware.py#L616-L637
20:07:49 sean-k-mooney it was added by https://github.com/openstack/nova/commit/770ab8eeb72b184ac6164aeabb89c4bf45f938a9
20:07:59 sean-k-mooney but in not conviced the resoning is correct
20:08:40 melwitt hm ok
20:09:50 sean-k-mooney the guest vcpu toplogy is indepenet of its numa toplogy
20:10:26 sean-k-mooney this patch was trying to support different guest vcpu toplogies per numa node which we have never supported
20:11:22 sean-k-mooney at least looking at https://github.com/openstack/nova/commit/770ab8eeb72b184ac6164aeabb89c4bf45f938a9#diff-027adff210e1ed4c63524a486cb988702337880b5c0773482200a136e391ecfbR773
20:16:15 sean-k-mooney it looks like we still have some of those unit tests https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_hardware.py#L792-L881
20:17:29 sean-k-mooney the last one is definetly not requesatable via the api
20:17:30 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_hardware.py#L858-L883
20:17:59 sean-k-mooney oh my func test run passed locally too.
20:18:08 sean-k-mooney ok really getting dinner now o/
20:53:02 openstackgerrit Lance Bragstad proposed openstack/placement master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/placement/+/760229
22:15:06 gmann stephenfin: done, left comment for https://review.opendev.org/c/openstack/nova/+/769520/1/nova/api/openstack/compute/hypervisors.py#363
22:15:24 gmann stephenfin: and other two patches of this BP also
#openstack-nova - 2021-01-07
04:46:27 openstackgerrit Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785
04:46:28 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240
07:16:08 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675
07:21:27 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675
08:50:37 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in flavor-access commands https://review.opendev.org/c/openstack/python-novaclient/+/769019
09:44:48 Yumeng hi gibi
09:45:37 gibi Yumeng: hi
09:46:00 Yumeng welcome back from holiday^^ how was it?
09:51:15 Yumeng gibi: Can you check my response here? https://review.opendev.org/c/openstack/nova-specs/+/750116/14/specs/wallaby/approved/support-vGPU-nova-cyborg-interaction.rst#225
09:54:04 gibi Yumeng: thanks. The time off was good.
09:54:27 gibi I will try to check back to that spec
09:54:34 Yumeng gibi: sounds nice!
09:54:40 Yumeng thanks!
09:55:08 gibi Yumeng: did you have some time of during this period or you will be off for the chinees new year instead?
09:56:13 Yumeng This year's Chinees new year holiday starts from Feb 11, so we still have time ^^
09:57:44 gibi OK
09:59:37 Yumeng gibi: but there will be some change in cyborg team this month. I will changed my company and work priority since Jan 18. So I'm going to step down from the PTL position and Xinran Wang will take over the PTL duty.

Earlier   Later