| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-10-06 | |||
| 09:51:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'InstanceNUMACell.min_threads' https://review.opendev.org/756070 | |
| 09:51:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Check inventory of shared CPUs for 'mixed' policy https://review.opendev.org/756101 | |
| 09:52:56 | gibi | bauzas: there is a 3rd place https://docs.openstack.org/api-guide/compute/port_with_resource_request.html | |
| 09:53:19 | lyarwood | tok~. | |
| 09:53:25 | bauzas | gibi: ah thanks, I remembered we documented it somewhere but I forgot about it | |
| 09:53:29 | lyarwood | argh weechat-- | |
| 09:54:12 | bauzas | lyarwood: what kind of tiktok video were you about to upload ? | |
| 09:54:15 | lyarwood | tosky: https://review.opendev.org/#/c/755270/10/roles/sync-ceph-conf-and-keys/tasks/main.yaml - could use your advice on this change btw, my ansible foo is failing me here. I'm trying to copy files from a deployed controller to a subnode. | |
| 09:54:56 | lyarwood | bauzas: ^ was trying to ask that question and weechat/screen/ssh borked | |
| 09:55:58 | bauzas | ;-) | |
| 09:58:55 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Reproposes Offline Reshape tool spec https://review.opendev.org/742908 | |
| 10:09:03 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Re-proposes Routed Networks https://review.opendev.org/756242 | |
| 10:09:51 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Offline Reshape tool spec https://review.opendev.org/742908 | |
| 10:22:16 | sean-k-mooney | lyarwood: there is an example of this for the ssh keys | |
| 10:23:14 | sean-k-mooney | the copy-build-sshkey role | |
| 10:23:37 | lyarwood | sean-k-mooney: yeah I tried using that approach but wanted to only copy the generated keyrings, iirc that role copies a hardcoded list | |
| 10:25:25 | sean-k-mooney | its defiended here | |
| 10:26:05 | sean-k-mooney | the ssh key it copies is defiend by this var https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/copy-build-sshkey/vars/main.yaml#L1 | |
| 10:26:12 | sean-k-mooney | but you could write a similar role | |
| 10:26:17 | sean-k-mooney | for the ceph keys | |
| 10:26:41 | lyarwood | sean-k-mooney: did you not click through to the review? :) | |
| 10:26:45 | sean-k-mooney | this is all you need to do https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/copy-build-sshkey/tasks/main.yaml#L16-L34 | |
| 10:26:53 | sean-k-mooney | nope | |
| 10:27:23 | sean-k-mooney | i see | |
| 10:27:37 | sean-k-mooney | shoudl this not be in the ceph devstack plugin repo instead | |
| 10:27:39 | lyarwood | sean-k-mooney: I'm just failing at sharing the list of generated keyrings between the controller and compute, it's a basic ansible thing I'm failing on | |
| 10:28:09 | lyarwood | sean-k-mooney: zuul wasn't happy when I started with it in the plugin | |
| 10:28:19 | lyarwood | sean-k-mooney: so I'm leaving it here until it's working | |
| 10:28:31 | lyarwood | gah baby woke up, brb | |
| 10:29:57 | sean-k-mooney | lyarwood: ok well you could alos look at https://github.com/openstack/devstack/tree/master/roles/sync-devstack-data | |
| 10:30:17 | sean-k-mooney | that copies the tls certs for multinode setups beteween hosts | |
| 10:32:16 | sean-k-mooney | its using the synchronize role instead of fetch and copy | |
| 10:47:06 | lyarwood | sean-k-mooney: yeah also looked at that in previous PS's and got confused so I switched back. | |
| 10:47:25 | lyarwood | sean-k-mooney: my main issue is with how I should store and share the list of keyrings between the hosts | |
| 10:47:58 | lyarwood | sean-k-mooney: hmm do I set it as a fact against the controller and then look that up from the compute? | |
| 10:48:06 | sean-k-mooney | lyarwood: you proably just want to sync all of them to the zuul executor and then all of them to the subnodes | |
| 10:48:38 | lyarwood | sean-k-mooney: right but I don't think any of the copy/sync modules support wildcards do they? | |
| 10:48:39 | sean-k-mooney | so just copy all of them into a singel folder and copy all the files in the folder | |
| 10:49:37 | sean-k-mooney | so you basically want to do https://github.com/openstack/devstack/blob/master/roles/sync-devstack-data/tasks/main.yaml#L21-L30 but replace the with_items | |
| 10:49:38 | lyarwood | k I'll give that a go once my wife gets home and I can throw the baby at her | |
| 10:49:56 | lyarwood | sean-k-mooney: right but the hardcoded list was something I wanted to avoid | |
| 10:50:04 | sean-k-mooney | ya you can | |
| 10:50:17 | sean-k-mooney | you can register the files as a fact on the contoler | |
| 10:50:27 | sean-k-mooney | then use it on the contoler to sync it to the exectutor | |
| 10:50:32 | lyarwood | yup | |
| 10:50:44 | lyarwood | the part I was missing was that it wasn't a local fact on the compute | |
| 10:50:46 | sean-k-mooney | then do the same thing on the executor to push them | |
| 10:50:58 | lyarwood | ansible is weird sometimesd | |
| 10:51:15 | sean-k-mooney | well its sort as a host var | |
| 10:51:27 | sean-k-mooney | most facts are specific to the host they are created on | |
| 10:51:57 | sean-k-mooney | but the point is to pull the data from the contoler to the executor then push it form the executor to the compute nodes | |
| 10:52:12 | sean-k-mooney | you never need to run the sync on the computes | |
| 10:53:02 | sean-k-mooney | if you know the contolers name you can also just use that to get its fact | |
| 11:10:39 | openstackgerrit | Rajat Dhasmana proposed openstack/nova master: WIP: Add support of blockCommit when VM is down https://review.opendev.org/756261 | |
| 11:18:07 | tosky | lyarwood: I think sean-k-mooney already gave more information than I could have provided | |
| 11:24:13 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Set different VirtualDevice.key https://review.opendev.org/749415 | |
| 11:33:52 | lyarwood | tosky: ack thanks | |
| 11:41:37 | andrewbonney | Hi. We're hitting an issue with live migration after moving to Ussuri which I think may be down to nova not handling some output from libvirt. I've put some debug here if anyone could take a look: http://paste.openstack.org/show/798740/. I'd be happy to post that to launchpad if preferred | |
| 11:42:36 | lyarwood | bauzas / melwitt ; https://review.opendev.org/#/q/branch:%255Estable/.*+status:open+owner:%22Lee+Yarwood+%253Clyarwood%2540redhat.com%253E%22+label:Code-Review%253E%253D2 - btw my stable backlog is starting to build up if either of you have time this week | |
| 11:48:02 | gibi | andrewbonney: seems like a valid bug. Could you please file a bug report in launchpad for it https://bugs.launchpad.net/nova/+filebug | |
| 11:48:21 | andrewbonney | Will do, thanks | |
| 12:04:23 | bauzas | lyarwood: ack, will look | |
| 13:51:09 | lyarwood | bauzas: many thanks btw | |
| 13:52:35 | bauzas | lyarwood: np, took a bit to verify all the changes, but thanks for it | |
| 13:56:32 | lyarwood | fun we dump the devstack run from a controller into the job logs twice for multinode jobs at the moment | |
| 13:56:36 | lyarwood | 29871 2020-10-06 12:07:45.753810 | TASK [run-devstack : Run devstack] | |
| 13:56:39 | lyarwood | 29872 2020-10-06 11:42:53.973082 | controller | + unset GREP_OPTIONS | |
| 13:57:02 | lyarwood | ^ that's the compute run with logs from the previously already logged controller run | |
| 13:57:07 | lyarwood | /o\ | |
| 14:33:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support extending locally attached rbd volumes https://review.opendev.org/752069 | |
| 16:05:30 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547 | |
| 16:17:57 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP: nova-next: Start testing the 'q35' machine type https://review.opendev.org/708701 | |
| 18:14:56 | sean-k-mooney | melwitt: can you take a look at https://review.opendev.org/#/c/751642/6 or lyarwood if you are about its relitivly minor but i need it for the follow up patch | |
| 18:20:33 | dansmith | sean-k-mooney: your comment in driver.py is exactly why N->N+m is not just doable when rpc versions match :) | |
| 18:21:53 | sean-k-mooney | ah becasue we somethimes move things | |
| 18:22:03 | sean-k-mooney | without chainging rpc verions | |
| 18:22:18 | dansmith | you're doing it here, yeah | |
| 18:22:37 | sean-k-mooney | yep for what its worth im doing it for upgrade reasons | |
| 18:22:40 | dansmith | I'm not saying change it, because we do other stuff like it, I'm just pointing out this as an example | |
| 18:22:49 | sean-k-mooney | ya | |
| 18:23:03 | dansmith | just something to keep in mind the next time someone asks why :) | |
| 18:23:14 | sean-k-mooney | ah yep | |
| 18:26:52 | dansmith | sean-k-mooney: check my questions on that and tell me if I should be -1ing | |
| 18:28:57 | sean-k-mooney | looking now | |
| 18:32:38 | openstackgerrit | Merged openstack/nova stable/queens: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729178 | |
| 18:32:47 | openstackgerrit | Merged openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow https://review.opendev.org/749228 | |
| 18:32:54 | openstackgerrit | Merged openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/749229 | |
| 18:35:50 | sean-k-mooney | dansmith: you can -1 i am missing the test. i dont need the host check but im not asserting we ignore and log the error in any of the tests | |
| 18:36:58 | sean-k-mooney | dansmith: i commented in line. is there a better way to handel the change in behavior. where im moving work that was prviously done in one api call to another? | |
| 18:37:21 | sean-k-mooney | its rare we do this but it sometimes happens | |
| 18:37:54 | dansmith | sean-k-mooney: no, I just wanted to note it, same as here | |
| 18:38:35 | sean-k-mooney | cool | |
| 18:41:48 | sean-k-mooney | hum same host resize. perhaps that is why we do that check. | |
| 18:42:07 | dansmith | sean-k-mooney: ... :) | |
| 18:42:18 | sean-k-mooney | ill chekc the call flow again when i add the unit test | |
| 18:42:24 | dansmith | cool | |
| 18:42:51 | sean-k-mooney | i think the new unplug call would be before the netowrkign is plugged for the dest | |
| 18:43:23 | sean-k-mooney | so i think it still works but ill make sure and either add the same check or leave a comment in the code | |
| 18:45:26 | sean-k-mooney | one of the side effect of when libvirt is in charge fo when libvirt is responcible for addign and removing port form ovs is | |
| 18:45:41 | sean-k-mooney | on same host resize it remvoe and add the port to ovs | |