Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-25
15:09:29 stephenfin so I just removed the mock
15:09:39 artom stephenfin, yeah, I can't reproduce it locally when running just that one single test
15:09:50 artom But maybe it's somehow related
15:10:20 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747978
15:21:02 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907
15:21:02 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906
15:21:03 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908
15:25:58 frickler artom: rs_goyal__: there's some work in progress on adding tag support to OSC, help appreciated. https://review.opendev.org/#/q/topic:story/2002195+(status:open+OR+status:merged)
15:28:43 frickler but I also admit that I didn't know about this feature up to now, which might help with some of my usecases, too, guess I need to take a deeper look anyhow. guess nobody did build cloud-init support for it, either
15:36:25 artom frickler, so I keep hearing that osc is moving to using the sdk... is that even true?
15:36:54 artom Because I started an effort to bring sdk up to speed (from the nova pov at any rate), the logic being that's the more "future-proof" place to invest work
15:37:11 artom But then I keep seeing stuff being added to osc directly...
15:37:31 artom Is there even a grand plan, or is this all ad-hoc patches?
15:39:06 openstackgerrit Merged openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
15:43:17 stephenfin lyarwood: reviewed the nova-image-download-via-rbd bp
15:44:05 stephenfin artom: not frickler, wdym by "stuff [being added] to osc directly"
15:44:40 artom stephenfin, I mean patches like https://review.opendev.org/#/q/topic:story/2002195+(status:open+OR+status:merged)
15:44:44 stephenfin doesn't osc just call e.g. novaclient or sdk, with just a few shims for cases like novaclient dropping an API
15:45:17 sean-k-mooney it can call both as far as i know
15:45:33 sean-k-mooney so you would jsut have to migrate indiviaual calls form one ot the other
15:45:36 artom stephenfin, ah, I see what you mean
15:45:52 artom stephenfin, there's no request logic in osc itself, it just call novaclient
15:46:18 artom I guess in that case I mean - not adding stuff to the sdk first
15:46:37 artom If it's supposed to be moving to the sdk, then why are new patches are being added that call novaclient?
15:47:02 sean-k-mooney artom: it just does parsing and passes the args on
15:47:07 frickler artom: mordred should be the right person to talk to about this, now that dtroyer seem to have moved on. sadly he also seems to be gone missing somehow
15:47:18 sean-k-mooney there is little logic in osc beyond that in general
15:47:52 sean-k-mooney thre are some microversion checks and other check to ensure its valid
15:48:07 sean-k-mooney but thats more validation of input then complex logic
15:48:49 stephenfin artom: Is it possible to talk to SDK for nova commands? 'self.app.client_manager.compute' will point to the novaclient client at the moment
15:49:09 stephenfin at least, last I checked
15:49:10 artom stephenfin, would have to look it up
15:49:11 sean-k-mooney stephenfin: you can just import the sdk modules
15:49:13 sean-k-mooney and call that
15:49:26 stephenfin you've have to init the sdk too, I'd imagine
15:49:51 sean-k-mooney proably unless there is a global instance you can use
15:50:07 lyarwood stephenfin: thanks, jsuchome I'll clean things up again unless you want to work through stephenfin's comments?
15:50:19 sean-k-mooney but its like how we use both sdk and keystone authclient and project client in nova
15:50:24 sean-k-mooney you can mix and match
15:51:23 jsuchome lyarwood: I'm changing those hard requests (doc + file handle), I would rather not go down the rabbit hole of new refactoring though
15:52:26 artom stephenfin, frickler, I'm asking selfishly in the context of https://review.opendev.org/#/q/status:open+project:openstack/openstacksdk+branch:master+topic:story/2007929
15:52:50 artom I'm not going to continue that if nothing of "substance" (sorry openstack-ansible) will ever use the sdk
15:53:11 artom There are plenty of broken things in Nova that I can fix with that time ;)
15:53:20 lyarwood jsuchome: yup np, I can fix up my change once you're done
15:53:32 lyarwood jsuchome: and we can push the other stuff to follow ups hopefully
15:53:45 openstackgerrit Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
15:54:33 artom I just kept hearing "osc is moving to sdk", so I figured catch up 1 thing (the sdk), start requiring the sdk for new API microversion, and then we don't have an ever increasing gap to close wrt to novaclient parity.
15:54:34 lyarwood TIL about http://rst.ninjs.org/
15:54:51 lyarwood no wonder stephenfin gets his rst correct first time
15:55:22 frickler artom: I'm pretty sure that the idea for OSC would be to use those things from the sdk, but I don't know if anyone commited to actually working on that. but surely a lot of people would approve that
15:55:24 stephenfin artom: TIL (or rather remembered) I have core on sdk
15:56:04 frickler artom: maybe best continue that discussion in #openstack-sdks , also eod for me now
15:56:28 artom frickler, ack. o/
15:57:19 frickler just as a final comment, OSC and sdk are a single project for a small while now, so in theory there shouldn't be any gap between those
15:57:34 stephenfin jsuchome, lyarwood: Thoughts on https://review.opendev.org/#/c/574301/35/nova/image/glance.py@225 ?
15:57:48 stephenfin Apologies if I've missed some context on that decision (to bring back the deprecated opt)
15:59:04 artom frickler, "in theory" :D
15:59:40 lyarwood stephenfin: I've not heard any plans for support for other support
15:59:45 jsuchome stephenfin: in general, I don't think there's a big chance to expand it ... but well, who knows
16:00:04 lyarwood stephenfin: I'd prefer however that we ruled that out at a later date
16:01:20 sean-k-mooney i could see use adding swift maybe
16:01:37 sean-k-mooney to pull the image drectly from swrift rather then streaming it via glance
16:01:40 jsuchome I think it's already mentioned in the blueprint btw
16:01:55 sean-k-mooney no one has asked for that however
16:02:39 sean-k-mooney but ya swift is the only thing i can think of that we might ever expand it for and even then im not sure it makes sense
16:02:47 sean-k-mooney im jsut thinking off the top of my head
16:03:20 sean-k-mooney the advantage of using the exsiting deprecated option is installer tools whoudl already support it
16:03:36 sean-k-mooney if we use anything else that creates more work for them
16:03:56 gibi o/
16:04:05 sean-k-mooney o/ enjoy your evening
16:04:19 gibi thanks
16:05:29 sean-k-mooney which nova cores like networking and libvirt :)
16:06:10 sean-k-mooney zuul hasnt finished running yet but i have an old patch that i want to make sure lands before m3
16:06:58 sean-k-mooney https://review.opendev.org/#/c/602432/ but it does not need to be reviewd right away the neutron dep merged earlier today so i finally got around to rebasing it
16:11:47 openstackgerrit Merged openstack/nova master: [goal] Prepare for job migration to Ubuntu Focal (20.04) https://review.opendev.org/738126
17:01:02 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363
17:01:02 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add helpers for rebuild, cold migrate, and shelve/unshelve https://review.opendev.org/747792
17:01:03 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213
17:01:04 openstackgerrit Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864
17:01:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995
17:01:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863
17:01:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865
17:01:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
17:09:17 openstackgerrit Merged openstack/nova master: Add reno for deprecated APIs policy changes https://review.opendev.org/747784
17:22:30 gmann gibi: reno patch is merged you can mark policy-defaults-refresh-deprecated-apis BP completed now.
18:25:08 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747978
19:53:00 openstackgerrit Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
20:18:01 openstackgerrit Merged openstack/nova master: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747969
21:22:44 lyarwood melwitt: thanks for the stable reviews, would you also mind looking at https://review.opendev.org/#/c/747357/ https://review.opendev.org/#/c/744553/ https://review.opendev.org/#/c/744550/ https://review.opendev.org/#/c/742706/ & https://review.opendev.org/#/c/729177/
21:34:13 melwitt ack will do
21:38:26 lyarwood awesome thanks :)
21:47:52 openstackgerrit Elancheran S proposed openstack/nova stable/ussuri: Removes the delta file once image is extracted https://review.opendev.org/748034
21:48:45 openstackgerrit Elancheran S proposed openstack/nova stable/train: Removes the delta file once image is extracted https://review.opendev.org/748035
23:29:50 openstackgerrit Merged openstack/nova master: db: fix database migrations when name includes dash https://review.opendev.org/747164
#openstack-nova - 2020-08-26
00:54:17 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059
02:51:06 openstackgerrit Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
02:55:58 openstackgerrit Merged openstack/nova stable/stein: Should not skip volume_size check for bdm.image_id == image_ref case https://review.opendev.org/744553
03:38:39 openstackgerrit Merged openstack/nova stable/ussuri: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/742706
04:14:50 openstackgerrit Merged openstack/nova stable/rocky: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729177
04:25:44 openstackgerrit Elancheran S proposed openstack/nova stable/ussuri: Removes the delta file once image is extracted https://review.opendev.org/748034

Earlier   Later