| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-25 | |||
| 14:31:19 | aarents | sean-k-mooney, I made some test reauest 7 detach on same instance taking 4s to detach with a lock per instance-port and > 10sec when only instance | |
| 14:32:27 | sean-k-mooney | yep as long as libvirt safely handels the parrale detach request we dont need to lock at the instance levle | |
| 14:32:35 | gibi | sean-k-mooney, aarents: good catch about the parallel detach, I queued up the fix in my review list | |
| 14:32:53 | aarents | So I prefer 'interface-%s-%s' on both | |
| 14:32:55 | sean-k-mooney | gibi: aarents found it :) | |
| 14:33:03 | aarents | gibi: thanks | |
| 14:33:10 | gibi | then aarents gets the prize :) | |
| 14:42:51 | aarents | That one of my two downstream summer bugs :P other one will come soon.. | |
| 14:43:58 | gibi | I had summer vacation, you had summer bugs. I'm feeling lucky :D | |
| 14:44:19 | aarents | :D | |
| 14:52:10 | rs_goyal__ | @gibi @artom : I tried tagging the network, but the interface is getting created like I explained above. I used `nova interface-attach --net-id <network> --tag priv <instance>`for attaching a newtork interface on an existing vm. | |
| 14:53:34 | artom | rs_goyal__, the actual interface names (eth0, ens1, etc) aren't affected | |
| 14:53:42 | artom | rs_goyal__, you need to look in the metadata | |
| 15:00:28 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747969 | |
| 15:01:16 | rs_goyal__ | @artom : okay. thanks. | |
| 15:03:05 | gibi | lyarwood: +2 | |
| 15:03:29 | lyarwood | gibi: thanks | |
| 15:03:29 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747972 | |
| 15:03:36 | lyarwood | stephenfin: ^ master change is up btw | |
| 15:03:47 | gibi | lyarwood: I thank you to taking care of this | |
| 15:04:22 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747973 | |
| 15:04:45 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747974 | |
| 15:04:46 | lyarwood | gibi: np :) | |
| 15:06:29 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747975 | |
| 15:07:47 | stephenfin | lyarwood: done \o/ | |
| 15:07:52 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747976 | |
| 15:08:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Move revert resize under semaphore https://review.opendev.org/747746 | |
| 15:08:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Move confirm resize under semaphore https://review.opendev.org/747745 | |
| 15:08:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958 | |
| 15:08:28 | openstack | bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | |
| 15:08:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add generic reproducer for bug #1879878 https://review.opendev.org/747744 | |
| 15:08:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Address TODO https://review.opendev.org/747748 | |
| 15:08:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup 'drop_move_claim' and '_drop_move_claim' https://review.opendev.org/747747 | |
| 15:08:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | |
| 15:08:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Move context manager up one level https://review.opendev.org/745674 | |
| 15:08:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675 | |
| 15:09:19 | stephenfin | artom: that failure in https://review.opendev.org/747744 is weird. Looks like the mock was being applied globally or something :-\ | |
| 15:09:29 | stephenfin | so I just removed the mock | |
| 15:09:39 | artom | stephenfin, yeah, I can't reproduce it locally when running just that one single test | |
| 15:09:50 | artom | But maybe it's somehow related | |
| 15:10:20 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747978 | |
| 15:21:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907 | |
| 15:21:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906 | |
| 15:21:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908 | |
| 15:25:58 | frickler | artom: rs_goyal__: there's some work in progress on adding tag support to OSC, help appreciated. https://review.opendev.org/#/q/topic:story/2002195+(status:open+OR+status:merged) | |
| 15:28:43 | frickler | but I also admit that I didn't know about this feature up to now, which might help with some of my usecases, too, guess I need to take a deeper look anyhow. guess nobody did build cloud-init support for it, either | |
| 15:36:25 | artom | frickler, so I keep hearing that osc is moving to using the sdk... is that even true? | |
| 15:36:54 | artom | Because I started an effort to bring sdk up to speed (from the nova pov at any rate), the logic being that's the more "future-proof" place to invest work | |
| 15:37:11 | artom | But then I keep seeing stuff being added to osc directly... | |
| 15:37:31 | artom | Is there even a grand plan, or is this all ad-hoc patches? | |
| 15:39:06 | openstackgerrit | Merged openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 15:43:17 | stephenfin | lyarwood: reviewed the nova-image-download-via-rbd bp | |
| 15:44:05 | stephenfin | artom: not frickler, wdym by "stuff [being added] to osc directly" | |
| 15:44:40 | artom | stephenfin, I mean patches like https://review.opendev.org/#/q/topic:story/2002195+(status:open+OR+status:merged) | |
| 15:44:44 | stephenfin | doesn't osc just call e.g. novaclient or sdk, with just a few shims for cases like novaclient dropping an API | |
| 15:45:17 | sean-k-mooney | it can call both as far as i know | |
| 15:45:33 | sean-k-mooney | so you would jsut have to migrate indiviaual calls form one ot the other | |
| 15:45:36 | artom | stephenfin, ah, I see what you mean | |
| 15:45:52 | artom | stephenfin, there's no request logic in osc itself, it just call novaclient | |
| 15:46:18 | artom | I guess in that case I mean - not adding stuff to the sdk first | |
| 15:46:37 | artom | If it's supposed to be moving to the sdk, then why are new patches are being added that call novaclient? | |
| 15:47:02 | sean-k-mooney | artom: it just does parsing and passes the args on | |
| 15:47:07 | frickler | artom: mordred should be the right person to talk to about this, now that dtroyer seem to have moved on. sadly he also seems to be gone missing somehow | |
| 15:47:18 | sean-k-mooney | there is little logic in osc beyond that in general | |
| 15:47:52 | sean-k-mooney | thre are some microversion checks and other check to ensure its valid | |
| 15:48:07 | sean-k-mooney | but thats more validation of input then complex logic | |
| 15:48:49 | stephenfin | artom: Is it possible to talk to SDK for nova commands? 'self.app.client_manager.compute' will point to the novaclient client at the moment | |
| 15:49:09 | stephenfin | at least, last I checked | |
| 15:49:10 | artom | stephenfin, would have to look it up | |
| 15:49:11 | sean-k-mooney | stephenfin: you can just import the sdk modules | |
| 15:49:13 | sean-k-mooney | and call that | |
| 15:49:26 | stephenfin | you've have to init the sdk too, I'd imagine | |
| 15:49:51 | sean-k-mooney | proably unless there is a global instance you can use | |
| 15:50:07 | lyarwood | stephenfin: thanks, jsuchome I'll clean things up again unless you want to work through stephenfin's comments? | |
| 15:50:19 | sean-k-mooney | but its like how we use both sdk and keystone authclient and project client in nova | |
| 15:50:24 | sean-k-mooney | you can mix and match | |
| 15:51:23 | jsuchome | lyarwood: I'm changing those hard requests (doc + file handle), I would rather not go down the rabbit hole of new refactoring though | |
| 15:52:26 | artom | stephenfin, frickler, I'm asking selfishly in the context of https://review.opendev.org/#/q/status:open+project:openstack/openstacksdk+branch:master+topic:story/2007929 | |
| 15:52:50 | artom | I'm not going to continue that if nothing of "substance" (sorry openstack-ansible) will ever use the sdk | |
| 15:53:11 | artom | There are plenty of broken things in Nova that I can fix with that time ;) | |
| 15:53:20 | lyarwood | jsuchome: yup np, I can fix up my change once you're done | |
| 15:53:32 | lyarwood | jsuchome: and we can push the other stuff to follow ups hopefully | |
| 15:53:45 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 15:54:33 | artom | I just kept hearing "osc is moving to sdk", so I figured catch up 1 thing (the sdk), start requiring the sdk for new API microversion, and then we don't have an ever increasing gap to close wrt to novaclient parity. | |
| 15:54:34 | lyarwood | TIL about http://rst.ninjs.org/ | |
| 15:54:51 | lyarwood | no wonder stephenfin gets his rst correct first time | |
| 15:55:22 | frickler | artom: I'm pretty sure that the idea for OSC would be to use those things from the sdk, but I don't know if anyone commited to actually working on that. but surely a lot of people would approve that | |
| 15:55:24 | stephenfin | artom: TIL (or rather remembered) I have core on sdk | |
| 15:56:04 | frickler | artom: maybe best continue that discussion in #openstack-sdks , also eod for me now | |
| 15:56:28 | artom | frickler, ack. o/ | |
| 15:57:19 | frickler | just as a final comment, OSC and sdk are a single project for a small while now, so in theory there shouldn't be any gap between those | |
| 15:57:34 | stephenfin | jsuchome, lyarwood: Thoughts on https://review.opendev.org/#/c/574301/35/nova/image/glance.py@225 ? | |
| 15:57:48 | stephenfin | Apologies if I've missed some context on that decision (to bring back the deprecated opt) | |
| 15:59:04 | artom | frickler, "in theory" :D | |
| 15:59:40 | lyarwood | stephenfin: I've not heard any plans for support for other support | |
| 15:59:45 | jsuchome | stephenfin: in general, I don't think there's a big chance to expand it ... but well, who knows | |
| 16:00:04 | lyarwood | stephenfin: I'd prefer however that we ruled that out at a later date | |
| 16:01:20 | sean-k-mooney | i could see use adding swift maybe | |
| 16:01:37 | sean-k-mooney | to pull the image drectly from swrift rather then streaming it via glance | |
| 16:01:40 | jsuchome | I think it's already mentioned in the blueprint btw | |