| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-18 | |||
| 21:25:39 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#32903-32924 | |
| 21:26:08 | iurygregory | yeah, seems like tempest is not updating the node with the boot_option... | |
| 21:26:16 | sean-k-mooney | i think its correctly installing it tox -evenv-tempest -- pip install -c /tmp/tempest_u_c_m.37WJbEB0sa /opt/stack/ironic-tempest-plugin | |
| 21:26:28 | sean-k-mooney | that using the version cloned by zuul | |
| 21:28:25 | sean-k-mooney | iurygregory: have you defiend the required tempest config options | |
| 21:28:26 | iurygregory | yeah the version installed is correct (at least the logs shows "23adec07f1d5998951fe841cd68989c6d85f7d98 Update basic_ops" | |
| 21:28:55 | iurygregory | yeah, I checked the config and it does look correct | |
| 21:30:04 | iurygregory | I double checked with the job-output.txt the flavors are correct | |
| 21:30:08 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/tempest_conf.txt#141-144 | |
| 21:30:10 | iurygregory | uuid etc | |
| 21:30:24 | sean-k-mooney | so ya it looks like they are set correctly | |
| 21:31:18 | sean-k-mooney | so this is what is ment to set the caps https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@205 | |
| 21:32:46 | sean-k-mooney | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@174 | |
| 21:32:54 | sean-k-mooney | by default it does not set teh caps | |
| 21:33:14 | iurygregory | yeah, but the test sends True | |
| 21:33:42 | iurygregory | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py@208 | |
| 21:33:45 | sean-k-mooney | yes https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py@208 | |
| 21:34:08 | iurygregory | at least it should send =) | |
| 21:35:13 | sean-k-mooney | does the compute capablity filter requrie all cap to be requested | |
| 21:35:45 | iurygregory | this information I don't know =) | |
| 21:36:15 | sean-k-mooney | i was wonderinf it the default falvor was failing but no | |
| 21:36:26 | sean-k-mooney | the only failing tests are teh new ones | |
| 21:36:46 | sean-k-mooney | well actully | |
| 21:36:49 | sean-k-mooney | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_65e/741886/9/check/ironic-tempest-ipa-partition-uefi-pxe_ipmitool/65e4cb5/testr_results.html | |
| 21:36:56 | sean-k-mooney | only 2 tests failed | |
| 21:37:03 | iurygregory | yeah | |
| 21:37:25 | iurygregory | the ones I did the changes and require the new flavor etc =) | |
| 21:38:23 | sean-k-mooney | well you added https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py@320 | |
| 21:38:25 | sean-k-mooney | whic passed | |
| 21:38:35 | sean-k-mooney | that looks like it can use the new code | |
| 21:39:39 | sean-k-mooney | oh that was skipped | |
| 21:39:45 | iurygregory | I'm not sure where did you see that test_baremetal_server_ops_wholedisk_image passed o.o | |
| 21:40:04 | iurygregory | oh =) | |
| 21:40:24 | iurygregory | because rescue wasn't enable so it will skip | |
| 21:40:24 | sean-k-mooney | im guessing rescure is not enabled or something like that | |
| 21:40:30 | sean-k-mooney | yep | |
| 21:41:12 | iurygregory | we are trying to make our jobs test partition and wholedisk images at the same time, so we can remove some jobs | |
| 21:43:07 | sean-k-mooney | so this is wehre the caps are currently configured | |
| 21:43:09 | sean-k-mooney | https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L2293-L2307 | |
| 21:43:15 | sean-k-mooney | staticly in devstack | |
| 21:43:46 | sean-k-mooney | well it goes on longer | |
| 21:43:48 | sean-k-mooney | https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L2293-L2344 | |
| 21:45:14 | iurygregory | yeah | |
| 21:45:29 | iurygregory | but tempest should be able to just go and update | |
| 21:45:37 | iurygregory | .-. | |
| 21:45:44 | sean-k-mooney | well | |
| 21:45:50 | iurygregory | or nope? | |
| 21:45:55 | sean-k-mooney | its updating them after it creates the instance | |
| 21:46:17 | sean-k-mooney | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@190 | |
| 21:46:23 | sean-k-mooney | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@197 | |
| 21:46:32 | sean-k-mooney | the node is not update until 205 | |
| 21:47:10 | sean-k-mooney | so you need to do it before creating the nova instance | |
| 21:47:17 | sean-k-mooney | so move it to 183 | |
| 21:47:20 | iurygregory | wow | |
| 21:48:19 | sean-k-mooney | am i reading that right | |
| 21:48:58 | iurygregory | this would be strange | |
| 21:49:11 | iurygregory | since nova is doing the things with the ironic virt driver | |
| 21:49:41 | sean-k-mooney | how do you mean | |
| 21:49:41 | iurygregory | the node is only ready on line 228 | |
| 21:50:18 | iurygregory | when nova is enable it uses the nova.virt.ironic https://opendev.org/openstack/nova/src/branch/master/nova/virt/ironic/ | |
| 21:50:24 | sean-k-mooney | well right now everything that happens after 200 | |
| 21:50:36 | sean-k-mooney | is waiting for ironcit to finish proviioning the servier | |
| 21:50:46 | sean-k-mooney | but you need to add the cabpiltiy before calling nova | |
| 21:51:24 | iurygregory | hummm | |
| 21:51:27 | sean-k-mooney | so the cap need to be set on one of the hosts before nova tries to find a node using the flavor | |
| 21:52:04 | iurygregory | so if I set on devstack/lib/ironic to grab one node and set it will work | |
| 21:52:20 | sean-k-mooney | this test also cant run in parallel with other tests since its cahanging capablities | |
| 21:52:56 | sean-k-mooney | sure it proably will work | |
| 21:53:39 | sean-k-mooney | to test both case in 1 job you would need two ironic compute nodes | |
| 21:53:54 | sean-k-mooney | then hard code one to each boot mode | |
| 21:55:09 | iurygregory | yeah | |
| 21:55:14 | iurygregory | tks for the help sean-k-mooney =) | |
| #openstack-nova - 2020-08-19 | |||
| 06:00:49 | openstackgerrit | Mamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/746836 | |
| 06:07:57 | openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | |
| 06:24:59 | openstackgerrit | Mamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/745895 | |
| 08:11:40 | lyarwood | gmann: with the switch to focal, are we dropping support for bionic? | |
| 08:35:35 | stephenfin | lyarwood++ Ta for reviewing those six patches by the way. I'm sure Takashi-san appreciates :) | |
| 08:35:39 | stephenfin | *the reviews | |
| 08:59:29 | lyarwood | stephenfin: np | |
| 09:56:16 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Add type annotations https://review.opendev.org/745162 | |
| 09:56:17 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop' https://review.opendev.org/745163 | |
| 09:56:18 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: windows: Add missing return https://review.opendev.org/746870 | |
| 10:05:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Log exception when unable to import rbd https://review.opendev.org/746873 | |
| 10:08:55 | stephenfin | lyarwood: https://review.opendev.org/#/c/734734/ might be of interest | |
| 10:19:15 | lyarwood | stephenfin: reviewed, issue with the test but agree with blocking that in the API | |
| 10:33:13 | lyarwood | stephenfin: https://review.opendev.org/#/c/574301/ - Can you take a look at my notes/question in this, tl;dr we end up relying on [libvirt] specific configurables within nova.image.glance *if* the default ceph config doesn't provide access to the RBD pool hosting glance images. | |
| 10:33:53 | lyarwood | stephenfin: I'm fine addressing that in FUPs in the future by introducing [glance] specific configurables for this | |
| 10:34:03 | stephenfin | sure | |
| 10:34:11 | lyarwood | stephenfin: but wanted other cores to agree with that approach before merging this | |
| 10:34:21 | lyarwood | stephenfin: kk thanks | |
| 10:36:36 | lyarwood | ah right cinder volumes | |
| 10:38:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM zuul: Enable [glance]/allowed_direct_url_schemes within nova-ceph-multistore https://review.opendev.org/743220 | |
| 10:47:47 | stephenfin | lyarwood: yup, agreed with not using libvirt-specific stuff in a generic place. Left my comments on the patch | |
| 11:12:47 | sean-k-mooney | stephenfin: wehn you write c/c++ do you put the { on a new line after the funtion signiture followed by another new line before starting the body | |
| 11:13:34 | stephenfin | Python isn't C | |
| 11:13:43 | stephenfin | and I haven't written a lot of C in quite some time :( | |
| 11:15:27 | sean-k-mooney | i know but you are formating things like peopel that do that. i have all been in the void myfunc(int arg) { camp or "auto myfunc(int arg) -> void {" where the code base is following almost always auto | |
| 11:15:43 | tosky | sean-k-mooney: if you change existing code, follow that style; there are different styles around | |
| 11:16:16 | sean-k-mooney | tosky: yes i do | |
| 11:16:20 | tosky | tl;dr there is no correct answer :) | |