Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-29
12:16:31 openstackgerrit Lee Yarwood proposed openstack/nova master: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710
12:20:06 lyarwood Does anyone have any ideas why this https://review.opendev.org/#/c/731506/ never ends up in the gate?
12:20:23 lyarwood I can't rebase it, it isn't in conflict etc
12:25:18 stephenfin lyarwood: possibly a bug in Gerrit? There is no Depends-On but it was based on a patch that has since been abandoned
12:25:35 openstackgerrit Stephen Finucane proposed openstack/nova master: compute: As cellsv1 is no more fold _detach_volume back into detach_volume https://review.opendev.org/731506
12:25:43 stephenfin that should do the trick
12:26:01 stephenfin lyarwood: Can you look at https://review.opendev.org/#/c/731506/ today?
12:26:10 stephenfin Also bauzas, perhaps? https://review.opendev.org/#/c/731506/
12:27:37 lyarwood looking
12:29:01 lyarwood stephenfin: wait, that's the link to my change
12:29:09 lyarwood stephenfin: which review did you want me to look at
12:29:25 stephenfin doh
12:29:27 stephenfin https://review.opendev.org/#/c/743568/
12:29:37 lyarwood stephenfin: and re https://review.opendev.org/731506 yeah I missed that it was still pointing at that change sorry
12:30:50 stephenfin all good
12:36:39 lyarwood stephenfin: done, LGTM, I guess func tests wouldn't make sense here given libvirt is acting up right?
12:36:56 stephenfin lyarwood: yes, that's my thinking too
12:49:43 ralonsoh stephenfin, hi! I you have some time: https://review.opendev.org/#/c/739961/
12:52:31 stephenfin ralonsoh: Could we get some context in the commit message?
12:52:41 stephenfin i.e. what it's for and why it's needed
12:53:07 ralonsoh stephenfin, ok, I'll add this
12:53:14 stephenfin thanks :)
13:00:58 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-traits master: Add NUMA affinity policy traits https://review.opendev.org/739961
13:14:28 aarents Hi nova,
13:14:56 aarents lyarwood : When you will have time for this https://review.opendev.org/#/c/696084/4 , I split the change with another: https://review.opendev.org/#/c/743537/ and added a tempest test to reproduce the issue: https://review.opendev.org/#/c/743708/1 (failed as expected in tempest-slow-py3 jobs)
13:17:50 openstackgerrit Takashi Natsume proposed openstack/python-novaclient stable/ussuri: Add a cleanup for a server in a functional test https://review.opendev.org/743756
13:19:00 openstackgerrit Takashi Natsume proposed openstack/python-novaclient stable/train: Add a cleanup for a server in a functional test https://review.opendev.org/743757
13:42:27 openstackgerrit Lee Yarwood proposed openstack/nova master: Use absolute path during qemu img rebase https://review.opendev.org/739246
13:43:50 lyarwood ^ from gibi LGTM now if any other cores have time today
14:52:14 openstackgerrit Merged openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
15:02:10 bauzas stephenfin: sorry, I was on PTO this morning
15:15:45 stephenfin bauzas: np. Any chance you could look at https://review.opendev.org/743568 today?
15:16:01 bauzas ack
15:16:08 stephenfin thanks :)
16:05:49 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/724842
16:06:04 lyarwood stephenfin: ^ can you +W that again when you get a chance?
16:06:33 lyarwood https://review.opendev.org/#/c/729596/ and this please
16:07:18 lyarwood melwitt: https://review.opendev.org/#/q/topic:bug/1889108 - would you mind taking a look at this series?
16:16:08 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703
16:16:21 bauzas stephenfin: you may be interested in ^
16:16:48 stephenfin bauzas: Opened in a tab. I'll review that first thing in the morning.
16:16:53 bauzas ++
16:17:43 openstack Launchpad bug 1889257 in OpenStack Compute (nova) "Live migration of realtime instances is broken" [Medium,In progress] - Assigned to Stephen Finucane (stephenfinucane)
16:17:43 bauzas stephenfin: I guess we couldn't catch https://bugs.launchpad.net/nova/+bug/1889257 on a functional test ?
16:18:36 bauzas stephenfin: I need to jump straight off the keyboard but I can review decently https://review.opendev.org/#/c/743568/ later tonight
16:18:58 bauzas to be fair, the bug isn't trivial to understand and there are implications on the way we generate the XML
16:19:32 bauzas fortunately, the XML implications are limited to the attribute that is bugged
16:20:11 bauzas stephenfin: but I guess non-realtime users would be impacted by this change too, right?
16:23:18 lyarwood bauzas: I asked about func tests earlier but we'd have to mock out the way libvirt is rewriting the xml etc, we could but I don't think it's required to land this tbh.
16:23:40 lyarwood bauzas: and AFAIK it only impacts realtime LM
16:26:02 lyarwood huh we don't have a regression keyword in launchpad for nova, that might be useful.
16:26:25 bauzas we have but this is release-specific
16:27:09 bauzas lyarwood: so, I need to be absolutely sure that vcpusched is only used by the realtime users
16:28:14 lyarwood bauzas: https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/virt/libvirt/driver.py#L5111-L5117
16:28:42 bauzas lyarwood: gosh lord, thank you
16:28:54 lyarwood bauzas: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8493-L8498
16:29:06 lyarwood artom: ^ did I miss anything btw? ./me thinks you know more about this
16:30:33 bauzas lyarwood: Saint Github tells me that the only reference of LibvirtConfigGuestCPUTuneVCPUSched is https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/virt/libvirt/driver.py#L5113
16:30:50 bauzas that's enough for me
16:43:05 melwitt lyarwood: ack will do
16:45:38 lyarwood thanks
16:58:52 openstackgerrit Merged openstack/python-novaclient stable/ussuri: Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/740488
17:00:17 openstackgerrit Takashi Natsume proposed openstack/python-novaclient stable/ussuri: Add a cleanup for a server in a functional test https://review.opendev.org/743756
17:06:08 openstackgerrit Stephen Finucane proposed openstack/nova stable/ussuri: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743804
17:10:24 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743805
19:31:30 openstackgerrit Merged openstack/nova master: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743568
19:45:32 openstackgerrit Sean McGinnis proposed openstack/nova master: Drop use of legacy encryptor specifiers https://review.opendev.org/743834
21:37:19 openstackgerrit melanie witt proposed openstack/nova master: WIP Add option to sync instance power states during shutdown https://review.opendev.org/743848
22:31:30 openstackgerrit Merged openstack/nova stable/train: objects: Update keypairs when saving an instance https://review.opendev.org/742709
22:31:36 openstackgerrit Merged openstack/nova master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/740575
#openstack-nova - 2020-07-30
01:20:06 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
02:44:13 openstackgerrit Brin Zhang proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326
02:44:13 openstackgerrit Brin Zhang proposed openstack/nova master: Optimize _create_and_bind_arqs logic in conducor https://review.opendev.org/726564
03:48:41 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
07:39:30 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
07:39:31 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
07:51:56 bauzas stephenfin: not sure you got a chance to see my comment https://review.opendev.org/#/c/743568/1/nova/virt/libvirt/migration.py@128
07:53:24 tony_su stephenfin: the first patch is uploaded and in almost-completed phase, and the second patch is ready for a new round of review.
08:24:44 brinzhang0 sean-k-mooney: please see https://review.opendev.org/#/c/715326/15/nova/compute/manager.py@3233, I agree with gibi, can we remove the eventlet.timeout.Timeout Exception?
08:55:40 openstackgerrit Alexandre Arents proposed openstack/nova master: Rebase qcow2 images when unshelving an instance https://review.opendev.org/696084
08:59:41 openstackgerrit Jie Li proposed openstack/nova-specs master: add volume backed server rebuild spec https://review.opendev.org/739349
10:12:48 sean-k-mooney brinzhang0: i am not sure, i think it could be raised form any https request but if we remove it and it is raised it will still be caught by the generic Exception
10:13:01 sean-k-mooney specifier
10:13:10 sean-k-mooney so it wont change behavior to remove it
10:13:19 sean-k-mooney so we could for brevity
11:01:31 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Removed the host FQDN from the exception message https://review.opendev.org/743950
12:19:39 gibi_pto dansmith: I've did a quick cleanup on the todays meeting agenda on the wiki for you
13:23:20 dansmith gibi_pto: roger, thanks, I was just going to look at it this morning
13:30:09 openstackgerrit Andrew Bonney proposed openstack/nova master: Fix misleading documentation for live_migration_inbound_addr https://review.opendev.org/741473
13:34:02 bauzas dansmith: I guess you'll handle the v-2 tag ?
13:34:20 dansmith bauzas: apparently there's nothing to do, we worked that out last week I think
13:34:31 bauzas mmmm really ?
13:34:37 bauzas lemme doublecheck
13:34:49 dansmith according to smcginnis, but if he tells me to do something I'll do it
13:36:01 bauzas dansmith: can't see any nova proposed change in the releases repo
13:36:08 bauzas for victoria-2 I mean
13:37:36 bauzas actually, nevermind
13:37:41 dansmith let's wait for smcginnis to respond
13:37:50 bauzas can't see any service project change for victoria-1 either
13:37:56 bauzas so I guess it changed

Earlier   Later