| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-28 | |||
| 19:15:49 | lyarwood | right sorry I mean with microversion = None | |
| 19:15:51 | sean-k-mooney | we teachnicaly have to support very micoversion untill we go to nova v4 | |
| 19:16:02 | lyarwood | yeah true | |
| 19:16:20 | sean-k-mooney | microversion = None is the same as 2.1 | |
| 19:16:22 | sean-k-mooney | i think | |
| 19:16:23 | gmann | functional tests are with 'latest' by default i think doing with 'latest' make sense | |
| 19:16:48 | lyarwood | gmann: it's set to None in _IntegratedTestBase | |
| 19:16:54 | sean-k-mooney | gmann: that is how i have always written them unless i was testing a feature | |
| 19:17:12 | artom | gmann, I think they're none, if I have the right code in front of me: https://opendev.org/openstack/nova/src/branch/master/nova/tests/functional/api/client.py#L135 | |
| 19:17:17 | sean-k-mooney | in which case i might use the microverion it was added in | |
| 19:18:00 | sean-k-mooney | lyarwood: is _IntegratedTestBase the new base of the functional test or the old one that we should not use anymore | |
| 19:18:18 | sean-k-mooney | there are a few baseclasses we can use in the funcational tests | |
| 19:18:31 | lyarwood | sean-k-mooney: the former I think, stephenfin is talking about replacing ProviderUsageBaseTestCase with it | |
| 19:18:53 | sean-k-mooney | waith isnte ProviderUsageBaseTestCase the thing we were ment to be moving too | |
| 19:18:59 | lyarwood | https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L1062-L1063 | |
| 19:22:12 | gmann | ah right, it is in ProviderUsageBaseTestCase not base and many tests side too | |
| 19:22:16 | sean-k-mooney | oh sorry _IntegratedTestBase is not the one with the weird implematnion of _wait_for_server_allocations | |
| 19:22:39 | artom | sean-k-mooney, that got fixed a while ago | |
| 19:22:46 | artom | stephenfin unified all the things | |
| 19:22:53 | sean-k-mooney | ya i rememebr | |
| 19:23:04 | sean-k-mooney | i just was not sure if we still had some remnetes | |
| 19:23:46 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Add live migration rollback volume attachment tests https://review.opendev.org/743534 | |
| 19:23:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Add CinderFixture to _IntegratedTestBase https://review.opendev.org/743535 | |
| 19:23:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/743319 | |
| 19:23:48 | openstack | bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 19:23:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression tests for bug #1889108 https://review.opendev.org/743289 | |
| 19:23:50 | sean-k-mooney | what is confution me is that _IntegratedTestBase has a preceding underscore | |
| 19:24:02 | sean-k-mooney | and i tought we were not ment to be using it directly anymore | |
| 19:24:13 | sean-k-mooney | ane moving to the public base class | |
| 19:25:09 | sean-k-mooney | oh that todo was added 2 weeks ago https://github.com/openstack/nova/commit/c60f90cb2f8e2a30ffee5abeebd78f9eee3c6b25 | |
| 19:26:57 | sean-k-mooney | so ya one of the main deltas right now is microversion = None in _IntegratedTestBase and microversion = 'latest' in ProviderUsageBaseTestCase | |
| 19:27:29 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L978 vs https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L1075 | |
| 19:29:55 | gmann | both are used in same amount so it is like half of functional tests run with 'None' and half with 'latest' | |
| 19:30:33 | sean-k-mooney | many other set it expcitly | |
| 19:31:14 | sean-k-mooney | or dont use either | |
| 19:31:40 | sean-k-mooney | the last regression i wrote did not use either of the base classes since the kept getting rewritten | |
| 19:31:43 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1835822.py#L22-L23 | |
| 19:31:59 | gmann | running with 'latest' can give better coverage of latest code set and capture if something effecting functionality in latest (as new version on top of old one)code path | |
| 19:32:37 | sean-k-mooney | i think latest is generally more corerct unless you are testing older version explcitly | |
| 19:32:46 | sean-k-mooney | or testing something that is not version related | |
| 19:33:00 | sean-k-mooney | in which can none and latest are qually valid | |
| 19:33:17 | sean-k-mooney | if you use none it wont catch if a new cahnge alters the behavior | |
| 19:33:53 | sean-k-mooney | well it will if you alter it without actounting for microverison i guess | |
| 19:34:32 | gmann | correct. | |
| 20:52:08 | openstackgerrit | Merged openstack/python-novaclient master: Add a cleanup for a server in a functional test https://review.opendev.org/743589 | |
| 23:47:33 | brinzhang | gmann: we already introduced microversion in Ussuri, this is the patch https://review.opendev.org/#/c/696860/ | |
| 23:48:19 | brinzhang | gmann: I know this is still very simple and needs further optimization. If you have better suggestions, we are looking forward to it | |
| 23:52:50 | brinzhang | gmann: you are an expert in api, you can do the api change in cyborg too, and we will be very happy to see you improve this ^ | |
| #openstack-nova - 2020-07-29 | |||
| 01:56:50 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 08:01:11 | tony_su | stephenfin: really appreciate your detailed review and I uploaded the latest patch reflecting the latest comments. | |
| 09:15:23 | lyarwood | stephenfin: https://review.opendev.org/#/q/topic:bug/1889108 updated for your reviewing pleasure btw | |
| 09:15:30 | stephenfin | ta | |
| 09:21:24 | stephenfin | melwitt, dansmith: Haven't investigated yet, but nova-ceph-multistore is failing again on some jobs. Could be nothing but just FYI https://review.opendev.org/#/c/673341/54 | |
| 09:25:34 | lyarwood | https://zuul.opendev.org/t/openstack/build/0709ecfb37c54cb8813afb42aefe9097/log/controller/logs/screen-g-api.txt#12286 | |
| 09:25:49 | lyarwood | rbd.OSError: [errno 116] error removing image | |
| 09:26:05 | lyarwood | [errno 2] error removing snapshot b'snap' from b'39db07f4-d56b-47f2-b7c2-81d3d4e8707e' Snapshot does not exist. | |
| 09:26:09 | lyarwood | that's a better error | |
| 09:32:34 | stephenfin | lyarwood: done; some comments on the last one but other straight +2s | |
| 09:32:42 | stephenfin | swot | |
| 09:34:43 | lyarwood | https://github.com/openstack/glance_store/blob/100fe260bfb6698795ae5d6fce6aeadecbed1772/glance_store/_drivers/rbd.py#L385-L407 - odd, that should create a snapshot | |
| 09:34:47 | lyarwood | stephenfin: ta | |
| 09:36:16 | lyarwood | yeah I'll address that now | |
| 10:02:03 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Add live migration rollback volume attachment tests https://review.opendev.org/743534 | |
| 10:02:05 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Introduce a server_final_status kwarg to _IntegratedTestBase.live_migrate https://review.opendev.org/743710 | |
| 10:02:05 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Add CinderFixture to _IntegratedTestBase https://review.opendev.org/743535 | |
| 10:02:05 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/743319 | |
| 10:02:05 | openstack | bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 10:02:05 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression tests for bug #1889108 https://review.opendev.org/743289 | |
| 10:03:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Introduce a server_final_status kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710 | |
| 10:03:58 | lyarwood | stephenfin: ^ thanks again | |
| 10:06:54 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Introduce a server_final_status kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710 | |
| 10:34:02 | sean-k-mooney | anyone know if you can rebuild or resize vms in a shelved state? | |
| 10:35:39 | sean-k-mooney | if the answer was yes for both that would be really helpful. | |
| 10:49:53 | openstackgerrit | Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/720769 | |
| 11:11:58 | sean-k-mooney | that would be a no :( | |
| 11:57:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/738239 | |
| 11:57:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/738240 | |
| 11:58:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/738019 | |
| 11:58:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/738018 | |
| 11:58:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: objects: Add type hints https://review.opendev.org/738020 | |
| 12:16:31 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710 | |
| 12:20:06 | lyarwood | Does anyone have any ideas why this https://review.opendev.org/#/c/731506/ never ends up in the gate? | |
| 12:20:23 | lyarwood | I can't rebase it, it isn't in conflict etc | |
| 12:25:18 | stephenfin | lyarwood: possibly a bug in Gerrit? There is no Depends-On but it was based on a patch that has since been abandoned | |
| 12:25:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: As cellsv1 is no more fold _detach_volume back into detach_volume https://review.opendev.org/731506 | |
| 12:25:43 | stephenfin | that should do the trick | |
| 12:26:01 | stephenfin | lyarwood: Can you look at https://review.opendev.org/#/c/731506/ today? | |
| 12:26:10 | stephenfin | Also bauzas, perhaps? https://review.opendev.org/#/c/731506/ | |
| 12:27:37 | lyarwood | looking | |
| 12:29:01 | lyarwood | stephenfin: wait, that's the link to my change | |
| 12:29:09 | lyarwood | stephenfin: which review did you want me to look at | |
| 12:29:25 | stephenfin | doh | |
| 12:29:27 | stephenfin | https://review.opendev.org/#/c/743568/ | |
| 12:29:37 | lyarwood | stephenfin: and re https://review.opendev.org/731506 yeah I missed that it was still pointing at that change sorry | |
| 12:30:50 | stephenfin | all good | |
| 12:36:39 | lyarwood | stephenfin: done, LGTM, I guess func tests wouldn't make sense here given libvirt is acting up right? | |
| 12:36:56 | stephenfin | lyarwood: yes, that's my thinking too | |
| 12:49:43 | ralonsoh | stephenfin, hi! I you have some time: https://review.opendev.org/#/c/739961/ | |
| 12:52:31 | stephenfin | ralonsoh: Could we get some context in the commit message? | |
| 12:52:41 | stephenfin | i.e. what it's for and why it's needed | |