Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-23
15:49:15 bauzas right?
15:49:31 stephenfin or when creating the server, since we verify all these stuff there now
15:50:14 gibi nova meeting starts in 10 minutes on #openstack-meeting-3
15:50:21 stephenfin No, we don't currently consider new/modified flavor extra specs or image metadata properties as warranting a new API microversion
15:50:24 stephenfin If that's what you mean
15:50:35 stephenfin We would need to introduce a new service version
15:50:46 stephenfin and wait until all compute nodes have been updated to that service version
15:51:14 stephenfin Like commit 9ddc60539f53e24bb92ef711674f5be4c7c0bcc3 I mentioned above
15:52:46 bauzas stephenfin: I need to review the approved spec
15:57:17 bauzas heh, https://specs.openstack.org/openstack/nova-specs/specs/victoria/approved/add-emulated-virtual-tpm.html#upgrade-impact
16:00:09 gibi lyarwood: ack
16:33:11 bauzas stephenfin: I'll name you John Dorian
16:33:24 bauzas and I'm just your Dr Cox
16:36:18 gibi aaaan beertime
16:36:21 gibi see you tomorrow
16:36:43 bauzas ++ me too (well, I also need to go to my beer shop actually)
16:38:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995
16:39:02 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/742706
16:49:32 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: objects: Update keypairs when saving an instance https://review.opendev.org/742709
17:01:07 elod lyarwood: thanks for the release patch update, I've also updated it as I guess the latest stein patch was just accidentally missed (or am I wrong?) >>> https://review.opendev.org/#/c/741760/
17:04:31 lyarwood ah did I forget to fetch before I checked
17:04:36 lyarwood yeah I did
17:04:39 lyarwood sorry!
17:04:41 lyarwood elod: thanks for doing that
17:09:29 elod no problem, thanks for looking it :) tomorrow we'll get a PTL+1 as well \o/ (I added that to gibi's TODO list o:))
18:38:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of security_groups policies https://review.opendev.org/742726
20:03:52 openstackgerrit Merged openstack/nova master: libvirt: Use better variable names, types for '_create_guest' https://review.opendev.org/740945
22:13:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in security_groups policy https://review.opendev.org/742757
23:28:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763
23:34:27 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764
23:40:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of networks policies https://review.opendev.org/742558
23:40:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in networks policy https://review.opendev.org/742561
23:46:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
23:52:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in networks policies https://review.opendev.org/742566
23:53:31 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in networks policy https://review.opendev.org/742568
23:58:11 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
#openstack-nova - 2020-07-24
00:15:12 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771
00:18:49 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
00:19:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
00:19:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771
00:23:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in tenant networks policy https://review.opendev.org/742772
01:15:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of volumes policies https://review.opendev.org/742773
01:22:14 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in volumes policy https://review.opendev.org/742774
01:23:24 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763
01:23:31 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764
01:38:41 openstackgerrit Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
01:57:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in volumes policies https://review.opendev.org/742777
02:07:31 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in volumes policy https://review.opendev.org/742779
02:28:45 alex_xu stephenfin: gibi, I saw you mentioned the upgrade issue for provider config yaml. I didn't follow the spec discussion in the beginning, could you remind me what is about? then I think I can help tony_su go through the problem.
02:30:14 openstackgerrit Merged openstack/nova stable/stein: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729176
02:50:43 openstackgerrit Merged openstack/nova stable/ussuri: objects: Update keypairs when saving an instance https://review.opendev.org/742631
03:15:58 openstackgerrit Xinran WANG proposed openstack/nova-specs master: SRIOV SmartNic Support Specification https://review.opendev.org/742785
03:26:45 tony_su gibi: stephenfin: A status update for provider-config-file patches. I am handling your comments which are all valuable. Most of them are easy and okay to simply upgrade patches. But a few like refactor schema into code or add new test coverage require more consideration and more days ...
03:27:07 tony_su gibi: stephenfin: A status update for provider-config-file patches. I am handling your comments which are all valuable. Most of them are easy and okay to simply upgrade patches. But a few like refactor schema into code or add new test coverage require more consideration and more days ...
03:32:47 openstackgerrit Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
04:16:02 openstackgerrit Xinran WANG proposed openstack/nova-specs master: SRIOV SmartNic Support Specification https://review.opendev.org/742785
07:29:58 gibi tony_su: don't worry. I appreciate your work on that series and I will look at it when you are ready
07:31:03 gibi alex_xu: I'm not sure I can recall an upgrade issue in the provider config series (but it is Friday so my brain is already slow) do you have a reference?
07:32:30 bauzas gibi: do you know the answer of https://review.opendev.org/#/c/739211/5/nova/tests/unit/test_crypto.py@21
07:32:31 bauzas ?
07:32:44 gibi bauzas: looking...
07:32:44 bauzas that's an horrible import
07:34:25 bauzas hmmm, can't find a castellanclient kind of thing
07:34:40 gibi bauzas: does castellan just an interface and by having castellen we don't have to pull in whole key manager backend like barbican
07:34:43 gibi ?
07:35:02 bauzas I'm not a specialist of any OpenStack key manager
07:35:16 bauzas but if you're right, that explains my readings
07:36:02 bauzas mmmm https://docs.openstack.org/castellan/latest/user/index.html#basic-usage
07:36:07 bauzas looks you're right indeed
08:41:06 stephenfin bauzas, gibi: The fix for that o.vo version issue is here, btw https://review.opendev.org/#/c/742650/1
08:41:16 gibi stephenfin: thanks
08:42:09 stephenfin alex_xu: As gibi said, I don't think anyone noted any upgrade issues with provider.yaml. Perhaps you're confusing it with the investigation of upgrade issues bauzas was doing for the vTPM series?
08:43:24 gibi stephenfin: ahh, that was the upgrade discussion yesterday ^^
08:43:42 gibi I knew there was something
08:43:49 gibi I just did not remember what
08:45:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
08:46:16 alex_xu stephenfin: ah, thanks :)
09:23:55 openstackgerrit Merged openstack/nova master: scheduler: Request vTPM trait based on flavor or image https://review.opendev.org/739210
09:24:03 openstackgerrit Merged openstack/nova master: crypto: Add support for creating, destroying vTPM secrets https://review.opendev.org/739211
09:24:16 openstackgerrit Merged openstack/nova master: manager: Prevent compute startup on invalid vTPM config https://review.opendev.org/739212
09:24:27 openstackgerrit Merged openstack/nova master: tests: Rename tests for '_create_guest_with_network' https://review.opendev.org/740464
09:24:37 openstackgerrit Merged openstack/nova master: tests: Move single use constants to their callers https://review.opendev.org/741280
09:24:46 openstackgerrit Merged openstack/nova master: tests: Define constants in '_IntegratedTestBase' https://review.opendev.org/741281
09:24:55 openstackgerrit Merged openstack/nova master: tests: Remove 'test_servers.ServersTestBase' https://review.opendev.org/741282
09:25:02 openstackgerrit Merged openstack/nova master: tests: Add 'PlacementHelperMixin', 'PlacementInstanceHelperMixin' https://review.opendev.org/741283
09:25:13 openstackgerrit Merged openstack/nova master: tests: Make '_IntegratedTestBase' subclass 'PlacementInstanceHelperMixin' https://review.opendev.org/741284
09:31:04 stephenfin Holy s***, they all merged in one go. No CI failures :O
09:31:11 openstackgerrit Stephen Finucane proposed openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
09:31:54 gibi stephenfin: that was a nice set
09:31:58 stephenfin bauzas, gibi: Can you look at ^ again real quick? Turns out 'scp' cares about the order of arguments. CI caught it for us and will catch it again if it's wrong
09:32:10 stephenfin (from https://zuul.opendev.org/t/openstack/build/7e8c6c6ddaba44e09a90a847dfe6ee46/log/logs/screen-n-cpu.txt)
09:32:10 gibi stephenfin: looking
09:32:14 bauzas ack
09:32:14 stephenfin Thanks
09:32:49 stephenfin It did
09:33:05 bauzas hah
09:33:09 bauzas fwiw https://linux.die.net/man/1/scp
09:33:32 stephenfin I just thought it was intermittent failures and wasn't looking at it often enough to spot the trend :)
09:33:39 stephenfin zuul++
09:34:04 bauzas stephenfin: i don't see any required ordering with scp manpage

Earlier   Later