Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-15
16:11:26 sean-k-mooney which hook to run
16:11:36 sean-k-mooney but i think it got moved in repo a long time ago
16:14:26 sean-k-mooney dansmith: melwitt we used to do something like this https://review.opendev.org/#/c/701051/1/playbooks/legacy/tempest-dsvm-networking-ovs-dpdk/run.yaml@a58
16:15:08 sean-k-mooney we defiend a pre_test_hook or post_test_hook function
16:15:18 sean-k-mooney which was invoked by devstack gate if it existed
16:16:38 sean-k-mooney we still do that for the grenate multi node https://github.com/openstack/nova/blob/master/playbooks/legacy/nova-grenade-multinode/run.yaml#L57-L60
16:19:36 sean-k-mooney i may have missed the point of your question
16:19:50 sean-k-mooney dansmith: did any of ^ help
16:20:02 dansmith sean-k-mooney: on a call, biab
16:20:35 sean-k-mooney crap im ment to be on a call too i thnk
16:34:17 openstackgerrit Merged openstack/nova stable/ussuri: catch libvirt exception when nodedev not found. https://review.opendev.org/739593
17:24:31 openstackgerrit Merged openstack/nova stable/ussuri: Correct reported system memory https://review.opendev.org/740666
17:29:55 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
17:29:55 openstackgerrit Stephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova https://review.opendev.org/631363
17:29:56 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Move single use constants to their callers https://review.opendev.org/741280
17:29:56 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213
17:29:57 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove 'test_servers.ServersTestBase' https://review.opendev.org/741282
17:29:57 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Define constants in '_IntegratedTestBase' https://review.opendev.org/741281
17:29:58 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Make '_IntegratedTestBase' subclass 'PlacementInstanceHelperMixin' https://review.opendev.org/741284
17:29:58 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add 'PlacementHelperMixin', 'PlacementInstanceHelperMixin' https://review.opendev.org/741283
17:29:59 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285
17:30:00 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_domain' https://review.opendev.org/741286
17:30:23 stephenfin cleaning up after reverted resizes is hard work :(
17:31:25 gmann playbooks/nova-next/post.yaml which run that script (https://github.com/openstack/nova/blob/89e65bd976be8e02fdb6932bb710b5165d7e00a3/.zuul.yaml#L199)
17:31:25 gmann dansmith: melwitt sean-k-mooney nova-next is zuulv3 native jobs and d-g not in pic. d-g run post script for legacy jobs only. zuulv3 run three phase in order 1. 'pre-run' (in hierarchical inheritance order, parent >child) 2. 'run' (this is not run in inheritance order means only parent run if child define one). and last is 3 'post-run' (in hierarchical inheritance order, parent >child) here it trigger the
17:32:03 sean-k-mooney gmann: yep i know
17:32:12 dansmith gmann: ack, that's what I was suspecting,
17:32:21 dansmith that we had to call the post playbook, I didn't even look
17:32:53 dansmith I'm trying to get a glance job that will do some smoke testing of the devstack stuff, since baking devstack assumptions into tempest doesn't really matter
17:32:59 dansmith er, doesn't really make sense
17:33:18 dansmith and I just want to like validate that the cirros image got imported as expected, with auto-added metadata and stuff
17:33:30 dansmith and that's kinda like what we do in that post job where we check the db state
17:34:56 gmann dansmith: that is little tricky if you do in post pahse as parent post is run first where all logs etc are collected
17:35:02 sean-k-mooney ah ok you want to just dump some extra info after the job run so we can validate the setup was correct
17:35:21 dansmith sean-k-mooney: well, I want to validate it, not just dump it but yeah
17:35:35 sean-k-mooney gmann: isint our post job run before our parent
17:35:38 dansmith gmann: nova-next overrides post-run right?
17:35:55 sean-k-mooney i though it was like an onion or stack call
17:36:08 dansmith I don't care the order, as long as I can fail and cause the job to fail
17:36:30 sean-k-mooney all our parent pre playbooks run firrst then ours then the un playbook then post run in reverse order
17:36:31 gmann right child post-run playbook -> parent post-run playbook sean-k-mooney is right.
17:36:43 gmann so we are good to run in nova-next post
17:37:01 dansmith yeah, that's fine, I don't care the order
17:37:01 sean-k-mooney dansmith: the post playbook run regardless of if run passes or fails
17:37:14 sean-k-mooney but if a pre playbook fails wee dont run the run playbook
17:37:14 dansmith sean-k-mooney: right, but if post-run fails, the job will fail right?
17:37:17 dansmith like our db archive test
17:37:22 sean-k-mooney oh am yes
17:37:26 gmann yeas, it will cause job failure
17:37:32 dansmith right, I just want the job to fail if I decide
17:37:36 sean-k-mooney but you can ignore failure in the ansible playbook if you wan
17:38:00 sean-k-mooney e.g. the ansible task can be marked to ignore any failures
17:38:02 dansmith basically, I will configure glance to auto-add a piece of metadata to images that get added, and then in post, just check that the cirros image has that metadata set, and if not, explode
17:38:17 sean-k-mooney so you can decied if a taks should mark the post playbook as a failure or not
17:38:39 sean-k-mooney dansmith: yep that should be failrly simple
17:38:43 dansmith yup
17:39:10 sean-k-mooney you are already doing most of it with your multistore job
17:39:20 sean-k-mooney in this case you need to enable the metadata plugin
17:39:35 sean-k-mooney then have a post job that just checks for it
17:39:37 dansmith yup
17:39:44 dansmith but I'm going to do it for glance jobs, not mine
17:39:51 sean-k-mooney sure
17:39:52 dansmith just because they're not testing any of that stuff right now,
17:40:05 sean-k-mooney it would be nice to do multi store for them too
17:40:08 dansmith and it requires config, not something tempest can do, so I want to example them towards actually testing that stuff :)
17:40:24 dansmith I think we're going to make the nova job global so they can run it too, right gmann ?
17:40:31 gmann if you do it via role the nova or other job can reuse that
17:40:35 sean-k-mooney dansmith: it already is
17:40:43 sean-k-mooney they just need to add it to there check pipeline
17:40:50 sean-k-mooney any repo can run any others jobs
17:40:52 gmann dansmith: right, even on devstack-plugin-ceph gate
17:40:57 dansmith sean-k-mooney: well, not yet because it's not landed
17:41:04 dansmith but yeah
17:41:09 sean-k-mooney dansmith: it can with depend on but ya
17:41:18 dansmith well, anyway :)
17:41:32 sean-k-mooney zuul is awsome that way
17:59:31 openstack bug 1550919 in OpenStack Compute (nova) queens "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Elod Illes (elod-illes)
17:59:31 openstackgerrit Merged openstack/nova stable/queens: Add functional test for bug 1550919 https://review.opendev.org/732715
19:29:59 openstackgerrit Merged openstack/nova stable/queens: libvirt: Fix misleading debug msg "Instance is running" https://review.opendev.org/732716
19:56:42 artom mordred, just wanted to bring your attention to https://review.opendev.org/#/c/741295/ and the corresponding story
19:59:56 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: Reject boot request for unsupported images https://review.opendev.org/708609
20:52:30 openstackgerrit Sean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676
21:59:11 mordred artom: awesome - lgtm - thanks!
22:09:15 openstackgerrit Merged openstack/nova master: virt: Add 'context', drop 'network_info' parameters for 'unrescue' https://review.opendev.org/730382
22:27:20 prometheanfire it looks like it's just nova that fails with mock-4.0.2 https://review.opendev.org/741091
22:35:00 openstackgerrit Merged openstack/nova master: crypto: Add type hints https://review.opendev.org/739207
22:52:03 melwitt prometheanfire: will look
22:53:12 melwitt I wrote that test 😝
22:57:47 prometheanfire :D
#openstack-nova - 2020-07-16
00:42:37 rouk i cant seem to make nova-serialproxy work correctly past stein, on train it logs that its connecting to the backend, but my client gets punted. with "remote host closed connection: Connection is already closed"
00:43:13 rouk dont see any bugreports on it, and the logs are pretty silent, can anyone verify that it works for them on train?
01:02:44 openstackgerrit melanie witt proposed openstack/nova master: Use unittest.mock instead of mock in test_websocketproxy https://review.opendev.org/741351
01:45:03 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512
01:45:26 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565
01:45:37 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898
01:53:37 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
01:53:58 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
01:54:07 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
01:54:18 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
01:54:32 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109

Earlier   Later