Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-06-26
10:06:12 zigo gibi: With the test removed from oslo.utils, now I only got a single failure which seems to be an unrelated broken test (which I'm ok to just disable): http://paste.openstack.org/show/795250/
10:06:47 gibi zigo: OK. I will let you know if I found something on my side
10:21:11 gibi zigo: there are different versions in http://paste.openstack.org/show/795248/ and in qa-logs.debian.net/2020/06/20/nova_21.0.0-2_unstable.log
10:21:23 gibi like oslo.utils is 4.1.1 in http://paste.openstack.org/show/795248/
10:22:00 openstackgerrit Alexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread https://review.opendev.org/734776
10:22:10 gibi zigo: never mind a looked at the wrong file
10:23:50 gibi zigo: I found the problem
10:23:57 zigo :)
10:24:04 gibi zigo: you have mock==4.0.2 if I install that then I have the same failure
10:24:50 zigo Ok.
10:25:00 gibi zigo: openstack pins that to 3.0.5
10:25:01 gibi https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L168
10:29:41 zigo gibi: Any idea how to solve the problem with this new mock version then?
10:29:50 zigo I obviously can't get the sid package to downgrade ...
10:30:04 zigo I'll get in touch with the package maintainer still though.
10:30:27 gibi zigo: that is a good question, right now I don't
10:46:42 gibi zigo: this seems related https://github.com/testing-cabal/mock/issues/487
10:49:32 gibi reading that it seems it is an issue in the python standard mock lib
10:55:10 zigo Thanks for the investigations.
11:23:04 openstackgerrit Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189
11:24:03 aarents gibi: I just read meeting minutes, I added bp/max-concurrent-snapshots in runways, Thanks!
11:56:22 gibi zigo: looking at the python reference __getattr__ should raise AttributeError instead of ValueError if the attribute is not found on the object. So https://github.com/openstack/oslo.utils/blob/master/oslo_utils/fixture.py#L82 is wrong. If I change the exception type to AttributeError then the problem is gone
11:56:31 gibi aarents: ack. I will look at it
11:57:53 zigo gibi: I'll do that in the oslo.utils package then !
12:00:23 gibi zigo: I will file a bug to oslo.utils to fix this
12:05:19 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
12:43:47 jsuchome gibi: Hi, thanks for the review! However, the part about splitting somerefactoring into another the patch ... the first versions of the patch did not include the refactoring and it is only included as it was requested by someone else...
12:45:00 jsuchome I mean it's hard to please everyone...
12:50:32 sean-k-mooney jsuchome: well you could do the refactoring first then the functional chagne as the second patch right that would keep both happy
12:50:47 sean-k-mooney jsuchome: not actully sure what patch you are refering too but just a suggestion
12:51:47 jsuchome the direct-rbd download one...
12:51:55 jsuchome https://review.opendev.org/#/c/574301/
12:54:50 sean-k-mooney ah i see. i can kind of see why gibi asked for them to be seperate
12:55:04 stephenfin bauzas: Care to look at https://review.opendev.org/#/c/730865/ and the following two patches? Trivial cleanup
12:55:15 bauzas stephenfin: ack, sure
12:55:22 sean-k-mooney the content of _verify_and_write looks very similar to the previous cod ebut its not clear if the differences are due to the refactor or the patch
12:55:31 stephenfin ignore the failing test - it's not an issue (see the following patch)
12:56:12 sean-k-mooney jsuchome: at least not at a 30 second glance i could figure it out if i reviewed it properly just more mental load
12:58:35 jsuchome sean-k-mooney: I can understand that. It's only because I've seen it hundred times it does not seem weird to me
12:58:38 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/725932
12:59:05 stephenfin elod: I rebased https://review.opendev.org/#/c/725932/ to drop lyarwood's -W. Care to +W again?
12:59:55 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/738199
13:01:00 elod stephenfin: thanks, yes, let's +W it :]
13:02:04 elod there it is
13:02:33 stephenfin ta
13:03:37 elod np
13:04:59 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove custom comparison methods https://review.opendev.org/472285
13:12:15 openstackgerrit Merged openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698
13:12:22 openstackgerrit Merged openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699
13:12:40 openstackgerrit Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189
13:39:35 openstack Launchpad bug 1885281 in oslo.utils "uuidsentinel does not follow __getattr__ protocol" [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)
13:39:35 gibi zigo: bug https://bugs.launchpad.net/oslo.utils/+bug/1885281 bugfix https://review.opendev.org/#/c/738207/
13:42:28 openstackgerrit Merged openstack/nova master: Make libvirt able to trigger a backend image copy when needed https://review.opendev.org/656998
13:50:44 zigo gibi: Super cool ! :)
13:54:00 itandops hi all, I'm installing openstack with openstack-ansible and get this error during nova install http://paste.openstack.org/show/795265/
13:54:47 itandops Is it required to have Placement API or any suggestion to solve this please ?
14:00:26 gibi aarents: thanks for adding max-concurrent-snapshots into the runway etherpad. Just a note, next time please add your patches to the Queue section, then I will make the move to the runway slot
14:01:06 aarents gibi: noted
14:02:18 gibi jsuchome: as sean-k-mooney put it, it would be nice to have the refactoring in the first patch and then the feature implementation in another patch on top of the refactor
14:19:38 melwitt elod: I think you're likely right that the cherry pick check only works if the hash being looked for is in the local branch, I'm wondering if we need to add '-r' to the --contains command here https://github.com/openstack/nova/blob/4ae5b61c4f9819e26c13c147b46ab2344bd3cc3a/tools/check-cherry-picks.sh#L11 https://git-scm.com/docs/git-branch#Documentation/git-branch.txt--r cc gmann
14:27:47 elod melwitt: it seems that even the 'git show --format='%b' --quiet $1' gives empty result back
14:28:38 melwitt elod: oh... sorry I didn't realize that's what it's failing on. I'm stumped about that then :
14:28:42 melwitt :/
14:29:24 elod melwitt: https://zuul.opendev.org/t/openstack/build/490f4df6fc384d48ba895af3a9cf9862/log/job-output.txt#865-866
14:31:48 elod melwitt: might be that the way how the repo is cloned causes the weirdness: https://opendev.org/openstack/project-config/src/branch/master/roles/use-cached-repos/tasks/main.yaml
14:32:32 melwitt hrm
14:33:02 elod only the .git is there I guess
14:37:00 elod maybe if the patch is not on the top of the branch then it can just see a merge patch ( like http://paste.openstack.org/show/795267/ )
14:38:26 elod i've pushed a dummy patch to see what's there exactly: https://review.opendev.org/738189
14:48:45 elod but correct me if I'm on a wrong track or poking the obvious :]
15:03:43 gmann melwitt: elod : it is still issue, rebasing patches on top of script merged one works fine
15:03:57 gmann * it is still issue?
15:10:11 elod gmann: it is still an issue :( see, e.g.: https://review.opendev.org/#/c/736957/
15:11:21 gmann elod: its is working fine on 736957 right?
15:12:12 gmann as it got rebased on top of ussuri lates code which has script changes, script got all the hashes correctly.
15:13:30 elod gmann: it works fine when it is rebased
15:13:36 gmann yeah
15:14:12 gmann same like stable/train changes we rebased yesterday.
15:15:59 elod gmann: but currently it seems to me that the script works only if the patch is on top of the given branch
15:16:32 elod i might be wrong though
15:17:34 gmann elod: oh is it? or on top of where script merged.
15:18:22 gmann that I have not tested. do we have any such change on stable where it is on top of script-merged-change but not on latest branch changes
15:18:40 elod gmann: I've created this dummy patch: https://review.opendev.org/#/c/738189/
15:19:19 elod but it is on stein, where the script is not even merged yet
15:19:53 gmann yeah
15:20:46 gmann we can wait for either of these merge and then recheck on other before rebase - https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/ussuri
15:23:23 elod my thinking is what I wrote here: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-06-26.log.html#t2020-06-26T14:33:02
15:24:22 elod but that's also a good check what you are saying
16:07:37 openstackgerrit Elod Illes proposed openstack/nova stable/stein: DNM: debug check-cherry-picks.sh on gate https://review.opendev.org/738189
16:08:09 stephenfin bauzas: Got another one for you https://review.opendev.org/#/c/706013/
16:17:56 itandops hello folks any suggestion about my error ?
16:37:34 stephenfin gibi: comment on https://review.opendev.org/#/c/736167/
16:38:38 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/738019
16:38:38 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/738018
16:38:39 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/738239
16:38:39 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add type hints https://review.opendev.org/738020
16:38:40 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/738240
16:39:37 stephenfin itandops: That looks like placement isn't registered in the service catalog https://docs.openstack.org/keystone/latest/contributor/service-catalog.html
16:40:08 stephenfin Placement is mandatory from OSP 13 or so
16:40:10 stephenfin Sorry, Newton

Earlier   Later