| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-12 | |||
| 15:07:23 | sean-k-mooney | ok ill put up a DNM patch that disablel the unnned jobs and just disables using ceph for nova | |
| 15:07:28 | sean-k-mooney | then we can tweak that | |
| 15:07:35 | dansmith | jsuchome: not a direct test that confirms it was somehow downloaded direct -- that would be very hard | |
| 15:08:18 | jsuchome | true, tempest run should indeed be enough | |
| 15:08:37 | dansmith | (and logs) | |
| 15:08:57 | dansmith | jsuchome: if you think that you need to add some logs to be able to validate it from the outside, you should go ahead and do that | |
| 15:09:24 | dansmith | jsuchome: perhaps a LOG.debug('Downloading %(image)s from per-scheme handler %(handler)s') that we can look for | |
| 15:11:10 | jsuchome | There's already "Successfully transferred using rbd" log line | |
| 15:11:21 | dansmith | okay cool | |
| 15:11:26 | jsuchome | LOG.info I beleive | |
| 15:12:08 | dansmith | jsuchome: ah you mean the "attempting to export" one | |
| 15:12:17 | dansmith | oh, no, | |
| 15:12:20 | dansmith | I see that one too | |
| 15:12:26 | dansmith | okay cool, should be covered and easy to validate | |
| 15:17:25 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | |
| 15:18:12 | lyarwood | jsuchome / sean-k-mooney ; https://review.opendev.org/727225 might work | |
| 15:18:16 | sean-k-mooney | dansmith: so before i push this | |
| 15:18:31 | lyarwood | ah sorry you're also working on it | |
| 15:18:34 | lyarwood | I didn't think you were | |
| 15:18:49 | sean-k-mooney | that is updating the plugin | |
| 15:18:59 | sean-k-mooney | im working on a patch to do it for nova | |
| 15:19:17 | lyarwood | it's the same either way | |
| 15:19:19 | sean-k-mooney | did you need to make those nova con changes too | |
| 15:19:31 | lyarwood | well no, you'd just use the job in Nova | |
| 15:19:41 | lyarwood | this change already pulls in the Nova changes | |
| 15:19:45 | dansmith | jsuchome: I dunno where you got so much karma, but enjoy this overly exuberant clamor to help while you can :D | |
| 15:20:05 | lyarwood | I'm just trying to hack around with zuul as much as I can at the moment | |
| 15:20:25 | lyarwood | I've still got the live migrastion job migration to zuulv3 in my backlog | |
| 15:20:29 | lyarwood | migration* | |
| 15:20:56 | tosky | lyarwood: is there something specific in that job compared to a "usual" devstack job? Maybe I can help | |
| 15:21:23 | lyarwood | tosky: the LM jobs? | |
| 15:21:50 | tosky | lyarwood: that one (and in general any job that requires to move from legacy to native zuulv3) | |
| 15:23:16 | lyarwood | tosky: http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013207.html covers some of it, it's currently three jobs in one | |
| 15:23:51 | lyarwood | tosky: I ran out of time in U to break things up but feel free to poke the changes early in V if you have time before I get around to it | |
| 15:24:54 | tosky | lyarwood: sure - I will ping everyone with pending legacy jobs as part of the work on the community goal | |
| 15:25:09 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] ceph direct download testing https://review.opendev.org/727228 | |
| 15:25:29 | sean-k-mooney | ok well that is just push to have it there. it will do the excat same thing as lyarwood version | |
| 15:25:40 | sean-k-mooney | its just in nova rather then the devstack plugin | |
| 15:26:54 | lyarwood | tosky: ack understood thanks :) | |
| 15:31:13 | jsuchome | lyarwood: sean-k-mooney: thanks a lot ... so, where exactly do I set those nova+glance config values? under $NOVA_CPU_CONF for nova? And the one for glance? | |
| 15:32:49 | openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | |
| 15:35:49 | lyarwood | jsuchome: glance should be configured automatically, we only had to add the two specific configurables your change is using in Nova as we disabled the configuration of Nova by the ceph devstack plugin. | |
| 15:36:57 | lyarwood | just corrected a mistake in my change, I'll check back in on it later. | |
| 15:38:06 | jsuchome | lyarwood: for glance I need DEFAULT.show_image_direct_url=true, are you telling me this is set by default? | |
| 15:38:43 | sean-k-mooney | im not sure its in the base job | |
| 15:38:48 | sean-k-mooney | so we might need to set that | |
| 15:38:57 | jsuchome | that's what I would expect | |
| 15:38:58 | dansmith | jsuchome: I think it must be, otherwise nova wouldn't be able to tell that the image is in the same rbd it is configured for, with the rbd backend | |
| 15:39:31 | jsuchome | I see, so you mean it already _is_ default for ceph jobs? | |
| 15:39:33 | dansmith | i.e. we already look at the locations field of the image, that's what you need right? | |
| 15:39:36 | dansmith | jsuchome: I expect | |
| 15:39:41 | sean-k-mooney | dansmith: we only have one cluser set up by the plugin so that would not be an issue we would see in teh gate | |
| 15:39:58 | jsuchome | yes, that's for location | |
| 15:39:58 | dansmith | sean-k-mooney: if we look at the locations and require one that matches, it would | |
| 15:39:59 | sean-k-mooney | i.e. it will always be the same | |
| 15:40:00 | dansmith | but I'm looking | |
| 15:40:33 | sean-k-mooney | i mean its not hard to add but ill chekc the parent jobs and see if we are doing it or not | |
| 15:41:02 | sean-k-mooney | or actully the plugin is likely where that would be set | |
| 15:41:22 | dansmith | https://zuul.opendev.org/t/openstack/build/fbd122f546684ffebdca5f2f73b6167c/log/controller/logs/etc/glance/glance-api_conf.txt | |
| 15:41:23 | jsuchome | lyarwood: sean-k-mooney: also this for nova conf: glance.allowed_direct_url_schemes = rbd ... as this is (was! and should not be anymore) deprecated option, I would not expect it to be set | |
| 15:41:33 | dansmith | show_multiple_locations = True | |
| 15:41:49 | sean-k-mooney | https://github.com/openstack/devstack-plugin-ceph/commit/62ea04c8d180c5419300ddc7784c5c46f9fcbdad | |
| 15:42:02 | dansmith | I think ^ is what we need for the check we do | |
| 15:42:12 | dansmith | not sure the difference between that and the show-direct-url one | |
| 15:42:19 | dansmith | because, AFAIK, the locations are the direct url | |
| 15:43:11 | dansmith | ah, | |
| 15:43:12 | jsuchome | so show_multiple_locations also implies the location info is present? | |
| 15:43:18 | dansmith | that commit implies that one impliesthe other | |
| 15:43:19 | dansmith | yeah | |
| 15:45:46 | sean-k-mooney | lyarwood's job is curerntly running https://zuul.openstack.org/stream/9b459dcfc0cd46d0a13ce5a5a1be2afe?logfile=console.log so we will know one way or another in about an hour | |
| 15:45:56 | sean-k-mooney | maybe too | |
| 15:46:00 | sean-k-mooney | *two | |
| 15:46:22 | sean-k-mooney | but if we need to add anything else we can do that quickly once its done | |
| 15:47:08 | jsuchome | well that allowed_direct_url_schemes is a must, we only fire the new download handler if it is set | |
| 15:47:35 | sean-k-mooney | so we need that in nova i can see if that is set by the plugin | |
| 15:48:17 | dansmith | it won't be | |
| 15:48:23 | dansmith | I thought lyarwood did it in his change | |
| 15:48:47 | lyarwood | sorry I missed that | |
| 15:48:56 | lyarwood | [glance]/allowed_direct_url_schemes=['rbd']? | |
| 15:49:10 | sean-k-mooney | ya i was about to ask the same https://opendev.org/openstack/nova/src/branch/master/nova/conf/glance.py#L64 | |
| 15:49:32 | dansmith | lyarwood: not sure what group, but yes, hang on | |
| 15:49:53 | sean-k-mooney | its in the glance group | |
| 15:49:59 | jsuchome | yep | |
| 15:50:27 | sean-k-mooney | do we plan to turn this on by default | |
| 15:50:27 | dansmith | if 'rbd' in CONF.glance.allowed_direct_url_schemes: | |
| 15:50:36 | dansmith | no | |
| 15:50:49 | jsuchome | it should be documented | |
| 15:50:56 | sean-k-mooney | ok we proably should remove the deprecation of that option in jsuchome patch | |
| 15:51:01 | sean-k-mooney | i assume it already does that | |
| 15:51:22 | dansmith | the spec says we will undeprecate it yes | |
| 15:51:28 | sean-k-mooney | k | |
| 15:51:39 | jsuchome | does it need a release note? | |
| 15:51:46 | dansmith | yes | |
| 15:51:56 | sean-k-mooney | the feature would even without the undeprecation | |
| 15:52:01 | sean-k-mooney | the same one can cover both | |
| 15:52:39 | jsuchome | ok, than it's another change for 574301 | |
| 15:53:18 | dansmith | jsuchome: I probably wouldn't pile that in there personally | |
| 15:56:48 | jsuchome | OK, another patch, no problem | |
| 15:57:03 | dansmith | jsuchome: at least for the moment, we can always squash | |
| 15:57:24 | dansmith | I think that by the time you get all the test stuff in this patch it will be plenty meaty | |