| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-08 | |||
| 15:40:02 | gibi | stephenfin: if we don't do that then GET allocation_candidates query will return no canididates during scheduling so I think this needs to be considered as a typo | |
| 15:40:35 | gibi | I'm OK not to have the length requirement enforced that is harder to justify as a typo | |
| 15:43:12 | dansmith | melwitt: ack yep | |
| 15:43:43 | melwitt | danke | |
| 15:47:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 15:48:15 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 15:48:40 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | |
| 15:49:04 | dansmith | melwitt: commented on something, if you can link me to that quicker than I can find it that'd be helpful :) | |
| 15:50:25 | melwitt | yeah hang on | |
| 15:58:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 15:58:44 | stephenfin | gibi: done and done ^ | |
| 15:59:46 | gibi | stephenfin: ack | |
| 16:00:13 | gibi | will review before I leave today | |
| 16:03:27 | melwitt | dansmith: finally replied. tracing that always confuses me for whatever reason | |
| 16:09:00 | gibi | stephenfin: does the solution for https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1669 is to use different dest for the two flags? I'm failing to implement mutual exclusivity in 2.85 | |
| 16:09:56 | stephenfin | oh, so error out if e.g. both the 'config_drive' and 'no_config_drive' dests are set? | |
| 16:09:58 | gibi | most probably I've already fried my brain for today | |
| 16:10:04 | stephenfin | that would work | |
| 16:10:14 | stephenfin | let me try it | |
| 16:10:24 | gibi | stephenfin: I let you fix 2.83 while I do similar things for 2.85 | |
| 16:10:31 | stephenfin | ack | |
| 16:10:54 | stephenfin | bauzas: question at https://review.opendev.org/#/c/715489/8/nova/virt/libvirt/driver.py@6953 | |
| 16:13:15 | bauzas | stephenfin: thanks, replying | |
| 16:15:12 | bauzas | stephenfin: replied. | |
| 16:18:33 | stephenfin | bauzas: cool, thanks for the clarification | |
| 16:19:56 | bauzas | stephenfin: yeah sorry this patch is mostly a cleanup prep work | |
| 16:28:01 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in simple tenant usage https://review.opendev.org/717586 | |
| 16:28:05 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | |
| 16:28:24 | stephenfin | gibi: you'll probably want that for 2.85, assuming you like the approach ^ | |
| 16:28:37 | gibi | ack | |
| 16:33:25 | gibi | stephenfin: +2 | |
| 16:33:42 | stephenfin | \o/ | |
| 16:37:50 | gibi | stephenfin: and +2 on both of the extra spec FUPs | |
| 16:43:19 | bauzas | gibi: stephenfin: sorry I dropped my attention from the issue gibi found (thanks btw.!) but can I take a look at it now ? | |
| 16:43:28 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP: Support multiple vGPU types https://review.opendev.org/718516 | |
| 16:43:28 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | |
| 16:43:29 | stephenfin | yup, I think so | |
| 16:43:54 | bauzas | gibi: stephenfin: FWIW, I worked the func tests for verifying both types and provided a FUP based on lyarwood's comments ^ | |
| 16:44:24 | bauzas | I totally understand how vGPU in libvirt is old greek, that's why you can ask me for more functional testing if you want | |
| 16:45:27 | bauzas | gibi: FWIW, your reshape test also simulates a Train compute and I didn't had to change this reshape test (except where to call the config) for making it work, which proves I didn't regress | |
| 16:45:48 | bauzas | stephenfin: and ack, will review your last bits before I go | |
| 16:52:00 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP: Support multiple vGPU types https://review.opendev.org/718516 | |
| 16:52:00 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | |
| 16:52:54 | dansmith | melwitt: so, I didn't go looking, but where's the entrypoint for the thing when we're running underneath a proper WSGI server like apache or nginx? I'm guessing maybe that won't suffer from the same issue because it's forked from the main process before it gets to any nova/oslo stuff, but.. did you confirm? | |
| 16:55:04 | melwitt | dansmith: oh, no ... I had looked only at the nova/cmd because I was focused on nova-scheduler. hmm | |
| 16:55:42 | melwitt | but I'd guess the same | |
| 16:56:28 | dansmith | melwitt: okay one more comment on the wsgi service if you can look | |
| 16:56:39 | openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | |
| 16:56:42 | dansmith | not related to scheduler of course, but ... | |
| 16:57:00 | openstackgerrit | Merged openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | |
| 16:57:04 | gibi | stephenfin: 2.85 client patch enhanced by following your lead https://review.opendev.org/712651 | |
| 16:57:33 | gibi | and that marks the end of my day. | |
| 16:58:02 | stephenfin | I'm knocking off shortly. Will grab that before then (y) | |
| 16:58:43 | gibi | see you folks tomorrow o/ | |
| 16:58:45 | melwitt | dansmith: oh, dang, I had meant to add to WSGIService as well but it slipped my mind, likely because WSGIService derives from Service ... but it overrides start() so I need to | |
| 16:59:01 | dansmith | melwitt: yeah | |
| 16:59:10 | melwitt | ok lemme do that. thanks for catching | |
| 16:59:46 | bauzas | gibi: have a good one \o | |
| 17:00:02 | dansmith | melwitt: yeah you'd kinda assume it inherits from Service above, but not so much.. I've been burned by that one before | |
| 17:00:31 | melwitt | oh it doesn't lol ... even THAT burned me | |
| 17:00:37 | melwitt | service.Service vs Service | |
| 17:01:32 | openstackgerrit | Merged openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | |
| 17:02:29 | stephenfin | bauzas: loads of comments on https://review.opendev.org/#/c/715490/ for the morning | |
| 17:02:46 | bauzas | stephenfin: days are long at home | |
| 17:04:02 | openstackgerrit | Merged openstack/nova master: Support live migration with vpmem https://review.opendev.org/687856 | |
| 17:04:05 | bauzas | stephenfin: actually, looking at your comments and trying to get the main problems so I could fix them while you sleep | |
| 17:04:20 | bauzas | you said caching | |
| 17:04:31 | stephenfin | yeah, for the call to '_get_supported_vgpu_types' | |
| 17:04:31 | bauzas | but we already cache it per se | |
| 17:05:09 | bauzas | stephenfin: well, we now lookup self.supported_vgpu_types | |
| 17:05:15 | sean-k-mooney | if you need to cache things use functool.lru_cache decorator | |
| 17:05:18 | bauzas | which is instanciated at startup | |
| 17:06:06 | stephenfin | bauzas: you're right. Sorry, I missed that /o\ | |
| 17:06:44 | bauzas | stephenfin: no worries I'll address your comments tho | |
| 17:07:29 | bauzas | stephenfin: I just provided a mapping table lookup method for getting the vgpu type, that's probably what confused you | |
| 17:07:29 | stephenfin | cool. Happy to toggle when there's a follow up | |
| 17:07:33 | sean-k-mooney | bauzas: you did comment about not wanting to check the config too many times in a respocnc too lee which confused me a bit as ya its only don on agent start | |
| 17:07:56 | bauzas | sean-k-mooney: the comment was on the previous patch IIRC | |
| 17:08:02 | sean-k-mooney | yes | |
| 17:08:02 | bauzas | unless I'm wrong | |
| 17:08:18 | sean-k-mooney | but i have had that in my mind while reviing the followup | |
| 17:08:23 | bauzas | ok, so, the previous patch calls self._get_supported_types N times | |
| 17:08:42 | sean-k-mooney | e.g. that was something you were were concerned about so i am watching for that | |
| 17:08:56 | bauzas | but this patch introduces some startup call that instanciates an object in the driver | |
| 17:09:11 | bauzas | that's not really a cached object | |
| 17:09:18 | bauzas | ie. we don't need to update it | |
| 17:09:29 | bauzas | we just read it once at startup, that's it | |
| 17:09:45 | sean-k-mooney | yep which is fine | |
| 17:09:50 | bauzas | (and that's how folks I tried to avoid the known issue of cache invalidation) | |
| 17:11:21 | sean-k-mooney | yep but use to reiterate if people feel they need cacheing of functions now that we can depend on being python 3 we shoudl use https://docs.python.org/3/library/functools.html#functools.lru_cache | |
| 17:11:50 | bauzas | sean-k-mooney: gtk | |
| 17:12:38 | bauzas | ah, interesting | |
| 17:12:51 | sean-k-mooney | there is a backport in cachetools which is technically in the requirements repo but i never felt there was a justification for using it in nova as an extra dep | |
| 17:12:54 | bauzas | but I wouldn't use it for simple dicts | |
| 17:13:23 | bauzas | yeah, it's intended for large dicts with high access rate | |
| 17:13:35 | bauzas | hence the name FWIW | |
| 17:14:04 | bauzas | sean-k-mooney: and honestly, maybe just worth it for nova-api | |
| 17:14:30 | sean-k-mooney | there are other places where it makes sense | |
| 17:14:53 | sean-k-mooney | if we ever think maybe we should add a cache and go to add a maunal modle level dict | |
| 17:14:59 | sean-k-mooney | we shoudl see if this can be used instead | |