| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-08 | |||
| 13:52:51 | gibi | sean-k-mooney: ack. I meant that qos is using CUSTOM traits through the port not the flavor | |
| 13:52:52 | sean-k-mooney | oh you ment qos does not use them via flavor extra specs | |
| 13:52:56 | gibi | yepp | |
| 13:53:14 | gibi | I just type something crazy first :D | |
| 13:53:19 | gibi | typed | |
| 13:54:13 | sean-k-mooney | looking at the validator i dont see wher CUSTOM_ traits are being blocked | |
| 13:55:24 | sean-k-mooney | https://review.opendev.org/#/c/718357/5/nova/api/validation/extra_specs/traits.py is not blocking it anyway | |
| 13:55:40 | bauzas | sean-k-mooney: gibi: I have a functional test that proves it works :p | |
| 13:55:54 | bauzas | (adding custom traits to a flavor) | |
| 13:56:39 | sean-k-mooney | i think we have a couple actully | |
| 13:57:07 | sean-k-mooney | bauzas: dont we have one for the compute status trait | |
| 13:57:20 | sean-k-mooney | we used used a custom one breifly | |
| 13:57:21 | bauzas | sean-k-mooney: indeed, and we always ask for it | |
| 13:57:33 | bauzas | but that's not a custom one | |
| 13:57:41 | sean-k-mooney | not anymore | |
| 13:57:48 | bauzas | root_required=!COMPUTE_DISABLED or something like this | |
| 13:58:07 | bauzas | but that's 'root' required | |
| 13:58:16 | sean-k-mooney | matt used a custome one for dev i can recall if we merged it after the standard one was added and release in os-traits or not | |
| 13:58:21 | sean-k-mooney | we proably waited | |
| 13:58:30 | bauzas | I was afraid of custom traits on a child RP not being bobbled up to the tree for verification but it does work | |
| 13:58:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 13:58:39 | stephenfin | gibi: done ^ | |
| 13:59:15 | bauzas | I was able to tag CUSTOM_NVIDIA_XX on a child RP and just request this trait on a flavor which was getting me the right RP as a result | |
| 13:59:19 | sean-k-mooney | bauzas: yes if you add them to the unumbered group i think we check the tree | |
| 13:59:34 | bauzas | sean-k-mooney: that's what the api-ref says at least :) | |
| 14:00:06 | bauzas | https://docs.openstack.org/api-ref/placement/?expanded=list-allocation-candidates-detail#list-allocation-candidates | |
| 14:00:25 | bauzas | "Allocation requests in the response will be for resource providers that have capacity for all requested resources and the set of those resource providers will collectively contain all of the required traits. These traits may be satisfied by any provider in the same non-sharing tree or associated via aggregate. " | |
| 14:00:44 | bauzas | custom traits are just treated equally | |
| 14:01:04 | sean-k-mooney | yep | |
| 14:01:45 | gibi | stephenfin: ack, still someting feels wrong | |
| 14:01:46 | gibi | 'resource:CUSTOM_FOO': 'boo', | |
| 14:01:46 | gibi | body = {'extra_specs': { | |
| 14:01:46 | gibi | def test_create_invalid_resource_spec(self): | |
| 14:01:47 | gibi | }} | |
| 14:01:49 | gibi | self.admin_api.post_extra_spec(self.flavor_id, body) | |
| 14:02:05 | gibi | this should fail as 'boo' is not int, but it is accepted | |
| 14:02:14 | gibi | haven't checked the latest ps | |
| 14:03:05 | gibi | pulling it now | |
| 14:03:22 | stephenfin | gimme a few | |
| 14:05:16 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464 | |
| 14:06:07 | sean-k-mooney | gibi: are you useing the correct microversion | |
| 14:06:29 | gibi | sean-k-mooney: I'm using the functional test env | |
| 14:06:47 | gibi | sean-k-mooney: and that sets it to 2.86 | |
| 14:06:49 | sean-k-mooney | right well it might not be using the latest microverions | |
| 14:06:53 | sean-k-mooney | ah ok | |
| 14:06:56 | sean-k-mooney | https://review.opendev.org/#/c/704643/23/nova/api/validation/extra_specs/resources.py | |
| 14:07:03 | sean-k-mooney | so the valu is defiend as an int | |
| 14:07:16 | gibi | there are a bunch of tests alreay there that works as expected | |
| 14:07:36 | gibi | something is wrong with the parameterized namespaced keys | |
| 14:07:47 | sean-k-mooney | its possible that boo is being treated as hex | |
| 14:08:08 | sean-k-mooney | actully proably not | |
| 14:08:51 | gibi | yepp, it accepts not-an-int as well | |
| 14:09:06 | stephenfin | gibi: s/resource/resources/ | |
| 14:09:29 | gibi | /o\ | |
| 14:09:55 | sean-k-mooney | stephenfin: should your typo chekcing not catch that :P | |
| 14:10:11 | stephenfin | nope, it's an unknown namespace :) | |
| 14:10:25 | gibi | stephenfin: you are right. resources works as expected | |
| 14:10:30 | sean-k-mooney | ... oh because we are droping ?validation | |
| 14:10:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 14:12:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | |
| 14:13:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM test stable rescue tempest/devstack changes https://review.opendev.org/700815 | |
| 14:21:07 | gmann | stephenfin: on extra spec tempest failure. new validation is with microversion right? and old microversion keep accepting the invalid things as they were ? | |
| 14:21:22 | stephenfin | gmann: Correct | |
| 14:22:04 | gmann | in that case tempest should not fail | |
| 14:22:36 | stephenfin | Oh, does Tempest default to the oldest microversion? | |
| 14:23:02 | stephenfin | Somewhat related, that change is actually not critical now since we've changed how validation works. Now we only care about known namespaces (e.g. 'hw:') | |
| 14:23:20 | gmann | yeah, 2.1 is default | |
| 14:23:58 | stephenfin | Ah, I wonder if one of the gate jobs was setting a higher default because I thought I saw failures early on | |
| 14:24:21 | stephenfin | before we changed to the current namespace-only model, that is | |
| 14:25:01 | gmann | i do not think we have any job run with latest. all microversion tests are with cap. | |
| 14:25:43 | gmann | but uncapped tests can be run with any microversion via configuration. so your change lgtm overall. I was curious if nova code is blocked due to tempest things | |
| 14:31:04 | gmann | stephenfin: +A on tempest fix. | |
| 14:32:20 | aarents | Hi there, I'm wondering if someone can evaluate this: https://review.opendev.org/#/c/717037 it's about a space available calucation issue during host periodic task | |
| 14:32:27 | gmann | stephenfin: can you review this policy warning things on olso.policy - https://review.opendev.org/#/c/717879/2 | |
| 14:37:24 | gmann | gibi: stephenfin : RE on config-drive things. sorry i could have hold +W. not allowing that filter for now or just allow as bool (what stephenfin proposal) make more sense. | |
| 14:38:06 | gibi | gmann: no worries | |
| 14:38:10 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | |
| 14:38:17 | stephenfin | gmann: Good timing :) ^ | |
| 14:38:23 | stephenfin | Looking at that oslo patch now | |
| 14:38:33 | gmann | thanks. checking.. | |
| 14:39:14 | bauzas | aarents: we're very close to FF, could you please ping us this one on Friday ? | |
| 14:39:49 | aarents | bauzas: sure | |
| 14:40:14 | gibi | bauzas: will you work on this Friday? | |
| 14:40:34 | bauzas | gibi: yup, our bank holiday is usually Monday | |
| 14:40:42 | bauzas | (only I mean) | |
| 14:40:46 | bauzas | gibi: you ? | |
| 14:40:56 | bauzas | Friday and Monday ? | |
| 14:40:58 | gibi | interesting we have both Friday and Monday off due to easter | |
| 14:41:48 | bauzas | heh, of course France only has a very few PTO days | |
| 14:41:55 | bauzas | poor of us | |
| 14:42:58 | stephenfin | :P | |
| 14:43:02 | gibi | :P | |
| 14:43:07 | aarents | :) | |
| 14:43:18 | bauzas | wait for May, dudes, wait for May... | |
| 14:43:51 | lyarwood | ha | |
| 14:44:09 | bauzas | actually, that makes a good call, Easter makes difficult any potential exception we could make | |
| 14:44:20 | bauzas | as it would differ for at least 2 working days | |
| 14:44:33 | bauzas | haven't realized that | |
| 14:48:43 | gmann | gibi: stephenfin how about not exposing non-working option --no-config-drive https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1561 | |
| 14:49:23 | gmann | or we should say something about non-working in help message so that users would get false un-filtered servers list | |