Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-03
11:07:17 stephenfin Mostly. You don't need to specify it twice since they say the same thing now, right?
11:07:31 happyhemant yeah
11:07:48 happyhemant thats my question shall specify it one time ?
11:08:23 stephenfin just once, yeah
11:09:05 happyhemant stephenfin: cool will let you know if it works or not
11:21:39 happyhemant stephenfin: i think the conf is not good for me i am missing something ` Invalid PCI devices Whitelist config: Invalid entry: 'map[physical_network:public product_id:0720 vendor_id:10df]'`
11:22:40 happyhemant `passthrough_whitelist: [{ "physical_network": "public", "vendor_id":"10df", "product_id":"0720" }]`this is what i have right now
11:23:18 stephenfin I'm assuming you're using some deployment too. Does it need to be escaped or anything, seeing as it's JSON in a string
11:25:16 happyhemant yes i am using deployment https://www.irccloud.com/pastebin/Uu9vQV2e/
11:26:17 happyhemant i have no idea tbh
11:31:46 stephenfin happyhemant: Can you put that into a string
11:31:55 stephenfin so passthrough_whitelist: '[{ "physical_network": "public", "vendor_id":"10df", "product_id":"0720" }]'
11:32:07 stephenfin (notice the extra quotes)
11:32:26 happyhemant stephenfin: heyy i think i found out i was missing '' this :(
11:32:30 happyhemant my bad sorry
11:33:12 happyhemant missing quotes sometimes blows your mind :D
11:39:09 happyhemant https://www.irccloud.com/pastebin/etoeESAh/
11:39:54 happyhemant stephenfin: i created two instances but result is still the same :( https://www.irccloud.com/pastebin/9xC23uMj/
11:40:16 stephenfin Damn. What are the logs saying?
11:40:46 stephenfin and how are you creating the ports and instances? openstackclient? Can you share the commands you're executing?
11:40:56 happyhemant nova-conductor https://www.irccloud.com/pastebin/UnFf1AUh/
11:41:04 happyhemant yes using openstackclient
11:41:40 stephenfin what about nova-scheduler?
11:42:20 happyhemant nova-schedular https://www.irccloud.com/pastebin/1cafm67C/
11:43:19 happyhemant for creating instance i have some script https://www.irccloud.com/pastebin/GNNjRZbJ/
11:43:47 happyhemant so at the end i do `create_sriov <name> <flavor-name>`
11:46:42 stephenfin happyhemant: Okay, unfortunately I'm not sure how much debug logging there is for this stuff so you might need to hack on the code a little to figure out what's going wrong. It's a misconfiguration but I can't figure out where :-\
11:47:26 stephenfin happyhemant: The code you want is in 'nova/pci/stats.py'. The 'PciPassthroughFilter' calls that
11:49:32 stephenfin happyhemant: If you go stick in a load of debug logging in that file, restart the services and then try again, you should be able to grok what's going on. For example, it would be good to ensure '_filter_pools_for_spec' is returning something https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L328
11:50:20 stephenfin so literally add 'LOG.debug('Got matching_pools: %r', matching_pools)' after that line
11:50:52 stephenfin ditto for every other 'matching_pools' assignment. That will let us figure out what's causing the PCI devices to be dropped
11:52:07 happyhemant stephenfin: thanks stephenfin again i will dig in more into that code i am not much familiar but will try to find out. Btw i use the same config with queens and it worked for me without any error
11:52:24 stephenfin what version are you on now?
11:52:41 happyhemant i am using master branch
11:53:42 stephenfin yeah, not a lot has changed there in a few releases. The only changes we made was the ability to configure NUMA affinity, but that won't affect you since you're not using that feature
11:53:57 stephenfin hence my thought that it's some configuration issue that we just haven't spotted
11:54:05 stephenfin anyway
11:54:49 happyhemant no problem but let me know if you find something and bon appetit
11:55:03 happyhemant i will try to dig in more
13:09:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: WIP: Hey let's support routed networks y'all! https://review.opendev.org/656885
13:18:30 Sundar dansmith, sean-k-mooney, gibi, efried, brinzhang: Re. https://review.opendev.org/#/c/674726/3/nova/exception.py@159 , if the client attempts an operation despite documentation that it is unsupported, is that not a client error?
13:21:44 gibi Sundar: for me it is a client error. but I have no hard oppinion on 400 or 403 both works for me
13:21:51 gibi alex_xu: ^^ ?
13:22:18 brinzhang_ gibi, Sundar, me too.
13:22:34 brinzhang_ 400 or 403 all works good for me
13:26:09 Sundar gibi, brinzhang_: It is currently handled in https://review.opendev.org/#/c/674726/3/nova/api/openstack/compute/servers.py@758 . However, the resulting error code is not 403, but is 500. I am still looking into that. Off the top of your head, do you see why?
13:27:46 gibi Sundar: are you sure that you hit Line 760 in your test?
13:30:32 gibi Sundar: as at a first glance your code looks correct
13:31:01 Sundar30 Sorry, got disconnected due to network issues.
13:31:54 gibi 14:30 < gibi> Sundar: as at a first glance your code looks correct
13:31:54 gibi 14:27 < gibi> Sundar: are you sure that you hit Line 760 in your test?
13:33:28 Sundar30 gibi: I'll double check that. Without that, one should have got 403 error code.
13:34:08 Sundar30 Back in 10 min.
13:36:16 gibi Sundar30: I'm on a meeting for 90 minutes so it will take time to answere
13:39:20 brinzhang_ Sundar30: How about inherit Forbidden class? it's code also 403, and your case is suitable for Forbidden, just need to override msg_fmt, do you think so?
13:42:51 brinzhang_ Sundar30: checked again, as gibi said, your code look correct, the phenomenon you said is strange
13:44:42 Sundar30 Back. Let me try some things.
14:36:05 openstackgerrit Brin Zhang proposed openstack/nova master: Store instance action event exc_val fault details https://review.opendev.org/694428
14:36:06 openstackgerrit Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
14:43:46 openstackgerrit Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
14:55:13 happyhemant stephenfin: hey hi again do you think `LOG.debug('Got matching_pools: %r', matching_pools)` after every matching_pools and building its image will help getting detailed logs ?
14:56:50 dansmith Sundar30: have you gone through the multinode test to look at the failures?
14:57:19 dansmith Sundar30: some stuff in there makes sense, live migration and such, but some other things are blocked that seem like they shouldn't be
14:57:40 dansmith actually, now that I say this I wonder if these are old results
14:58:14 dansmith ah yeah, from yesterday before you pushed
14:58:51 Sundar30 dansmith: Yea, I have updated the patches. Where do you see the multinode results?
14:59:00 dansmith I just rechecked it so we can get the updates
14:59:06 dansmith Sundar30: https://review.opendev.org/#/c/709641/6
15:00:20 Sundar30 Good
15:03:03 Sundar30 dansmith: We discussed https://review.opendev.org/#/c/674726/3/nova/exception.py@159 earlier today. Are you ok with 403 error code?
15:04:41 dansmith 403 means "forbidden despite proper authorization", which to me could mean "you're not allowed to do this with this thing", which seems perfectly appropriate to me
15:04:52 dansmith I'm also fine with 400, but I definitely don't think 403 is wrong
15:05:45 stephenfin happyhemant: It should help, yes
15:08:03 happyhemant stephenfin: ok thanks so i actually started building new image lets see what we see but i am done for today so will let you know about it tomorrow. Tbh i am completely lost cause of it and doing some silly stuff i hope it will get fixed tomorrow or soon :(
15:24:23 openstackgerrit Dan Smith proposed openstack/nova master: Fix two test cases that use side effects in comprehensions https://review.opendev.org/711039
15:51:27 dansmith gibi: I went through the bottom chunk of the cyborg patches yesterday and many of my concerns have been resolved,
15:51:35 dansmith but I need to focus on the higher ones and the test results still
15:51:51 dansmith Sundar revised the set between yesterday and today too
15:52:02 dansmith have you looked recently and/or how are you feeling on it?
15:56:04 gibi I haven't looked that recently. But I planning to
15:57:04 gibi I can try to get a look through tomorrow morning
15:59:12 dansmith gibi: cool.. I think test coverage is still a problem, even in some of the cases you've already pointed out, but I've tried to continue to hammer on that
16:03:04 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812
16:03:04 openstackgerrit Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811
16:03:05 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430
16:03:05 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429
16:03:06 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
16:03:06 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
16:04:50 gibi dansmith: ack
16:05:41 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050
16:18:36 mriedem lyarwood: beware this https://review.opendev.org/#/c/710861/
16:20:16 lyarwood mriedem: oh fun
16:20:43 lyarwood mriedem: thanks for the heads up
16:22:45 openstack Launchpad bug 1788014 in OpenStack Compute (nova) rocky "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,Triaged]
16:22:45 mriedem found the related bug https://bugs.launchpad.net/nova/+bug/1788014 so i -1'ed that backport
16:22:54 mriedem looks like the fix never made it to rocky though so it's still an issue there
16:24:43 lyarwood \o/ thanks
17:36:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: WIP: Hey let's support routed networks y'all! https://review.opendev.org/656885
17:37:00 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support routed net during cold migration https://review.opendev.org/711071
19:35:31 openstackgerrit Michael Bayer proposed openstack/nova master: Remove oslo_db.sqlalchemy.compat reference https://review.opendev.org/711093

Earlier   Later