| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-06 | |||
| 09:33:33 | ralonsoh | I would like to confirm that in the logs | |
| 09:39:08 | ralonsoh | stephenfin, https://7147d7e07a0a4e67ee4e-8dbb68c995c97f9fb5b4258bb26a4c49.ssl.cf2.rackcdn.com/703537/7/check/neutron-ovn-tempest-ovs-release/7b55444/controller/logs/screen-n-api.txt | |
| 09:39:27 | ralonsoh | we are creating IPs without any port associated | |
| 10:05:57 | stephenfin | ralonsoh: What happens if I do 'list_ports(ids=['foo'])' and 'foo' doesn't exist? | |
| 10:06:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't error out on floating IPs without associated ports https://review.opendev.org/706213 | |
| 10:06:19 | stephenfin | I assume I'll just get an empty response, i.e. {'ports': []} | |
| 10:06:34 | stephenfin | ralonsoh, gibi: That's the fix, btw ^ | |
| 10:08:19 | ralonsoh | stephenfin, yes, you have an empty list | |
| 10:08:33 | ralonsoh | show_port will return an exception | |
| 10:08:39 | ralonsoh | list_ports don't | |
| 10:08:50 | stephenfin | cool, that's what I'd assumed in that patch | |
| 10:16:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework how we check for extensions https://review.opendev.org/705792 | |
| 11:09:01 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Rename _is_storage_shared_with to _is_path_shared_with https://review.opendev.org/693337 | |
| 11:09:14 | lyarwood | stephenfin: ^ can you +W that again, had to rebase to clear the conflict. | |
| 11:09:30 | stephenfin | done | |
| 11:10:05 | lyarwood | ta | |
| 11:11:25 | gibi | stephenfin: a floating ip without a port is an unused floating ip? | |
| 11:11:55 | openstackgerrit | Guo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120 | |
| 11:12:04 | stephenfin | gibi: Yup. We're using | |
| 11:13:11 | stephenfin | ...it for the 'GET /os-floating-ips' API, and that describes itself as "Return(ing) a list of floating IPs allocated to a project." | |
| 11:13:21 | gibi | cool, thanks | |
| 11:24:34 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844 | |
| 11:25:45 | brinzhang | gibi, lyarwood: this is my spec's invalid link fix patch https://review.opendev.org/#/c/705933/, please review | |
| 11:27:19 | openstack | bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,In progress] https://launchpad.net/bugs/1663456 - Assigned to Brin Zhang (zhangbailin) | |
| 11:27:19 | brinzhang | gibi, lyarwood: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1663456 this is the bug 1663456 fix, one is +2 by stephenfin | |
| 12:09:25 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add server actions v82 samples test https://review.opendev.org/706251 | |
| 12:16:49 | gibi | stephenfin: fyi if you need I can reproduce the stestr bug https://github.com/mtreinish/stestr/pull/285 in a pretty stable way in nova | |
| 12:17:53 | stephenfin | gibi: I had this https://review.opendev.org/#/c/700522/ | |
| 12:31:22 | gibi | stephenfin: you won :) | |
| 12:31:38 | gibi | stephenfin: is there a way I can help the stestr fix merged? | |
| 12:34:05 | artom | stephenfin, left you a drive-by comment on https://review.opendev.org/#/c/705792/3 | |
| 12:37:12 | openstackgerrit | Arnaud Morin proposed openstack/nova master: Force refresh of instance info cache on event https://review.opendev.org/702394 | |
| 12:55:01 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | |
| 13:07:30 | kashyap | stephenfin: Thanks for taking time to address your own nits here! https://review.opendev.org/#/c/693844/ | |
| 13:08:00 | kashyap | stephenfin: For future, don't worry about it. I don't consider it "tedious" to adddress reviewer's feedback (and yours fall "within reason" almost always) :-) | |
| 13:08:55 | kashyap | Appreciate it regardless. Ah, I see that in some places I've used single back ticks instead of the double back ticks | |
| 13:15:45 | gibi | efried: I cannot join to the today's nova meeting as I have a F2F meeting at the same time | |
| 13:51:04 | stephenfin | gibi: Other than annoying mtreinish and lifeless, probably not :) | |
| 13:51:12 | gibi | :) | |
| 13:51:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework how we check for neutron extensions https://review.opendev.org/705792 | |
| 13:51:57 | stephenfin | artom: oh yeah, done | |
| 13:52:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix Instance.obj_what_changed behavior for the "extra" field https://review.opendev.org/706267 | |
| 13:52:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix obj_what_changed for InstancePCIRequests ovo https://review.opendev.org/706266 | |
| 13:54:08 | brinzhang | stephenfin: hi, I have a question with the cmd.test_policy, https://github.com/openstack/nova/blob/master/nova/tests/unit/cmd/test_policy.py#L119 | |
| 13:55:17 | efried | gibi: specifically for that one patch the important thing was seeing how the steps taken to extract device profiles and convert them into resource requests correspond to the same steps for bandwidth resources. | |
| 13:55:47 | efried | gibi: I put a patch above that one that moved some of that stuff around, would be nice to get your nod on that. | |
| 13:55:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Selectively refresh instance.pci_requests during rollback https://review.opendev.org/706269 | |
| 13:55:54 | brinzhang | stephenfin: I added a new policy to the os-instance-action https://review.opendev.org/#/c/706179/2/nova/policies/instance_actions.py@27, but while run the unit test in cmd.test_policy, it was failed, and the "passing_rules " cannot get the new rule 'os_compute_api:os-instance-actions:show_details | |
| 13:56:05 | gibi | efried: ack, I will try to review those | |
| 13:56:41 | brinzhang | stephenfin, eric: I saw this file was changed or add by you (from github), can you give me some idea? | |
| 13:56:59 | brinzhang | efried | |
| 13:59:40 | efried | me? | |
| 13:59:56 | sean-k-mooney | you :) | |
| 14:00:37 | gibi | dansmith: I spent time on the selective refresh of instance.pci_requests based on obj_what_changes(), see the my stab at it here https://review.opendev.org/#/c/706269/1/nova/compute/manager.py@8566 and in the parent patches | |
| 14:02:22 | brinzhang | efried: yeah, but it's in two years ago :) | |
| 14:03:00 | efried | brinzhang: ping me after the nova meeting | |
| 14:04:07 | brinzhang | efried: ok, I am looking into the "def _check_filter_rules()", but cannot get some useful info, need some help :) | |
| 14:06:05 | efried | brinzhang: if this is a policy thing, I'm definitely not the best person to ask. Have you checked with gmann? | |
| 14:06:16 | efried | johnthetubaguy would also be a good resource if he's around... | |
| 14:14:56 | openstackgerrit | sean mooney proposed openstack/nova-specs master: move implemented spec for train https://review.opendev.org/706276 | |
| 14:18:46 | umbSublime | o/ | |
| 14:29:00 | dansmith | gibi_on_call: re: cyborg, know that I'm about +2 on the rest of the set aside from the second patch I've been deferring to efried on.. hopefully no major concerns as it's been a looong road :) | |
| 14:30:38 | bauzas | efried: you're always using this acronym : NTF | |
| 14:30:49 | bauzas | what's this ? | |
| 14:31:55 | efried | bauzas: NumaTopologyFilter, sorry | |
| 14:32:04 | bauzas | oh ah | |
| 14:32:08 | bauzas | gdi | |
| 14:32:12 | bauzas | thanks | |
| 14:38:31 | artom | stephenfin, cheers! I'll do a proper review soon | |
| 14:49:02 | bauzas | sean-k-mooney: question for you | |
| 14:49:28 | bauzas | sean-k-mooney: if I want 8VCPUs, 8GB of RAM and hw:numa_nodes=2 | |
| 14:49:35 | bauzas | does my memory split in twice ? | |
| 14:51:27 | sean-k-mooney | yes and if you cant devidie the vcpus and ram an integage number of times it raise an error | |
| 14:51:41 | sean-k-mooney | so if you didn 8VCPUs, 8GB of RAM and hw:numa_nodes=3 | |
| 14:52:04 | sean-k-mooney | then its an error unless you also use the other args for asymetric numa toplogies | |
| 14:52:24 | bauzas | what kind of error ? | |
| 14:54:00 | bauzas | sean-k-mooney: it only tells that it raises an exception in https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs | |
| 14:54:30 | brinzhang | gmann: are you around? | |
| 14:55:28 | sean-k-mooney | yes it raise an exception and the vm goes to error state | |
| 14:56:10 | sean-k-mooney | bauzas: actully the vm wont go to error | |
| 14:56:22 | sean-k-mooney | it will rais the excptionin the api before we create teh vm db record | |
| 14:56:33 | bauzas | cool, that's what I hoped | |
| 14:56:37 | bauzas | a synchronous 40x | |
| 14:56:53 | sean-k-mooney | proably a 400 bad request | |
| 14:56:57 | bauzas | because we also need to make it for the translation mechanism | |
| 14:57:03 | bauzas | ideally, same exception | |
| 14:57:03 | sean-k-mooney | a 4xx for sure | |
| 14:57:30 | brinzhang | efried: how about now? :) | |
| 14:57:32 | sean-k-mooney | ya so this is all handeled in the hardware.py module | |
| 14:57:46 | sean-k-mooney | and its reused in several places | |
| 14:58:23 | efried | brinzhang: for which? The spec review? | |
| 14:58:56 | sean-k-mooney | bauzas: its all handeled by https://github.com/openstack/nova/blob/014c1ab864cec6213750c5ef57d8080ae8cd973d/nova/virt/hardware.py#L1742 | |
| 14:59:00 | brinzhang | efried: I added a new policy to the os-instance-action https://review.opendev.org/#/c/706179/2/nova/policies/instance_actions.py@27, but while run the unit test in cmd.test_policy, it was failed, and the "passing_rules " cannot get the new rule 'os_compute_api:os-instance-actions:show_details | |
| 14:59:24 | bauzas | sean-k-mooney: thanks, looking | |
| 14:59:38 | bauzas | okay, will look | |
| 14:59:54 | brinzhang | efried:https://github.com/openstack/nova/blob/master/nova/tests/unit/cmd/test_policy.py#L119 the check function is here | |
| 15:00:18 | Sundar | creating ARQs, etc. Do you agree? | |
| 15:00:18 | Sundar | efried, dansmith, sean-k-mooney: Re. https://review.opendev.org/#/c/631243/55/nova/accelerator/cyborg.py@86, I am adding checks for keystone exceptions here. However, if this 'get device profile' call fails, there will be no further calls to Cyborg for that instance. So, there is no point in adding redundant exception checks to other calls for | |
| 15:00:48 | sean-k-mooney | bauzas: the importnt bit for you is https://github.com/openstack/nova/blob/014c1ab864cec6213750c5ef57d8080ae8cd973d/nova/compute/api.py#L925 in _validate_and_build_base_options | |
| 15:01:15 | dansmith | Sundar: you should assume every call to another service could fail | |