Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-31
15:33:51 gmann and i abandon this which were removing the user_id from policy target. test in 70629 should keep working for user enforcement through out the policy changes - https://review.opendev.org/#/c/701642/1
15:34:27 melwitt k makes sense
15:43:28 openstackgerrit Merged openstack/nova stable/stein: FUP for in-place numa rebuild https://review.opendev.org/702974
15:46:13 openstackgerrit Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
15:46:23 melwitt gmann: reviewing https://review.opendev.org/705135 I'm wondering if we should add a policy test for "fails with other project" (the testing that was originally missing the bug)
15:48:05 gmann melwitt: I am adding those in this where tests failing now and with this fix it should pass - https://review.opendev.org/#/c/705126/
15:48:24 gmann i need to rebase that on top of fix to show the test passing. is that fine ?
15:48:37 melwitt yeah, was just about to ask that
15:49:00 gmann ok
15:49:41 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix os-attach-interfaces policy to be admin_or_owner https://review.opendev.org/705135
15:49:52 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127
15:50:08 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126
15:50:17 gmann done.
15:50:40 melwitt thanks!
15:52:18 efried sean-k-mooney: if you're about, would you please confirm that https://review.opendev.org/#/c/702981/ is correct, and I'll send it
15:52:56 sean-k-mooney ill take a look now
15:56:28 sean-k-mooney efried: so an exception will be raised if the pagesize is not supported. so if we get to that line i think it means we dont have enough left of that size based on https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L660 im just reading futher
15:59:03 efried It's a debug log, so I'm not going to make a big deal out of it. I'll fast approve if it's correct. If it's an improvement, that'd be even better :)
15:59:28 cmurphy gmann: thanks, will review again today
15:59:40 gmann cmurphy: thanks
15:59:59 sean-k-mooney well it depens on how you interpert support. it cant suport the request. because its out of space. that is how that was intended to be interpreted
16:00:18 sean-k-mooney efried: im leaving a comment now but i think we can just change the message to
16:00:53 sean-k-mooney remove the or
16:01:40 sean-k-mooney e.g. "Host does not support requested memory pagesize as there are not enough free pages."
16:02:47 efried ack, thanks sean-k-mooney
16:04:13 stephenfin what other stable core can I annoy to merge this? https://review.opendev.org/#/c/663888/
16:04:20 stephenfin it's been open for aaaaaaages
16:06:43 sean-k-mooney stephenfin: you can try annoying dansmith but im not sure that will end well for you :P
16:06:52 sean-k-mooney although technically no
16:07:05 sean-k-mooney since that would be 3 form redhat
16:08:21 melwitt I'd ping elod to review (I hope that's his nick)
16:08:34 sean-k-mooney tonyb: johnthetubaguy can you take a look at https://review.opendev.org/#/c/663888/ for stephenfin
16:18:26 dansmith sean-k-mooney: pretty sure we said that's not a problem on stable especially for clean backports, and especially for something like this
16:19:18 sean-k-mooney ya i think you are right
16:20:22 stephenfin dansmith: cheers
16:28:48 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653
16:29:25 stephenfin sean-k-mooney, efried, bauzas: That ought to be useful if/when we start working on mempage modelling in placement ^
16:31:06 stephenfin also artom who cares about functional tests ^
16:32:07 artom stephenfin, yep, I'll take a look - and thanks for re-visiting NUMA func tests :)
16:32:27 artom There's one outstanding piece of dansmith's feedback I need to address though, about forcing servers on hosts
16:34:04 sean-k-mooney stephenfin: more func test for this stuff is always useful
16:34:46 sean-k-mooney if we can use that as a basis to also validate the placemnt reshape that will be needed even more so
16:37:39 efried wow, neat, a 3+yo patch
16:59:19 openstackgerrit Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847
17:00:53 artom stephenfin, there, done
17:00:59 stephenfin wonderful
17:01:09 stephenfin 1:1 then I'll finish my comments on yours
17:01:18 stephenfin (it's 90% there)
17:03:02 openstackgerrit Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256
17:10:29 stephenfin artom: done
17:11:06 efried Hey kids, it looks like blockdiag 2.0.0 breaks our docs build. I'm working on it.
17:11:07 artom stephenfin, thank you! I'll go do sean-k-mooney's downstream review, then circle back here
17:11:36 artom efried, would you say that it's... block-ing us? :D
17:11:56 efried yeah, just give me a few minutes to diag-nose it.
17:12:10 dansmith like, by smell?
17:12:22 efried just so
17:12:45 gibi dansmith: thanks. I have to get back to that patch next week. I appreciate your time and I see your point how a future instance.save() can ruin things.
17:13:43 dansmith gibi: ack, I've been looking at some of the related things you found too
17:14:30 efried stephenfin: jfyi although I opened an issue against blockdiag, I suspect it's possible the problem is in the monkeypatching in doc/source/conf.py
17:15:45 efried mm, maybe not, removing that didn't resolve. But I went and built docs in another repo that uses blockdiag (networking-bagpipe) and didn't have the same problem.
17:16:56 stephenfin efried: Looks like that project has had a lot of releases since so that monkeypatching probably isn't necessary any more. However, I'm not sure how it would affect things. What's the error?
17:17:09 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:17:29 efried stephenfin: https://github.com/blockdiag/blockdiag/issues/126
17:18:11 stephenfin could you edit that comment so I can read it. Just indent everything by 4 or add ``` before and after the code blocks
17:18:30 stephenfin please and thanks :)
17:18:44 efried stephenfin: done
17:19:33 efried stephenfin: hm, I don't actually see blockdiag being *used* in our repo.
17:20:30 stephenfin neither do I, now that you say it
17:20:56 openstackgerrit Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847
17:21:13 efried stephenfin: except for a static svg
17:21:35 efried stephenfin: which I would have thought, since it was static, wouldn't affect anything... but we're also using the svg2pdfconverter
17:21:36 efried so maybe
17:21:45 stephenfin Remove it and see what happens? :)
17:21:51 efried remove the svg?
17:22:12 stephenfin Looks like da7e1ede9e73bf0e107b9b37954f204cea544439 may have remove the vestigial traces of blockdiag
17:22:17 stephenfin nah, the extension
17:22:39 efried ...
17:23:04 stephenfin We do use seqdiag
17:23:11 stephenfin but I think that's a different project
17:23:52 stephenfin yup, sure is
17:24:16 efried removing the rsvgconverter extension didn't resolve.
17:25:18 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:28:22 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:29:07 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653
17:30:29 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
17:32:21 openstackgerrit Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256
17:32:27 efried stephenfin: hm, I also tried blacklisting in doc/requirements but that didn't work. ISTR something about upper-constraints overriding no matter what you do locally.
17:33:03 sean-k-mooney efried: is repoducing as simple as pull master and run tox -e docs locally
17:33:09 stephenfin sean-k-mooney: yup
17:33:42 stephenfin oh, okay, seqdiag uses blockdiag. Lovely
17:33:52 stephenfin as does actdiag
17:34:10 sean-k-mooney cool ill take a look while i wait for test to finish
17:34:26 sean-k-mooney ok it sould like we need a temproy cap then
17:35:18 stephenfin efried: Does that other project also use stestr, out of curiosity?
17:35:37 stephenfin actually, nvm
17:35:59 stephenfin this is docs, not tests
17:36:32 sean-k-mooney right we are invoking sphinx not stestr
17:37:44 stephenfin efried: This is the thing I introduced the monkeypatching to fix
17:37:53 stephenfin I remember now. I bet they've moved some modules around
17:37:53 sean-k-mooney we should just put blockdiag<2.0.0 in upper-constrats.txt

Earlier   Later