| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-24 | |||
| 14:51:51 | bauzas | right, I was about to paste this | |
| 14:52:01 | bauzas | and *before* we call the driver method for finishing it | |
| 14:52:08 | bauzas | which is important | |
| 14:52:32 | gibi | yep, driver call comes after the alloc revert | |
| 14:52:35 | openstack | Launchpad bug 1778563 in OpenStack Compute (nova) "Resize/Cold-migrate doesn't recreate vGPUs" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | |
| 14:52:35 | bauzas | gibi: context being https://bugs.launchpad.net/nova/+bug/1778563 | |
| 14:53:00 | bauzas | which means I also have to consider the revert resize case | |
| 14:54:40 | bauzas | gibi: do you remember when we delete the migration allocation on a revert (since we don't have a revert confirm AFAIK) | |
| 14:54:46 | gibi | when you migrate on the dest host you need to set up the vgpu resources, but when you revert the vgpu resource on the source host still has to be allocated | |
| 14:55:07 | bauzas | gibi: yeah, that's something I have to keep | |
| 14:55:17 | bauzas | we're doubling the needed vgpus | |
| 14:55:18 | gibi | bauzas: but isn't it kept automatically? | |
| 14:55:35 | bauzas | gibi: when you resize, we regenerate a new libvirt XML | |
| 14:55:42 | bauzas | gibi: without using the existing mdevs | |
| 14:55:52 | bauzas | gibi: so the mdevs are there, but unallocated | |
| 14:56:43 | gibi | before resize confirm I expect that both the source and the dest host has an instance xml with mdevs so revert does not need to recreate the instance xml on the soruce | |
| 14:59:02 | gibi | bauzas: actually the _revert_allocation call in the finish_rever_resize delets the migration allocation by moving the allocation from the migration.uuid to the instance.uuid | |
| 14:59:11 | gibi | so the migration.uuid will not have any allocation left | |
| 14:59:29 | gibi | and dest allocation is overwritten by the source allocation during the move | |
| 15:27:44 | gibi | stephenfin: how do you feel about the usefulness of the schema for nova in https://review.opendev.org/#/c/703133 based on Ilya's answer to my clarification question? | |
| 15:29:17 | gibi | stephenfin: I'm a bit hesitant but convincable to look into forgeing a test case that validates nova generated metadata against the stored schema during a libvirt based func test | |
| 15:30:27 | stephenfin | gibi: Yeah, I'd be in the same frame of mind. If there's a test, it's not a huge burden and it's helpful to someone, sure, why not | |
| 15:30:40 | stephenfin | just so long as _I_ don't have to write that test :) | |
| 15:31:27 | gibi | I see. :) It is friday afternoon so I think I will not start any big thing for this week but I can at least try my test idea out before the weekend | |
| 17:48:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Test network_data.json schema https://review.opendev.org/704182 | |
| 17:48:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add JSON schema for network_data.json https://review.opendev.org/703133 | |
| 17:49:10 | gibi | stephenfin: my stab at the problem ^^ | |
| 17:51:35 | gibi | I failed to include the metadata service into existing normal functinal test (it made the test stop for ever at the fixture setup) but I was able beef up the existing MetadataTest class with a real instance | |
| 17:51:55 | gibi | and with that I stop my work week, see you on Monday | |
| 17:52:14 | sean-k-mooney | enjoy the weekend | |
| 17:52:34 | gibi | sean-k-mooney: same to you | |
| 17:52:42 | sean-k-mooney | stephen left an hour ago | |
| 19:55:23 | openstackgerrit | Merged openstack/nova stable/stein: Mask the token used to allow access to consoles https://review.opendev.org/702181 | |
| #openstack-nova - 2020-01-25 | |||
| 00:44:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291 | |
| 13:03:33 | alistarle | Hi, concerning https://review.opendev.org/#/c/701763/2, you ask me to check if any other filter also required for non-admin, I propose to allow to filters on all field that are by default readable by non admin users when you display servers detail, do you agree ? | |
| 13:04:35 | alistarle | Thy way, I will update the spec to allow not only AZ filter but to allow all filter that "should be" allowed by default for non admin | |
| 14:40:33 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | |
| 15:29:09 | openstackgerrit | Victor Coutellier proposed openstack/nova-specs master: Non-admin user can filter their instances by AZs https://review.opendev.org/701763 | |
| 15:31:34 | openstackgerrit | Victor Coutellier proposed openstack/nova-specs master: Non-admin user can filter their instances by AZs https://review.opendev.org/701763 | |
| 19:21:45 | openstackgerrit | Merged openstack/nova master: Fix typos for update_available_resource reference https://review.opendev.org/702602 | |
| 20:02:03 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | |
| 20:02:04 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707 | |
| 20:02:04 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | |
| 20:02:05 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | |
| 20:02:05 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | |
| 20:02:06 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | |
| 20:02:06 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | |
| 20:02:07 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553 | |
| 20:02:07 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940 | |
| 20:02:08 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | |
| 20:02:08 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554 | |
| 20:02:09 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | |
| #openstack-nova - 2020-01-26 | |||
| 14:57:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/rocky: Mask the token used to allow access to consoles https://review.opendev.org/704255 | |
| 15:02:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/rocky: Mask the token used to allow access to consoles https://review.opendev.org/704255 | |
| #openstack-nova - 2020-01-27 | |||
| 09:45:23 | stephenfin | bauzas: Today's a spec review day for me. Just reviewed https://review.opendev.org/#/c/702943/ | |
| 09:49:00 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Small fixes to unified limits spec https://review.opendev.org/703773 | |
| 09:59:44 | bauzas | stephenfin: ack, thanks | |
| 10:00:08 | bauzas | FWIW, I should do the same... | |
| 10:38:49 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Re-proposes multiple vGPU types in libvirt https://review.opendev.org/702943 | |
| 10:50:47 | stephenfin | bauzas, efried: Think you folks could look at https://review.opendev.org/#/c/682655/ today? It's just a reproposal and I hope to have the mostly trivial code up later this week | |
| 11:17:20 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Additional upgrade clarifications for cpu-resources https://review.opendev.org/666032 | |
| 11:30:10 | openstackgerrit | Merged openstack/nova-specs master: spec update: virtual persistent memory https://review.opendev.org/695868 | |
| 11:53:03 | stephenfin | kashyap: Loads of comments left on https://review.opendev.org/#/c/693844/, when you have time | |
| 11:54:46 | kashyap | stephenfin: Will check, on the phone; thanks! | |
| 12:07:02 | kashyap | stephenfin: Thanks for taking time to review; reasonable questions, will respond there. | |
| 12:15:54 | stephenfin | huaqiang: Is it you that's working on bp/use-pcpu-and-vcpu-in-one-instance ? If so, just hit the spec at https://review.opendev.org/#/c/668656/ | |
| 12:33:16 | openstackgerrit | Merged openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152 | |
| 13:35:41 | gibi | stephenfin: replied in https://review.opendev.org/#/c/701763 | |
| 14:00:57 | gibi | stephenfin: you were the second +2 on https://review.opendev.org/#/c/699669/ but did not +A it. Is it intentional? | |
| 14:11:44 | openstackgerrit | Merged openstack/nova-specs master: Re-proposes multiple vGPU types in libvirt https://review.opendev.org/702943 | |
| 14:18:16 | efried | stephenfin: Would you please make a blueprint for that? | |
| 14:35:30 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Make RBD imagebackend flatten method idempotent https://review.opendev.org/704330 | |
| 14:36:36 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Make RBD imagebackend flatten method idempotent https://review.opendev.org/704330 | |
| 14:50:03 | efried | lyarwood: I've been procrastinating on https://review.opendev.org/#/c/669121/ -- at some point would you mind directing me to the piece of the CI that shows it's doing what's expected? | |
| 14:51:41 | efried | oh, I guess it's not waiting on me, since there's an open dep. That makes me feel less slackerish. | |
| 14:55:33 | lyarwood | efried: yup I've been pinging away in openstack-qa about this for a while, I'll try to get it over the line today. The CI you're looking for is actually against that change as the dep is for an openstack/grenade change. | |
| 14:57:06 | efried | thanks | |
| 14:58:10 | lyarwood | gah .gz files, has zuul regressed recently in terms of being able to display these .gz log files as plain text via the web ui? | |
| 14:58:40 | lyarwood | or were these just plain text before and are now .gz? | |
| 14:59:16 | lyarwood | either way it's now impossible to share URLs to specific log lines etc | |
| 15:01:43 | efried | lyarwood: Yeah, infra changed a thing, something about swift, and now a few jobs, including legacy ones, are double-compressing log files. It's a serious PITA. | |
| 15:02:41 | efried | Apparently we can fix it somewhere in the job definition itself, but so far nobody has gone and done that. Not sure how much of that is because nobody knows how (that's certainly *my* excuse) or just haven't had the time. | |
| 15:03:16 | efried | Another hesitation with that is that we *should* just go convert those jobs to zv3, which would make the problem go away, and which we're supposed to be doing anyway. | |
| 15:03:43 | efried | that also has been not done, and for similar reasons I imagine. | |
| 15:03:55 | efried | smarter people than me have made attempts, but nothing has closed | |
| 15:04:31 | lyarwood | efried: ack thanks, I did start looking at switching the nova-lvm job over last week but didn't post anything. | |
| 15:04:54 | lyarwood | sean-k-mooney: have you started converting any of the grenade jobs to zuulv3? | |
| 15:05:04 | lyarwood | iirc you were looking at this right? | |
| 15:05:07 | efried | I will personally buy a cookie for whoever makes the .gz problem go away, I don't care how. | |
| 15:21:28 | gmann | lyarwood: grenade job zuulv3 work https://review.opendev.org/#/q/topic:grenade_zuulv3+status:open | |
| 15:22:32 | lyarwood | gmann: awesome thank you, I'll take a look shortly | |
| 15:50:10 | lyarwood | melwitt: https://review.opendev.org/#/c/703005/ - Did you have another openstack/nova change using https://review.opendev.org/#/c/548936/ btw? | |
| 16:02:32 | melwitt | lyarwood: yeah, I was dual purposing this https://review.opendev.org/701478 | |
| 16:03:32 | lyarwood | melwitt: ah cool thanks | |
| 16:04:29 | melwitt | I got motivated to test out the grenade change while trying to get some info on that cell timeout gate failure in grenade jobs (bc the log files are all gzipped and annoying to have to download). zuul v3 conversion solves that problem | |
| 16:13:12 | dansmith | efried: just want to make sure it's clear that I'm waiting for you to ack this before I really do much with it: https://review.opendev.org/#/c/631243/52 | |
| 16:14:38 | efried | dansmith: okay, thanks for the heads up. | |
| 16:15:03 | dansmith | efried: seems like you haven't been through that set lately, are you planning to go through it again soon? | |
| 16:15:18 | efried | I can do that, yes. | |
| 16:15:33 | efried | dansmith: I was actually mostly waiting for you to be happy with it. | |