| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-20 | |||
| 08:44:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291 | |
| 08:54:10 | lyarwood | sean-k-mooney: ack, will do. | |
| 08:55:09 | lyarwood | stephenfin: https://review.opendev.org/699291 - assuming this now passes CI can you +W again, I rebased by mistake. | |
| 09:12:01 | shilpasd | dansmith: hi, i want your opinion on my comment added https://review.opendev.org/#/c/694462/8/nova/db/sqlalchemy/api.py@2008 | |
| 09:12:22 | shilpasd | dansmith: would like to hear from you on this | |
| 11:42:42 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: [OVS] VLAN tag should be set in the Port register https://review.opendev.org/703373 | |
| 11:49:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.hyperv' https://review.opendev.org/703149 | |
| 11:49:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.vmwareapi' https://review.opendev.org/703148 | |
| 11:49:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.xenapi' https://review.opendev.org/703151 | |
| 11:49:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.powervm' https://review.opendev.org/703150 | |
| 11:49:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.cmd', 'nova.console', 'nova.db' https://review.opendev.org/703154 | |
| 11:49:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve final issues with 'nova.virt' https://review.opendev.org/703153 | |
| 12:21:49 | openstackgerrit | Ilya Etingof proposed openstack/nova master: Add JSON schema for network_data.json https://review.opendev.org/703133 | |
| 12:38:25 | openstackgerrit | Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790 | |
| 12:41:08 | brinzhang__ | stephenfin: hi, adding metadata to the creating aggregate, it does not populate the aggregate's 'updated_at' field, that's why the functional tests failed | |
| 12:41:49 | brinzhang__ | stephenfin: please review the latest patch https://review.opendev.org/#/c/702790/5/nova/objects/aggregate.py@191, thanks | |
| 12:42:11 | openstackgerrit | Merged openstack/nova master: functional: Add unified '_build_server' helper function https://review.opendev.org/697537 | |
| 12:42:18 | openstackgerrit | Merged openstack/nova master: functional: Add unified '_(build|create)_flavor' helper functions https://review.opendev.org/697538 | |
| 12:42:24 | openstackgerrit | Merged openstack/nova master: functional: Add '_delete_server' to 'InstanceHelperMixin' https://review.opendev.org/697539 | |
| 13:39:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261 | |
| 13:40:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use common server create function for qos func tests https://review.opendev.org/701353 | |
| 13:42:35 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066 | |
| 13:44:04 | openstackgerrit | Merged openstack/nova master: Make removal of host from aggregate consistent https://review.opendev.org/696392 | |
| 13:45:54 | gibi | alex_xu: would you like to be a liaison for the api change https://review.opendev.org/#/c/701763 ? | |
| 13:46:30 | gibi | dansmith: replied in https://review.opendev.org/#/c/702261/ | |
| 13:47:57 | stephenfin | gibi: Care to hit this now that others have looked at it? https://review.opendev.org/#/c/696745/ | |
| 13:49:09 | openstackgerrit | Merged openstack/nova master: Set instance CPU policy to 'share' through image property https://review.opendev.org/688603 | |
| 13:50:10 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Set instance CPU policy to 'share' through image property https://review.opendev.org/703393 | |
| 13:51:06 | gibi | stephenfin: looking | |
| 14:08:22 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 14:08:33 | kashyap | stephenfin: When you get a moment --^ does that look better? | |
| 14:09:57 | kashyap | stephenfin: Quick change-log: (a) we should keep the both extra spec properties (see comments); (b) modified the driver function to make (correct) use of the extra spec props; (c) added a rel-note for change in semantics | |
| 14:10:05 | kashyap | stephenfin: Thanks for the earlier review. That was useful | |
| 14:16:45 | gibi | stephenfin: +A, thanks | |
| 14:16:49 | brinzhang__ | gibi: https://review.opendev.org/#/c/701763/2 I leave some comment on | |
| 14:16:53 | stephenfin | gibi: Thanks | |
| 14:16:56 | stephenfin | kashyap: Will do | |
| 14:17:04 | gibi | brinzhang__: ack | |
| 14:20:09 | gibi | brinzhang__: replied | |
| 14:24:33 | brinzhang__ | Yeah, I think "rule:project_reader_api" role is good to me | |
| 14:24:42 | brinzhang__ | gibi | |
| 14:25:44 | brinzhang__ | gmann: are you around? | |
| 14:28:35 | gmann | stephenfin: one question on hacking cap - https://review.opendev.org/#/c/695733/4/test-requirements.txt@5 | |
| 14:28:44 | brinzhang__ | gmann: 'rule:project_reader_api' and 'rule:project_member_api' which different from 'rule:system_admin_or_owner' and 'rule:system_or_project_reader'? I am not sure | |
| 14:29:14 | gmann | brinzhang__: did not get completely. | |
| 14:30:09 | brinzhang__ | gmann: which scope? | |
| 14:30:11 | stephenfin | gmann: Makes sense. Will submit a follow-up | |
| 14:30:24 | gmann | brinzhang__: 'system_*' rules are with system level scope and project only rules are project scopped. | |
| 14:30:29 | gmann | stephenfin: +1 thanks | |
| 14:30:56 | gmann | brinzhang__: 'rule:system_admin_or_owner' and 'rule:system_or_project_reader' are [system, project] both scoped. | |
| 14:33:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add '_create_server' helper https://review.opendev.org/697540 | |
| 14:33:42 | brinzhang__ | gmann: other words, if we are *system_* role, we can get all projects resource. and if we are *project_* role, we just can get his own project's resource, right? | |
| 14:34:46 | gmann | brinzhang__: right. | |
| 14:35:10 | brinzhang__ | gmann: Thanks :) | |
| 14:35:57 | gmann | in addition to that, new default roles also considered like reader etc. so admin can get member,reader but not vice versa (on both scope case) | |
| 14:36:22 | brinzhang__ | gibi: so filter instances by az, I think use "rule:project_reader_api" is ok, what do you think? | |
| 14:37:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: requirements: Limit hacking to one minor version https://review.opendev.org/703405 | |
| 14:37:46 | brinzhang__ | gmann: yeah, I reviewed your docs of this :P | |
| 14:38:28 | stephenfin | gmann: ^ | |
| 14:38:53 | gibi | brinzhang__: based on you discussion with gmann it looks OK to me | |
| 14:39:06 | gmann | brinzhang__: gibi link ? | |
| 14:39:11 | gmann | stephenfin: thanks | |
| 14:39:36 | brinzhang__ | gmann, https://review.opendev.org/#/c/701763/ | |
| 14:39:36 | gibi | gmann: we are reviewing https://review.opendev.org/#/c/701763/ with brinzhang__ | |
| 14:39:54 | gmann | ok, thanks. | |
| 14:45:40 | gmann | brinzhang__: gibi i left comment in review. we should not need policy there. we already have policy to allow admin filters to access by non-admin. | |
| 14:46:01 | gmann | this case of when operator/user want AZ to be always allowed for non-admin not based on configuration. | |
| 14:46:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused code https://review.opendev.org/703408 | |
| 14:47:54 | gibi | gmann: thanks. does os_compute_api:servers:allow_all_filters' | |
| 14:48:17 | gibi | gmann: does os_compute_api:servers:allow_all_filters makes every filtering available for the user? | |
| 14:48:26 | gmann | gibi: yes, but that allow all admin filters. | |
| 14:48:54 | gibi | gmann: so that cannot be used to selectively enable AZ filtering for non-admin | |
| 14:49:06 | gmann | as per discussion with author on IRC, this policy is not they want to use for making AZ for non-admin and wanted AZ to be available by default | |
| 14:49:40 | gmann | gibi: yeah, i mean if we default any filter for non-admin then we do not need policy for that. | |
| 14:50:48 | gibi | gmann: so simply adding availiability_zone to nova.api.openstack.compute.servers.serverscontroller._get_server_search_options would make the AZ filter available to non-admin by default | |
| 14:50:53 | gmann | if we think AZ is for non-admin then we should not add config way to disallow for non-admin. | |
| 14:51:02 | gmann | gibi: yes | |
| 14:51:16 | gibi | gmann: I got it, thanks | |
| 14:52:10 | gmann | but i am little concern to bump microversion for this single fitler. i commented to do a audit for all such filter first. like we did for API clenup BP(doing such cleanup together in single microvesion) | |
| 14:52:55 | gibi | gmann: and I've just agreed with you about that | |
| 14:53:00 | gibi | :) | |
| 14:53:02 | gibi | in the review | |
| 14:53:12 | gibi | gmann: thanks for the review | |
| 14:53:19 | gmann | thanks. | |
| 14:54:27 | brinzhang__ | gmann, gibi: so this spec's context is ok, we donot car about the policy's limit :) | |
| 14:55:09 | brinzhang__ | gibi: I am ok with that ^ | |
| 14:55:22 | gmann | yeah, policy is not required for that. we should add another configurable way which is not required. | |
| 14:55:58 | gibi | brinzhang__: I still think this is a valid spec. we don't need a new policy. And we should review the other existing admin-only filters to se other need to be moved to the non-admin set | |
| 14:56:41 | gmann | s/should/should not | |
| 14:57:12 | brinzhang__ | gibi: yeah, like gmann said, *that* should done in a micoroversion, avoid more microversions to do one thing | |
| 14:57:26 | gibi | brinzhang__: exactly | |
| 14:59:41 | brinzhang__ | gibi: I think I would like to do, but it will be start after our holiday~ | |
| 15:00:55 | gibi | brinzhang__: sure. holiday recharging is important :) I also expect the author to do the first sweep of the existing filters | |
| 15:01:59 | brinzhang__ | gibi: ^^ | |
| 15:17:07 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | |
| 15:17:07 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/695180 | |
| 15:21:57 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 15:22:22 | kashyap | sean-k-mooney: ^ I reworded the commit message; and reworded the puropose more clearly. | |
| 15:22:42 | kashyap | sean-k-mooney: (And tweaked the driver.py; hop that looks OK.) | |
| 15:25:07 | sean-k-mooney | i would still delete the backgroud section to be honest. that should have beeen in the patch that chagne to use /dev/urandom by default not this chagne but i wont block on it | |